summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 5Mike Kaganski
- Revise uses of getSomething to use getFromUnoTunnel Where that is impossible, use getSomething_cast to unify casting, and minimize number of places doing low-level transformations. The change keeps the existing tunnel references that last for the duration of the pointers' life, because sometimes destroying such reference may destroy the pointed object, and result in use after free. Change-Id: I291c33223582c34cd2c763aa8aacf0ae899ca4c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122101 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 4Mike Kaganski
- Change implementations of getSomething to use getSomethingImpl Or where that's impossible, use getSomething_cast to unify this and reduce number of places where we reinterpret_cast. All static methods getting tunnel ids were renamed to getUnoTunnelId, to comply with the convention used in <comphelper/servicehelper.hxx>. TODO (in separate commits): - Revise uses of getSomething to use getFromUnoTunnel Change-Id: Ifde9e214b52e5df678de71fcc32d2199c82e85cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122100 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 3 [API CHANGE]Mike Kaganski
- Replace all uses of OImplementationId in core with UnoIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> OImplementationId uses broken double checked locking; additionally, it uses it at the first call to getImplementationId, not when the object is constructed. This implementation can't be changed, cince it's part of published API; it can't rely on C++11, which would be required for use of thread-safe statics and move the initialization to ctor. The class has obsolete _bUseEthernetAddress member, that is unused and ignored since 4e9fa7e339a1cd6cb2fec643715991bcf5057cec. No need to implement it when replacing its uses to UnoIdInit. The deprecation is the API CHANGE. No published API is introduced to replace it; 3rd-party code should seek alternative solutions, or just keep using the deprecated functionality. TODO (in separate commits): - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: I8b6e684e5389bc0d5bb3b7f21f72a4c8f684107d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122077 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 2Mike Kaganski
Replace uses of sw::UnoTunnelImpl and sw::UnoTunnelGetImplementation with respective comphelper::getSomethingImpl and comphelper::getFromUnoTunnel. Drop the former from sw/inc/unobaseclass.hxx. TODO (in separate commits): - Replace all uses of OImplementationId in core with UnoTunnelIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: I1e350a88260277a67b833af56b285ac2277f433a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122075 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 1Mike Kaganski
The header got some changes: 1. Move UnoTunnelIdInit and isUnoTunnelId into 'comphelper' namespace 2. Rename UnoTunnelIdInit to UnoIdInit, as a precondition to replace of uses of OImplementationId with it, including in XTypeProvider 3. Introduce convenience functions 'getSomething_cast' to cast between sal_Int64 and object pointers uniformly. 4. Rename getUnoTunnelImplementation to getFromUnoTunnel, both to make it a bit shorter, and to reflect its function better. Templatize it to take also css::uno::Any for convenience. 5. Introduce getSomethingImpl, inspired by sw::UnoTunnelImpl; allow it handle cases both with and without fallback to parent. 6. Adjust UNO3_GETIMPLEMENTATION_* macros TODO (in separate commits): - Drop sw::UnoTunnelImpl and sw::UnoTunnelGetImplementation - Replace all uses of OImplementationId in core with UnoIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: If4a3cb024130f1f552f988f0479589da1cd066e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122022 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-14Untabify odk/util/check.plStephan Bergmann
(trying to change the actual content of those lines would otherwise trigger our "indent with Tab" git commit hook) Change-Id: I97449056eb7850d3993fa5ac565e342d0bcbf200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122093 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-14tdf#135683 speedup DocumentRedlineManager::GetRedlinePosNoel Grandin
use binary search Change-Id: Icd442ba18cb27cdcb5955fa8bbce421b26d5ad44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121205 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-14Drop some useless conversions to sal_Int32Stephan Bergmann
These started out as sal::static_int_cast<xub_StrLen> in 1b9a6329fcda25fd738bd0e0a36663a6e745cab8 "INTEGRATION: CWS calcwarnings", presumably to silence some signed-to-unsigned conversion warnings, then morphed into the completely useless sal::static_int_cast<sal_Int32> with the String -> OUString changes (where the length parameter changed from unsigned xub_StrLen to signed sal_Int32), which then started to hide erroneous overflow (see e.g. 4a4be7a1edead11b48e1a8598e52a3246e6744bb "tdf#144106 Don't proceed ptrim_i past ptrim_f") from tools like -fsanitize=implicit-integer-sign-change with the OUString -> std::u16string_view changes (where the length parameter changed from signed sal_Int32 to unsigned std::size_t). If there were demand to prevent signed-to-unsigned conversion warnings here, that should be done with o3tl::make_unsigned instead. Change-Id: I9b078658500b6ed5dcd0e860d2f0b725133188f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122092 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d098ee2b7fba8b173fd718490c8e537c13d936b0 - fix path of embed Change-Id: I99168be951490a532ca7cc0ab2be906584bd7290 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122068 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-14tdf#144483 sw mail merge: save ranges in a single documentBalazs Varga
In the Save mail merged document dialog, it wasn't possible to save mail ranges in a single document, because of the bad UI of the dialog window: grouping range selector as a radio button with the single document/individual documents radio buttons. Moreover, commit f3993912ec4b526aa57cb4bfb4745d7298a4da82 "tdf#144427 sw mailmerge: fix merge all document" removed the hidden workaround: setting range at the third radio button, and selecting the first radio button. Using checkbox for the third option solved the problem as proposed. Change-Id: I43798fb036de07d1001bcb8d72c20de2d9c577b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122078 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-09-14sw: fix undo manager de-registration from editeng on shutdownMiklos Vajna
editeng/ asserts in the ImpEditEngine dtor that the undo manager it owns is indeed an EditUndoManager, and not a subclass. This means that if a subclass is set as the undo manager of editeng, then SetUndoManager() should be called in pairs: once to set it and once to unset it. The unset should happen before destroying the EditEngine. This normally works because SwView either has an active text edit and then its dtor calls SdrEndTextEdit() or it doesn't have an active text edit. The broken case was when the text edit was already ended, but the draw view still had a text edit outliner, which has an EditEngine, which knows the sw undo manager. The product build deleted the sw undo manager when deleting the EditEngine, and then later when the SwExtTextInput dtor wanted to access the sw undo manager, it crashes due to use-after-free. Fix the problem by explicitly disposing the undo manager of the draw view in the dtor of SwView. Also fix a couple of more places where an SdrObject* is returned and we didn't check if the result is a nullptr. Caught by the loolstress tool in online.git: cp test/data/hello-world.odt /tmp/test.odt ./loolstress ws://localhost:9980 /tmp/test.odt test/traces/writer-hello-shape.txt /tmp/test.odt test/traces/writer-hello-shape.txt /tmp/test.odt test/traces/writer-hello-shape.txt /tmp/test.odt test/traces/writer-mash-text-table.txt /tmp/test.odt test/traces/writer-mash-text-table.txt Change-Id: Ib838b2adf900b4f3bec63d2d62d432327bc0c6c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122086 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-14wina11y: Use XAccessible* instead of void*Michael Weghorn
Change-Id: If52de3a71af63697815e4ec6a19f9139d5a6973d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122085 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-14tdf#141704 PPTX import: fix hyperlinks on imagesTibor Nagy
Hyperlinks on images pointing to the "first/last/ previous/next" slides and "exit presentation/go to the website/go to the slide" weren't imported. Note: images added via the Content placeholder will be fixed later. Change-Id: Idda1ff6fd3243b06262637c7c8e579e78309e317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121369 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b7491d7d5cd174d4100c3de5f46cff20d7840809 - typo Change-Id: I1b26b14b3fdcf47351601ce5ea7bbdbadb65d887 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122067 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-14Adapt to Bison 3.8 internal yyn -> yyrule renameStephan Bergmann
see <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=f30067ed51f23802fc91761ede1506dfa72b2865> "glr2.cc: log the execution of deferred actions" including "Rename argument yyn as yyrule for clarity." YYBISON was defined as 1 rather than as a representation of the Bison version prior to <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=21c147b6e5372563b7c4741deadaddb9354f4b09> "yacc.c: provide the Bison version as an integral macro", which shouldn't be a problem here. And YYBISON is apparently completely undefined with /usr/bin/bison on macOS. (The preceding comment always mentioned "yyi" and "yyrmap" in apparent mismatch with the actually used "yyn" and "yyr1" ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import", so just leave it untouched.) Change-Id: I4f901407aa21ed4abec84e661d813ee7599f02f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-14ofz: Null-dereference READCaolán McNamara
Change-Id: I4f6d93943bd0c9e5834952b56beb6bd84411a55d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-14ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib3afba47155bc70f579284244514d745f1075f7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122080 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-14tdf#143854: Revert "tdf#57585 Add new bullet behaviour to impress"Xisco Fauli
This reverts commit 070a5b039b181c380b1b9724a015314ff78c30ed. Reason for revert: Many PPT files are affected when saved to ODP. I waited a while before reverting it but not reaction from the developer Change-Id: Ibfd2f508930e1a3ef56961536454ea1eda55f8c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122061 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-14tdf#144057 sw track changes: hide deleted table rowsLászló Németh
and tables in Hide Changes mode. Previously it was possible to "hide" them only by accepting all the deletions, because Hide Changes mode hid only the cell content, but not the deleted rows and tables, leaving empty rows and tables in the document. Follow-up of commit 05366b8e6683363688de8708a3d88cf144c7a2bf "tdf#60382 sw offapi: add change tracking of table/row deletion". Change-Id: Ib0424f5a17f2213fc7466e966d8ce6812ffde5e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122079 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-14ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I5906dc1f9f0295d406c01871e5fed1da0025682f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-14configure: test_curl is always "yes"Michael Stahl
Presumably this should check enable_curl instead. Change-Id: Ifc0b871e9c34bdb43ef14b8002d4997860266a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122040 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-14tdf#42982: improve UNO API error reporting4k5h1t
Change-Id: I1252c89f23e70eb88744585bb2abd4fe3794e1d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121918 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-14svx: GetMarkedObjectByIndex() may return nullptrMiklos Vajna
Seen in this crash: #6 SdrMarkView::ImpIsFrameHandles() const (this=this@entry=0x7f5a310) at svx/source/svdraw/svdmrkv.cxx:594 #7 0x00007f9779c71058 in SdrMarkView::HasMarkablePoints() const (this=0x7f5a310) at svx/source/svdraw/svdmrkv1.cxx:32 #8 0x00007f9779d0c142 in SdrView::GetContext() const (this=0x7f5a310) at svx/source/svdraw/svdview.cxx:1297 #9 0x00007f976185adf4 in SwWrtShell::GetSelectionType() const (this=this@entry=0x7f32d90) at sw/source/uibase/wrtsh/wrtsh1.cxx:1424 #10 0x00007f9760e3d5b9 in SwCursorShell::sendLOKCursorUpdates() (this=this@entry=0x7f32d90) at sw/source/core/crsr/crsrsh.cxx:2055 #11 0x00007f9760e4046b in SwCursorShell::UpdateCursor(unsigned short, bool) (this=this@entry=0x7f32d90, eFlags=eFlags@entry=6, bIdleEnd=bIdleEnd@entry=false) at sw/source/core/crsr/crsrsh.cxx:2041 #12 0x00007f9760e41747 in SwCursorShell::EndAction(bool) (this=0x7f32d90, bIdleEnd=bIdleEnd@entry=false) at sw/source/core/crsr/crsrsh.cxx:276 #13 0x00007f976105865a in SwEditShell::EndAllAction() (this=this@entry=0x7e98ed0) at sw/source/core/edit/edws.cxx:102 #14 0x00007f976109f8ed in SwFEShell::DelSelectedObj() (this=0x7e98ed0) at sw/source/core/frmedt/feshview.cxx:2295 #15 0x00007f976184a447 in SwWrtShell::DelRight() (this=this@entry=0x7e98ed0) at sw/source/uibase/wrtsh/delete.cxx:442 #16 0x00007f9761680d6b in SwEditWin::Command(CommandEvent const&) (this=0x7e9ba10, rCEvt=...) at sw/source/uibase/docvw/edtwin.cxx:5483 Change-Id: I916be9ce846c8750acdaf5fc791e1adb3692e002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122076 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-14tdf#144305 sw: fix rendering of ruby portions with non-default ruby alignmentMiklos Vajna
Regression from 301278b656e76b6f42af5cf8a6f5c6c02acfffeb (sw: allow the height of a line to be larger than 65536 twips, 2021-05-20), the problem was that changing from sal_uInt16 to sal_uInt32 broke SwRubyPortion::Adjust_(), which relied on integer promotion rules to have a negative diff. Old storage size was smaller than int, so got promoted to signed int, so the result could be a small negative number. New storage size is an unsigned int, so no promotion happens, so the new result was a large positive number. Fix this by casting to signed int explicitly. Change-Id: I8778c1bd0d62e27c99d4ceb1bb7bc6107a179803 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122048 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-09-14Update git submodulesRoss Johnson
* Update helpcontent2 from branch 'master' to 103d2d6a3525d7b4972300702bffa92aa71011c3 - tdf#100777 - update related documentation for ctrl-UP Arrow Change-Id: Iec89eda03e243feff68e407f01ee693a5fe8ed83 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122052 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-09-14tdf#100777 - Bind Ctrl+Up to uno:GoToStartOfPara (instead of prev paragraph)rocso
Change-Id: I87707ab2779ddbbb72a67620d3760c0a61ee7599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122032 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-09-14Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' to 7fcb420ec4010eeaad4176d6df0dcc7451aa9094 - Update ICU regexp URL Change-Id: Id64c141945e981560e01b789a3664955af923528 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122074 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-09-13tdf#144457: sc: Add UItestXisco Fauli
Change-Id: I1ad059db209a90a8cf5a78ca8cbd6eaabded8195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122039 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-13tdf#142415 mouse events not propogated to table control event handlersCaolán McNamara
handle this with explicit callbacks from the cell widget for those events Change-Id: Ie605ca4286afc0fbd321f339fb7963771a303df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122050 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-13tdf#126879: sw_htmlexport: Add unittestAndreas Heinisch
Change-Id: Id3abc7cf73756255d408f01cef47d02f89b79190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122051 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-09-13tdf#144106 Don't proceed ptrim_i past ptrim_fStephan Bergmann
...which would cause p2 - p1 to be negative in lcl_appendLineData and thus construction of a std::u16string_view with a huge positive length of type size_t. In 64-bit builds where size_t is 64-bit, that would then cause termination due to an uncaught std::bad_alloc. But in (implicitly) --disable-assert-always-abort 32-bit builds where size_t is 32-bit, this would silently have worked before 1efec9ec21dba32335e311d367b636538e219621 "Tighten rtl_{string,uString}_newFromStr_WithLength implementation", when the huge positive size_t value was cast back to a negative sal_Int32 that was gracefully handled by rtl_uString_newFromStr_WithLength. Change-Id: I3b95a9fce62b99ffc150f76a1c6ccddcdacdae0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122038 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-13loplugin:mergeclassesNoel Grandin
Change-Id: I908518ac14715f7e546a154b1d5a5ab77eeb4155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122021 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-13Explicitly set cursor position for x11 'gen' backend, tdf#144457 follow-upEike Rathke
... (and other backends?) Change-Id: If45b83080aa2df50ef27ad282eb6fa1d4a022703 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122037 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-09-13ScAccessibleSpreadsheet: Use 2 local vars instead of class membersMichael Weghorn
Those vectors are only used in 'ScAccessibleSpreadsheet::CalcScAddressFromRangeList' and cleared before use, so just use local variables instead. Also, use a 'std::pair<SCCOL,SCCOL>' instead of a 'std::pair<sal_uInt16,sal_uInt16>' for holding a pair of column indices and drop the 'PAIR_COL' typedef. Change-Id: Iacddba03cb72a5cfb6cf3ced0001258ef9db9107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122028 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-13Drop unnecessary extra indentationMichael Weghorn
There's no reason to introduce extra blocks here. Change-Id: Ie3e72e8535617865646bb8161890aebfbc0db4d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122027 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-13Check string boundsEike Rathke
Doesn't occur in practice because all date acceptance patterns start with a YMD character, enforced by the dialog, but just in case.. Change-Id: I8ed43a272e9501c6977888b1f587ed14c85024ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122025 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-09-13tdf#144085: sc_macros_test: Add unittestXisco Fauli
Change-Id: I8f5d8fa6efebaeb686baca280c7b9850a6192aad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122031 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-13loplugin:simplifypointertoboolStephan Bergmann
Change-Id: I0186e8f1566ec2e4cec768cc18bdeba0bae182b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122033 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-13loplugin:cow_wrapperNoel Grandin
check the classes that use o3tl::cow_wrapper so that they don't unnecessarity trigger copies Change-Id: I545e627598217f3e61ba2c384adb8d4f8b404829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122030 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-13fix ccache size detection with ccache 4.4Rene Engelhard
which changed format. but ccache -p has the same format in 4.2 and 4.4 so use that one Change-Id: I4de0241109c580becb96ce0c1b461c2642a4631e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120928 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-09-13Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 74c629f13542c1ee188cd5e9723528e97536e80e - This statement is kinda arrogant. Explaining things is the job of Help. Change-Id: I1f6eb627ac082317cfe0f42c9d344ceac7ccac46
2021-09-13Resolves: tdf#116184 Check that there is no trailing number behind a matchEike Rathke
... without being separated by a blank so the match is rejected if it doesn't possibly form a date+time input and input can be accepted as decimal fraction. Change-Id: Iabd1d216366ecb8454c59822ce58f112bfa6091e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122024 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-09-13loplugin:methodcyclesNoel Grandin
Change-Id: Ia14e47b811ca56d8d4517f262e008985d6aebe35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-13CSV import dialog: fix tooltip for "Evaluate formulas" optionMing Hua
This option was added in commit 4c29c2bfab18b25229e0bc71014fd2ca42ec5bff with appropriate label and extended tooltip, but the (regular) tooltip seems to be just copy-and-pasted from "Skip empty cells" option and not changed to fit the new option. Change-Id: I2425f4dc67468f152a7180d98e2e48c15de351fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121987 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-09-13a11y: Set new tab name in AccessibleEventId::NAME_CHANGED eventMichael Weghorn
The previous use of 'sOldName' instead of 'sNewName' looks like a copy paste mistake which would result in "Sheet %1" being set for the new name. cppcheck warned about this: "Variable 'sOldName' is assigned a value that is never used. Change-Id: I8676f42bb6548ce1618d14f84b77541f279bac58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122023 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-13properly separate code built with different CPU settingsLuboš Luňák
Trying to write smart code and mixing different CPU flags doesn't play nice together. Those global variables are not runtime-protected by a CPU check, and so may crash with illegal instruction error. And those inline functions may not get inlined and the compiler is free to choose just one copy, any of them, so it may be the one requiring the most demanding CPU settings. So use only dumb code in files compiled with CPU intrinsics. Change-Id: I8200fd4d9f991fab6fdc741120e7aa96ff9b470d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121929 Tested-by: Jenkins Reviewed-by: Dante DM <dante19031999@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-13uitest: combine execute_modeless_dialog_through_command methodsXisco Fauli
Change-Id: Idada1927f6b8b55133e1ff8c776a987699df1dc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122012 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-13uitest: guard the remaining execute_modeless_dialog_through_commandXisco Fauli
Change-Id: I239fe94cc8983e679c82aa43d74d8099b13e73b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122011 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-13uitest: guard execute_modeless_dialog_through_command in swXisco Fauli
Change-Id: Ie3acd6eb716d6d3532bb50b5b9002f80044a2bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121913 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-13uitest: guard execute_modeless_dialog_through_command in scXisco Fauli
Change-Id: Ifd03ae26659ff56d36bfe8d4938d690ada761d5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121912 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-01 03:42:26 +0000