summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-12-02can pass window directly to CreateTemplateDialog nowCaolán McNamara
Change-Id: Ic7ff388a338b2b90f4509c807f7ffcb34e468edb Reviewed-on: https://gerrit.libreoffice.org/64343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-02weld SwGlossaryGroupDlgCaolán McNamara
Change-Id: I142123b474e0e35f6da375977e33d40e0ad39054 Reviewed-on: https://gerrit.libreoffice.org/64324 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-02tdf#120703 PVS: logical AND had been used instead of bitwiseMike Kaganski
V560 A part of conditional expression is always true: sal_Int32(0xFF) != 0. Change-Id: I5f19c4ff20e91767d22a85239f9693d68ff360b1 Reviewed-on: https://gerrit.libreoffice.org/64414 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-02tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: Ia9c496ec93bedb13764969bf21c3f21d84caacef Reviewed-on: https://gerrit.libreoffice.org/64413 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-02tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScAnnotationsObj. Change-Id: Ife8c2d51a3aae409fa008c5ad2515a8976481771 Reviewed-on: https://gerrit.libreoffice.org/64407 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-02tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScAnnotationsObj. Change-Id: Icbd34ffe4b4911754045e4a5dc511b3fb25d4dd0 Reviewed-on: https://gerrit.libreoffice.org/64404 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01weld OfaAutoCompleteTabPageCaolán McNamara
Change-Id: I84f051fd1dc127663fd510c81addb0fd0cdc2c26 Reviewed-on: https://gerrit.libreoffice.org/64278 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-01sc: turn on clang-format for scarealinksobjJens Carl
I accidentally formatted the file with commit 20533db9eaafac18b02c81c64b583c76a5ca66a6, so it can be enabled. Change-Id: I36fb6e9107f4f5b2ac708890184bb4981a703474 Reviewed-on: https://gerrit.libreoffice.org/64401 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01tdf#120703 PVS: do not split a band that is just one pixel highMike Kaganski
This is what mentioned in the comment to the line, so implement just that V560 A part of conditional expression is always true: pBand->mnYTop < pBand->mnYBottom. Change-Id: I1027a30a07d49940a31838deddb457b6379eb887 Reviewed-on: https://gerrit.libreoffice.org/64399 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-01Rename testGetByIndex to testIndexJens Carl
Rename testGetByIndex to testIndex of sheet::XSheetAnnotations test cases so it won't collide with testGetByIndex of container::XIndexAccess. Change-Id: Ic48ffe954c9f4f00b68066ad5d0d2df89cc4dfd7 Reviewed-on: https://gerrit.libreoffice.org/64402 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01Related: tdf#121721 use premultiply unpremultiply tablesCaolán McNamara
for tdf#121721 this brings the time down between pressing F5 and seeing the image from 4 seconds to 1.4 seconds Change-Id: I8e7f15e5126218b040e96f9143827ff788b4fb51 Reviewed-on: https://gerrit.libreoffice.org/64111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-01Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - REGEX: correct ICU URL to use http, not https (which seems unavailable) Change-Id: Iaeed0d81dc88418c2bffab730fd682ca8cb3b101 Reviewed-on: https://gerrit.libreoffice.org/64313 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-01tdf#39468 Translate German commentsJens Carl
Change-Id: I27e5e4604cd999d778eb84976b3bea0ef35122ee Reviewed-on: https://gerrit.libreoffice.org/64353 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-01tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java test to C++ for ScAreaLinksObj. Change-Id: I374b7301caf67c900b7a64920d2ac5b642a8c6fd Reviewed-on: https://gerrit.libreoffice.org/64376 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01tdf#120703 PVS: the condition needs &&, not ||Mike Kaganski
... ever since commit 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24 V560 A part of conditional expression is always false: nRangeNo < nRCount. The value range of unsigned short type: [0, 65535]. Actually, simple if (nRangeNo < nRCount) would be enough, given that if sal_uInt16 is less than another sal_uInt16, it cannot be equal to greatest sal_uInt16. But let's keep this redundant comparison, in case types or define changes later. Change-Id: I886a0bc847a8c30966dea3ea0670bcee9b43c7f1 Reviewed-on: https://gerrit.libreoffice.org/64021 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-01Simplify containers iterations in sfx2, shellArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I42361d6a73d201db8eb6dca09d79768e2d62051d Reviewed-on: https://gerrit.libreoffice.org/64389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-01tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I38f3e3243f8cb891c9a0fe2f4c68bc76acd1ef44 Reviewed-on: https://gerrit.libreoffice.org/64020 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-01tdf#121844: properly implement autoTxRot supportMike Kaganski
... after commit cf7b97d1328ec2f2c8254abb9ce67d63d9c54c80 Change-Id: If46265f49a85d92254fedb719d76ff7319c092cc Reviewed-on: https://gerrit.libreoffice.org/64396 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-01loplugin:redundantfcastStephan Bergmann
Change-Id: Ifb6a8c21be89b940bb33e4b966785ec3f7113efa
2018-12-01turn on hori scrollbar if WB_AUTOHSCROLL set and content doesn't fitCaolán McNamara
Change-Id: I8812d6d5ccce6f84298a4c978c50f1e84653c559 Reviewed-on: https://gerrit.libreoffice.org/64341 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-01src/dest widget args reversedCaolán McNamara
Change-Id: I60062d5111bbdab4f212770fe33992781254f733 Reviewed-on: https://gerrit.libreoffice.org/64340 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-01weld OfaAutocorrExceptPageCaolán McNamara
Change-Id: I735ca7d70045b278d6b885cc2de35bf76885b487 Reviewed-on: https://gerrit.libreoffice.org/64258 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add missing <bascode> div in page Change-Id: I50e0c7254d9e13582a7c7e544afc657da8c85f9a Reviewed-on: https://gerrit.libreoffice.org/64347 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-12-01sfx2: fix Android build, check HAVE_FEATURE_MULTIUSER_ENVIRONMENTMichael Stahl
Change-Id: I2d78f35898cc514b20500018a7d360e3c78127aa
2018-12-01tdf#58944: comment DOCX table header row limit betterLászló Németh
Change-Id: I725dce3754d5234c4f1398ef5392e72e0249d70f Reviewed-on: https://gerrit.libreoffice.org/64388 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-12-01tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScAreaLinksObj. Change-Id: I89beb6a1c05d853e94ebbedb031d87484cb84b38 Reviewed-on: https://gerrit.libreoffice.org/64373 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01Enable XIndexAccess test casesJens Carl
Add macro OOO_DLLPUBLIC_TEST to class XIndexAccess (needed to use the test cases), refactor ctor, and add missing header files. Change-Id: Id8b27c8c3a3d7fc5c64fafd25b0d9b4b511c281f Reviewed-on: https://gerrit.libreoffice.org/64375 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01tdf#121744 XLSX Export Combinated Chart (Column and Line)Jozsef Szakacs
Each of the Column and Line Chart creates it's own x and y Axes. So now the LineChart Exporter Method uses the same Axes as the BarChart. Thanks for the help: - Balazs Varga - Adam Kovacs Change-Id: Ie763cf831c2ce63ef204d1fdcbff634e7ca8fad5 Reviewed-on: https://gerrit.libreoffice.org/64146 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-12-01convert to range forTomaž Vajngerl
Change-Id: I3558010129eaafdab94ca3f8a63abeda32318fbb Reviewed-on: https://gerrit.libreoffice.org/64336 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-01test signing with certificate chain and private key in PEM formatTomaž Vajngerl
Change-Id: If3b121e44ceec8be668820a7e8a9e35c15d547ff Reviewed-on: https://gerrit.libreoffice.org/64295 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-01xmlsecurity: clean-up code a bitTomaž Vajngerl
Change-Id: I4a43f1f33f73919f56150310e7d05244d81b7510 Reviewed-on: https://gerrit.libreoffice.org/64294 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-01lokit: disable triggering of GUI when changing a signed docTomaž Vajngerl
When a signed document is changed and saved, the dialog pops up on the GUI to warn that the signature will be removed. When saving over the lokit this dialog isn't shown and assumes that we don't want to save (throws an exception) which means we can't save the document ever. This changes the behavior so that we allow removal of the signature and saving can proceed. Change-Id: I52e4a53f0cd3a326c767daee6301a78122af09d4 Reviewed-on: https://gerrit.libreoffice.org/64293 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-01Add SolarMutexGuard where neededTomaž Vajngerl
When triggering rechecking of signature status, an assert fails and brings down the program because we don't hold a SolarMutex. The rechecking of signature status needs to broadcasts. Change-Id: Ib500b06d2e191465df1e0da2097ddb1b6b06725a Reviewed-on: https://gerrit.libreoffice.org/64292 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-01lokit: convert PEM certificate to DER if it is detected as suchTomaž Vajngerl
Change-Id: I1ae105067c109a32f4acc34749b425d9e4e26514 Reviewed-on: https://gerrit.libreoffice.org/64291 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-01sw_redlinehide_4a: MoveDeletedPrevFrames() should only moveMichael Stahl
... frames from a layout with hidden redlines. Change-Id: I8f5d5bbbc5bfd49a8a52579a1c34157b9c5c4515
2018-12-01sw_redlinehide_4a: fix infinite loop in SwAttrIter::Seek()Michael Stahl
It's actually possible for Seek to be invoked with a position that is neither 0 nor >= the current position: lcl_CalcOptRepaint(), called from SwTextFormatter::FormatLine(), will move backwards via some funny heuristic and call GetCharRect(), which then seeks. Change-Id: If061a768b9a0155d9a95b190c44e7048312f4ba3
2018-12-01sw_redlinehide_4a: fix asserts caused by invalid index in SwUpdateAttrMichael Stahl
There is no reason for SwpHints::TryInsertHint() to add 1 to the end index of an empty hint, which results in an invalid index when the end of the hint is at the end of the node. The only user of the indexes in SwUpdateAttr is SwTextFrame::SwClientNotify() and it already extends a 0 range to 1. Change-Id: I7355bac931cd8dd390f96d04546d73273f364cda
2018-12-01sw_redlinehide_4a: stop toggling ShowDelete in SwAutoFormatMichael Stahl
Change-Id: Ib6495d4248faa679d5a55642ac51baf419708287
2018-12-01sw_redlinehide_4a: TextFrameIndex goes liveMichael Stahl
Change-Id: Ie59c09bdc57505e16022c43791d5e65cc233d5b9
2018-12-01sw_redlinehide_4a: SwEditShell::AutoCorrect() etc.Michael Stahl
The hope is that the AutoCorrect never deletes nodes, hence never deletes SwTextFrames, hence we can pass in the SwTextFrame::GetText() result and it will be updated via the SwTextFrame::SwClientNotify() on editing operations. Change-Id: Ib644d0373963119b9f7fe6767b028fd89724feb3
2018-12-01sw_redlinehide_4a: SwAutoFormat::AutoCorrect()Michael Stahl
Change-Id: I0ab7665f8635d6716fce996408db1e2bedf54d0c
2018-12-01sw_redlinehide_4a: SwAutoCorrDoc iterates frames, not nodesMichael Stahl
Adapt this in a similar way, with a DeleteSel() that skips over delete redlines. The Replace functions fortunately only have callers that replace 1 character currently, but there is another ReplaceRange() call that needs a litte more complicated handling. Change-Id: Idd5c80e96c0f355d3dc965b2f70376258d23e1a3
2018-12-01sw_redlinehide_4a: SwAutoFormat iterates frames, not nodesMichael Stahl
In order to not require moving the delete redlines out of the document body, rely on the DeleteSel() implementation skipping over the redlines, and also pass the shell's layout to the various SwDoc functions that are called. Previously, the redlines were not deleted by DeleteSel() due to SwAutoFormat setting RedlineFlags::Ignore. Change-Id: Ib05ecb534993368d81f66e70124617968b4c8e9a
2018-12-01sw_redlinehide_4a: SwAutoFormat: manually skip redlines when deletingMichael Stahl
Change-Id: I001e61305ee8416f851f834d3068bd91de8281f8
2018-12-01sw: fix wrong title of AutoFormat with redlining dialogMichael Stahl
(regression from 9fcef57a34dbd88a98621dfaf8668fa076dd98f1) Change-Id: Id6ea5841dd25a30519deb825c3ae0aaa7469c250
2018-12-01sw: rename misleading DeleteCurrentParagraph()Michael Stahl
Rename also DelPrevPara() and DeleteCurNxtPara(). Also document the state transitions. Change-Id: I0b874852a4c1aab8d5d3a55b9dfef360e313089c
2018-12-01sw: remove nutso check from SwNoTextFrame::PaintPicture()Michael Stahl
This is a remnant of code that was removed with commits 2cbc57c8283d26924d95b77398f85e96ca4ea155 CWS swqbf91 and becf02e58637276ab80227ffb19aa01c86e4962d CWS swqbf89. The level counter was apparently abused to store the load status of SwGrfNode's image. Since the counter is always 0, the condition is always true and TriggerAsyncRetrieveInputStream() is always called here; let's hope not calling it isn't going to break anything. Change-Id: I4cef0ddab081ed2df1fc6e88230a8c19a5632d7e
2018-12-01sw_redlinehide_4a: some page break calls in SwFEShell/PageBreakWinMichael Stahl
... should use layout. Change-Id: Iabb29bb49558ef1c805ede3300042b815f62136a
2018-12-01sw_redlinehide_4a: fix SwDoubleLinePortion/SwMultiCreator/SwBracketMichael Stahl
Missing TextFrameIndex conversion. Change-Id: Ie7b58b74aa6bb1e2ff8199031a9f59f5c3ba68c0
2018-12-01sw_redlinehide_4a: finish conversions guess.cxx,itrcrsr.cxx,porfld.cxxMichael Stahl
... and tests. Change-Id: I847a9441b73cdfc9bd826fad2c9075a9aa1d7d2d
generated by cgit (git 2.34.1) at 2025-01-09 08:51:39 +0000