summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-11-29tdf#158237 sw: use c++20 contains() instead of find() and end()Bogdan Buzea
Change-Id: Ic8622a035fcd3c8a4a9883db9df8275cf6b10a30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176801 Tested-by: Jenkins Reviewed-by: Simon Chenery <simon_chenery@yahoo.com> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-29PVS: V773 The return value of function 'lcl_CopyStyle'...Xisco Fauli
... is required to be utilized. A memory leak is possible. Change-Id: Iae82c6a9dd124ac073c0eb99141d4104b1e05101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177551 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-29add some comments to weld::ComboBoxNoel Grandin
because it took me a while to figure out the magic value here Change-Id: I9a188d23a1f5aaac1bff10f795a916bc30cfb7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177534 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-29fix various getSelectedItemPos implementationsNoel Grandin
clearly we do not often have combobox's that have nothing selected, otherwise these issues would have arisen sooner. The immediate cause of fixing this was the assert VCLXListBox::getSelectedItemPos which was triggered when using X-ray to examine a writer document Change-Id: Ia5ec713ef54a841010a9b680d4520f7160d48167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177532 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-29sw: layout: fix toggling Hidden Paragraphs not shrinking flysMichael Stahl
There are 2 as-char flys with 2 hidden paragraphs each, and when turning off show hidden paragraphs, the paragraphs shrink to height 0 but the flys don't - this is because due to other hidden paragraphs earlier, the position of the flys change and Shrink() is called before MakePos() and then it uses the old position to check and that results in a negative nRstHeight, so the upper doesn't actually shrink. Fix this by always calling MakePos() before MakeValidZeroHeight(). (presumably regression from commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 or one of its follow-ups) Change-Id: I9a4ffadff02b6a2bc59c6a37aa15abec429e1068 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177524 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-11-29sw: layout: fix toggling Hidden Paragraphs that have followsMichael Stahl
When a hidden paragraph is split across pages, there is nothing that joins its follow (SwContentFrame::MakePrtArea() has code to do it but it wasn't called even before the previous commit?) and when the follow is formatted is doesn't move back. So just join all follows asap in SwContentFrame::MakeAll(). (presumably regression from commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 or one of its follow-ups) Change-Id: Icecdf17c1c1e11a3b62c7e5bf2c6624f234c94f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177500 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-11-29loplugin:unusedmethods tweak for less noiseNoel Grandin
Change-Id: Idedd1680b03f6b62ff80ad7d0fd74c11d1675053 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177533 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-29tdf#162514 i18npool: Handle abbreviations in dictionary breakiteratorJonathan Clark
Restores abbreviation handling to spell checking. Regression from commit 44699b3de37f07090ac6fee1cd97aa76036e9700 "tdf#49885 BreakIterator rule upgrades". Change-Id: I2883f984952aa3e54cfe800590a16c0de74ae0e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177506 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-11-29PVS: V614 Potentially null smart pointer 'pFillData' usedXisco Fauli
Change-Id: I3026788bc8a239dc467b0a43c865c9659f392108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177540 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-29sw: layout: fix toggling Hidden Paragraphs resulting in bad layoutMichael Stahl
1. SwContentFrame::MakeAll() needs some more checks to ensure that it never Formats a hidden text frame. This fixes the reported problem that turning off "Hidden Paragraphs" in Tools->Options->Writer->View results in bad layout (extra completely empty page at the end). 3. This means HideAndShowObjects() must be called manually in that case as it was previously called inside Format(), see testHiddenSectionFlys. 2. SwTextFrame::Prepare() as called from calcing some upper (table cell) in the bugdoc needs to avoid invalidating a hidden frame so it isn't formatted (triggered new assert). 4. SwLayAction::IsShortCut() had what looks like an obvious and ancient mistake that was causing a crash in testTdf155011. 5. SwTabFrame::MakeAll() should not calc the next if it's hidden, that was causing a problem in testThemeCrash where a hidden frame moved back into an overfull body and immediately forward again, triggering the new asserts. 6. SwTextFrame::IsHiddenNow() caused interesting problem where some ancient (CVS import) check for a 0 width would skip the invalidating due to the 2. change when called from SwViewShell::Reformat() ... lcl_InvalidateContent() in testParagraphMarkInCell; unclear why this check exists, let's avoid it for the cases where we definitely know that only doc model should determine visibility. 7. JunitTest_sw_unoapi_1 triggers new asserts because MakePos() in a cell ends up invalidating the text frame; fix it up again. (presumably regression from commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 or one of its follow-ups) Change-Id: I619f4be852eca5124f49d9a91e1de658b7070074 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177486 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-11-29cid#1606728 Overflowed integer argumentCaolán McNamara
Change-Id: I6fef2b6818018b8a0f82125ef2d8220688d642a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177536 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-29crashtesting: failure to export forum-mso-en4-491312.xlsx to odsCaolán McNamara
probably since: commit 65129e0bc5abfe7afc612eb46f1434e627265a7d CommitDate: Tue Feb 2 22:06:18 2021 +0100 tdf#137081, tdf137082 fixes shape handling in RTL sheets Change-Id: Ife720a0ccbff0029ace822d246dc227e01846734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-29Related: tdf#163945 don't directly flush graphics with Skia/MetalPatrick Luby
When dragging a selection box on an empty background in Impress and only with Skia/Metal, the selection box would not keep up with the pointer. The selection box would repaint sporadically or not at all if the pointer was dragged rapidly and the status bar was visible. Apparently, flushing a graphics doesn't actually do much of anything with Skia/Raster and Skia disabled so the selection box repaints without any noticeable delay. However, with Skia/Metal every flush of a graphics creates and queues a new CAMetalLayer drawable. During rapid dragging, this can lead to creating and queueing up to 200 drawables per second leaving no spare time for the Impress selection box painting timer to fire. So with Skia/Metal, throttle the rate of flushing by calling display on the view. Also, with the reduced Skia/Metal flushing load from this fix, the color conversion when drawing to an NSBox appears to be no longer needed. The converted color appeared less saturated, at least to me, so accept the (hopefully now imperceptible) performance hit of drawing an NSBox with native colors. Change-Id: I55b4ab763bf20c6c2acad65587b703fc6f645264 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177530 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins
2024-11-29tdf#163989 a11y: Avoid "showing" event on empty notification labelMichael Weghorn
The label in the search bar has a notification a11y role in order for the text (like "Search key not found") to be announced when screen readers receive an event indicating that the notification became visible (an object:state-changed:showing event for AT-SPI on Linux). However, commit 48ba98a51f029cd14b5d982dab36eb581d40fef3 Date: Wed Nov 29 14:29:57 2023 +0100 Resolves tdf#158412 - Don't show chevron in quick find bar caused this event to be triggered also when the label has no text, which resulted in Orca just saying "Notification", without any indication what that notification might be. Avoid that by not setting the label to hidden at the beginning of LabelItemWindow::set_label if the label text is empty, so setting it to visible again doesn't have any effect if it's already visible when the method gets called. An alternative might be to switch to using dedicated notification events instead of using a label with a notification a11y role, now that that kind of event is available in AT-SPI2 since at-spi2-core-commit [1] commit 26835da29918be2c0da6c08fb70d893de22891d2 Author: Mike Gorse <mgorse@suse.com> Date: Thu Aug 4 12:38:27 2022 -0500 Add an "announcement" event/signal to allow objects to send notifications Fixes #63 [1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/26835da29918be2c0da6c08fb70d893de22891d2 Change-Id: Ia4fbf9544f72e10c74e92487619222d59f55cfa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177523 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29sfx2 lok: fix crash in SfxLokHelper::notifyOtherViewsUpdatePerViewId()Miklos Vajna
Crashreport signature: > SIG Fatal signal received: SIGSEGV code: 1 for address: 0x0 > program/libmergedlo.so > SfxLokHelper::notifyOtherViewsUpdatePerViewId(SfxViewShell const*, int) > sfx2/source/view/lokhelper.cxx:1098 > program/libswlo.so > SwSelPaintRects::Show(std::vector<rtl::OString, std::allocator<rtl::OString> >*) > sw/source/core/crsr/viscrs.cxx:514 ... > program/libswlo.so > SwWrtShell::SwWrtShell(SwDoc&, vcl::Window*, SwView&, SwViewOption const*) > sw/source/uibase/wrtsh/wrtsh1.cxx:2032 ... > program/libmergedlo.so > framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) > framework/source/services/desktop.cxx:592 I.e. it can happen that during load we don't yet have a view, similar to commit a2b22f5b551cb2030cd29d3dd3510fca42a0bfc1 (sfx2 lok: fix crash in SfxLokHelper::notifyUpdate(), 2024-11-26). Change-Id: Id17a61296a181a2ba4909b633d46a3c9d7aacb02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177525 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-29fix refreshing git-hooks when using git-bashChristian Lohmaier
real symlinks require admin-rights or developer mode, and the other fallback mechanisms won't work for the version of git that comes with git-bash. Either spawning the process failes or worse it silently fails and basically ignores the hook. MSYS uses regular file copy when using "ln -s" which means to make sure the current version of a hook is used the hooks need to replaced everytime or the file contents need to be compared. When using hardlinks instead it is enough to check whether the source and target share the same inode. Change-Id: Ib2e325048779828313afc7fc9d120661d55fc3a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177498 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-11-29Update git submodulesMarco A.G.Pinto
* Update dictionaries from branch 'master' to 0fdcd7916f2e59da20419d408cad8bcb909c5ae5 - Updated the English dictionaries: GB+ZA Change-Id: Ifea0bef5714162def9b5adc7dd20c1d6d69d05e0 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/175966 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2024-11-29tdf#163325 - Check Lower() frame during ToC previewAndreas Heinisch
Change-Id: Ife0e974d66d5ddbe3c831c64e4da28442e476da4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177234 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2024-11-29pdf: R6 hash algorithm and test, introduce PDFEncryptorR6Tomaž Vajngerl
This adds PDFEncryptorR6 and adds R6 hash implementation and makes sure it is correct with a test. Change-Id: I11ca746a6b676bb294723b4ef76069f1d4f3a182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177384 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-11-29PVS: the 'bDummy' variable was not initialized.Xisco Fauli
This variable is passed by a reference to the 'readArguments' function in which its value will be utilized. Inspect the fifth argument. Change-Id: I39d71ac5e76d3d9a808fa08a430af9aa0686684d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177494 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-29tdf#164048 sw a11y: improve error/warning levels withBalazs Varga
adding two A11y issue level: Error and warning level, and categorizing our accesibility issues based on how the PAC 2024 tools and WCAG behave with the different warnings/errors. Change-Id: If4e4800497340318bb990326c64de655f24a47e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177389 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-29lok: slideshow: animated shape bounding box in twipsMarco Cecchetti
Since we have slide size in twips we need shape bounding box in twips too. Change-Id: I41e4658278e7b36b87a6bccc72b429944ef27e4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177522 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-11-29tdf#130857 qt weld: Implement QtInstanceTreeView::set_selection_modeMichael Weghorn
Change-Id: I1b41a57ccdda4cdbd8a3a8ab3dbde495a51df80e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177508 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29cid#1607551 silence Overflowed constantCaolán McNamara
Change-Id: I128a60a312fe15a3333bd7dad37257c80fb20d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177521 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-29cid#1634810 Overflowed constantCaolán McNamara
Change-Id: I634a88af23116fd823b9b595cdb801a032593688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-29m_pDocShell seen as null in SwXTextDocument::getPostItsCaolán McNamara
#2 SwView::GetPostItMgr (this=<error reading variable: Cannot access memory at address 0xc8>) at sw/inc/view.hxx:659 #3 SwXTextDocument::getPostIts(tools::JsonWriter&) () at sw/source/uibase/uno/unotxdoc.cxx:3351 #4 0x00007f6238ac7cc8 in getPostIts (pThis=0x36aa6cb0) at /opt/rh/devtoolset-12/root/usr/include/c++/12/ext/atomicity.h:111 #5 doc_getCommandValues () at desktop/source/lib/init.cxx:6739 #6 0x00000000005863e0 in lok::Document::getCommandValues (pCommand=<optimized out>, this=<optimized out>) at /home/collabora/jenkins/workspace/package_cool_24.04_rpm/rpmbuild/BUILD/coolwsd-24.04.9.2snapshot/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx:492 #7 ChildSession::getCommandValues(StringVector const&) () at kit/ChildSession.cpp:1180 Change-Id: Ib2a3c2e7eb1a108ad969588f6c313cade145e8ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176600 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit c0542a438d91051bcdab1f5bc19ee46c90bd91a7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-29cid#1635775 Use of auto that causes a copyCaolán McNamara
looks like a stray line I think Change-Id: I065a35d6e161c37d832e308f7ed1ce239e4e2bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177516 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-29tdf#164046 style searching improvement breaks Impress layoutNoel Grandin
regression from commit 6c2f827697b898c9d351b79c2dbb5aefc8b70dcc Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sun Oct 20 15:07:41 2024 +0200 improve style searching in SvXMLStylesContext Two problems - the original code was searching by DisplayName, not Name, so add another index for DisplayName, and the prefix matching was not properly matching. Change-Id: Ifd43bdb89d33067954298115c8700b87c7f93050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177488 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-29Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to dc50ebde81a0e9266806878b69de81da422ec39c - Revert "enable help for Tagalog (tl)" This reverts commit 3d37519d37c1ac9e5d30b45f1cd922c73107d4d1. Reason for revert: apparently not all files have been added for master Change-Id: Ia0979a8abca4aa598563598276c9a9c0e0518a33 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177515 Tested-by: Jenkins Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-11-29android-viewer translated using WeblateWeblate
Interlingua currently translated at 75.8% (88 of 116 strings) Change-Id: I6f6529872aa3c3cf3553eacebe280195fa5f0699 Co-authored-by: Weblate <noreply@documentfoundation.org> Co-authored-by: eduver <hmcb2080@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177478 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29lok: jsdialog: enable font name box after saveSzymon Kłos
When we save - we block UI. In the lok we disable that for some cases like in commit e005690e9c648ce516c1ed60da6341c7215bf2c9 lok: avoid sending jsdialog messages during background save. But we also use save file to generate previews of shapes what happens on eg. resize in Online. Then we trigger disable and enable cycle for frames - and we end with FontNameBox enabled! That was causing the JSDialog combobox still being locked - because frame unlock was using direct VCL API, not weld:: one in the InterimItemWindow. Let's fix that with proper StateChanged handling. So now it is functional. But still I think there is some error in the logic - as after save we should beg the "before save" state of control not "always enabled". But it's different problem. Change-Id: Ia8e5c8c864156271b5f68d482234e83eb57b0deb (cherry picked from commit cbe229ec219e56ce1bb5dd9598f9052a98504249) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177489 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-11-29tdf#158237 Use C++20 contains() instead of find() and end()Simon Chenery
Change-Id: I596245603c0945438a940465122cb4c3e6954e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177140 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-29tdf#146553 Enable additonal functions in editable section while in r/o modeOliver Specht
Insert/Edit table, insert lists, insert AutoText automatic spell checking Change-Id: Iccef3965316dc6079ea56a0283023c5a658512cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165031 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-11-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to aa5fa6c008064ee28c01354b1f40920b2de83b2c - Mute L10N in Navigator context help page Change-Id: I5211d028909ca140fbe2d9eed6fa57cbf57b84c5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177510 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-28sc a11y: Make 2 members non-mutableMichael Weghorn
... and use a non-const pointer when iterating instead. Change-Id: I165b0ce907cadacc76562bff974ff913a3a711da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177480 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-28tdf#163913 Implement font-relative marginsJonathan Clark
This change adds loext:margin-left and loext:margin-right, which implement margins that support font-relative units. See tdf#36709 for additional details. Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-28tdf#143148: Replace include guards with #pragma once in XpmReader.hxxManish
Change-Id: I2708f103cb9e63294cd2ee056dc490c734285a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177487 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-28crash seen in export of forum-mso-en-2962.doc to rtf and reimportCaolán McNamara
Change-Id: I3813d8ebcb1e678ece2e3c3554bb0ddb7b546b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-28Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to 3d37519d37c1ac9e5d30b45f1cd922c73107d4d1 - enable help for Tagalog (tl) Change-Id: I0e35015d4d2526ea0d09404140a1ee73ce658350 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175653 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-11-28Fix typoAndrea Gelmini
Change-Id: I8ac3024a3865a5e2e45d9eca70f1ca5e067971c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177495 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-28cid#1607902 Overflowed constantCaolán McNamara
Change-Id: Id43616644bc8495a6a5944de099ddfc29016bbe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177484 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-28clarify that nNum is reused for two different thingsCaolán McNamara
so the first use of nNum is dead after scope no logic change intended Change-Id: I81a51531418b32a09f5b9dba1131bc65ac71df3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-28we can deindent this and make it conditionalCaolán McNamara
given that we return early on the opposite condition no logic change intended, git diff -w is your friend Change-Id: I37b7db3a1d092ffbe0ef41561982555f6b6d3bae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177482 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-28return early if bUseChkStr is trueCaolán McNamara
no logic change intended Change-Id: Ie1b4d15af35b01c9f490db7eb33c9493775ab9b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177481 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-28cool#4250 - add API to set per view options.Michael Meeks
Change-Id: I5e3b3b3548ba93b96b33fe682405a2b0b53bbdee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176715 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 8dcb86a4a724f143f7d5cfcc3d1231a7f924cbd9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177445 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2024-11-28lok: getSlideShowInfo: interactions: check that properties are availableMarco Cecchetti
Not all properties are available for all kind of shapes. In this case Visible is not available for a SvxFrameShape. Change-Id: I7811ab6cd04d782f8758fbee449bbc5bc421fd51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177470 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-28tdf#164074 sw inline heading: add up/down outline movingLászló Németh
Move inline headings with their outline tree in Navigator, clicking on the Move Heading Up/Down icons. Instead of changing CompareSwOutlineNodes, which breaks the code at other places, add a new SwOutlineNodesInline and CompareSwOutlineNodesInline to sort inline headings (put in Inline Heading frames) with normal headings only for MoveOutlinePara and other part of Navigator's outline moving. Reordering chapters and sections using the Navigator was limited for normal (root) headings, but not for headings in text frames and tables. Recent implementation of inline headings use text frames with Inline Heading frame style, anchored as characters to their paragraphs. Now these inline headings are movable with the Navigator, with their outline tree, i.e. the paragraph where the inline heading anchored as character, the following paragraphs without inline heading, or the following subsections. Note: selecting the inline headings is possible by the Navigator content tree or or by clicking inside the text of the inline heading in the document. Note: according to the fix for tdf#143569, multiple headings in the same text frame or table are ordered alphabetically in the Navigator. This doesn't effect the inline headings, where there is only a single heading in an Inline Heading text frame. Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880 "tdf#48459 sw inline heading: apply it on the selected words", commit d87cf67f8f3346a1e380383917a3a4552fd9248e "tdf#131728 sw inline heading: fix missing/broken DOCX export" and commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8 "tdf48459 sw inline heading: add Inline Heading frame style". Change-Id: I7618aa1d4e1ddc20512d81c9a2babfa660053cbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177438 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-11-28Fix typosAndrea Gelmini
Change-Id: I60eaa9de20577ef7c7930c3ade23851c91ea3260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177475 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-28loplugin:fakeboolStephan Bergmann
Change-Id: I41d767833eb3dbc4264c1d6b63b7ddb71e422472 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177469 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-11-28loplugin:reftotempStephan Bergmann
Change-Id: I6ec03b1c3238a9c222444078b3d9b5ccb40d81d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177468 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
generated by cgit (git 2.34.1) at 2024-12-28 18:22:51 +0000