summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-25vcl: add some basic Bitmap testsChris Sherlock
Change-Id: Ib697f0499cd40b44eab154794c227574cf831eef Reviewed-on: https://gerrit.libreoffice.org/50282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25tdf#115895 - Color picker images missing in ImpressNoel Grandin
VirtualDevice does not have an alpha channel by default. Change-Id: I4eebd7a23546a77dc9df2e2dad12d37eec4560ef Reviewed-on: https://gerrit.libreoffice.org/50248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25forcepoint #8 ensure ColumnDef lifetimeCaolán McNamara
Change-Id: Idb0c7b1530dc57f4d7c14751f1b76caecc3b03a6 Reviewed-on: https://gerrit.libreoffice.org/50288 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25forcepoint #7 check ksc5601_2uni_page21 boundsCaolán McNamara
Change-Id: I578e7a63bb50f2088d35174d88f075c00469bad3 Reviewed-on: https://gerrit.libreoffice.org/50285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25convert all help responses to gtk's -11Caolán McNamara
and ok responses to gtk's -5 and cancel responses to gtk's -6 and close responses to gtk's -7 and yes responses to gtk's -8 and no responses to gtk's -9 Change-Id: Ia1a261a3a711ed9f5d8c0b0c639897c3064bb08c Reviewed-on: https://gerrit.libreoffice.org/50206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-24starmath: Adjusting by 0 is the same as doing nothingTakeshi Abe
Change-Id: I417c67ca8be458befff4ff3151404fe3833e7582 Reviewed-on: https://gerrit.libreoffice.org/50227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2018-02-24Resolves: tdf#104250 import sheetProtection hash attributesEike Rathke
Change-Id: Ibae0934a84173b0933a03a6050abaaf3384404cb
2018-02-24Write ScOoxPasswordHash to OOXML if set, tdf#104250 prepEike Rathke
Change-Id: I51996c673e6c44bbfc27972800d78d9807fe67db
2018-02-24Handle mbEmptyPass and empty hash with OOXML hash value, tdf#104250 prepEike Rathke
Change-Id: Ib24102c442c4675cc5b256fcf8e9d81370aba11f
2018-02-24Add ScTableProtectionImpl::setPasswordHash() for OOXML, tdf#104250 prepEike Rathke
Change-Id: I9589f750cf2f69f4b725cd351aa9ef3749190431
2018-02-24Check also ScOoxPasswordHash::verifyPassword(), tdf#104250 prepEike Rathke
Change-Id: Idf1ec7a4b7cde674891df05aae369c403c028fee
2018-02-24Add ScOoxPasswordHash::verifyPassword(), tdf#104250 prepEike Rathke
Change-Id: Ife588fa0626b01336813e956a25e51541d1096e6
2018-02-24Consider ScOoxPasswordHash in isProtectedWithPass(), tdf#104250 prepEike Rathke
And clear in setPassword() Change-Id: Ib68bb5be8d6908909afc1e1d5bd6bbeccb6d0083
2018-02-24forcepoint #6 release virtual devices before releasing font cacheCaolán McNamara
Change-Id: Iacfbe7da788235c96519ecd106d09ab534c83849 Reviewed-on: https://gerrit.libreoffice.org/50281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-24Use for range loops in basegfx and basicJulien Nabet
Change-Id: I5b2086c245695aeb30630150b3c5ccf61fbd6a56 Reviewed-on: https://gerrit.libreoffice.org/50280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-24Fix typosAndrea Gelmini
Change-Id: Ie1cff6b690e69d23c16a1a60ef4271d6cf48c13b Reviewed-on: https://gerrit.libreoffice.org/50260 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-24EventHolder used in dynamic_cast should better be SAL_DLLPUBLIC_RTTIStephan Bergmann
...so that the dynamic_cast is guaranteed to work on macOS (where RTTI equivalence is determined by address, not by strcmp). The relevant dynamic_castis in DocumentEventNotifier_Impl::processEvent in dbaccess/source/core/dataaccess/documenteventnotifier.cxx, and at least during a `make check` it appears to only be fed dbaccess::DocumentEventHolder (aka comphelper::EventHolder<css::document::DocumentEvent>) instances also created in documenteventnotifier.cxx (so the dynamic_cast happens to work fine also on macOS in that case). But better be conservative and mark EventHodler as SAL_DLLPUBLIC_RTTI after all. Change-Id: I99c842418d3f51265d96b8deb0dfc6c7a1540be5 Reviewed-on: https://gerrit.libreoffice.org/50258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-24[Pardus] tdf#112481 Ability to add worksheets on CalcMert Tümer
This patch is sponsored by ULAKBIM/PARDUS project. Signed-off-by: Mert Tümer <merttumer7@gmail.com> Change-Id: Id67e3c400971b47738fe2f628955534f34839493 Reviewed-on: https://gerrit.libreoffice.org/49294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-24Removed duplicated includesAndrea Gelmini
Change-Id: I04ea7b0e923e903210aef81e9d72e554bbf9e1c9 Reviewed-on: https://gerrit.libreoffice.org/50208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-24Make shell stack more robust against rogue extensionsKatarina Behrens
It shouldn't happen that a view is placed above the shells it has spawned on sfx2 dispatcher's shell stack 'cause during dispose, such view gets deleted before the shells that still refer to it. Alas it does happen with Wollmux (which makes couple of Writer UNO API calls before SwView is activated) so guard against that Change-Id: Ic7f21992c5e55a48c63dffc733c8f5b0a59a9126 Reviewed-on: https://gerrit.libreoffice.org/50256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-24tdf#115880 end drawview text editing on move navigationJim Raykowski
and leave draw mode This fix provides a bonous fix for incorrect behaviour of Table move when a Drawing Object has focus. Change-Id: Id554f4f0bac547e65f47544f116f40f49d4d6135 Reviewed-on: https://gerrit.libreoffice.org/50154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-24tdf#115968: make libcmis work better with CIB doximaAndreas Brandner
Change-Id: I1758bcee9a191937ed265dc26212f259a59fffef Reviewed-on: https://gerrit.libreoffice.org/50231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-24Remove accidently committed debug linesTamás Zolnai
Change-Id: Id083a3bb38ba89e00239e71387377691afd4f31c
2018-02-24sd lok: Delete selection highlight after cutting text.Tamás Zolnai
Call drawing also after the new selection is set, similar to other cases where DrawSelectionXOR() is called before and after selection change. In desktop LO drawing is always called again and again by timeout, so there the selection is updated anyway, while in LO online painting does not emit a notification. Change-Id: I6e9337fc0cfb61656387ba44d901521c3dfa60dd Reviewed-on: https://gerrit.libreoffice.org/50268 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-24Hash Base64, Sequence and cleansing, tdf#104250 prepEike Rathke
Change-Id: I58d48b8caa780138b8431bec9db20c9d0e9abce7
2018-02-24Hold ScOoxPasswordHash at ScTableProtectionImpl, tdf#104250 prepEike Rathke
Change-Id: I8a3e7e0a29058708ac0a2c5b78afc69bf7bf04a6
2018-02-24Add ScOoxPasswordHash::clear(), tdf#104250 prepEike Rathke
Change-Id: Iaf3bb2ad74fe99435c74e9ea018168ff7e92a977
2018-02-24Modernize a bit accessibility and basctlJulien Nabet
by using for range loops + compare end iterator with "!=" instead of "<" Change-Id: I615a8ca417a58fde4976bb6d8d9112dc5d993a88 Reviewed-on: https://gerrit.libreoffice.org/50277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-24Implement OOXML password hashing algorithm, tdf#104250 prepEike Rathke
As per https://msdn.microsoft.com/en-us/library/dd920692 Change-Id: Iebacaf3549dab28fd3033f9c241130fd66782b25 Reviewed-on: https://gerrit.libreoffice.org/50259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-24tdf#115863: fix TIFF importAron Budea
Regression from 651e1f6cda04468394c65c2fd88d915902ac0306 Change-Id: Id1604fb8eb11ea4e39846591e3912b40a7e7cc96 Reviewed-on: https://gerrit.libreoffice.org/50269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2018-02-24add test for deduplicating cond format against same formatMarkus Mohrhard
Change-Id: I9e21b5b53f7a3c579bdaf5dc0dd6102be805faf9 Reviewed-on: https://gerrit.libreoffice.org/50217 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-24better same document test for conditional format copy&pasteMarkus Mohrhard
Change-Id: Ic896202e072a036108c06768f29ba767d3ea7769 Reviewed-on: https://gerrit.libreoffice.org/50218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23tdf#115828: hsqldb supports multiple resultSetsJulien Nabet
Regression from 3c567e55e6aed9e0da892d8b9fc09f8a0c784fcc Thank you to Lionel for this suggestion Change-Id: I5eeadc1968e57d586e55a7aa5488b2ab3ee43724 Reviewed-on: https://gerrit.libreoffice.org/50202 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-23forcepoint #5 null derefCaolán McNamara
Change-Id: I95b67f98b7028d7ca7c4a9d1c15100e42d359816 Reviewed-on: https://gerrit.libreoffice.org/50241 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-23Revert "tdf#96892 3 to 5 digit precision"Caolán McNamara
1 to 3 was helpful, reportedly 3 to 5 isn't. This reverts commit c4b23192b4ab1f3ea75df7e48da36b6b17de248b. Change-Id: I51d31a8473ff51f1dcc89a063af568803efe5e11 Reviewed-on: https://gerrit.libreoffice.org/50252 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-23StyleSheetUser use in dynamic_cast should better be SAL_DLLPUBLIC_RTTIStephan Bergmann
...so that the dynamic_cast is guaranteed to work on macOS (where RTTI equivalence is determined by address, not by strcmp). The relevant dynamic_cast is in SdStyleSheet::IsUsed in sd/source/core/stlsheet.cxx, and at least during a `make check` it appears to only be fed SdStyleSheet instances derived from StyleSheetUser (and SdStyleSheet is also defiined in Library_sd, so the dynamic_cast happens to work fine also on macOS in that case). But better be conservative and mark StyleSheetUser as SAL_DLLPUBLIC_RTTI after all. Change-Id: I760f58357b7fe3b4826ea496934e03da3499419e Reviewed-on: https://gerrit.libreoffice.org/50246 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-23tdf#103571: Avoid spurious heavy SalEvent::DisplayChanged callbacksTor Lillqvist
It seems that on some Macs that the NSApplicationDidChangeScreenParametersNotification is sent for unknown reasons quite often. I can reproduce the problem by changing the Dock size in System Preferences while LibreOffice is running, but others seem to get it without resorting to such trickery. The code used to invoke the SalEvent::DisplayChanged callback in all cases, which can be extremely heavy, as it involves re-measuring text layouts all over the place in all open document windows. Avoid that if the geometry in fact has not changed. Sure, there still is the problem that LibreOffice can become unresponsive for several seconds when the display geometry *does* change, like when you attach or detach a display. Change-Id: I659881e5e392bd599f6be190835e32a77d9f4725 Reviewed-on: https://gerrit.libreoffice.org/50249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-23Move OOXML password definitions to struct ScOoxPasswordHash, tdf#104250 prepEike Rathke
Change-Id: I595d5ae8db6f739900afdfdde1e36b0a0b1d2179
2018-02-23tdf#115873 sd navigator: adapt IsEqualToDoc() to Fill() furtherMiklos Vajna
SdPageObjsTLB::Fill() populates the navigator tree list box, SdPageObjsTLB::IsEqualToDoc() determintes if it has to be refreshed or not. Commit f3c68cdf8f6a0273c62b493552f78af0138a44e8 (tdf#115873 sd navigator: allow selecting but not focusing on objects, 2018-02-21) already brought IsEqualToDoc() closer to Fill() with using the same iteration mode for the SdrObjects, but that's not enough. Fill() uses flat iteration, then checks for group shapes explicitly and visits them recursively. Change IsEqualToDoc() to do the same, this way selecting "Rectangle 3" in the testcase won't result in a jump back to "Slide 1" (as an effect of IsEqualToDoc() returning false for an up to date tree list box). Change-Id: If2543cbc282af06ba43d4804e7ed455c8b9828cd Reviewed-on: https://gerrit.libreoffice.org/50234 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-23deduplicate cond format against source format if possibleMarkus Mohrhard
Change-Id: Ie4bbbb078f2d0456cd5f3ad6e2c5627aca9fbaa9 Reviewed-on: https://gerrit.libreoffice.org/50216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23add test for tdf#115835Markus Mohrhard
Change-Id: Ic07e35fcba503461793abb88b463b6e43ca61972 Reviewed-on: https://gerrit.libreoffice.org/50212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23forcepoint #5 check for short readCaolán McNamara
a zip file within a structured storage stream. underlying storage stream claims larger size that it can satisfy on read Change-Id: I8516b12df33ad78b2525192826f5e3aef2622eb8 Reviewed-on: https://gerrit.libreoffice.org/50238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-23tdf#115374: add GPG SEInitializer service for WindowsThorsten Behrens
Amends commit 1c58b047d117bb087abc571b74c06cdf7499b1a0, seems we need that now on Windows, too Change-Id: Ia0c5e1e577a4f8dfe02b4d8eda0d220fa5e5f2a1 Reviewed-on: https://gerrit.libreoffice.org/50235 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-23Fix --enable-python documentationSamuel Thibault
python is always used at build-time. Saying that --disable-python disables python support at build-time is confusing. Change-Id: Ic7206c832b1cf3ee41d67152198660c13aa86652 Reviewed-on: https://gerrit.libreoffice.org/50229 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-23Don't reformat all connectors every time spellchecking timer firesKatarina Behrens
Editing document with many (~1k) connectors eats all available CPU power as every spellchecking event locks and then unlocks SdrModel which in turn repositions ALL connectors in entire document, so let's not do that Additionally, set OutlinerParaObject and broadcast only when something has actually changed Change-Id: I647b7309729dce153b8e05eff4677fe7bb9840a7 Reviewed-on: https://gerrit.libreoffice.org/49995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-23tdf#114768: Update default font list for Simplified ChineseYousuf Philips
Change-Id: I23e92f1248d8f0bc424278e565bd5bfdbe30f7c5 Reviewed-on: https://gerrit.libreoffice.org/49520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2018-02-23tdf#113651 Sync Calc Track Changes commands with WritersYousuf Philips
For a consistent UX Change-Id: I1ad937124786d2e7d0a752f819144172ae902ed5 Reviewed-on: https://gerrit.libreoffice.org/45267 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-23new loplugin:doubleconvert to with ColorData workNoel Grandin
Change-Id: Ib8f2ef485f548645c4b0e7cf080b72b28c4e278d Reviewed-on: https://gerrit.libreoffice.org/50226 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-23blind android build fixCaolán McNamara
Change-Id: I8e5722ee922c609fa71c766692f79f138217bf05
2018-02-23oss-fuzz: explicitly mention the rc files we wantCaolán McNamara
Change-Id: Iabefbc3873b45f58fb8e493d043b0e08a3f425f9