summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-02-19KDE5FilePicker: Fix build on 32 bit archsMichael Weghorn
This fixes the following build error on 32 bit archs as reported by ricotz for LibreOffice 6.2.1.1 on #libreoffice-dev: [build CXX] vcl/unx/kde5/KDE5SalGraphics.cxx In file included from /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.h:29, from /<<PKGBUILDDIR>>/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hdl:6, from /<<PKGBUILDDIR>>/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XTypeProvider.hdl:6, from /<<PKGBUILDDIR>>/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XTypeProvider.hpp:6, from /<<PKGBUILDDIR>>/include/cppuhelper/compbase.hxx:25, from /<<PKGBUILDDIR>>/vcl/unx/kde5/KDE5FilePicker.hxx:22, from /<<PKGBUILDDIR>>/vcl/unx/kde5/KDE5FilePicker2.cxx:20: /<<PKGBUILDDIR>>/include/cppu/unotype.hxx: In instantiation of ‘static const com::sun::star::uno::Type& cppu::UnoType< <template-parameter-1-1> >::get() [with T = int]’: /<<PKGBUILDDIR>>/include/cppu/unotype.hxx:321:37: required from ‘const com::sun::star::uno::Type& cppu::getTypeFavourUnsigned(const T*) [with T = int]’ /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.hxx:268:55: required from ‘void com::sun::star::uno::operator<<=(com::sun::star::uno::Any&, const C&) [with C = int]’ /<<PKGBUILDDIR>>/vcl/unx/kde5/KDE5FilePicker2.cxx:664:22: required from here /<<PKGBUILDDIR>>/include/cppu/unotype.hxx:296:38: error: no matching function for call to ‘cppu_detail_getUnoType(T1*)’ return cppu_detail_getUnoType(static_cast< T1 * >(0)); ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I5b734160c4ce218a9a982ba4a595add13affa365 Reviewed-on: https://gerrit.libreoffice.org/67983 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-19svx: allow UINameSingular property.Mark Hung
UINameSingular is used in the title of the animation effect. It was missed in media objects, contorl objects, frames, tables, etc., causing the title of the animation effect to become just a number without prefixing object type before it. Change-Id: I7446d59b1b80102c34b8326e20927f60ad24da25 Reviewed-on: https://gerrit.libreoffice.org/67934 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-19tdf#122624 XLSX OLE in DOCX: export view positionsLászló Németh
of the visible sheet of an embedded spreadsheet, instead of exporting always the first column and row. Change-Id: Iaf87bfc5b7658cd4d64cb9c83c50bbf66fd6e7f0 Reviewed-on: https://gerrit.libreoffice.org/67982 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-18tdf#122624 XLSX OLE in DOCX: import view positionsLászló Németh
of the visible sheet of an embedded spreadsheet, instead of showing always the first column and row. Change-Id: I7b712d97f152da3cecf8371e21cf0a82ef21f199 Reviewed-on: https://gerrit.libreoffice.org/67867 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-18Update git submodulesRoman Kuznetsov
* Update helpcontent2 from branch 'master' - HELP: Add new internal error codes for Calc Source - /core/include/formula/errorcodes.hxx Change-Id: I64fcef138cf9ec89d4501ea71aa4bab54d9d04fd Reviewed-on: https://gerrit.libreoffice.org/67620 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-18oox smartart, cycle matrix: handle aspect ratio in composite algoMiklos Vajna
This way the 4 quadrant shapes in the center of the SmartArt form a circle, as width is shrinking. It's not height growing, as OOXML spec clearly says "ar" always just shrinks one axis. (>1 and <1 "ar" is to be handled when they are seen in action in an actual document.) Change-Id: I69f2390ee881253151cccc336ecbf1806a1216dc Reviewed-on: https://gerrit.libreoffice.org/67980 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-18android: Add a missing dependency.Jan Holesovsky
Useful when you switch sdk to a different location. Change-Id: I95301cc9adf50a0bbd918cc7562b8871093625b8 Reviewed-on: https://gerrit.libreoffice.org/67873 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-02-18Resolves: tdf#122355 search help for active notebook pageCaolán McNamara
before checking for the dialog, to get more specific help results. Change-Id: I2d6128fa39d3f7ebf15e194354307dd924590009 Reviewed-on: https://gerrit.libreoffice.org/67973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-18make Makefile-clang.mk also use gb_Output_announceLuboš Luňák
So that the output is consistent, even though the actual build handling is different. Change-Id: I460dfe4c2ac74515cc1b598d47e119eb249b8277 Reviewed-on: https://gerrit.libreoffice.org/67972 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-02-18make uninteresting code in clang's makefile to the uninteresting partLuboš Luňák
Change-Id: I235284c7198aa2a295b4d81ff2f8e9ca554a4174 Reviewed-on: https://gerrit.libreoffice.org/67971 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-02-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Housekeeping in some BASIC Help embeds Change-Id: I6bbc8f8450d2160b9715b90d066e51278aaf564d Reviewed-on: https://gerrit.libreoffice.org/67976 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-18oox smartart, cycle matrix: fix too large height in composite algoMiklos Vajna
The user-level problem was that the height of the entire smartart was too large. The reason for this was that: - composite algorithm gets the constraint height should be 77% of width, this means 6096000 -> 4693920 EMUs - at the same time the parent container is already smaller, 4064000 EMUs - a few lines later we already limit the max height with std::min(), but in the meantime an incorrect y position is calculated, exactly due to the lack of early limited height Solve the problem by making sure composite algorithm never works with a height (even when using it to calculate vertical center) that exceeds the height of the parent. Change-Id: Iba29ed8b6e376bf379c40f1cddfce3ae45beff0a Reviewed-on: https://gerrit.libreoffice.org/67970 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-18reorder to reduce size from 64 to 48 bytesCaolán McNamara
ofz#13164 1.200G -> 1.195G Change-Id: I3738b7635a7927f1f88021e5bf00dcc5509e6ea3 Reviewed-on: https://gerrit.libreoffice.org/67960 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-18Make findOperator more precise wrt acceptable parameter typesStephan Bergmann
Change-Id: I0a1ea253d999c9444344188d764134e83ae0c495 Reviewed-on: https://gerrit.libreoffice.org/67959 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-18use unique_ptr in OComponentEventThreadNoel Grandin
and simplify - by passing in a std::unique_ptr to addEvent we avoid the need to have a virtual clone method Change-Id: Ie425476a3158c7a66e399c2a9f33d2612dab5cbb Reviewed-on: https://gerrit.libreoffice.org/67962 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-18use clear() instead of erase(begin, end)Noel Grandin
Change-Id: Ie1dcff4c2e5f52521b4172ef5726413a9d048214 Reviewed-on: https://gerrit.libreoffice.org/67961 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-18tdf#42949 Fix IWYU warnings in basegfx/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic8476ddc7805546f2f6f253f282ac976bb3b7bd6 Reviewed-on: https://gerrit.libreoffice.org/67699 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-18sd: fix crashing when adding new effects to media.Mark Hung
Check if the objct has name roperty with hasPropertyByName() before accessing in case some objects ( media, table, control, etc. ) do not have name property. Regression caused by e559d360d0a19 ( related to tdf#90243 ). Change-Id: I05fc45c631f8acd3b9ba8c8305d4bc1e31651824 Reviewed-on: https://gerrit.libreoffice.org/67901 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-18Resolves tdf#121596 - Include a key combination to insert thin spacesheiko tietze
uno:InsertNarrowNobreakSpace/ FN_INSERT_NNBSP added and asigned to shift+alt+space Change-Id: I20dd4159bc35ee378bee75af9734b1f25dfd8b1a Reviewed-on: https://gerrit.libreoffice.org/66776 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-02-18Remove extra char in personas_list.txtMuhammet Kara
I don't know how this extra ; slipped in. Change-Id: Ic8938f7733065f0d18052d9dc08d7d7fbcd61468 Reviewed-on: https://gerrit.libreoffice.org/67913 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-18sw: remove not needed condition in SwTextFrame::SwitchHorizontalToVertical()Miklos Vajna
The distance of the content from the left edge of the parent frame (in vertical mode) is the same in both the top-to-bottom and in the bottom-to-top cases. Change-Id: I9dff075276b884cb8742584cbd4b8310e7cea553 Reviewed-on: https://gerrit.libreoffice.org/67955 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-18fix comparison of std::lower_bound resultNoel Grandin
turns out using a compare operator that takes something other than the element type as a parameter is really hard to get right. The changes in: basic/source/classes/propacc.cxx comphelper/source/property/propagg.cxx vcl/source/font/font.cxx are a regression from commit 35e80e9726b5fee6a00caa58349a4b5d924dad7c Date: Fri Oct 19 16:01:19 2018 +0200 when calling std::lower_bound The change in toolkit/source/awt/vclxtoolkit.cxx is a regression from commit 76dd28afc9c0eb632a5dd20eb51704ee0bbc4b58 Date: Tue Oct 9 16:27:11 2018 +0200 loplugin:staticvar in various Change-Id: Icf6db22e1fc091517a53dd3624913c8c2071c106 Reviewed-on: https://gerrit.libreoffice.org/67954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-18sw: prefix members in dbfld.hxxMiklos Vajna
Change-Id: I8319173b5bae27456287f2ed8e028b0dc351c4b7 Reviewed-on: https://gerrit.libreoffice.org/67952 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-18Tell about presumed corresponding negated operatorStephan Bergmann
Change-Id: Ic7ed64ecc4902853dc7431294484abb74e8da65b Reviewed-on: https://gerrit.libreoffice.org/67953 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-18tdf#123261 Styles items get checkbox option in menubar and popupmenuandreas kainz
Change-Id: I54d8aa665e290b735e90212f4d7dc47576415bca Reviewed-on: https://gerrit.libreoffice.org/67940 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-02-18tdf#123485 Excel 2003 xml file with xls extension detected as HTMLNoel Grandin
regression from commit 7ea01578eed8459678369d0256de016930b3af40 Date: Fri Oct 19 13:04:43 2018 +0200 loplugin:staticvar in soltools..svx turns out using std::lower_bound as a binary search is rather painful. Change-Id: Ide6f5cf4ff91a8832daa43a7fec2f5cfc97fc94a Reviewed-on: https://gerrit.libreoffice.org/67951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-18Resolves tdf#122322 - Modifying max number of saved word searchesheiko tietze
Expert configuration Common::Misc::FindReplaceRememberedSearches defaulting to 10 introduced Change-Id: Id51bb78ee1f5ad9e73fa56e5f2d07773c528f9a7 Reviewed-on: https://gerrit.libreoffice.org/67614 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-02-18Resolves tdf#123091 - Move Display Fields section from Formatting Aids to Viewheiko tietze
Change-Id: Ie302ff30328bd23c280369db0bb84c6103335ae3 Reviewed-on: https://gerrit.libreoffice.org/67812 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-02-18tdf#123255 writer Menubar Comment group rearrangementandreas kainz
Change-Id: Ib8e26e806899f564d9417cd10159d9de47d43cd1 Reviewed-on: https://gerrit.libreoffice.org/67530 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-02-18Removed duplicated includeAndrea Gelmini
Change-Id: I4d0da48bad9470a336f0412aaa976f454a2428c4 Reviewed-on: https://gerrit.libreoffice.org/67935 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-18tdf#98896: GetWidth/GetHeight vs getWidth/getHeight strikes back!Mike Kaganski
Regression from commit d04ee940a04922f6fc511882cff956a03b39583b Before commit 73f89b5d36dbae26072a1e749f10dfd6ffb6dd6e, the code to calculate full-screen rectangle only had one mode, and used Rectangle::Width+1/Rectangle::Height+1, with a comment "difference between java/awt convention and vcl". Commit 73f89b5d36dbae26072a1e749f10dfd6ffb6dd6e added another calc mode, and used Rectangle::GetWidth()/Rectangle::GetHeight(), which compensate for the +1 themselves. Then, in commit 6b5059c7b7129c3b9f00d784b6fa5248a24a6d4b, the original mode was changed to Rectangle::GetWidth()+1/Rectangle::GetHeight()+1, which was incorrect (resulting in an extra +1 for that code path). And last, in commit d04ee940a04922f6fc511882cff956a03b39583b, both the original mode, and the new mode were changed from GetWidth()/ GetHeight() to getWidth()/getHeight(), which fixed the original mode, but broke second mode (the +1 wasn't added there, so it got lost). This change stangardises both modes to use the GetWidth()/GetHeight() pair. Yay for more functions differing by case and meaning! Change-Id: Id64684d01a55849d18557d06c59e91b5cb93385d Reviewed-on: https://gerrit.libreoffice.org/67941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-18Fix product nameSamuel Mehrbrodt
Change-Id: I35ac8f6ad54c7990bd5fb24dc0a30ebb8e1e8254 Reviewed-on: https://gerrit.libreoffice.org/67949 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-18tdf#123481 jurt: Avoid thread deadlockingSamuel Mehrbrodt
Change-Id: I7b6454090aeb1046a814520166a5b8c39b716f6d Reviewed-on: https://gerrit.libreoffice.org/67861 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-18Simplify containers iterations in [f-l]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: Ib3fab47318d1bfbb4df8f886a8cd9596525a420f Reviewed-on: https://gerrit.libreoffice.org/67914 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-18Removed executable permission on xlsx fileAndrea Gelmini
Change-Id: Ib09622d0fd01546f3020a2fd40e5e89a33517277 Reviewed-on: https://gerrit.libreoffice.org/67946 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-18loplugin:simplifybool, check for !(!a op !b)Noel Grandin
Change-Id: Ic3ee9c05705817580633506498f848aac3ab7ba6 Reviewed-on: https://gerrit.libreoffice.org/67866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-17weld HangulHanjaOptionsDialogCaolán McNamara
Change-Id: Ic155a1f393bfcc95e094ed194acba0d98fce248d Reviewed-on: https://gerrit.libreoffice.org/67945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-17tdf#122305 tdf#122307 wrap label based on current wizard widthCaolán McNamara
rather than wrap on 82 characters, which is still too large for the width we are given Change-Id: I8bbb2d06d974f78d442cf59faebd29a8e22d7750 Reviewed-on: https://gerrit.libreoffice.org/67942 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-02-17uitest Chart - Y axis dialogZdeněk Crhonek
Change-Id: I993e834086ba6b909665055590bbb53dc529a156 Reviewed-on: https://gerrit.libreoffice.org/67944 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-02-17SfxFilter: truncate extensions list at first empty one...Matteo Casalin
... instead of rebuilding such list token by token until an empty extension is found Change-Id: Ib084b3064dccd1cf820bbb62ed47db03224b2161 Reviewed-on: https://gerrit.libreoffice.org/67631 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use optimized OUString concatenationMatteo Casalin
Change-Id: I61cbbf8613bd0a2221a8244cb76b10cf0e81a4a8 Reviewed-on: https://gerrit.libreoffice.org/67634 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Avoid string comparison if result is knownMatteo Casalin
Change-Id: I766c343194f81497f95108d1259b697d3ad363a5 Reviewed-on: https://gerrit.libreoffice.org/67642 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use optimized OUString concatenationMatteo Casalin
Change-Id: I7093167a5a8ff70dcc1227bd878e70f60c22a288 Reviewed-on: https://gerrit.libreoffice.org/67648 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Simplify by using startsWith()Matteo Casalin
Change-Id: I88bede6de1c2070691d3ba992858d36efe6626b7 Reviewed-on: https://gerrit.libreoffice.org/67649 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Simplify: getToken+comparison ==> startsWithMatteo Casalin
Change-Id: I69d714db155fe27c27ff1769ae5f71161d1de5cf Reviewed-on: https://gerrit.libreoffice.org/67641 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: Idea363ebc0948c83d739b5f9ed8fbf44c734935c Reviewed-on: https://gerrit.libreoffice.org/67643 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I463614e55ff9bae7bf3223a67d2ad2ab7725ee3e Reviewed-on: https://gerrit.libreoffice.org/67644 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I0f4e864ed27a5a9e071489c74f72859118627b08 Reviewed-on: https://gerrit.libreoffice.org/67645 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Precalculate all needed tokens and use indexingMatteo Casalin
Change-Id: If83e1b89e0116f0b20549daf839bd24621c926be Reviewed-on: https://gerrit.libreoffice.org/67647 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I28d1a4f5a32bbe6e2278e9694c85d9a72dde8a23 Reviewed-on: https://gerrit.libreoffice.org/67650 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
generated by cgit (git 2.34.1) at 2025-01-13 06:56:11 +0000