summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-21Drop o3tl::optional wrapperStephan Bergmann
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21loplugin:sequenceloop improve rvalue detectionNoel Grandin
to avoid false positives Change-Id: Id20eb0837fa6764139af3fc4481c768700ec2dad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-21tdf#130274 sw_redlinehide: fix ChgAutoCorrWord() if replaced text ...Michael Stahl
... is fully deleted. This crashes on English text with 'i'->'I' substitution. The assumption that there's some part of the found text that is not deleted is only correct for the case where tracked changes are hidden, but not when they are shown. (regression from 9926ea7dd07f1f3d012ddf97941a42bb7fa5717d) Change-Id: I0e81494659ea7e187101a703f64483dd68c73d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89151 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 197930c8b95d59a9ac099b58672fa66e6d87bca4 - Remove very old unused CSS Change-Id: I8af3443fb8db832ac2fc9a88dfb6fd779d3475ed Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89163 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-21tdf#130517 improve accelerators on Print dialog pageSeth Chaiklin
- add accelerator for Print - change accelerators for other "p" items - All Pages to A - Preview to v - Order (not needed, because _r on checkbox is enough) Change-Id: I7db4153829132dcbbb7c7356591f43df809583ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89127 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-21tdf#130598 improve a tip-of-the-daySeth Chaiklin
- tip about updating software - also added link to relevant help page Change-Id: I44ce2a17de311aa31a7b525510dcb8525cbf3dbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89131 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-21Revert "make Linux Clang Jenkins builds use -Og"Luboš Luňák
Per discussion in https://gerrit.libreoffice.org/c/core/+/88918 the Jenkins Clang is 5.0.2, which seems to be too old to even handle properly some kind of debuginfo with -Og. So while this indeed does make Jenkins builds faster, this has to wait until Jenkins uses a Clang version that can handle this better :(. This reverts commit c922d13b5b0ad983e64a046405fca9cd048c75fc.
2020-02-21tdf#130799 DOCX import: fix missing inside vertical bordersSzabolcs Toth
caused by incomplete handling of tables with 1-column rows with merged cells. Have to check the rows below current to see if they contain also one cell, therefore form a column, or more than one cell, in which case do not remove vertical borders. Regression from commit: 8a2eb40abbd52d960dd21308157186be0ca9dd3d (tdf#129442 DOCX import: fix right border of 1-column tables). Change-Id: If9ca7ccd42255e78c61b6271e19262ab5cc8e439 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89081 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-21tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesCanberk TURAN
I fixed if-conditons in UnoGraphicExporter.cxx and I deleted extra slash character at start of zcodec.cxx file. Change-Id: I464e7b0dcbfe835d04c5031bfbd6e46bccbb1216 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87470 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-21writerfilter: make sure own header is the first oneMiklos Vajna
This way we get a build error in case TableManager.hxx is not self-contained. Change-Id: Ia82c30a554c8726db2486cb8fc0dc73013ad2a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89169 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-21Set Firebird creation option experimentalJulien Nabet
See: http://document-foundation-mail-archive.969070.n3.nabble.com/About-putting-Firebird-creation-option-experimental-tt4274028.html http://document-foundation-mail-archive.969070.n3.nabble.com/ESC-meeting-minutes-2020-02-20-tt4274082.html for rationale Change-Id: I73d1563575252ebbcfb764753294bceb29e9bf12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89167 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-21tdf#130657 OOXML chart import: fix charts without CrossBetweenBalazs Varga
by using default values for ShiftedCategoryPosition. Regression from commit 111c260ab2883b7906f1a66e222dbf4dc3c58c4f (tdf#127777 OOXML chart export: fix "CrossBetween" for not imported charts) Change-Id: Idd48a8343e7d6609b487daf7182e9716f2f5e01f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88709 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-21xmloff: create SchXMLImport_Meta instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I7f783161c190940b10d9acd971a008c17f4f7dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89158 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I2194158d555958f0192d8d6c18e4c093608b8fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-21external/firebird: Remove dead conditionalsStephan Bergmann
For one, Clang appears to support __has_feature since at least 3.x times. That simplifies the first check, from 14955ed91b282ccbb395cb47c6d76e3b42b34748 "external/firebird: Support Clang ASan". And for another, the second check, from 25764ffd4db0e5db6f9cc9f3da8691e607f48b83 "external/firebird: Better workaround for Clang alignment expectations", can be simplified now that we no longer support neither Clang < 4 on Linux (since 685aca47da835e80f34b295c5d6389df03d1a8c2 "Bump (Linux) Clang baseline to 5.0.2") nor Xcode < 9 on macOS (since b4f666f2e677b05cab8395fe7972b45b15f60c3f "Bump Xcode baseline to 9.3"). But that means we are always setting USE_ASAN when building with Clang now (to work around certain Clang alignment expectations, regardless of whether or not we build with -fsanitize=address). Nevertheless, keep the __has_feature(address_sanitizer) check as a comment, to make this a bit clearer. Change-Id: Idc9720bd763bc1e00585773ef096202e2a8a6a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89162 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20Remove dead conditionalStephan Bergmann
Clang 4 is no longer supported on Linux since 685aca47da835e80f34b295c5d6389df03d1a8c2 "Bump (Linux) Clang baseline to 5.0.2" and Xcode 9 is no longer supported on macOS since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". Change-Id: I7f82b703f6a1f1dcd2ae322363b1813a8c3be948 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89161 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20macOS Xcode ld is known to always support -platform_version nowStephan Bergmann
...after 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". This effectively reverts b7fd89100d8653dc73955780358fe31d38b68ebf "tdf#122218: Baseline Xcode 9.3 ld presumably doesn't support -platform_version". Change-Id: Ib79563babe3cc948556d5369b0f6b6a8d208cab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89160 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20Adapt structurallyIdentical to current needsStephan Bergmann
...since aad94d48b19135a2e46ac7b2c0f41f3bb29bb5a7 "Silence warnings in salvtables.hxx", where --enable-compiler-plugins=debug had started to fail with > In file included from vcl/source/app/salvtables.cxx:75: > vcl/inc/salvtables.hxx:128:69: fatal error: TODO: Unexpected 'IdenticalDefaultArgumentsResult::Maybe' [loplugin:overrideparam] > weld_drawing_area(const OString& id, const a11yref& rA11yImpl = nullptr, > ^~~~~~~ > include/vcl/weld.hxx:2138:69: note: TODO: second argument is here [loplugin:overrideparam] > weld_drawing_area(const OString& id, const a11yref& rA11yImpl = nullptr, > ^~~~~~~ > MaterializeTemporaryExpr 0x7fdff3111360 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' lvalue > `-CXXBindTemporaryExpr 0x7fdff3111340 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' (CXXTemporary 0x7fdff3111340) > `-CXXConstructExpr 0x7fdff3111308 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' 'void (class com::sun::star::accessibility::XAccessible *)' > `-ImplicitCastExpr 0x7fdff31112f0 'class com::sun::star::accessibility::XAccessible *' <NullToPointer> > `-CXXNullPtrLiteralExpr 0x7fdff31112b0 'nullptr_t' > MaterializeTemporaryExpr 0x7fdff39275d8 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' lvalue > `-CXXBindTemporaryExpr 0x7fdff39275b8 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' (CXXTemporary 0x7fdff39275b8) > `-CXXConstructExpr 0x7fdff3927580 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' 'void (class com::sun::star::accessibility::XAccessible *)' > `-ImplicitCastExpr 0x7fdff3927568 'class com::sun::star::accessibility::XAccessible *' <NullToPointer> > `-CXXNullPtrLiteralExpr 0x7fdff3927528 'nullptr_t' Change-Id: I2603180571df2248d4697ba63e1a8391d0dfc596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89157 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4Stephan Bergmann
...as discussed at <https://lists.freedesktop.org/archives/libreoffice/2020-February/084471.html> "Bump macOS Xcode baseline to 11?" and <https://lists.freedesktop.org/archives/libreoffice/2020-February/084519.html> "ESC meeting minutes: 2020-02-20". (Code that might no longer be relevant will be cleaned up in follow-up commits.) Change-Id: I179e6099937d244502bd0e7fbff43f1734984213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89154 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20update creditsChristian Lohmaier
Change-Id: I35d24b2ace80622fc81935039a833121f1da2795
2020-02-20loplugin:unusedfieldsNoel Grandin
Change-Id: Ic036265f4e0b41108c5b72f0142b0aaf88d10713 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89118 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20Fix buildSzymon Kłos
Change-Id: Ia38f9a66c5743b524e84887e5dc23535710f2db6
2020-02-20Move Boost.Spirit usage away from legacy namespaceAdam Majer
Remove BOOST_SPIRIT_USE_OLD_NAMESPACE defines and move all usage of Boost.Spirit to boost::spirit::classic namespace. Change-Id: I7dc5bed4d1b51f4a0bd1a4ae40c2024222127ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89079 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.com>
2020-02-20sidebar: provide indent field boxes with useful id for hiding on mobile.Michael Meeks
Change-Id: I45feb65dbc48810f27e4f7151de46bafcb54af00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89128 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-20loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I47f0bfe8b1968ea33b0c20b06ef7d3eea3f29a61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20loplugin:singlevalfieldsNoel Grandin
Change-Id: I9ff752b06facfbb04c10c8f9b46b650143b02ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89117 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20Silence warnings in salvtables.hxxSzymon Kłos
Change-Id: I2d621688776c789b24ec1c593da2e4880cefd3a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89103 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-02-20Create header file for SalInstanceBuilderSzymon Kłos
Change-Id: If8d7578d9a5926cdf565efbf0bc12719e5ef6fc2 Move more declarations for SalInstance to header file Change-Id: Ib7240ffd003e202be04b462209cfb2abafcc18ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89102 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-02-20'rational' is an adjective, 'rationale' is a nounTor Lillqvist
Change-Id: I38678a74603729b63ac7a164249586e0891b74e2
2020-02-20Update git submodulesStephan Bergmann
* Update helpcontent2 from branch 'master' to bf2dff69f84ad28836924d3bf311910248aca1f9 - tdf#130426 Update documentation for Basic Chr and ChrW functions ...for <https://gerrit.libreoffice.org/c/core/+/89090> "tdf#130426 Support Basic Chr(&H8000), ..., Chr(&HFFFF) again" Change-Id: I425a55ba1b055f94d993bb99c5412cc0414dc48d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20tdf#130426 Support Basic Chr(&H8000), ..., Chr(&HFFFF) againStephan Bergmann
...after it had been broken by d5b7627a0e738c0866b819910153b96b611813f8 "tdf#62326 - Macros: Converting Hex strings of negative value". The corresponding help update is <https://gerrit.libreoffice.org/c/help/+/89100> "tdf#130426 Update documentation for Basic Chr and ChrW functions". Change-Id: I5f08b1ef907d840b491315a1f445f729b4999d0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89090 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20tdf#129529 sw_redlinehide: infinite loop in SwLayHelper::CheckInsert()Michael Stahl
The bugdoc has this in meta.xml: meta:page-count="819" meta:paragraph-count="302" ... for which SwLayHelper::CalcPageCount() cunningly estimates a maximum of 0 paragraphs per page, and at that rate an infinite number of pages are required... Not sure what a reasonable minimum should be, paragraphs could be 16 pages long even with 64k limit, but it does appear unlikely. (regression from 7e8b4756d95057f069467b34e7849f9354856578 which disabled the use of the layout-cache in the bugdoc) Change-Id: Icd9ab145cc2f0714b50de9b5b4a1ef10ac1d49a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89106 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-20tdf#126076 XLSX export: fix automatic line chart markersTünde Tóth
The default automatic line chart markers in XLSX spreadsheets created with Microsoft Excel 2010 became squares after export. Change-Id: I58a3e10212608a356eef8fbd1e100eda4dbebaca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88461 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-20tdf#129553 sw_redlinehide follow-up: simplify ReplaceBackReferences()Michael Stahl
In the special case of bParaEnd the nStart/nEnd aren't actually used so it's pointless go to to all this trouble; refactor this so it's more obvious. Change-Id: I0328950e11d86a2313be64f6c662afd1898185e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89092 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-20use fast-parser APIs for embedded script parsingNoel Grandin
essentially, this duplicates and converts the service in xmlscript/source/xmlflat_impexp/ and then converts it to use SvXMLImport APIs, stripping about 3 layers of unnecessary indirection in the process. Also improve some exception throwing in sax/ to make the next programmers life easier when finding the source of exceptions. Change-Id: I1ac552ee0565349e8322a55f6f609cf9f4521cab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20Revert typo in documentationStephan Bergmann
...that had been introduced with c66fe94d3e9cc1394dd4b569a3d8f374208a729b "Fix typos" Change-Id: Id7608d8feb8e52bb6742ac079bfa7b4151ef07a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20sw: fix unintended change in SwExtraPainter::SwExtraPainter()Michael Stahl
nVirtPageNum was an obfuscated optional, by assigning 1 and 2 instead of 1 and 0... probably the only difference is that this saves a function call? (regression from a26c4dbd9ca17578fd5c165bd89b618751fabb3c) Change-Id: Ie8bccebd331fade9dd006da7c1b5a758946b8549 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89049 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-20tdf#90749 chart: add leader lines to custom data label positionsBalazs Varga
also export them as CustomXML extension for MSO interoperability. Note: pie chart is not yet supported. See commit 4223ff2be69f03e571464b0b09ad0d278918631b ( tdf#48436 Chart: add CustomLabelPosition UNO API property) Change-Id: Ia8142408414d4ad8f689d789386db50038ed13f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88531 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-20tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorEda Nur Var
Change-Id: I9c9a9af78bab721f112c33e485c431aac11bece6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87523 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-20tdf#42982: Improve UNO API error reportingFaruk Demirbaş
Change-Id: I36bf1809a296e2d559911f9132fedf84fcd1e249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87577 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-20uitest: forgot to uncomment this lineXisco Fauli
introduced in ae17b8481532fa192f3f93a6dcf687fed394cf58 Thanks to Stephan for pointing out Change-Id: I4124762e4cb600773e4f471a10a8b4736434679f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89075 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-20tdf#42982 Make UNO error reporting more descriptiveBurak Bala
Change-Id: Iea5527ec88778f573b2e03ccd069142b7493c63c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87650 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-20tdf#130794 qt5: Actually, ignore non-spontaneous QEvent::ShortcutOverrideMichael Weghorn
In fact, the assumption in commit 034f56015c1c7a61faede33fb5306f63b5585632 ("tdf#126785 qt5: Ignore external QEvent::ShortcutOverride") was a fallacy and it's exactly the other way around: "Normal" typing leads to "spontaneous" events of type QEvent::ShortcutOverride, since those originate from outside, are triggered via X11 events or Wayland equivalent, and the non-spontaneous ones are the additional ones that happen when e.g. the Orca screen reader is enabled. In a short test, no non-spontaneous QEvent::ShortcutOverride ever occured when using LibreOffice a bit with Orca disabled on X11 or Wayland (and on Wayland also not with Orca enabled, since Qt accessibility is broken there, s. QTBUG-73945 [1]). (Side note: In a quick test with Qt 5.12.5 and Plasma on Wayland, 'xcbSourceDispatch' from Qt library's qxcbeventdispatcher.cpp was also used in the Wayland case to when processing the keyboard events). [1] https://bugreports.qt.io/browse/QTBUG-73945 Change-Id: I1be1977e67f84fa657f6fc197e0b91822b6a3a2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89073 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-20Turn fprintf into warningSamuel Mehrbrodt
so that this does not show up in release builds Change-Id: I7d95a85e596818fcdafbf37891f3e0ae24aa7155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88952 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-20Revert "Don't display reload as toggle command"Samuel Mehrbrodt
Turns out the reload toggle is used to turn off html documents meta refresh https://www.w3schools.com/TAGS/att_meta_http_equiv.asp where LibreOffice honours that html refresh and toggling this off will stop it doing that This reverts commit 89b80daec907a456f08946dd9ebbc6efbd9b5391. Change-Id: I6928a693d5ffde9ea01020be4e59631e8b10be93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88793 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-20uitest: comment out problematic assertXisco Fauli
> The new test appears to be unreliable. At least > <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/28839/>, > <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/28823/>, and > <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/28822/> all failed > with > > > FAIL: test_run (tdf130440.tdf129346) > > ---------------------------------------------------------------------- > > Traceback (most recent call last): > > File "/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/sd/qa/uitest/impress_tests/tdf130440.py", line 34, in test_run > > self.assertEqual(document.CurrentController.getCurrentPage().Number, 2) > > AssertionError: 1 != 2 7ed602a3b8c0ffe922b4f082cd4cdaa5a8f0d64c aimed to fix it but it still fails sometimes I believe it fails because both slides are selected at the same time in the slide pane. Change-Id: Ie9757d1122e278b0d49ca9a09caf1765d2df154d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89048 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-20tdf#42949 Fix IWYU warnings in writerfilter/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I47ff7eecabc87081eb953c5970a3cbd56c86d728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88897 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-20Remove some unused includesMiklos Vajna
Change-Id: I28b007cff3a99bc40901ecdeaecacf42b4521574 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89058 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-20add macOS malloc debugging env varsNoel Grandin
which would have saved me some time when debugging a recent macOS issue. Change-Id: I370826501db14fc563b553428f480f50bde48f9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20tdf#130776 Show the bullet on second level in smartart.Gülşah Köse
Change-Id: Ie35867862d30d490a97dc6f245b50c7311dafe50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88993 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-29 16:21:57 +0000