summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-05Resolves: tdf#114927 recognize both Januar and Jänner in de-* German localesEike Rathke
Change-Id: Ifcf087a8a20a1cdc460bd2caf6d1ceb528792e0d Reviewed-on: https://gerrit.libreoffice.org/61415 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-05loplugin:useuniqueptr look for deleting in loops with iteratorsNoel Grandin
Change-Id: I0e5bf671ee11265c0afa8770430ec9e064e05fe3 Reviewed-on: https://gerrit.libreoffice.org/61402 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05Fix typoAndrea Gelmini
Change-Id: Ic491b7f63726abe25acb61c619c15967e496094d Reviewed-on: https://gerrit.libreoffice.org/61422 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-05bodge up a workaround for GtkComboBox menus not appearing under waylandCaolán McNamara
when the menu is too tall to fit and the active entry is sufficiently far down the menu that the problem gets triggered. i.e. https://gitlab.gnome.org/GNOME/gtk/issues/94 as a workaround set wrap to 1, which is good enough to make GtkComboBox take an alternative path to the one which sets the problematic rect-anchor-dy value and the menu will at least appear Change-Id: Ia05887e0db727b7e1045179e36d348d22228a0ce Reviewed-on: https://gerrit.libreoffice.org/61416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05tdf#120022 SVG Colibre icon is broken in web browserandreas kainz
Change-Id: I0dc2594371f6d11e6ba1f02de7d70bdde3af9957 Reviewed-on: https://gerrit.libreoffice.org/61409 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-05tdf#85850 Pass CTRL+F5 event in sidebar to parent classesJim Raykowski
Change-Id: I86e1fba17402d0a5f06d7942cf0733b0f2c924ba Reviewed-on: https://gerrit.libreoffice.org/61276 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-05fix iterator invalidation assertNoel Grandin
which only recent versions of MSVC (from 15.8.6) seem to spot. It resulted in PythonTest_sw_python failures with "vector iterators incompatible" assertion on the dest != maDestructedListeners.end() check ever since commit 4a290888580474f9542f185091bb2a6fcf4e9a53 Date: Mon Oct 1 14:31:00 2018 +0200 SvtBroadcaster unify the normal and PrepareForDestruction paths Although this code appears to always have been wrong, it is just that it is being hit much more often now. Change-Id: I45d4f2ceef4ddf19c205702645a41363eea93f21 Reviewed-on: https://gerrit.libreoffice.org/61397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05Related: tdf#120287 sw layout, TabOverMargin: fix too wide tab portionMiklos Vajna
What happened is: - the paragraph was split into two lines, at the correct position - but then the first line checked how wide the tab portion can be, and there it concluded that it has a lot of space, so the tab portion was 1418 twips wide, instead of the expected "almost zero" 69 The root of the problem was that first the text break was determined using the TabOverMargin rules (more horizontal space), but later a check validated the result ignoring the TabOverMargin flag (less horizontal space). Fix this inconsistency by using GetLineWidth() in SwTextPortion::Format_() instead of manual calculation. Change-Id: Iaa7144341dfeaa8d177716dd87165598f11fd573 Reviewed-on: https://gerrit.libreoffice.org/61403 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-05Record external/gpgmepp/version.patch as sent upstreamStephan Bergmann
Change-Id: Ibc0dc42f3df8c5a4acc1ccece5a4ef63bd04fd39 Reviewed-on: https://gerrit.libreoffice.org/61405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-05weld QueryPropertiesDialogCaolán McNamara
Change-Id: Id523fdb25a24e2ef205bd24e594c8e01772d7a58 Reviewed-on: https://gerrit.libreoffice.org/61406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05weld modeless sfx SearchDialogCaolán McNamara
Change-Id: I90a9b5dcf8878356b6666f8fe911d5dce9391904 Reviewed-on: https://gerrit.libreoffice.org/61396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05use more std::unique_ptr in FmFormView::createControlLabelPairNoel Grandin
Change-Id: I36f364739e5a37f9adc0fbad8a49a71947b7318b Reviewed-on: https://gerrit.libreoffice.org/61399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05Alpha channel in BitmapColor - change bIndex to alphaTomaž Vajngerl
We want to store the alpha channel in BitmapColor. To achieve this we can repurpose bIndex attribute for alpha. Generally we don't need bIndex at all as we can infer if we use index colors or not from the context (using palette or not) Change-Id: I18fe748beeca59e2869368a1c3c2ee9d2062b41e Reviewed-on: https://gerrit.libreoffice.org/61057 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-05Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Uppercase function MUNIT Change-Id: Ife835065f29789785d5382081c2ebecb576e34dd Reviewed-on: https://gerrit.libreoffice.org/61407 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-10-05return std::unique_ptr from SdrText::RemoveOutlinerParaObjectNoel Grandin
Change-Id: Id4833818b48a572b7fa4f3c5d7bba1bf9548a0fe Reviewed-on: https://gerrit.libreoffice.org/61398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05use more std::unique_ptr in EnhancedCustomShapeEngineNoel Grandin
Change-Id: Ib488b15e55492fb469258bfba59e6475dbdb058f Reviewed-on: https://gerrit.libreoffice.org/61400 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05sc: Enhance binary search for ScMarkArraySerge Krot
Change-Id: I0fe6a0b8987fb3c3229c5aabcbf056cfb365650c Reviewed-on: https://gerrit.libreoffice.org/61373 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-05move WindowStateMask into vclenum.hxxCaolán McNamara
Change-Id: Ia9e4d65f769c94f99a2eb23dd93d9d7cc81c398b Reviewed-on: https://gerrit.libreoffice.org/61395 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05sw_redlinehide_2: add unit test with char attributesMichael Stahl
Change-Id: I8c5de1f850e3e2dd879bf3ccbedb08615ef0bf44 Reviewed-on: https://gerrit.libreoffice.org/61375 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-05sw_redlinehide_2: add unit test with tableMichael Stahl
Change-Id: Ia0334e08fb70e04e75c1bb6fe1f00a451d4567e3 Reviewed-on: https://gerrit.libreoffice.org/61374 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-05sw_redlinehide_2: add unit test with sectionsMichael Stahl
Change-Id: Ic9957f0a0624da2086e9e1eaded5f3df879e8e9f Reviewed-on: https://gerrit.libreoffice.org/61367 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-05sw_redlinehide_2: import ShowRedlineChanges from flat-odt as wellMichael Stahl
In this case a generic ImportInfo property set is created in XmlFilterAdaptor::importImpl(), so the XMLRedlineImportHelper is responsible for setting this. Change-Id: I6ec7ab2bab3ee10a585af88effb74f465e4bbae1
2018-10-05sw: create RtfExport instances with an uno constructorMiklos Vajna
Change-Id: I08cbfa2b9ccc7bc1c5d1ebeb9e06238472b2fa26 Reviewed-on: https://gerrit.libreoffice.org/61393 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-05sw_redlinehide_2: add unit tests with fly frames in flysMichael Stahl
Change-Id: Iaf56bfc92fe3628c53d2426c9b955610d7dc4c5a Reviewed-on: https://gerrit.libreoffice.org/61261 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-05Qt5AccessibleWidget: Implement QAccessibleValueInterfaceSamuel Mehrbrodt
Change-Id: Ia431650586ec26f5dc321cb162afa632ddb53ab3 Reviewed-on: https://gerrit.libreoffice.org/61361 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-05use std::unique_ptr in sw::IDocumentUndoRedoNoel Grandin
Change-Id: I504706ff1a3fc11a7a06ebe935f9dbc5323aefe8 Reviewed-on: https://gerrit.libreoffice.org/61369 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05use more std::move in sw/Noel Grandin
Change-Id: Id2f063550db3a3110e4bae8e18d0e7b9a7bf5df3 Reviewed-on: https://gerrit.libreoffice.org/61368 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05use std::unordered_map in localeNoel Grandin
instead of hand-coded hash table Change-Id: I1c52f98b5a72609f7cd8086227017a486d97520e Reviewed-on: https://gerrit.libreoffice.org/60706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05soltools: fix -Werror=format-overflowMichael Stahl
error: ‘sprintf’ may write a terminating nul past the end of the destination (Why does GCC8 complain about this now and not before?) Change-Id: I62cd9dec02d313b5aff1afc4cadf38ca1909ffb1 Reviewed-on: https://gerrit.libreoffice.org/61381 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-04Reformat this eye-cancer causing messEike Rathke
A mix of clang-format and manual. Change-Id: Ice3d96d1400329fc7386e2d4544c69641658600f
2018-10-04Resolves: tdf#106340 resize dialog when search/replace labels are shown/hiddenCaolán McNamara
Change-Id: I1e20807f613a73c7dbefcb8e331f99d484eb5c04 Reviewed-on: https://gerrit.libreoffice.org/61384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04Record external/liborcus/version.patch.0 as covered upstreamStephan Bergmann
Change-Id: I006a16cfc83e5b03408a2e772e752bb210901686 Reviewed-on: https://gerrit.libreoffice.org/61380 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04Add external/liborcus/README, containing link to upstream projectStephan Bergmann
Change-Id: Iea609a8e90d8b2bf8bcac2b537699b08073f25ae Reviewed-on: https://gerrit.libreoffice.org/61379 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04Missing CppunitTest dependencies on new macOS/Windows vclplug backendsStephan Bergmann
...after 1698debed2993fc5f262aa3ebbdb32fc112ac556 "Implement Windows VCL backend as plugin" and 3af4e1a0825c5b11ae4ef58fc411378aab669387 "Implement MacOSX VCL backend as plugin". (On these platforms, the tests apparently call into the respective vclplug backend code regardless of whether the test is "headless" or not.) Change-Id: I6d93eacd9f94047add94ba3e866e6be1eb35c879 Reviewed-on: https://gerrit.libreoffice.org/61376 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04-Werror,-Wdeprecated-declarations (--with-macosx-version-min-required=10.14)Stephan Bergmann
These are all the cases where the warning doesn't suggest a direct replacement, so the existing code is just wrapped in SAL_WNODEPRECATED_PUSH/POP for now. A companion commit will cover cases where there is a direct replacement that can probably be applied (even backwards-compatibly with our current baseline, hopefully). Change-Id: I899537cb36dd69e08b5442ad4af7ce69ce2ddaec Reviewed-on: https://gerrit.libreoffice.org/61354 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04Do not let end row creep above start row, tdf#69977 tdf#119305 follow-upEike Rathke
commit 3acc5a2383f5b0458e3caf1505fe6b8ad7dc3fb0 CommitDate: Tue Mar 27 13:26:30 2018 +0200 tdf#69977 improve creation of large charts changed the loop such that it removed the stop condition for rStartRow < rEndRow, and commit aaa3c31ba79b1b3d335dcf55d72837a13411b45e CommitDate: Tue Sep 11 20:29:04 2018 +0200 tdf#119305 Chart created from fully selected sheet only targets header row still checks only for a minimum of the original end row and the last data row, which for an empty (no data) range selected may be above the start row. Change-Id: I9de08d09be62e86e7c946df701c49314fa4d682e Reviewed-on: https://gerrit.libreoffice.org/61389 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-04tdf#120301 oox: lclIsWhiteSpace should return true for a spaceJustin Luth
Change-Id: I72c79c1fed4d9a91bf02024eef23cd3b1a58632e Reviewed-on: https://gerrit.libreoffice.org/61388 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-04sw: switch XAutoTextContainer to use user-dir filesThorsten Behrens
This amends 4967d498c486800b72ba34192c82c232bc0685bd to put .bau files into user dir instead of shared config Change-Id: Ic58b2cb10a62e90deebec9cd8d7dce5ef6218b43 Reviewed-on: https://gerrit.libreoffice.org/61387 Tested-by: Jenkins Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de>
2018-10-04tdf#120291 Attaching a connector makes draw Draw busy-loopNoel Grandin
regression from commit ffe84f49270e0a8818365ca7d1fd5242abff5562 remove SdrObject::GetHdl in favour of AddToHdlList Change-Id: Idb15b976f6e1fcb6ffeda933ffbec96d59e6f155 Reviewed-on: https://gerrit.libreoffice.org/61370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Resolves: tdf#120238 remove wrong assert()Eike Rathke
There may be a non-empty RowMap even if nColCount == 0 || nRowCount == 0 if there was only one column or row (or cell) selected and bRowHeaders and/or bColHeaders were set, thus nColCount and/or nRowCount were decremented by 1. Regression from commit b1f9aa5f58ea322097998839e00d95fc40be8b22 CommitDate: Fri Sep 28 09:04:07 2018 +0200 loplugin:useuniqueptr in ScChartPositionMap Change-Id: I942e3fcc92449da57d708f654000387f862a4066
2018-10-04gla11y: better print paired element for visibility conflictSamuel Thibault
Change-Id: I1f3bcaf732d01c5def7b84ecbd14e0cbe3397927 Reviewed-on: https://gerrit.libreoffice.org/61300 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-04sal_False -> false in commentLionel Elie Mamane
Change-Id: I3344af4ce28bd2b94725ea9336ce1b1ab9c98554
2018-10-04weld SwCreateAddressListDialogCaolán McNamara
Change-Id: I9b8fa8ff001f82904db2478a6c88419294df2855 Reviewed-on: https://gerrit.libreoffice.org/61364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04loplugin:redundantcastStephan Bergmann
"static_cast from 'CGContextRef' (aka 'CGContext *') prvalue to 'CGContextRef' (aka 'CGContext *') prvalue is redundant" with --with-macosx-version-min-required=10.14 at least. (Not exactly sure why this warning only starts to appear now. Presumably something changed in the system headers. Lets see whether older baseline builds are happy with the dropped casts, too.) Change-Id: Id52d1891e5e33f7c37d095440339980b4000ca4e Reviewed-on: https://gerrit.libreoffice.org/61353 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04weld SwFindEntryDialogCaolán McNamara
Change-Id: Ia45e4ce13b92fd73fcc8ad52233aa5eccc3cfb6d Reviewed-on: https://gerrit.libreoffice.org/61365 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SwAddRenameEntryDialogCaolán McNamara
Change-Id: I687486a392450fcf3b92fdc4d7a193b10f829835 Reviewed-on: https://gerrit.libreoffice.org/61363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SchLegendDlgCaolán McNamara
Change-Id: Ie57d195782d9fbfdf555205e53e733529b4c1ae8 Reviewed-on: https://gerrit.libreoffice.org/61360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04drop SvMemoryStream::GetBufferNoel Grandin
since it does the same thing as GetData() Change-Id: I18d35aa4e67ad7775987160c021863d0de90179b Reviewed-on: https://gerrit.libreoffice.org/61350 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Select the current format if multiple instead of first matching format codeEike Rathke
This never worked.. Change-Id: I79b8687dde4faac383121abeda70931d0192b33d Reviewed-on: https://gerrit.libreoffice.org/61290 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-04external/gpgmepp: Clash between VERSION and trunk libc++ <version>Stephan Bergmann
...on macOS with case-insensitive file systems. When compiling e.g. workdir/UnpackedTarball/gpgmepp/lang/cpp/src/parser/exception.cpp, libtool adds -I../../.. (presumably to find files like workdir/UnpackedTarball/gpgmepp/config.h), and including e.g. <string> internally includes <version> now, and workdir/UnpackedTarball/gpgmepp/VERSION happens to win. So just remove VERSION from the sources, which appears to not be needed at least in our build of gpgmepp. (An alternative approach might have been to use -iquote../../.. instead of -I../../.., but that's probably hard to shoehorn into the libtool-generated compiler invocation.) Change-Id: Ib1a30a6b825cab208238d17ff384e7900a27047d Reviewed-on: https://gerrit.libreoffice.org/61359 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>