summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-11-03fix gcc-wrapper for ccache.exeLuboš Luňák
This reverts a part of 18cc01b63996f81b284e3bc827d1be7f3da8983a . Change-Id: Ib7abbc41eeb6abd573f540ae2d0d2822e68b9abb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124613 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-03Fix typosAndrea Gelmini
Change-Id: If203853359b1c30c6cb6feea6c1ff718bcaa0188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124622 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-03prelim tdf#136472: remove implementation specific unit testsJustin Luth
These test documentations are completely pointless. They test something implementation specific without anything to actually test for accuracy. 4-test_segfault_while_save.docx: pseudo-preventative test. 8-fdo49940.docx: an empty page with no header/footer enabled. Who cares if it is called Default style or First Page. Change-Id: I4a9a6fcfe3621eaa745470487b32b2cbd66f0973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124590 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-11-03Prepare for removal of non-const operator[] from Sequence in testtoolsMike Kaganski
Change-Id: If67f845a0350766c7d098a399bd2fae6048c9100 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124400 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-02ofz#40625 avoid Integer-overflowCaolán McNamara
not much else can be done as far as I can see except to saturate Change-Id: Ifb7e47b03c76eca26b7340b047032e971401e86b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124619 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02cid#1493241 Wrapper object use after freeCaolán McNamara
unclear if this is the right fix here Change-Id: I6910ff405c2acb03fadd8e751e971d9b010b7d52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124620 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02Tweak loplugin:implicitboolconversion to allow some more bool -> sal_BoolStephan Bergmann
...in templated code, to cater for the needs of <https://gerrit.libreoffice.org/c/core/+/124400> "Prepare for removal of non-const operator[] from Sequence in testtools". For one, by defining ImplicitBoolConversion::TraverseInitListExpr, make sure that Clang versions before and after <https://github.com/llvm/llvm-project/commit/0a42fe70a566f22599e04a6f1344ca2dc5565e17> "[AST] Treat semantic form of InitListExpr as implicit code in traversals" behave the same. Old versions of Clang would have erroneously reported Sequence<Sequence<sal_Bool>> s2{ { false } }; (and reported Sequence<Sequence<sal_Int32>> s4{ { false } }; twice) in compilerplugins/clang/test/implicitboolconversion.cxx when one of the four combinations of syntactic/semantic visit of the outer/inner InitListExpr defeated the intended suppression logic in ImplicitBoolConversion::TraverseCXXStdInitializerListExpr. And for another, ImplicitBoolConversion::TraverseInitListExpr can subsume the exising ImplicitBoolConversion::TraverseCXXStdInitializerListExpr. But for a third, that would still make Sequence<Wrap2<sal_Bool>> s6{ { false } }; in compilerplugins/clang/test/implicitboolconversion.cxx emit a false warning, so add a cheesy "TODO" chicken-out special case to ImplicitBoolConversion::checkCXXConstructExpr for now. Change-Id: Ib9a1b78a7812feb98c673b75a357af7737168342 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124583 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-02Drop char*-based API from NamedValueCollectionMike Kaganski
Change-Id: I87f339b348580e256a8d65470ad15cbdabf2c9dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124609 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-02xmloff: Prevent gutter margin xml property to be deallocatedTomaž Vajngerl
Previously we stored a pointer to the gutter margin XMLPropertyState so we could read it later. The problem with this is that in between when we storing and reading the property state, we add elements to the rProperties vector, where the XML properties are allocated. Adding new elements to the vector can cause that the internal array is reallocated to a bigger size and elements copied to the new array, so our pointer shows to a invalid (deallocated) memory address. This issue is fixed by moving the code up to before we add new elements to rProperties vector and a big warning is written to not use XMLPropertyState* pointers after the code adds to the rProperties vector. Change-Id: I24b0285d49e678fcb3b333bf4054f5cef4207003 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124572 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-11-02SwNavigator: correct outline level comparison used in determiningJim Raykowski
outline content type member count Outline content type member count can be less than the number of outline nodes in the document model if the outline level setting is less than outline level maximum, MAXLEVEL. Currently, the outline node count is incorrectly compared to the outline level maximum in determining the outline content type member count. The member count is compared against the old member count to determine if the member array needs to be cleared and filled when a member in the array is wanted by a call to the GetMember function. This patch changes the outline level maximum to be compared to the set outline level. Change-Id: Ie1348575becbbc14446b417bcd568f158330cf9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124537 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-11-02Add comments to two arrays mentioning that they must match the enum PaperTor Lillqvist
At least I think they must. Also add a comment to the enum pointing at those arrays. There are now four different places in four files that must be manually kept in sync. Quite possibly more. This stinks. Change-Id: I7b5c721329c69a16b8cdf07390d481ec77c7b5ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124610 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-11-02Replace some macros in formsJulien Nabet
DECL_IFACE_PROP2 + DECL_IFACE_PROP3 + DECL_IFACE_PROP4 + DECL_BOOL_PROP3 Change-Id: Ibfe652001f4e914cad364222bcaf38dec69298e5 Change-Id: I432e045b9d071d61cd142bca66f40233cd59ef0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124564 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-02Resolves: tdf#119206 run properties sync when launched during saveCaolán McNamara
use (abuse?) a SynchronMode of true, which will become SfxRequest::IsSynchronCall of true in SfxObjectShell::ExecFile_Impl to request that we do not want the properties dialog to be run async. It looks impractical to rearrange all the post-dialog-call close code to be part of some callback executed when the dialog completes. Change-Id: Id2bde24986204dea3d312c0b4a91bf5c0a6f7916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02Revert "tdf#117895: "Edit document properties before saving"..."Caolán McNamara
This reverts commit 3add3e5b70ad991c8351a54b0da62d05e977458f to try and alternative approach Change-Id: Ieb36b78246586cc7f1977c67eab130d2ae025988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02Revert "tdf#120343 show pdf in async pdf export dialog callback"Caolán McNamara
This reverts commit 9df8a2eb8c216b16927aac2182b881b21d8b2d14 to try an alternative approach. Change-Id: I2f1e2cd28cbaee5ab3d7a3cec808ec5bb7777cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02drop PendingDrawObjectsInPaM in favor of detecting draw objects removalCaolán McNamara
Change-Id: I9f24f16ae47c8c178259650944bd80e19d6a887d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124568 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02tdf#132499: first stab to remove old stuff from ODBC ver < 3Julien Nabet
Change-Id: I683d4933fe4a2453b8ac5e9e8aa61946c4173bac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124566 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-02ofz#40593 remove Objects from m_xResizeDrawObjects if deleted during parseCaolán McNamara
Change-Id: I11fa665175ef067a36f4822676c02d4df1e1e250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02SwNavigator: fix two uses of UpdateListBoxJim Raykowski
1) UpdateListBox only needs to be called in the CommandHdl function when the content tree displayed is changed using the context menu Display submenu. 2) When content is deleted it is unnecessary to call UpdateListBox. Change-Id: I69679b4b074932dff5d594217e456ca818971032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124578 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-11-02SwNavigator: Track frame content before other contentJim Raykowski
Do this to prevent other trackable content from being track when a frame is selected. e.g. a hyperlink is at the start of frame content and the frame is selected. Without this patch the hyperlink is highlighted in the Navigator content tree instead of the frame. Change-Id: I0adac6659de6a5698b50a887052cc6aaffee578d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124577 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-11-02extract a ReorderingDropTarget for reuseCaolán McNamara
Change-Id: I0ae69bbf644e220e1bf3352d98eb4fd735167416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02SwNavigator: Make list of open files in Display sub menu consistentJim Raykowski
with list of open files in open files list box This patch makes the display format used for the list of open files in the content tree context menu 'Display' sub menu consistent with the display format used for the list of open files in the open files list box by adding '(inactive)' after the file name of an inactive file and removing the space after the open parenthesis and before the closing parenthesis surrounding the word 'hidden' for the hidden shell file. Change-Id: I91670377fae576cab6f013ed6f2eb3d0e6a88eaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124580 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-11-02Resolves: tdf#136945 fix custom slide show dnd to reorder pagesCaolán McNamara
Change-Id: Ib28d6779e772fd8ad30899354cde2c281085b328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124593 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02SwNavigator: Disallow going to content when content is not visibleJim Raykowski
Change-Id: I3644956866b562118fcb4610bce0b977cab29dce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124576 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-11-02tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktopHenrik Palomäki
Change-Id: I0b95ad5d1e46ed04717d7dccec7c6621b5d4d1e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124595 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-11-02tdf#141908 replace usage of sal_Int32 with colors in htmlexportHenrik Palomäki
Change-Id: I0403ccdb875f5372a13ebdc0fdf0f4ed396af773 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124436 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-02vs-ide-integration: make projects' GUIDs stableMike Kaganski
Use uuid.uuid5 with a custom URL to generate stable GUIDs. This avoids glitches in IDE when re-opening the solution after its re-generation makes some previously opened files to show duplicate entries in IDE's tabbed UI. Also drop the UniqueIdentifier elements from .vcxproj.filters files, which are optional and only used in VS automation [1], so are useless with randomly-generated GUIDs. [1] https://docs.microsoft.com/en-us/cpp/build/reference/vcxproj-filters-files Change-Id: I91dae730286b3187a6ceffcb9ae3afc2b479f4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124594 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-02tdf#139336 sw: fix extra pages of multicolumn sections with footnotesAttila Szűcs
Adding footnotes to multicolumn sections resulted page-long section layout, not regarding to the amount of its text content. E.g. a page with n multicolumn sections and footnotes could load as n (mostly empty) pages. The problem is related to the footnotes showed under columns of sections, which can be ambiguous at different column number of the different sections on the same page. As a workaround for interoperability, show footnotes per pages to remove the extra pages, e.g. allowing to show the separated sections on a single page, like MSO does. Note: a compatibility option will be added to avoid regressions. Note: This fix doesn't change multicolumn page styles or not evenly distributed multicolumn sections or footnotes not collected at the end of the sections. Test: choose Edit Section... in local menu of the sections of the unit test document. In Options..., see checkbox "Evenly distribute contents to all columns" on page Columns, and Footnotes/"Collect at end of text" on page Footnotes/Endnotes. To see the result of the new settings, save and reload the document. Note: DOCX format doesn't support "Collect at end of text", only OpenDocument. Note: In MSO, it's possible to set multimulticolumn footnotes separately from section column number. It's column number can be 1–4, or "auto", which uses the column number of the first section of the page. See also tdf#138508 (Single column footnotes on multi-column pages). Change-Id: I6a3534ac043971479275a3e8bb0713bd3d8ceaa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121822 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-11-02tdf#136945 use ListStore instead of TreeStore to avoid dnd creating subnodesCaolán McNamara
because this just wants a flat list and a drop "on" a row shouldn't create a child of that row, but a sibling Change-Id: I0a6b360ffe13018d6878bd4bc3012ee3f5807a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02vs-ide-integration: create folders for Executables/Libraries/TestsMike Kaganski
This makes the solution more manageable - one can collapse unneeded categories. And put LibreOffice.natvis to Utility folder, to move it to bottom. Change-Id: I869faaf5756c65e6812b58627acd03bf816dea2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124588 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-02keep showing focus rect on the first element during highlightCaolán McNamara
for the case nothing is selected but non-hover shows the bare focus rect to indicate focus is in the valueset though nothing is truly selected Change-Id: Ibe7fa38711f935126e1c0803c395b43b9720ca6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02mbDrawSelection is always true when evaluatedCaolán McNamara
Change-Id: I043e68d5a5a6af8814f1db0f61f1cd95078ad11c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124570 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02crashtesting: ended up using the wrong strerror_rCaolán McNamara
since... commit bbab833bd956e220db3548ddd0a00dfd30836de1 Date: Thu Oct 28 10:07:00 2021 +0100 endian check in internal neon looks dubious Change-Id: If96bb1bc1dda70f25fa49b3c68ee8993db7d9017 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124587 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02xmlsec: fix OOXML signing with multiple certs, extend the testTomaž Vajngerl
Signing OOXML with 3 or more times didn't work as other ids ("idPackageObject", "idOfficeObject", ...) were not uniqe. This change makes those ids unique by appending the signature id. The signature ID is now generated for OOXML too, while previously it was a hardcoded string ("idPackageSignature"). The test for signing multiple OOXML was written before, but didn't catch the issues because it didn't assert the status of the document after loading it again. This is which is now fixed (and also added changed for the ODF test case). Change-Id: Ifa20ea17498b117a4c57f6eddf82f8e83bc640bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124571 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-11-02sw: prefix members of SwAnnotationShell, SwBaseShell, SwContent and ...Miklos Vajna
... SwDrawTextShell See tdf#94879 for motivation. Change-Id: Icaa59a07dcc680a9f2f167165c89fec72e99d92b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124582 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-11-02tdf#145317 sw ms export: handle First Page with a first headerJustin Luth
partial revert of LO 5.2.4's tdf#101814. Just because the page style has a first doesn't mean that it should not check if it is also a first-follow that could be merged into a single ww8section. In this case, the follow page-style's H/F definitions were lost, because only the First Page style was considered. No existing unit tests matched these conditions. I did test bug 101814's CAFCA - Modèle feuille A4 - v2015-2.odt and it still shows the same H/F. Change-Id: I7389f8d85ba24a3f9c6487efe4acd27d96b0869c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124213 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-02Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to 5f532332487c5c57eecb949d0d83fdf2c5f4e7ac - Update help to explain that CONVERT_OOO Change-Id: I6f981b70f98c95cef510a60f4791336446db8648 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124193 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-11-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 95f006af3ffbe256ebf095db8be2ebd1321e673e - Refactor database files Change-Id: I97f41e7a5268ee307e3e0b051abebb35b917ed73 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124565 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-11-02tdf#145486: Prevented crash by not updating readOnly valuehomeboy445
Change-Id: I88c2b8a9a05335a16154a23a541882a3ca6de3e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124555 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-02Use braces to workaround a strange GCC bugMike Kaganski
Using gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1~20.04): [CXX] ucb/source/ucp/cmis/certvalidation_handler.cxx In file included from /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/converter_lexical_streams.hpp:62, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/converter_lexical.hpp:54, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/try_lexical_convert.hpp:44, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast.hpp:32, from /home/user/core.git/external/boost/include/boost/lexical_cast.hpp:30, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/format_date_parser.hpp:14, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/date_generator_parser.hpp:20, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/date_facet.hpp:25, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/gregorian/gregorian_io.hpp:16, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/gregorian/gregorian.hpp:31, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/posix_time/time_formatters.hpp:12, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/posix_time/posix_time.hpp:24, from /home/user/core.git/external/boost/include/boost/date_time/posix_time/posix_time.hpp:30, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/local_time/local_time.hpp:11, from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time.hpp:15, from /home/user/core.git/external/boost/include/boost/date_time.hpp:30, from /home/user/core.git/workdir/UnpackedTarball/libcmis/inc/libcmis/object.hxx:40, from /home/user/core.git/workdir/UnpackedTarball/libcmis/inc/libcmis/document.hxx:39, from /home/user/core.git/workdir/UnpackedTarball/libcmis/inc/libcmis/libcmis.hxx:34, from /home/user/core.git/ucb/source/ucp/cmis/certvalidation_handler.hxx:19, from /home/user/core.git/ucb/source/ucp/cmis/certvalidation_handler.cxx:23: /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/lcast_unsigned_converters.hpp: In member function ‘CharT* boost::detail::lcast_put_unsigned<Traits, T, CharT>::main_convert_loop()’: /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/lcast_unsigned_converters.hpp:149:17: error: this ‘while’ clause does not guard... [-Werror=misleading-indentation] 149 | inline CharT* main_convert_loop() BOOST_NOEXCEPT { | ^~~~~ /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/lcast_unsigned_converters.hpp:150:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘while’ 150 | while (main_convert_iteration()); | ^~~~~~ It surfaced after commit 00a76942e423589e3fdd4e059be753eab3393344, apparently showing some version-specific compiler bug. Change-Id: I92a989726cea5eafd762f724cfc0b3c1f986824c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124474 Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-01Related: tdf#145363 provide an explicit parent for page formatCaolán McNamara
when launched from another dialog let it take that as the parent Change-Id: I07bfe03717cbe140301060e6e85bdbdef953bf5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-01tdf#145363 provide an explicit parent for numbering-style dialogCaolán McNamara
when launched from another dialog let it take that as the parent Change-Id: I64247b0b670c3e44176b6323c074cfd0711feefb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124558 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-01loplugin:unusedmember: Work around more cases not marking an enum as referencedStephan Bergmann
...similar to the "For some reason..." workaround already present in VisitElaboratedTypeLoc. (Thanks to mst for finding this.) Change-Id: Ic682e8290efa64093d3c4a831dfb4d23091b6056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124559 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-01ucb: webdav-curl: remove SerfLockStore::getLockToken()Michael Stahl
Looking rather obsolete, plus NonInteractive_LOCK() can just get the token as a parameter since it's called only by LockStore. Change-Id: I4c5c84135592fbab20f36c93d0c99b80fccb0976 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124453 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-01ucb: webdav-curl: fix MOVE/COPY/DELETE crashMichael Stahl
These need "nobody"; some errors like 401 will return a body that should be ignored. Change-Id: If2f726aa34d4d3fae1bd61bc87b62e2d55a7ff26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124561 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-01ucb: webdav-curl: rewrite authentication loop for reentrancyMichael Stahl
Surprisingly calling authenticate() can lead to a reentrant call via event loop, which fortunately deadlocks with non-recusive mutex, or we'd have a much more difficult to debug problem: 5 std::unique_lock<std::mutex>::unique_lock() 7 http_dav_ucp::CurlProcessor::PropFind() 8 http_dav_ucp::CurlSession::PROPFIND() (this=0x391fe80, rURIReference="/testL.odt", depth=http_dav_ucp::DAVZERO, o_rResourceInfos=std::__debug::vector of length 0, capacity 0, rEnv=...) 9 http_dav_ucp::DAVResourceAccess::PROPFIND() (this=0xab3bb00, nDepth=http_dav_ucp::DAVZERO, rResInfo=std::__debug::vector of length 0, capacity 0, xEnv=uno::Reference to (class ucbhelper::CommandEnvironment *) 0x390b578) 10 http_dav_ucp::Content::getProperties() (this=0xa8ba9a0, xEnv=uno::Reference to (class ucbhelper::CommandEnvironment *) 0x390b578) 15 SfxBaseModel::isVersionable() (this=0x7159c90) 19 SfxBindings::Update_Impl(SfxStateCache&) 24 Timer::Invoke() (this=0x7394708) 30 g_main_loop_run () 35 (anonymous namespace)::executeMasterPasswordDialog() 40 (anonymous namespace)::UUIInteractionHandler::handle() 41 PasswordContainer::RequestPasswordFromUser() 42 PasswordContainer::GetMasterPassword() 47 PasswordContainer::find() 48 uui::PasswordContainerHelper::handleAuthenticationRequest() 57 ucbhelper::InterceptedInteraction::handle() 58 http_dav_ucp::DAVAuthListener_Impl::authenticate() 59 http_dav_ucp::CurlProcessor::ProcessRequestImpl() 60 http_dav_ucp::CurlProcessor::ProcessRequest() 61 http_dav_ucp::CurlProcessor::PropFind() 62 http_dav_ucp::CurlSession::PROPFIND() (this=0x391fe80, rURIReference="/testL.odt", depth=http_dav_ucp::DAVZERO, o_rResourceInfos=std::__debug::vector of length 0, capacity 0, rEnv=...) 63 http_dav_ucp::DAVResourceAccess::PROPFIND() (this=0xab8c060, nDepth=http_dav_ucp::DAVZERO, rResInfo=std::__debug::vector of length 0, capacity 0, xEnv=uno::Reference to (class ucbhelper::CommandEnvironment *) 0x390b578) 64 http_dav_ucp::Content::getProperties() (this=0xa8ba9a0, xEnv=uno::Reference to (class ucbhelper::CommandEnvironment *) 0x390b578) 67 ucbhelper::PropertySetInfo::hasPropertyByName() (this=0xa8d7a20, Name="TitleOnServer") 68 SfxBaseModel::getTitle() 74 framework::TitleHelper::impl_updateTitle() 75 framework::TitleHelper::documentEventOccured() 78 SfxBaseModel::postEvent_Impl() (this=0x7159c90, aName="OnModeChanged", xController=empty uno::Reference) 79 SfxBaseModel::Notify() 80 SfxBroadcaster::Broadcast() 81 SfxObjectShell::SetModalMode_Impl() 82 SfxViewFrame::SetModalMode(bool) 83 SfxFrameWindow_Impl::ModalHierarchyHdl() 86 SalFrame::NotifyModalHierarchy() 88 SalGtkFilePicker::execute() 92 ModelData_Impl::OutputFileDialog() 93 SfxStoringHelper::GUIStoreModel() Need to move authentication loop to the outer function, so that all the option guards in ProcessRequestImpl() are reset/set again, and also delay setting the option guards from the various callers so they can be reset in ProcessRequest() before authenticate(). Change-Id: Id697b1459f94f80fc58cee7768c2bd388369b29c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124452 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-01curl: build with zlib on WNTMichael Stahl
Change-Id: I53eb6ed41fb8a17a79f72807df15822e9c1c6e88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124290 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-01ucb: webdav-curl: implement CurlSession::abort()Michael Stahl
It looks like libcurl has an API to wake up a transfer in another thread, but have to use curl_multi_poll() instead of curl_multi_wait() to enable that. Change-Id: I728416eba45eb6665b0041955cdce8bee07e845e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124220 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-01ucb: webdav-curl: escape broken SharePoint 2016 URIsMichael Stahl
[ reimplement commit 069aa870aadb9f9069e8715c8be30394410f0288 ] Change-Id: I01a93e3a448e6dc921d1e0471ae01c8ac8feea11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124218 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-01ucb: webdav-curl: tdf#82744: fix WebDAV lock/unlock behaviour - part 4Michael Stahl
[ reimplement Sharepoint 2013 workaround from commit fed2984281a85a5a2f308841ec810f218c75f2ab ] Change-Id: Ib7f5a66e32d630e900f5f77c882ba791a9ab7aac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124217 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-02-07 08:22:31 +0000