summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-02-28make SetMaster private in SwDrawContactBjoern Michaelsen
Change-Id: I9d4f35c8973e3240cc5e9cd870fcdc4ed70a717c Reviewed-on: https://gerrit.libreoffice.org/34700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-28Avoid -fsanitize=nullStephan Bergmann
...during CppunitTest_xmlsecurity_pdfsigning: > tools/source/stream/stream.cxx:1220:20: runtime error: null pointer passed as argument 1, which is declared to never be null > /usr/include/string.h:43:28: note: nonnull attribute specified here > #0 0x7fb2116abe4a in SvStream::ReadBytes(void*, unsigned long) tools/source/stream/stream.cxx:1220:13 > #1 0x7fb1dee7a4f0 in xmlsecurity::pdfio::PDFStreamElement::Read(SvStream&) xmlsecurity/source/pdfio/pdfdocument.cxx:3639:13 > #2 0x7fb1dee350ec in xmlsecurity::pdfio::PDFDocument::Tokenize(SvStream&, xmlsecurity::pdfio::TokenizeMode, std::__debug::vector<std::unique_ptr<xmlsecurity::pdfio::PDFElement, std::default_delete<xmlsecurity::pdfio::PDFElement> >, std::allocator<std::unique_ptr<xmlsecurity::pdfio::PDFElement, std::default_delete<xmlsecurity::pdfio::PDFElement> > > >&, xmlsecurity::pdfio::PDFObjectElement*) xmlsecurity/source/pdfio/pdfdocument.cxx:1153:44 > #3 0x7fb1dee464d3 in xmlsecurity::pdfio::PDFDocument::Read(SvStream&) xmlsecurity/source/pdfio/pdfdocument.cxx:1306:12 > #4 0x7fb1e7916ffe in PDFSigningTest::verify(rtl::OUString const&, unsigned long, rtl::OString const&) xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx:127:5 > #5 0x7fb1e791dd86 in PDFSigningTest::sign(rtl::OUString const&, rtl::OUString const&, unsigned long) xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx:178:5 > #6 0x7fb1e791ef8e in PDFSigningTest::testPDFAdd() xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx:189:29 > #7 0x7fb1e798885b in CppUnit::TestCaller<PDFSigningTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6 > #8 0x7fb22b8bfd8b in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #9 0x7fb211f6699f in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:36:14 > #10 0x7fb22b87e3ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #11 0x7fb21ba510cf in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #12 0x7fb22b87e3ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #13 0x7fb21f6ff2c4 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #14 0x7fb22b87e3ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #15 0x7fb22b7fc350 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #16 0x7fb22b87e3ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #17 0x7fb22b87ae70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18 > #18 0x7fb22b93a0f5 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:28 > #19 0x7fb22b8bdfa4 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #20 0x7fb22b8c27a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #21 0x7fb22b8c1819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #22 0x7fb22b8c27a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #23 0x7fb22b8c1819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #24 0x7fb22b9785c9 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #25 0x7fb22b93840d in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:9 > #26 0x7fb22b97989b in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #27 0x53043c in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:305:20 > #28 0x52c089 in sal_main() sal/cppunittester/cppunittester.cxx:455:20 > #29 0x52a742 in main sal/cppunittester/cppunittester.cxx:362:1 > #30 0x7fb229b05400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289 > #31 0x437d49 in _start (workdir/LinkTarget/Executable/cppunittester+0x437d49) Change-Id: I8bf8c28219b4525874f83fbb164eb5eec02ac1b6
2017-02-28move troublesome SetMaster from SwContact down to SwDrawContactBjoern Michaelsen
Change-Id: I4fc0565175cda316e5b26c78fd0a05a4e27e527a Reviewed-on: https://gerrit.libreoffice.org/34699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-28mpMediaItem might be nullptrMarkus Mohrhard
This fixes at least two crashes reported through the crashreporter: http://crashreport.libreoffice.org/stats/signature/avmedia::MediaItem::getTime() http://crashreport.libreoffice.org/stats/signature/avmedia::MediaItem::getDuration() Change-Id: I92eeca229fa46921317586d0317e9f00309e793b Reviewed-on: https://gerrit.libreoffice.org/34710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28we can just comment the variable name outMarkus Mohrhard
Change-Id: Idcb2365f3ba39a086eaa4698457fcd02cec780f8 Reviewed-on: https://gerrit.libreoffice.org/34709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28VBA: unit test for PtrSafe and compiler directivesJustin Luth
#If Vba7 Declare PtrSafe Function xx #Else Declare Function xx #End if Change-Id: I807efb9fa68b5ac50f2bd59ba7cfa45c499af189 Reviewed-on: https://gerrit.libreoffice.org/34522 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28VBA: allow and ignore compiler directivesJustin Luth
Instead of erroring out on this: #If Win64 Then Declare PtrSafe Function aht_apiGetOpenFileName Lib "comdlg32.dll" #Else Declare Function aht_apiGetOpenFileName Lib "comdlg32.dll" #End If just treat the # commands as remarks and continue on. This type of coding will become more common as 64bit versions of Office require such constructs. Change-Id: I63bfb8cbe9ad3ef35bab4c041d9d94daa7fbba18 Reviewed-on: https://gerrit.libreoffice.org/34518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28tdf#48140 Replace CellRangeAddress with ScRangeBartosz Kosiorek
Change-Id: I5aa1dabf938e1567d386fceb153e2986862f70a6 Reviewed-on: https://gerrit.libreoffice.org/34707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28starmath: Add test cases for errors at parsingTakeshi Abe
Change-Id: Ic8de7f1c925d7a77520681121cbdd00c036ccab8 Reviewed-on: https://gerrit.libreoffice.org/34683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-27uitest: catch more exceptions during shutdownMarkus Mohrhard
Change-Id: Ie4bfc28c32b4b21c75ca92b95521c03a0683db32 Reviewed-on: https://gerrit.libreoffice.org/34692 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-27uitest: move the processing of actions into the idle handlerMarkus Mohrhard
Change-Id: Idead7314096f879f147dd87e6ce8f4b79b8f70c1 Reviewed-on: https://gerrit.libreoffice.org/34691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-27uitest: add scheduler method that runs until a signal is receivedMarkus Mohrhard
The other method only runs 1000 events. Change-Id: I43076988e9e25b35e3fdfd8dff19270d9e066d9a Reviewed-on: https://gerrit.libreoffice.org/34690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-27Clean up use of integer typesStephan Bergmann
Change-Id: Ia3c3e8b6c1988561284d91545e98e4939973c4b9
2017-02-27move assign() into operator=() and add the relevant bits to copy-ctorEike Rathke
Change-Id: Iac606a8e5e4fc9beb019d95d2a05f0ab9d9dad34
2017-02-27add VBA CHR() test caseZdeněk Crhonek
Change-Id: I9e7aefdd0309fd4f209fba6fb4f698b098856d01 Reviewed-on: https://gerrit.libreoffice.org/34133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-27Better fix not causing unrelated loplugin:loopvartoosmallStephan Bergmann
...for e7aab255c1595c8cc54e0eab3d8d1059fb3d00f1 "warning C4018: '<' : signed/unsigned mismatch" Change-Id: I9a91244f2136e2cd31c480511e3b08c721b478e4
2017-02-27rework ScCaptionPtr to have a distinct head elementEike Rathke
Not only saves a pointer per list element, but future versions could hold a document pointer and/or drawing layer's draw page as well. Change-Id: I85e05981239223bec88c47f2ebe4c22e50cd9a0d
2017-02-27tdf#106206 PDF export: fix unexpected /Im0 in page contents streamMiklos Vajna
The early return should just skip the code that's specific to pdf images, not everything. Change-Id: Ia9e02b05051a085a9fdf2f690c21f9ffccb7bf4d Reviewed-on: https://gerrit.libreoffice.org/34685 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-27Rename misleadingly named include file fillpropertiesgroupcontext.hxxTor Lillqvist
There is nothing called FillPropertiesGroupContext. Rename the file to "misccontexts.hxx" as I could not come up with some more specific name that would describe the collection of classes defined in it. Rename the corresponding cxx file, too. Change-Id: I44db1db8c63c8e897774597b46a237a214aacedf
2017-02-27There is nothing called FillPropertiesGroupContext since 2009Tor Lillqvist
So bin two pointless and misleading comments that consist of just that identifier. Change-Id: I14724b21d43283dbda1856ab28c56ae44512c3cc
2017-02-27Clean up a few SAL_INFOs a bit and add useful note about the ==cscode== etcTor Lillqvist
I dislike OSL_THIS_FUNC, it is too verbose, at least with Clang on Linux. Just use the Class::Name without parameters and namespaces. Change-Id: Ic8722a131463762ab70ff35d64ae7040c67bf595
2017-02-27fix leakCaolán McNamara
Change-Id: If7f710aa62cea43e2c59d91e136daba9650b3912
2017-02-27chart: use c++11 for-statement in VSeriesPlotterTomaž Vajngerl
This makes the code much more readable.. Change-Id: Ic9078daffeba28984749c61d059701b3cdcca8bd Reviewed-on: https://gerrit.libreoffice.org/34687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-27OSelectionBrowseBox::AddGroupBy parameter _nCurrentPos is unusedStephan Bergmann
...since ef40dde69e7fff331b7e31460638703a2c82bc9d "INTEGRATION: CWS dba30d" Change-Id: I2dbd73bd77f71cbf88768dcc2dc4a38f65b84eef
2017-02-27fix leakCaolán McNamara
Change-Id: I00438178582bd4c78bffeca18067abeb667b8367
2017-02-27sc: make tabview3 more readableTomaž Vajngerl
- add some curly-braces - join consecutive if statements - declare variables inside for statement Change-Id: I369452cdd684f71a7bd30b5dc072831b982ee1b3 Reviewed-on: https://gerrit.libreoffice.org/34686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-27fix leakCaolán McNamara
Change-Id: Ie352e9b7fe52d41492141ebba9b5d332960dadd5
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: Icf0e75d0e213c4562f4ee57df0537d394031645b
2017-02-27tdf#105829 Infobar design, tdf#102785 Font issueheiko tietze
Only one constructor to append an infobar Colors defined at one place in infobar.cxx based on InfoBarType Icons as an additional attribute of the notification Change-Id: I4dc85c2b4ef0b7eafc139290b3b4ee21636da6ec Reviewed-on: https://gerrit.libreoffice.org/34426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-27tdf#105093 vcl PDF export: add embedded video testcaseMiklos Vajna
Fails with commit 4ad249af88d15f2c8a09f0721a59d82718fcc201 (tdf#105093 sd PDF export: handle embedded videos, 2017-01-04) reverted. Change-Id: I413ec9a5da3c0783541dcd28fb9a62dd896f955b Reviewed-on: https://gerrit.libreoffice.org/34681 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: I682b4e2750658efded5f4167d4f7026ed5fac8dc
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: I7f490335efef71b13aae66e9467cd74429509d7d
2017-02-27Clean up use of integer typesStephan Bergmann
Change-Id: Idf47d1511aff3cdb7c139671173a97e405b6078e
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: I00e73eabb34ae98088a8e88d0c8677bf236a5e09
2017-02-27tdf#102779 Notebookbar: extra space for small tab labelsSzymon Kłos
Change-Id: I2cd7be7ef49552acd84aa4b5042955dcb18f328f Reviewed-on: https://gerrit.libreoffice.org/34679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-02-27Improve the Document Provider UXbrainbreaker
This commit improves the user experience of different Document Providers in the app. In case ext sd card is not present, the option is disabled in Navigation Menu. If the device does not support USB OTG, the option is disabled. LibreOfficeUIActivity registers a broadcast receiver in onCreate which detects if a USB device is connected and directs the user to Settings page to configure it. In case of errors in configuration in any case, user is directed to Settings activity after appropriate toast. Change-Id: I680f78a679e2071ce8330c8168d7aa4e95041723 Reviewed-on: https://gerrit.libreoffice.org/34650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: I631ea0012f8e999f14aa08b42f28d6115a73d084
2017-02-27OSL_ENSURE->assertCaolán McNamara
Change-Id: I21edad9865717674217d2d10b9ec2a689d9d65f9
2017-02-27use std::unique_ptrCaolán McNamara
Change-Id: I3f00cd66a0a8aa0571733caf4db4d16dfd102683
2017-02-27Remove unused forward declarationStephan Bergmann
Change-Id: I1ca1bd56289ea1005b76dd387ef7610ff1b0a3db
2017-02-27Use WeakImplHelper to implement MenuBarManagerStephan Bergmann
Change-Id: I3a30bc86796a7ad24616cb11ae10b6886e09c1e9
2017-02-27Remove odd check that writeUInt32 indeed writes four bytesStephan Bergmann
If you look at the oldest available version of SvPersistStream::WriteDummyLen in 8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import", it looks like there was an issue with whetever earlier way was used to reserve a four-byte space in the stream with "Sun sp" (whatever that shall mean). Change-Id: I861a445ae72f1ced502f70917707336eb5dddf04
2017-02-27xmlsecurity PDF verify: fix parsing of nested dictionariesMiklos Vajna
This is triggered by an upcoming unit test for tdf#105093. Change-Id: I3c8e8662fcadaea1f6e19bf6194d8159916f368b Reviewed-on: https://gerrit.libreoffice.org/34678 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-27Probably better to restrict the sequence sizeStephan Bergmann
...to any elements actually written. Was like that ever since the code's introduction in d3ffe3ed3fa1b80c7e54439673029e105940db80 "fdo#67737 : fix for flip not being imported & rendered correctly". Change-Id: I460c1c7c578bd7e53cc2e868da0b7aeb5f19194f
2017-02-27tdf#105299 Dialogs must not be resizableheiko tietze
Patch doesnt solve the issue but makes the wizard dialog HIG compliant Change-Id: Ib45b49671bc247ad2bce072e4cc4260ed551ef7c Reviewed-on: https://gerrit.libreoffice.org/34652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-02-27tdf#106082 fix missing statusbar translations (l10ntool is picky about syntax)Christian Lohmaier
having the ; on a separate line made all strings following that have the string-ID of the next unit, altering the msgctx and thus translations wouldn't apply anymore Change-Id: Ia1e3c36a9d2a57725c90e6c3f33de99bed85ec41
2017-02-27loplugin:loopvartoosmallStephan Bergmann
Change-Id: I2e80e15ded19e09853ec16f9876e425a88cf910e
2017-02-27loplugin:loopvartoosmallStephan Bergmann
Change-Id: Id2771f413798ed9ceb76e9c4dd3113633d4e481e
2017-02-27tdf#77111 odt import: treat PAGEDESC_PAGENUMOFFSET==0 as autoJustin Luth
Ever since 2010 commit 7edaf190 zeroes have been saved as XML_AUTO. Ever since 2014 commit c2ccd20c, a numoffset of zero is no longer considered to be auto (for MS compatibility) but is still treated as auto during xml export. Thus, any older documents that had been saved with a zero should still xml import as auto instead of as 0. Change-Id: I1a0df32a8e2f1b30b2bedbf4c9bb07ebec239637 Reviewed-on: https://gerrit.libreoffice.org/33267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-27loplugin:loopvartoosmallStephan Bergmann
Change-Id: I3ada4fc8c8ebcf04962be03c048fb87bc0d6dbf8
generated by cgit (git 2.34.1) at 2024-12-28 08:03:57 +0000