summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-02-26loplugin:refcounting in formsNoel
Change-Id: Idba46c8b30a3c44f12c0aaa8a00477865ecfb848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111542 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-26loplugin:refcounting in basicNoel
Change-Id: Idbee5b35215f794e6785925dafb6f160caa24a22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111541 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-26tdf#134940 sw: fix AutoCorrect of arrow "-->"László Németh
Fix bad replacement of "-->" with "–>" instead of "→" (i.e. premature replacement of "--" to n-dash) since '>' was added to IsAutoCorrectChar(). Regression from commit 57f07b1d7378d218648667c5b1315cc8ad905875 "tdf#133524 AutoCorrect: support double angle quotes". Change-Id: I06f0cddb48d13c8e230dab964f79f588799ed4ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111527 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-26Simplify VistaFilePickerImplMike Kaganski
Change-Id: I13ac92f8f28a1d912681239fee1780093f8be444 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111561 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-26tdf#131000: sc: Add UItestXisco Fauli
Change-Id: Icb2737de1e9e14c55cf4a2f999d1d0585c98b895 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111570 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-26tdf#131522: sw: Add unittestXisco Fauli
Change-Id: I8920f12c655b7106a3eb2a5a3916793453c3694a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111569 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-26qtcreator: Create *.pro and *.pro.shared files in builddir, not srcdirMichael Weghorn
With the previous modifications to Qt Creator IDE integration, this makes 'make qtcreator-ide-integration' work when run from a separate build dir, and allows to use multiple build dirs for the same source dir in parallel, each with its own set of Qt Creator files referring to the specific build in their build and run settings. Change-Id: I5d85d0d280be5e5edca15760bcccfc793e1e4b2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111553 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-02-26qtcreator: Use absolute paths in *.pro filesMichael Weghorn
... as a preparation to make this work for the srcdir != builddir case as well. Change-Id: I87507b9866f97cdbdf848c6b187b3b8f17262b6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111552 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-02-26qtcreator: Simplify adding of file extensionMichael Weghorn
Create a new method 'get_file_path' which basically does what 'get_header_extension' and 'get_source_extension' did, but already concatenates the extension to the input; call that one and rename other methods accordingly. While at it, let 'get_source_extension' search for files in srcdir instead of builddir, as another step in making generation of qtcreator-ide-integration work properly for the case where srcdir != builddir. Change-Id: I1e34bfdb726192b4af21e9003205fa551545ae31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111551 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-02-26qtcreator: Don't explicitly delete old *.pro{,.shared} filesMichael Weghorn
They are overwritten when written with the new content anyway, since opened with file mode 'w+', i.e. they're truncated first. This also simplifies handling the case where srcdir != builddir, for which support will be added in a subsequent step. Change-Id: I1dd3386cdf0b97a6299357d6c12ed2d7b6365eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111550 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-02-26qtcreator: Translate comment: "et" -> "and"Michael Weghorn
Change-Id: I2fe51ab0cdfca5c94bd520ed7f9096bc7c8f6fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111549 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-02-26qtcreator: Move assignment to 'mode' out of try blockMichael Weghorn
The variable is used outside of the try block further down. While that works with how Python handles variable scopes (and there is no exception before the assignment happens), moving the variable outside makes the context/scope clearer. Change-Id: Iecfd0477ffb4515cf58736ee138fc8ca7273967f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111548 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-02-26devtools: support showing type's name as valueTomaž Vajngerl
Change-Id: Ifd99e884efe229dee2d0b42c6c66d3d9c3c90e7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111531 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-26devtools: add popup menu for properties to inspect objectsTomaž Vajngerl
With this change it is possible to inspect an object that is listed in the properties (instead of expanding the tree view node). Change-Id: I8b2229af650b46064c82bdd3fe93192d352d32e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111530 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-26tdf#124176 Use pragma once in sw/source/core/textSuhaas Joshi
Change-Id: I6fa5895ae050e9f8cbb4cfd13572ddad0e2cb1f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108832 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-02-26tdf#124176 Use pragma once in sw/source/core/textSuhaas Joshi
Change-Id: I2104cad267e6f704f9389b03ff3f116fca875517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108796 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-02-26Slightly simplify COMReferenceMike Kaganski
Change-Id: I6447dbdc3e2549d0e55feeee80249bdf75924ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111466 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-26loplugin:refcounting in connectivityNoel
Change-Id: Iee324d84334f60a13615a4d422d480c9c597fdbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111539 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-26loplugin:refcounting in avmediaNoel
Change-Id: I0cd6d6a4a45d77b25f04c3b49327f1cf9279c6a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-26devtools: support XIndexAccess and XNameAccess in object inspectorTomaž Vajngerl
If the current object in the object inspector is an container that supports XNameAccess or XIndexAccess, we now show the named or index values in the property view. This way the user can navigate to sub-objects, which is sometimes needed because we get an object supporting this intefaces, but can't navigate further. Best example would be XShapeCollection, which is what you get when selecting a shape (because with a selection we can select multiple shapes), but it is not possible to navigate to the shape without this change. Change-Id: I6a18723eccbc41519e3eacf68bc5b6488e02fe22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111529 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-26Implemented MoveShapeHandle methodmert
This method will be shared among 3 modules via uno:MoveShapeHandle uno command Change-Id: I921a1f7f004e2004e142954b40b4b93282eb8fed Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111373 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111507 Tested-by: Jenkins
2021-02-26Send handle information of selected shapes to LOKmert
Include the handle information to the callback for the new uno command for interactive dragging/resizing operations. Change-Id: I57c03abc22d3831606da2b698f1de080e9b4da78 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108686 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111506 Tested-by: Jenkins
2021-02-26WIN don't use --wrapper-print-cmdline in verboseJan-Marek Glogowski
This breaks configure, as it fails the check: "gcc-wrapper.exe --wrapper-print-cmdline supports -c -o file.obj... no" That's because that cmdline is written to stderr, but that check also tests for the stderr output and diffs it with some linker boilerplate, which definitly has a different command line, so there is practically no way to use that flag with configure. I'm not sure how that even passed here. Even a current autconf still produces the same check code then the old libjpeg-turbo configure script already contains. Regression from commit 4108665b63ab432732b8b351568c255d872cc3ff ("WIN cross: fix gpg-related library builds"). Not sure, if I should drop the whole flag.... Change-Id: Ie01b00c5890c66479c33c61589366ce35cc783ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110962 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-02-26fix unpack-sources to not require GNU findAndrew Udvare
This makes bin/unpack-sources work on systems that do not have GNU coreutils in PATH, such as macOS. Change-Id: I54ed219eedf0f45c039edb6e486f3afe273dd51f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107936 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-02-26tdf#132368 svx: empty the interop grab-bag on ending text editMiklos Vajna
Regression from commit aafaf1f55fa413ad49d4556cf7c0a713dd206ae4 (PPTX export: save SmartArt as diagram instead of group of shapes, 2019-03-13), the idea of interop grab-bag was to carry additional information around as long as the object is not changed. However, actual clearing of the grab-bag was never implemented, do this when editing shape text. An alternative would be to do this in SdrObject::SetChanged(), but Writer sets the layer of SdrObjects during layout (when the import filter is already finished and undo is enabled), so that would mean loss of the smartart metadata for DOCX. Change-Id: I9ab205b4ef84169f4b5a16b86fe9a152e3370a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111560 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-25tdf#140601 change tooltip to "Toggle Restart Numbering"Seth Chaiklin
Change-Id: I13dc4bdba4379e2610b505f9126a481bb95a832c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111320 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-25Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to ea1198386289e62c63639b708d2c5db0d9401b19 - tdf#139667 update howtoget for Ordered tab - Bullets and Numbering Change-Id: I27f763c1945184824a5e1c31369ebe6c4052e227 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111464 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-02-25Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to ae135a1767acad73ac3fafe4af3ac941d0f69bc8 - related to tdf#139667 update shortcut keys for Writer F12, Shift+F12 * update to Ordered and Unordered List * indicate that F12 and Shift+F12 is a toggle * update to <h1>,<h2> Change-Id: Id106c7786b8e7cf09d72636a6ca0125b78e949cf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111574 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-02-25drop archaic rollable supportCaolán McNamara
Change-Id: I69f94cd8013a31f8f6bcf62d703b99f659a1ebb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25drop WB_ROLLABLECaolán McNamara
as far as I can see Rollable isn't a thing anymore Change-Id: I274e9dc88c793a5833e26bce292b4e92617ae084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111554 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25allow use of FloatWinPopupFlags without including complete floatwin.hxxCaolán McNamara
Change-Id: Ica412938ead6f213668b3aa876bff81d8f512f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111526 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25dockwin.hxx doesn't need to include floatwin.hxxCaolán McNamara
Change-Id: Ib0408f715c9a12f32ce2f8049d2c9c7272201d76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111504 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25sw: fix incorrect loop condition in SwTransferable::isComplex()Miklos Vajna
We're not consuming hints in that loop, so we want to end when the iteration ended, not when the list of hints is empty. Change-Id: I2cb735c03c3551f7b0be8b314183780eedff9ecf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111519 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-25Use std::gcdMike Kaganski
Change-Id: Ie24472aa2fd3bcda0ccb5945de38bd865b7d01aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111462 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-25tdf#36466 sc UI: add new options to deselect hidden cellsTünde Tóth
Implement "Select Visible Rows Only" option to deselect the cells of the hidden rows in the actual selection. Implement "Select Visible Columns Only" option to deselect the cells of the hidden columns in the actual selection. Test e.g. on some data on A1:C1: 1) hide column B (don't try to test with autofilter, because copying of the filtered cells has already worked this way). 2) Select A1:C1 (2 visible cells) 3) Choose Edit->Select->Select Visible Columns Only (no visual feedback) 4) Copy the selection. 5) Paste it e.g. in D2: only A1 and C1 are copied, but not B1. Change-Id: I354ebdf6be6bddae4440f3e9b4929c6e82abc1df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111100 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-25tdf#136570 OOXML import: fix height of OLE objectsAttila Bakos (NISZ)
e.g. OLE icons or math formulas by skipping unset border properties. Regression from 636d16efe45a55c1a5a7a451c46fbb8618bf0393 (tdf#135653 OOXML import: fix OLE background color). Change-Id: I64bd68037d063de81fbb302b90d65b77af50a622 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111119 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-25tdf#140469 XLSX import: apply more than 8 filtersBalazs Varga
in OOXML autofilter import by removing the artificial limit (which looked like the limit for conditions handled by the standard filter in LO, but not for the autofilter). Now the autofilter popup menu does not always select all items, if the document contained more than 8 selected items there. Change-Id: Iaa6ce15d4b1162ab78dd001734721ae859283d0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111156 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-25tdf#98690: sc: Add UItestXisco Fauli
Change-Id: I19695798fa693b05d48d69514a037368241f696a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111525 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-25tdf#140572 writerfilter: ignore position in docDefaultsJustin Luth
Despite the documentation saying that anything in docDefaults should apply everywhere unless it is overridden in a higher priority style, the subscript/superscript setting in docDefaults seems to be ignored. Makes sense in a way, but perhaps document those exceptions? I looked for documentation in both "docDefaults" and "position" and didn't see anything suggesting why it is ignored. Change-Id: If676415b112921e4cb8f7306b8c8ad93a6fd8cde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111442 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-25online: fixed freeze pane not writing correct data on file savePranam Lashkari
problem: when we save the file after setting freeze panes in online, opening same file in Desktop libreoffice will show incorrect view, each freeze view would start from A1 this patch ensures that we write correct starting cell pos for each freeze view Change-Id: Ic8ccd5fb5cbedf2ea4f0e9376f0cfdd530e32d6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111505 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-02-25adjust tooltip in Save as dialogSeth Chaiklin
Change-Id: Id54442ce9e65ab1dea010d762b989210f69f6e8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111427 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-25tdf#115815 sw: fix lost annotation ranges of redlinesLászló Németh
Annotations of tracked deletions lost their ranges during ODF export, according to the limitation of ODF or its recent implementation. As a workaround, save and restore the start of the annotation ranges using temporary bookmarks (which can be part of text:deletion). Note: maybe it's possible to split redline ranges regarding to the start of the annotation ranges, mixing tracked deletions with normal text or tracked insertions, but this would be a not backward compatible solution, because the ODF import of this file inserts extra (not tracked) spaces around the annotation, losing the original text content. Change-Id: I786993a05ee1683076e213374a92969d1856cf8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111489 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-25pdfium: turn the PDFium class into an interfaceMiklos Vajna
This will allow a dummy implementation that only provides PDFiumLibrary::get() and nothing else. Change-Id: Ia63b3f0b7751e5c05716825f0854282e4007207e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111502 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-25tdf#139734 Remove redundant asserts after MacrosTest::loadFromDesktopMoaz
MacrosTest::loadFromDesktop itself asserts on its return value. Thus, the additional checks in unit tests are redundant, and only create noise unrelated to the tested functionality. Change-Id: If616001b296afdde38f5a23ececee3d44b4a395d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111290 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-25tdf#133473 Change SDRATTR_SHADOWSIZEX flag.Gülşah Köse
SDRATTR_SHADOWSIZEX holds a percentage value. So we shouldn't use METRIC_ITEM. Change-Id: I9f1a20d5871f60d2899ef7d525f4cf837b0a9088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111311 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-24tdf#138271: sw: Add UItestXisco Fauli
Change-Id: I9bfa7e83fcafe9b809daf93e5a41bc74c9d5e3f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111501 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24tdf#139486: sw: Add UItestXisco Fauli
Change-Id: I250bd21d1ffb7f2076ef08a1d69c0c6929e8420f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111492 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24drop an unneeded includeCaolán McNamara
Change-Id: I086036cf19b7e011da17ab5767460ac3e10eab2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111497 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24drop unneeded includeCaolán McNamara
Change-Id: I6d58ca8565f8de2d76482e24af1e027f900c5373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111496 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24drop empty headerCaolán McNamara
Change-Id: Id0442482f940cf5329e2c9d44ed90b7d5b862aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111495 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-06 15:48:47 +0000