Age | Commit message (Collapse) | Author |
|
this is one of the secondary analyses this plugin performs
Change-Id: Iaa4424c2396470c6f1df85b0290fbffdda35fa08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143177
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which is a bit misleading
Change-Id: Ifd986c0bda8311453b17ed08d2aeab5b09665a04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143185
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I269315556624c48373815640605a93c91a4c9819
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143184
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
to avoid collision with Window::ImplScroll
Change-Id: I16e72ff842054979733b5149cd220a7a77f79351
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143187
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
As I see it, every test compare the same file with and without
OpenCL. However detectOpenCLDevice calls
sc::FormulaGroupInterpreter::enableOpenCL_UnitTestsOnly()
so OpenCL is always enabled
Change-Id: Ib6f896e246558de7439f2fe8601c446e4447def1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143183
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
the "Rapid Security Response" feature added with macOS 13 (Ventura)
makes Safari a stub in a different location. Instead of the traditional
/Application/Safari.app/ the call to query the default app will return
/System/Volumes/Preboot/Cryptexes/App/System/Applications/Safari.app/
So instead of a full match, just check for the suffix.
Change-Id: Ic4abfe33c118827bc0e089e9966e57a0fd8c0526
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143178
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Handling of image counter was incorrect if the
document contains embedded documents, overwriting
images with the other ones.
See also commit cf2dc247ff5f726238856e9b46a4926a30430e14
"DOCX export: image deduplication and clean up" and
commit 3f6df3835fec71ea61894f9a3bbfe5e4a06a5495
"DOCX export: fix image counters for multiple documents".
Change-Id: I3ce3e370f96fa8b9feca3bc73f06ddca933215d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143036
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
The font name of the watermark text is currently hardwired to Helvetica,
a sans-serif font.
The problem is that this looks bad in case your document uses serif or
monospace fonts. Or perhaps your document uses a single font and you
want to make sure that the watermark uses exactly the same font.
Fix the problem by adding a new "WatermarkFontName" PDF export filter
option to specify the font name explicitly.
Example cmdline usage:
soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkFontName":{"type":"string","value":"Times"}}' test.odt
Change-Id: I2f065e1517236695b0a95369bdcd803125018587
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143143
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I8d7bb4593839d3660b6609d836b09d50b68f5712
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143141
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
* Update translations from branch 'master'
to eee3cf83384a758f9cc80d11885e1fcaa06b0fc3
- update translations for master
and force-fix errors using pocheck
Change-Id: I87cd0e8ca6efc815adbc6b60971fd376e8da0818
|
|
When compiled without PDFium, two tests in svx were causing segmentation
faults, as they were trying to access null pointers. Add a check for the
pointer returned and end test if it is a nullptr (based on how it is done
in other tests).
Change-Id: Iab3c341a20f002adc92fac22ef76ed022aa49422
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143081
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
In addition to leaking memory, the struct holds a couple of VclPtr,
so would prevent destroying referenced windows.
Change-Id: I258b5f32aca033a602d7b2805b33bd08ba637309
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143154
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Modify testPreserveMacroTemplateSignature10 and
testPreserveMacroTemplateSignature12 to test:
OTT -> OTT -> OTT
OTT -> ODT -> OTT
before it was:
OTT -> OTT
OTT -> ODT -> OTT
Change-Id: I1a0b7f1607202e994bf5847660b5abdc715106eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143140
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The offset is defined by formula's top/left borders (in UI under
Format->Spacing).
Change-Id: Ic17356f8c6e4db3cbe0df765d133ee240f5b088d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143136
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change shape line width values of minimal office theme
to the correct 0.5, 1, 1.5 pt (from 0.7, 2, 3 pt).
Change-Id: Ied7ad2e29daed9130df8b8c8d8baf5342f1c75da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142427
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
The font height of the watermark text is currently automatic: we start
with a value based on the page size and then decrease it till the text
fits.
The problem is that sometimes you want a smaller value, but specifying
this was not possible.
Fix the problem by adding a new "WatermarkFontHeight" PDF export filter
option to specify the font size explicitly.
Example cmdline usage:
soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkFontHeight":{"type":"long","value":"100"}}' test.odt
Change-Id: Iceab943b7a995badfcdc6b12ecc9264e39e4a3a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143135
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
LJT-01-003 of https://libjpeg-turbo.org/pmwiki/uploads/About/TwoIssueswiththeJPEGStandard.pdf
Change-Id: I834e0891c4bb91907750282a26b8b803f94b8fb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143131
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Quoting <https://gerrit.libreoffice.org/c/core/+/143098/2#message-62ac4499370dd88eeb3181f52d817e831150c94d>:
> What we do in other such cases is not make it conditional on the
> pointer argument being non-null, but rather make it conditional on the
> length argument not being zero. That way, it only catches the
> "harmless" case of an "irrelevant" null pointer in combination with a
> zero length, and doesn't hide bugs where the pointer is erroneously null
> while the length is non-zero.
So check for the length and not for the pointer argument.
Change-Id: I1894eb67d49a9ae40cdce29de865172400a271dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143134
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
...when the target type is a reference type and the source and target type have
different cv qualifiers. (And fix the fallout. And make the tests cover that
somewhat more exhaustively; and while at it also test that the plugin can cope
with dynamic_cast to void pointers, which is the only legitimate case where a
dynamic_cast can involve types that are not (pointers or references to)
non-class types.)
Change-Id: Ia568ddb5dbc4a84c275db172791c345d95964857
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143133
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...which caused `make translations` fail for me with
> [POT] pot.done
> dyld[96290]: Library not loaded: @__VIA_LIBRARY_PATH__/libuno_sal.dylib.3
> Referenced from: <CD4F28D6-E3BE-3126-B861-C90BF3E14492> .../workdir/LinkTarget/Executable/cfgex
> Reason: tried: '/System/Volumes/Preboot/Cryptexes/OS@__VIA_LIBRARY_PATH__/libuno_sal.dylib.3' (no such file), '/usr/local/lib/libuno_sal.dylib.3' (no such file), '/usr/lib/libuno_sal.dylib.3' (no such file, not in dyld cache)
> Error: Failed to execute .../workdir/LinkTarget/Executable/cfgex -i .../connectivity/registry/ado/org/openoffice/Office/DataAccess/Drivers.xcu -o .../workdir//pot/connectivity/registry/ado/org/openoffice/Office/DataAccess.pot
(This is the opposite case to 17cfd43e28c45626b1e0990bd0e51fdc97409ebe "Avoid
external processes picking up instdir/program/libxml2.so.2". Here, the
executables called from Executable_localize are LO-internal executables that
need the libraries in instdir/. There, the scripts called from
Executable_localize in turn only call external tools that shall not accidentally
pick up LO-internal libraries from instdir/.)
Change-Id: Ib1aa240ee47a21d14ec0463fee85bebe82453cee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143118
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Which means XmlPortionDumper can be finally removed.
See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
(CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
2022-04-07) for motivation.
Change-Id: I50e6c49a50c5ccbec9e426ad796d85865dcc93e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143128
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
For a while, plainText needed special handling
added in commit 9700c1b2170ad04453a361ed5647937833ac3c18
Date: Mon Jul 25 09:13:03 2022 +0200
sw content controls, plain text: add DOCX import
But now it is treated the same as all the others
and so can be lumped together with the other case statements
since commit de90c192cb8f1f03a4028493d8bfe9a127a76b2a
Date: Mon Sep 19 10:01:36 2022 +0200
sw content controls, plain text: enable DOCX filter with data binding
Change-Id: Ie1ebe3873e8f49ae9747f1a77d08bfc0dec2d9f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142953
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Change-Id: Ibd9fc78d88732b63d418404fa23e1560bf531fbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142984
Tested-by: Jenkins
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
for tdf119074-1.odt, while I have a strong memory of testing that it
solved the problem, I know find that it doesn't.
Change-Id: Id7fc800702c6a417810cba22f180d933d9fcd9b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143125
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I070b7a8ea599f1faddb009c68aeb4b8536cc52e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143130
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia0060f20a8851e0431efaef0dc04fb36ae2c41a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143129
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If874c0227ec724fa5b1517080db252e64f9597c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143121
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Massively called it is really unnecessary to do that each and
every time. The debug build is slow enough..
Change-Id: I06525e4ca1fa23a1d49dd735370eb157157800e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143127
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: Ifd1d5baa6e304d370b82e93781abf47da437c766
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143123
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ia666ef09e60f1d52e813adb392a99b68008d1f21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143091
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
This is micro-optimization, but..
Change-Id: Ic5d43bc0ce9343cf194e189777109636d3b587c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143126
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Exporting the DOCX bugdoc back to DOCX resulted in a document that can't
be opened in Word.
Examining the output, the problem is that the document had 2 inline
<w:sdt> elements with <w:id>, and we mapped such <w:sdt> elements to
both grab-bags and content controls, leading to duplicate <w:sdt>
elements on export. This is schema-valid, but it goes against the
intention of the spec and Word can't open it.
The initial fix was just a writerfilter/ tweak to avoid grab-bagging
<w:id> for inline <w:sdt>, but CppunitTest_sw_ooxmlexport4's
testSimpleSdts points out that in other cases we already require
preserving <w:id>. Fix the problem by storing <w:id> in the content
control, which is essentially a subset of
<https://gerrit.libreoffice.org/c/core/+/142818>.
Thanks to Justin Luth! - he prototyped the DOCX filter for <w:id>.
Change-Id: I9f002b770049ce8be30253d0b39410d9a58981dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143117
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Hide notes in hidden rows or columns just like we do
in case of other sdrobjects.
TODO: unit test
Change-Id: Ib136324d5d0dd8777fc0912af6d8b9ac39935ac1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143024
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
|
|
For unkown reasons only TitleText and OutlineText were tagged when this
code was added in 2004 commit 489cf28b88e174db4dffc55d9aa245e7d7c90a2c.
Tag as Div, like Writer in SwTaggedPDFHelper::BeginBlockStructureElements().
Change-Id: I55ccf26bceac4f89383f1ec1de6c00d0a1353615
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143120
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
...introduced in 6cb400f41df0dd108cdb4b4d3ec6656844814147 "store the SfxItemSet
inside SfxSetItem by value". It appears to make more sense here to check that
an SfxItemSet is not an SfxAllItemSet, than to check that an SfxSetItem is not
an SfxAllItemSet.
Change-Id: I292c2a88910db9852cf8ba7c61999c5f281ed14a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143119
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... that can actually cope with negative (BCE) proleptic Gregorian
calendar dates, which already for Julian calendar dates 0001-01-01
and 0001-01-02 they are.
Change-Id: I38481007e705f95da0f4f73a6bb298ce42494f72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143115
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
So they can be reused, specifically in
connectivity/source/commontools/dbconversion.cxx
Change-Id: I8b2b59e3cb078a73d5f670f0756404471009cf9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143114
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: Ia265f9f5e1151efae6d2b4cbb3c06f4ddbcc06e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143068
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
rather than effectively emulate it poorly
Change-Id: If1c215892645d83937d97158a2d3f8ddac10364e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143104
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7be721d9409890fe1f26125f06561e85cb1ddb27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143113
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 8e7f48e5e03d5588b00d341c5a82fa1a74b2bdd9
- tdf#151827 Improve the ODBC connection help page
As requested by the OP this page clarifies that we're actually connecting to a ODBC data source.
I also made other improvements to the text and fixed the case when the user presses F1 in the Data Source selection dialog.
Change-Id: I89817df62e5dadaa4e1258768f442bbc4bb08fe7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142916
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Iec561daa71b17cedf0ea4cd2b473df9591a7bf3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142900
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Unify the code and use GetFormula everywhere.
No need to define a specific assertion when
we can use OUString comparison instead
Change-Id: I7cd6f16bb32d6a659cac4e656bd4465393533cb5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143094
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This patch saves the last run macro using the Macro Selector dialog
(via Tools - Macros - Run Macro).
Change-Id: I9da9262daffec402fc5f76691473263f9319664e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142632
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
|
|
As requested by the OP, this patch improves the strings used in the Database Wizard for ODBC connections, clarifying that we're actually connecting to a data source.
Change-Id: I8752204759ea03481542c20d0626ad27d1c3959d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142917
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: Iae2158ff4de0cab4307379c48011d5b6ca844b13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142821
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ic80c0753b600ff6e846f2f38a1c46cb67763e2fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142820
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I98e862c4c1124b1db8eb3e0ea7ff96effd629185
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142721
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I9be3df3a4c00e7f1bbfc4f2462c8cf9a0f813f9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142656
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
As introduced in commit 99102d4263189d347c7a7d0df8fd782e8c4c8ad5.
Change-Id: Iece8595a401df7bd5a514244d4a4fc825a49f9de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142819
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|