summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-22pvs-studio: V716 Suspicious type conversion in return statementCaolán McNamara
https://docs.microsoft.com/en-us/windows/desktop/api/objidl/nf-objidl-irunnableobject-isrunning has IRunnableObject::IsRunning as returning BOOL unlike ::Run which returns HRESULT Change-Id: I992d8ba33502eff56b582e1cb9b73f6227c383b8 Reviewed-on: https://gerrit.libreoffice.org/62169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22Add unit test for mysqlc connectorTamas Bunth
It can be used to test the mysqlc connector whenever there is an external mysql or mariadb server running. The test runs only when CONNECTIVITY_TEST_MYSQL_DRIVER environment variable is set. This variable should contain the URL of the database, including the port number and the host name. The URL should also contain a user name password pair which can be used to connect to the external database. The URL format is the following: [user]/[passwd]@sdbc:mysql:mysqlc:[host]:[port]/[db_name] README is updated and contains detailed information about the test. Change-Id: I1bbc9369ff193a29c06de63a0f6cc975877c8da3 Reviewed-on: https://gerrit.libreoffice.org/62171 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-10-22loplugin:staticvar ignore rtfkeywd.cxx for nowNoel Grandin
Change-Id: I2bd26bcad94aa905f0c87d92b43561855409e330
2018-10-22Let CppuniTest's unoexceptionprotector handle uncaught exceptionsStephan Bergmann
(it nicely prints exceptions' messages, too) Change-Id: I66bb4fd856d0249a7dc5bc58975b6ea322f9a9ca Reviewed-on: https://gerrit.libreoffice.org/62165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-22Resolves: tdf#120785 no parent set via status barCaolán McNamara
Change-Id: Ibdc0f75b18330b77e18293f7485e165d2133290e Reviewed-on: https://gerrit.libreoffice.org/62179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22Disable loplugin:staticvar for nowStephan Bergmann
produces false positive > [CXX] svtools/source/svrtf/rtfkeywd.cxx > /home/sbergman/lo/core/svtools/source/svrtf/rtfkeywd.cxx:38:23: error: var should be const, or whitelisted [loplugin:staticvar] > static RTF_TokenEntry aRTFTokenTab[] = { > ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ Change-Id: I7cd96988218d1192ced2fadff911c7ec89088012
2018-10-22tdf#120703 (PVS): redundant nullptr checkMike Kaganski
V668 There is no sense in testing the 'pMed' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Ia630fd30d86e9b8f9ce85077edbd949274bbee70 Reviewed-on: https://gerrit.libreoffice.org/62125 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-22Resolves: tdf#120731 crash in border tabpageCaolán McNamara
Change-Id: Id11b8fdc91e552a38a78f13df410f4d364e7acbf Reviewed-on: https://gerrit.libreoffice.org/62170 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#119506 Draw Contextmenu in Writer, Calc, Draw, Impressandreas kainz
and all the other sw modules Change-Id: Ie407f858bf1d17f3af4c2948fcd4cb40bc9e8c92 Reviewed-on: https://gerrit.libreoffice.org/61963 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22tdf#119547 Media Contextmenu sync in all appsandreas kainz
similar layout to graphic Change-Id: Id97460cdeb1db62326b7cb2e7655a39af2c1ae99 Reviewed-on: https://gerrit.libreoffice.org/61962 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22NB tabbed calc: finishing correct padding and final tab reviewandreas kainz
Change-Id: Ib0bb557a2a98d8256182aab29b98b953ffc9c7a4 Reviewed-on: https://gerrit.libreoffice.org/62172 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-22tdf#120410: Disable insert/delete row/page break if sheet is protectedXisco Fauli
Follow-up on f7982d4dfa85f15a6f0c25e9795a5847ecfcbf31 Change-Id: I2defd3474fdbb0b87898df7734bb076ab95c8c08 Reviewed-on: https://gerrit.libreoffice.org/61950 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-22loplugin:staticvar ignore this case for nowNoel Grandin
Change-Id: Ic0e5e113ff16dbb3fb246c52f5a2fee8d9f52304
2018-10-22pvs-studio: silence V649 dubious Two identical 'if' statementsCaolán McNamara
Change-Id: I303b4db52e852011d45a147f3010a8f934c1f77b Reviewed-on: https://gerrit.libreoffice.org/62167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120176 - Text appears as white on first launchheiko tietze
Splash screen text should be black now Change-Id: I963ffc89c48fdc1de148586cd6f0fb4bf35d44bd Reviewed-on: https://gerrit.libreoffice.org/61924 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22tdf#120034 - Position of New > Master Document questionableheiko tietze
Item moved above Templates... Change-Id: I813544bbfb76c34dd3e73daf87d8d5ea1478240b Reviewed-on: https://gerrit.libreoffice.org/61787 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22pvs-studio: V794 The assignment operator should be protectedCaolán McNamara
Change-Id: Ia443a0e61a091d877c8da26bf7d45bf4261f8669 Reviewed-on: https://gerrit.libreoffice.org/62166 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22loplugin:unusedfields improvemementsNoel Grandin
treat fields touched in operator== as not being important, which finds some more stuff (but also adds some false+) Change-Id: I3f5d504d7dec7945a917afbcd58c92df74f03645 Reviewed-on: https://gerrit.libreoffice.org/62020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22loplugin:staticvar in variousNoel Grandin
looks for variables that can be declared const and static i.e. they can be stored in the read-only linker segment and shared between different processes Change-Id: I8ddc6e5fa0f6b10d80c75d5952df8ddd311cf892 Reviewed-on: https://gerrit.libreoffice.org/61591 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22pvs-studio: V668 no sense testing against null as memory was allocated by newCaolán McNamara
category V668 complete Change-Id: I986d4cb89a7c72d54d71ea01fc598a9958deee24 Reviewed-on: https://gerrit.libreoffice.org/62138 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The '!aDelData.isDeleted()' condition was already verified in line 359. Change-Id: Ie66aa65c024e30d34a4b0766ddad3fa24ce98644 Reviewed-on: https://gerrit.libreoffice.org/62163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V728 An excessive check can be simplifiedCaolán McNamara
for... "The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression" subcases, where the args are already bool Change-Id: Ica8b5c4974c513f7f7ad8acf17ca931e85ebc8af Reviewed-on: https://gerrit.libreoffice.org/62146 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V785 Constant expression in switch statementCaolán McNamara
Change-Id: I2ac33db8d265f1af1c8fc8def2d3a45c5be37741 Reviewed-on: https://gerrit.libreoffice.org/62154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The 'pNew' condition was already verified in line 47. Change-Id: Ib6b6a48f8c565ee28bbbaa8846f549639b6291be Reviewed-on: https://gerrit.libreoffice.org/62159 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-10-22pvs-studio: V1001 variable assigned but is not used by the end of the functionCaolán McNamara
Change-Id: Ida759ae9fce3d384b19e41683bdcd796eb158efe Reviewed-on: https://gerrit.libreoffice.org/62147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): redundant comparisons, dynamic_cast<T&> in dtorMike Kaganski
V560 A part of conditional expression is always true: (nHintStart >= nStartIdx) V509 The 'dynamic_cast' operator should be located inside the try..catch block, as it could potentially generate an exception. Raising exception inside the destructor is illegal. V560 A part of conditional expression is always true: pHint. Change-Id: Icfb9a2961f5db034fd19f4665fe3ceaae6232350 Reviewed-on: https://gerrit.libreoffice.org/62039 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-22tdf#120674 set DlgEdForm early in DlgEdObj::EndCreateArmin Le Grand
Change-Id: I5ba0504265f5692614a8db0117883528bd4bfc0b Reviewed-on: https://gerrit.libreoffice.org/62000 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-10-22tdf#120249: fix escaping to handle quotes and multiple trailing backslshesMike Kaganski
Follow-up of commit f4103a42d58535e21c48ff94ab000ab0305c62e3 Change-Id: I4562386d3151875dff8e9eddf31c4af3333cefb7 Reviewed-on: https://gerrit.libreoffice.org/61245 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-22NB tabbed draw and impress: finishing correct paddingandreas kainz
and final tab review Change-Id: Ia91398f65486f09fccce19b3b1a568f96844cd24 Reviewed-on: https://gerrit.libreoffice.org/62164 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The 'pArgs' condition was already verified in line 47. Change-Id: Id63eb556610ec457864e44b7d3f49e46f133e5a9 Reviewed-on: https://gerrit.libreoffice.org/62162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The 'SwKeyState::KeyToView != eFlyState' condition was already verified in line 1723. Change-Id: I4fb5d7a5e50822985ca753706d4cdb1693439118 Reviewed-on: https://gerrit.libreoffice.org/62161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The '!pNumRule' condition was already verified in line 2092. Change-Id: I2fc040e9c3053b351b99eb123285ef05f20813f5 Reviewed-on: https://gerrit.libreoffice.org/62160 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The 'pColumn->GetWidthOption()' condition was already verified in line 1033. Change-Id: I5bc11bceddc8090f41bf86b45f880ceea3dfb204 Reviewed-on: https://gerrit.libreoffice.org/62158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The 'mpView' condition was already verified in line 417. Change-Id: I64d522412f1f627ab04a29f90b33177ef726eb58 Reviewed-on: https://gerrit.libreoffice.org/62157 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The 'bOk' condition was already verified in line 1553. Change-Id: I19a30071ebfc1937d03f2fdfcbfc12017e3e835e Reviewed-on: https://gerrit.libreoffice.org/62156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The 'mpViewShell' condition was already verified in line 887. Change-Id: I90e8beee2f66936122824e403ae82aebceb3adc4 Reviewed-on: https://gerrit.libreoffice.org/62155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22Simplify containers iterations in ucb, ucbhelperArkadiy Illarionov
Use range-based loop or replace with STL functions. Change-Id: I3cdb0f89523008199af1550de164a52b75c52ba5 Reviewed-on: https://gerrit.libreoffice.org/62088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22Sync extension registration on startupSamuel Mehrbrodt
There are cases where the extension registration becomes invalid (empty rdb files) which leads to extensions not starting up, although installed and active. Syncing extension repos on startup fixes that. The performance impact is negligible (1ms in my measurements). Change-Id: I10475ce6a054b43c4591b17a8486648ca6a30068 Reviewed-on: https://gerrit.libreoffice.org/61943 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-22tdf#120703 (PVS): redundant nullptr checkMike Kaganski
V668 There is no sense in testing the 'pProgress' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Ida8c103e5f08d380e5c2de5bc5d269597bd32e30 Reviewed-on: https://gerrit.libreoffice.org/62151 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-22loplugin:singlevalfields look for fields that can be boolNoel Grandin
Change-Id: Ief773b661a8378a10db56943b32127c7a2c86d11 Reviewed-on: https://gerrit.libreoffice.org/62037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22loplugin:staticvar in soltools..svxNoel Grandin
Change-Id: Ie9f36eb0e00aaee34a27f136ed903f8f87e52dcc Reviewed-on: https://gerrit.libreoffice.org/61916 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22bump product version to 6.2.0.0.alpha1+Christian Lohmaier
Change-Id: If6dedb58b6918d9815c47f898a8b19eb9c0d5681
2018-10-22add Lower Serbian (dsb) language packChristian Lohmaier
Change-Id: Ibafa81b412036e98fa9ab047fc8e204660eae120
2018-10-22Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations for 6.2.0 alpha1 also add Lower Sorbian and force-fix errors using pocheck Change-Id: I616de90d5159504de836211412a2266296b2f624
2018-10-22elementary: Finalize chart graphics, separate dbtable & regulaaaaaaaaaaaaar ↵Rizal Muttaqin
table, etc Change-Id: Ib3c5a5a09eff26acabf64e4cbc2e7019ca3264e7 Reviewed-on: https://gerrit.libreoffice.org/62142 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-22tdf#120703 (PVS): too complex condition; wrong conditionMike Kaganski
V728 An excessive check can be simplified. The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression. V668 There is no sense in testing the 'pCTLOptions' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. The latter is apparently error in our condition, since the || turned it into unconditional execution, but _xISC must be a valid reference inside the block, since it's dereferenced there in all code paths. Change-Id: I7fbbb1c4b54503db50e8eabd2666cbcd05758103 Reviewed-on: https://gerrit.libreoffice.org/62153 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski
V668 There is no sense in testing the 'hdo' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Ic889dcba4e9d77a6dd27dd1603ed37d39e9fe581 Reviewed-on: https://gerrit.libreoffice.org/62152 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checksMike Kaganski
V668 There is no sense in testing the 'pClipDoc' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. V560 A part of conditional expression is always true: pDoc. V560 A part of conditional expression is always true: pMergeFlagAttr. V560 A part of conditional expression is always true: pMergeFlag. Change-Id: Ief75a140cca58fe458dc3c1fd18a9bbaa1ea39cb Reviewed-on: https://gerrit.libreoffice.org/62143 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski
V668 There is no sense in testing the 'pBackgroundPropertiesPtr' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I728ffa74ec5e1f1f428224c79bd17c53b3ad3829 Reviewed-on: https://gerrit.libreoffice.org/62150 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): missing nullptr check; redundant nullptr checkMike Kaganski
V1004 The 'pDocShell' pointer was used unsafely after it was verified against nullptr. Check lines: 258, 561. V668 There is no sense in testing the 'pFrameView' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I768d3f56dbd5edd070da9d989ab2d85c4b8e868f Reviewed-on: https://gerrit.libreoffice.org/62149 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-03-19 17:54:12 +0000