Age | Commit message (Collapse) | Author |
|
After
commit 2f5e7a07775690e57d639eeca7a1e41733fa93a9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Sep 7 08:09:31 2023 +0200
tdf#157092 a11y Let only drawing area dispose its ValueSet acc
had fixed a crash when using the search feature with the Qt-based
VCL plugins, the previous `DBG_ASSERT` that got promoted to a
real assert with the above commit got triggered now that a11y CHILD
events for removed children are handled since
commit be8b031d8b3c66b223ea2478f1129427f3a362bd
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Sep 7 09:51:38 2023 +0200
qt a11y: Forward CHILD event for removed child
, s. the backtrace in tdf#157160.
Since the ValueSet isn't needed for this, and at least removing
a listener after the ValueSet has been dropped even seems logical if it's
a valid use case to delete the ValueSet before e.g. hiding the
window (s.a. comment in above-mentioned
2f5e7a07775690e57d639eeca7a1e41733fa93a9), don't check for it,
but only that the object hasn't been disposed yet
(as was effectively the case before
2f5e7a07775690e57d639eeca7a1e41733fa93a9, when
only a SAL_WARN would have been triggered).
Change-Id: I5be0a44decbe4508f4a419ec3dca9f8aaf85e951
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156782
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
* Update dictionaries from branch 'master'
to 272686e247e81719b86c71d7d1672bc775d91031
- Fixes issue #156669: Updates Catalan dictionaries (spelling, hyphenation, and thesaurus) with latest releases.
Change-Id: Iac7161011d3fc2e684b22f4588be1f812f6d8da1
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/155469
Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
* Update dictionaries from branch 'master'
to 1a0dc6e5aee05f2a07a632adf6e121082fbd1bf5
- Add Indonesian hyphenation library to dictionary package
Change-Id: I807f295947ef9ab053f990c9220a78dad8485629
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/145372
Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
* Remove external/libgpg-error/w32-build-fixes-3.patch.1, which has
redundant contents with a part of external/libgpg-error/w32-build-fixes-5.patch.
Change-Id: I330b5f92717c1c5f6c0637940dfe7c3ac7e58b21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145169
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Checked on jenkins using 'make check' and
+void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
Change-Id: Iabe77c0bd01177066a7a565c0d83c03f61f5fc13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156716
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to f419319c17c61a5fbd36e1bdd1a6b281283ac421
- Create a menu file for writer-only table commands
Change-Id: I401d42c9af27881da223cc51e666d14999d64062
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156780
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: Ieadd35fef7f709e9eaf0f26238f7613076aa8c52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156775
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
WIP SvxUnoShapeModifyListener
Change-Id: I6ec837deec36d5a9c232a02b3759f4f1f9a8686d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156722
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
Change-Id: I6ec236f317d4da7559422a82acdc8d1b2ae8a44e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156723
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 3d76b0da48187a968762fb3c4b2cdd462abc7688
- tdf#155875 UI cmds Writer/Table in Help(41)
+ refactoring
+ Table - Convert menu (part 41)
Change-Id: I9fd415b9b26b8cddde419c09ee7ef85f3ea77a6c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156779
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to ecdb331fcdc8bd47a3556d6cc39380ff40e0e9ad
- tdf#155875 UI cmds Writer/Table in Help(40)
+ refactoring
+ Table - RowSplit command (part 40)
Change-Id: Ieae864974dfd600bf9c2c75cf2cfeff7f076dbdf
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156778
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to c7be50ba620c4b90e136442087f5eb36b97fc608
- tdf#155875 UI cmds Writer/Table in Help(38)
+ refactoring
+ Table - Headers Repeat command (part 38)
Change-Id: Ibb03109bb1b4d6dfc7460be181e8457b14f9d1c0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156777
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to ff28718632e3062ced6aea9f38cf8934bf3f36d4
- tdf#155875 UI cmds Writer/Table in Help(37)
+ refactoring
+ Table - Number recognition (part 37)
Change-Id: I0fba1c1d55aade21c39321ae5c5c4ddabfc72a9d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156776
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
accidentally pushed the test commit:
commit d3e0130b1e5a0beb7995565b6e365aec248eece0
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri Sep 8 14:02:13 2023 +0200
XPdfDecomposer does not need to implement XAggreggation
Change-Id: I8d65d69723120648020654ded658d0fa7c62d906
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156769
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+ void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
Change-Id: I3eb7f69ab16bedbe32e457f67257393822dc90d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156718
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
Change-Id: I650ef48d993450650bfe466ca9d4a9ab32b4493d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156724
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
Change-Id: Id392a4fc3ddf34ce1fa2b66eb1e509e05184e50c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156721
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
WIP SwXFootnoteProperties
Change-Id: Id1e1a0195e770bcbcebd9b55355de230c8641547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156725
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I174a9e84eba4e136d1f487a09afc0b37952ce9e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156766
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 9f24e78f7c45b3fae572c80e3a0542203c829fa8
- (related) tdf#149796 "autoupdate" -> "Automatic update from document"
Update label, and add "tip".
Change-Id: Ief8a36820cf83ccc92b242f7a7b085211303f0ff
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156595
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to a8c9e70bd53f131132fcb79c3fc2f5f16dc3c2c8
- tdf#155875 UI cmds Writer/Table in Help(36)
+ refactoring
+ Table - Format Numbers Styles (part 36)
+ Fix links for AutoFormat.xhp
Change-Id: Ifa15a17e072a2d0d2bcfd8312d8fa47b93e8b742
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156761
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I89d3a3074929ba867975ae57d350b7e4211ed67c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156757
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I88d79ca31981a49736af571067831c703cf65d3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156755
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ifac298898f2d36bcbaffb111346d1e9fa71b2e1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156758
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I1a853bec38ce31d7961a150d4f3958c38c896559
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156756
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Icf7b6216180fe259cc9c529ea5c48720324c9262
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156759
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Also add tooltip for this option
Change-Id: Ie3725219da3b617f8fa6027de7ffac357cf5adeb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156593
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
|
|
Return false immediatly if there are no outline nodes in the document
since then there can be no folded outline content selected.
Adjust selection that includes the end of content node so that the
end of content node is not included in the selection. This fixes a
crash that occurs when outline folding is enabled and Master
document 'Text' is deleted by using the Navigator popup menu item
'Delete'.
Change-Id: I28be127566c3820b3e78834495bbb354cf2d01aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156631
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
The files are renamed, and the associated lines in Makefiles and
elsewhere are also changed.
Change-Id: Ieec38055690e03afd8982320ee0836904a3f41eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156670
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
the delegating class already implements the interface and forwards the
method calls
Change-Id: I8b0c74be87656675a887ddda2e7c44b63f165c2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156699
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+ void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
+
Change-Id: I324e0f8825f8b9e8619b1238624b4288720b08cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156719
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+ void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
+
Change-Id: I4313e8c25ab3fec4b96c7a0643c7acf9ba89785f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156717
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+ void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
+
Change-Id: I5ff6b1e166aff1ad67464785cf39d748f5dfc236
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156700
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Icf6a28f1270fc95a4edfc81a06fc79d5d2da17df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156720
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ifb793b9f1d1476617239b826705f8838bdc66303
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156714
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Again this is a change to improve understandabilty/changeability
of SfxItemSet code plus some cleanups. Still did a callgrind round
to check - it slightly got faster. In a start/load(complex SW doc)/
show/shutdown cycle compared with master I get 96.722 mio cycles
compared with 99.851 mio in master.
Main focus was to isolate two aspects: preparation and cleanup of
an Item for usage in an SfxItemSet. For that we now have
implCreateItemEntry: to do all needed actions to create/prepare
an Item for membership, including evtl. AddRef/Cloning/using
ItemPool stuff.
implCleanupItemEntry: to do all needed actios to correctly
clean that Item up again.
All formally accesses distributed over SfxItemSet (and other places)
are cleaned-up to use these. The Item-counter in DBG code that I
already added helped a lot to do this.
Also cleaned up PutImpl to 1st check if action is necessary (Item is
already in place) or not, reducing spot to cleanup an Item that
was handed over as bPassingOwnership to one place.
I also added a 2nd flag, bItemIsSetMember, that tells if the Item
given as input is already member of an SfxItemSet, in that case a
shortcut can be used (increase AddRef, use).
Adapted all places AFAP to use the new container interface
(begin(), end(), ...) where useful.
Made GetItemState inline and directly use the tooling method. Same
for InvalidateItem.
Added much more comments to describe what's going on or to hint at
problems (check for CAUTION).
Removed PutDirect - not needed anymore, probably was there to not get
recursive death loop with callbacks in SW.
More smaller changes.
Checked with all apps, played around. Still, stuff may come up, so
I put on gerrit the tests will show and give further hints. At last
SfxItemSet is a minefield :-)
Had to adapt SfxItemSet::implCreateItemEntry when input Item is
a StaticDefaultItem. SfxItemPool::PutImpl needs to be called in
that case.
Had to correct bItemIsSetMember in all cases if the transfer
of SfxPoolItems is between SfxItemSets with different
SfxItemPools. This is and will be necessary as long as the
Items are stored at the pool.
After a hard deep-dive I found the error: m_nCount was not in
all cases correct, invalid items get counted.
Win build *insists* for initialzation of local var aEntry in
SfxItemSet::PutImpl, triggers warning C4701:
"potentially uninitialized local variable 'aEntry' used". This
is not the case here, but I know of no way to silence the
warning in another way, so added an extra-call to begin().
Re-added to use static pool defaults directly, possible After
the fix 6d8c6e8d60956fd36094035a526c1a29a902204b, thanks for
that. This avoids some cloning of Items.
CAUTION: static default items are not *that* static as it seems
(or: should be). If they are freed with the Pool (see
::ReleaseDefaults) they will be deleted. If the target pool is
different from the source pool static default items from the
source pool can be used that then might be deleted (sigh).
A solution would be to change all pools to really work on
static instances of default items.
Another one would be to know here that the
targetPool != sourcePool, so maybe extend
bItemIsSetMember -> bSamePool.
A good test for this is CppunitTest_chart2_uichart/testTdf98690.
Until solving/cleaning up we unfortunately *have* to continue
to clone static default items...
Change-Id: Ibd8dc6d612f594a5ad88c75fcee8726d89a6090c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156306
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
Change-Id: Ie327885b238134092b4d3dd5f406941cf452239a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156707
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This is not generally a problem
Change-Id: If7957da45e5ad00f881ef3a7c5c676b09494ec77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156713
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If4d924b07875ffb8586e93eb84b4f01cd0c3ba34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156712
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia45385aa5f76390f17fbcb14f7872ba0a0d9e14f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156665
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
which means we need a few more cppu::queryInterface variants
Change-Id: I5cf7805ab9576919bfd66a3b239917e48a7f8f61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156701
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Revert partly tdf#151260 fix
Change-Id: I4c052e2cd1cb41dc8bda4b388b46e4416e351434
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156669
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Otherwise the title was just "Name"
Change-Id: I883d2468c7bd97782b0aef4165a6afe4ff39ce31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156659
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: I7a7574c3ffaa45aeb9bb97d9a1963c52d5619d99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156658
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
with the more standard comphelper::containerToSequence
Change-Id: I29a67e52e7c25c2d67b0cd617acc7068737bad5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156702
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Checked on jenkins using 'make check' and
+ void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
+
Change-Id: Iddfef9353c3a63547546e2db49083083d2dc74c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156695
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
to help track down an intermittent UITest failure on jenkins, which
would otherwise assert inside the UIObjectUnoObj constructor
Change-Id: I1b06c1eef5fe3402857b7a300decd48488ec621c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156698
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to ba616b2299e419762f2eca9ba5b55ed5a4f31c9f
- tdf#155875 UI cmds Writer/Table in Help(35)
+ refactoring
+ Table - AutoFormat Styles (part 35)
+ uno:AutoFormat refers to similar dialogs in Calc and Writer
+ but each on its module
+ merged in shared/01/AutoFormat.xhp with app switch
+ removed obsolete files (merged)
Change-Id: I9324c517f19934027311c297d012397650b60cf4
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156685
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 8daa94aa1ff1135d3d2552182c7f2d23cc21d6f2
- tdf#155875 UI cmds Writer/Table in Help(34)
+ refactoring
+ Table - Protection (part 34)
+ protection is called by "uno.Protect" in menus
+ in Calc: protect sheet dialog
+ in Writer: protect cell directly
+ merged in shared/01/Protect.xhp with app switch
+ removed obsolete files
Change-Id: Ieada8a774a14a19f79f58e22fd807bf5aacaf64b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156678
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 5f31e41620bb668c611701c87a9f2b1cbf3c93c9
- tdf#155875 UI cmds Writer/Table in Help(33)
+ refactoring
+ Table - split/merge table (part 33)
Change-Id: I86a47fc6b6941d7efd89e485e299271bea737826
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156677
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|