summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-05-31Add DocumentOpen and NewDocument to XApplicationOutgoing and emit suchTor Lillqvist
Change-Id: Ia2a0ade0af45f1ba99b0cfa860bd1986edcf272e
2018-05-31Emit DocumentChange events less eagerly (to Automation clients)Tor Lillqvist
They are supposed to be emitten when a new document is created, an existing document opened, or a document is made the active document. (Hopefully our SfxEventHintId::ActivateDoc matches the last one semantically.) Change-Id: Ic53285fc3d1b9a61ababf77f06477081cef20f27
2018-05-31Initialise mxMSF in all casesTor Lillqvist
Change-Id: Ib7fcdbe934b66971995574226f982a6865faab1b
2018-05-31Add informative commentTor Lillqvist
Change-Id: I428c2bbaa273d893fa5a3cc42bb7f3d060f375ad
2018-05-31Add ooo::vba::word::XDocuments::OpenNoRepairDialog()Tor Lillqvist
Just call Open() with the same parameters. (Most of which are cheerfully ignored.) Change-Id: Ia9b980bf870bac04fab7e23843d29f66d5859037
2018-05-31Fire the DocumentBeforeClose event (call the callback)Tor Lillqvist
Change-Id: I9c7a17aa9bdbbba29cd12a0e3d09c9047e9b5678
2018-05-31Add ooo::vba::word::XApplicationOutgoing::DocumentBeforeClose() callbackTor Lillqvist
Change-Id: Iccdb7bc262b8f85caf7efb4407a1f00ff0cfb4a8
2018-05-31We need to keep an ooo::vba::word::XDocument ref in the SwDocShell for...Tor Lillqvist
... Application callbacks that want to pass a such. DocumentBeforeClose() is one. (Not yet implemented.) Change-Id: I1e065d608a55e054fb41b0006a76c731915f3ebb
2018-05-31First attempt at passing arguments, also in and inout, to Automation callbacksTor Lillqvist
Change-Id: Iff629243888153250b655a5e942ced024e3338a7
2018-05-31A few SAL_INFO tweaksTor Lillqvist
Change-Id: I4a9c6341891bc80d8ab7648ed972d57739aa4f4a
2018-05-31First attempt at implementing CXTypeInfo::GetFuncDesc() and ReleaseFuncDesc()Tor Lillqvist
The returned information for the methods is fairly bogus, though. Not sure now (a few months after I wrote the code) whether this added functionality was actually needed, or whether I just added it for potential future need, and with the intent that it needs to be improved significantly then later if actually needed. Change-Id: Ifb132f494cdd7172b4b1d05cc26e2370ea595f41
2018-05-31ofz#8644 oss build brokenCaolán McNamara
Change-Id: I51daa79f3f2772d054b7ece248a37b9e5cca4960 Reviewed-on: https://gerrit.libreoffice.org/55121 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31Prepare to handle out (and inout) parameters to event callbacksTor Lillqvist
Change-Id: I47054c1df40d1058618b0fbd3fdb82fa93ca8836
2018-05-31Add Document.Close event generationTor Lillqvist
Use a similar idea as for the Application events. Use the SwDocShell to keep the XSinkCaller. Call the Close event from SwXTextDocument::close(). Change-Id: Ie873238c5a966fc859d45b59f424ae0e9f4fbfc7 Reviewed-on: https://gerrit.libreoffice.org/55110 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-31Add one more #define _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING 1Tor Lillqvist
Change-Id: I228ae626532b3ae6f632701e71d3da182c496612
2018-05-31drop last use of TransferableHelper::GetSystemClipboardCaolán McNamara
Change-Id: I405b0cac0db5f08aa2f9fb73927c4c21f0250988 Reviewed-on: https://gerrit.libreoffice.org/55076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31tdf#117864 TransferableHelper::GetSystemClipboard requires a focus windowCaolán McNamara
Change-Id: Ibd9b9218cf12e80db1fc9a70bdbab38d3df950f7 Reviewed-on: https://gerrit.libreoffice.org/55073 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31RTL support for custom widgetsCaolán McNamara
Change-Id: I34038f047c002a1ec1276f8c523db0e1c4d29065 Reviewed-on: https://gerrit.libreoffice.org/55100 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31SwModule is a convenient (?) place for passing events to Automation clientsTor Lillqvist
Generate Application.DocumentChange and Application.Quit events. SfxHintId::DocChanged seems to correspond nicely enough to Application.DocumentChange. It is generated a bit eagerly, but as its documentation is fairly vague and no specific detailed information is passed in parameters anyway, it probably doesn't hurt if a client gets it a bit more often with LO than with some other product. Can now remove the FIXME-marked Quit event things in SwVbaApplication. Now need oovbaapi in many makefiles for them to compile. Change-Id: I4d0c5b93b584f198bcc854002eec7aaba7909ecc Reviewed-on: https://gerrit.libreoffice.org/55106 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-31libnumbertext: update to 1.0 beta 3László Németh
– new Bulgarian and Icelandic language support – fixes of language data based on libreoffice-l10n's patches and feedback (see ChangeLog in the external package for details) Change-Id: I98598747c8b4e8e7fba380998c6ebbc1f63fef2e Reviewed-on: https://gerrit.libreoffice.org/54936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-05-31move some CanvasHelper::implDrawBitmap inside vclNoel Grandin
part of making mask and alpha internal details of Bitmap/BitmapEx Change-Id: I87ca24af18a29f5eb8a5761c5d95ae2806d97e77 Reviewed-on: https://gerrit.libreoffice.org/55078 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-31Remove leftover hardcoded check for SwVbaApplicationTor Lillqvist
Instead, be generic, check whether the objects implements ooo::vba::XConnectable. That's what we do in the IID_IConnectionPointContainer case, too. Change-Id: Ib499aa011775f79a2accaef64e19738bdb7ed143 Reviewed-on: https://gerrit.libreoffice.org/55109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-31Add ooo.vba.word.XDocumentOutgoingTor Lillqvist
Change-Id: I0243ee3e492d8445ebcc059293dcc4cb3c5c889b Reviewed-on: https://gerrit.libreoffice.org/55105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-31Bin leftover misleading commentTor Lillqvist
Change-Id: I594258303469a1f5b9490b824fdc304a5a780784
2018-05-31Updated coreOlivier Hallot
Project: help fc875c6ab3763e36008fd872b3670d953f18ba9d Fix default cases in switches Change-Id: I40f6c8e5a6fd0a0ff1d3e6205de449f14598212b Reviewed-on: https://gerrit.libreoffice.org/55107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-31Updated coreOlivier Hallot
Project: help a0b4db5f17e58f656d527b807e09ed02b04c2827 tdf#58134 Some Options settings cannot be reset Add warnings in help pages when some options cannot be reset. This patch does not close the bug, which in some cases is a bug in the dialog controller. Change-Id: Ie6d0019a9c6611c2ad8784f593ceefa5748bf56b Reviewed-on: https://gerrit.libreoffice.org/55103 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-31We want just one SwVbaGlobals and SwVbaApplication for all Automation clientsTor Lillqvist
I think. Anyway, if it turns out we do want one per client, easy to revert this. (And it isn't very common to have several Automation clients connected at the same time anyway, surely.) There will still additionally be one SwVbaGlobals (and SwVbaApplication) per open document with a StarBasic interpreter, though. I think. Change-Id: I5f7dbfd65b5decb152c1192298bc85dcf6027d64 Reviewed-on: https://gerrit.libreoffice.org/55094 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-30Work in progress related to invoking events in Automation clientsTor Lillqvist
XConnectable interfaces need a second IID, for the interface "itself", not the coclass. (I am sure there is some catchy short term for that, I just can't find it right now.) Allow several simultaneous sinks for a SwVbaApplication. Not sure in what case such would be needed, but you never know about 3rd-party client code, and it's trivial to handle anyway, so why not. Lots of FIXMEs still. There is likely also a lot of leaks. But at least an event handler in a simple VBScript script does get invoked. Note that the changed and added code in extensions/source/ole is totally unaware of what outgoing ("event") interfaces Writer or Calc implements, it is all handled generically through the UNO interfaces I added recently. One particular thing that needs doing is to actually make Writer (and Calc) raise this kind of events when necessary. The current code to invoke events handlers in StarBasic (including StarBasic code running in "VBA" compaibility) is very much tied to having StarBasic running (not surprisingly), which of course is not at all the case when it is an Automation client that is manipulating a Writer or Calc instance and wants events. There is demonstration-only code in SwVbaApplication::Documents() to raise the "Quit" event. (I would have put that in the SwVbaApplication destructor but that doesn't seem to get called.) That should of course go away once we invoke other relevant events in appropriate places. And the "Quit" event needs to be invoked when the application is quitting. The whole callback mechanism with IConnectionPoint etc is still partly a mystery to me. It is entirely possible that even if this now works for a simple VBScript client, it won't work for (for instance) a VB6 client that might exercise the APIs of the COM interfaces we provide in a different way. Add XSinkCaller, for something that perhaps calls one or several XSinks. Change-Id: Ica03344010e374542f4aceff5ec032c78579f937 Reviewed-on: https://gerrit.libreoffice.org/55093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-30dont use GetMask in GeoTexSvxBitmapExNoel Grandin
part of the process of making Bitmap's internals be private to vcl Change-Id: I3784c14be1572d4df64b9cbdb5adcebdd1b274fd Reviewed-on: https://gerrit.libreoffice.org/55050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-05-30fix "vcl: move Bitmap::MakeMonochrome() to BitmapMonochromeFilter"Noel Grandin
commit 1f6af5c409105562edf2a034f4841c1aeb5a38b5 "vcl: move Bitmap::MakeMonochrome() to BitmapMonochromeFilter" seems to have dropped a line of code which means the filtering doesn't actually have an effect. Change-Id: If46c15bd9ab9d4e3911bdb9baf3091889b1f634d Reviewed-on: https://gerrit.libreoffice.org/55071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-05-30tdf#117859 crash in Tab Color a11yCaolán McNamara
Change-Id: I935f0b1a28b483fad70caf7af96742dee74916ad Reviewed-on: https://gerrit.libreoffice.org/55087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-30sw HTML filter: handle embedded ODF content in xhtml/reqif modeMiklos Vajna
Embedded native data (what we don't parse just carry on) and real OLE2 embedding already worked, this adds the case where the actual content is ODF, just inside OLE2. The DOC import/export had support for handleing ODF content inside OLE2, so reuse that code: add new functions to SvxMSDffManager for import purposes and reuse SvxMSExportOLEObjects for export purposes. Change-Id: I0acf65d4bf29af896b8f1dd625e8672050aae350 Reviewed-on: https://gerrit.libreoffice.org/55088 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-30mariadb-connector-c: fix Windows buildMiklos Vajna
--enable-ext-mariadb-connector is not the default, this fixes the build after using that switch up to the mariadb-connector-c module. mysql-connector-cpp is still broken, VS 2015 gives internal compiler error there for the used boost pieces... Change-Id: I1845cde03d5166594aac67c23e61186920ab3785 Reviewed-on: https://gerrit.libreoffice.org/55055 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-30Add a (dummy) ooo::vba::word::XApplication::ShowMe() implementationTor Lillqvist
Some customer VB6 code calls it. It doesn't seem to do anything interesting in Word either, so I don't feel that bad for it not doing anything in Writer. Change-Id: I81162fcdd0caa22b19760f8cb40266f7f571d8ce Reviewed-on: https://gerrit.libreoffice.org/55069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-30Implement InterfaceOleWrapper::GetTypeInfoCount()Tor Lillqvist
It is just supposed to return 1, after all. And we do try to implement the GetTypeInfo(). (Sure, the testing I am doing that turned out to require GetTypeInfo() to work then immediately after this runs into much harder problems to solve, but that is another issue.) Change-Id: If7e0707d7b404d6a46b24e642c2146b3bfff03f0 Reviewed-on: https://gerrit.libreoffice.org/55070 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-30tdf#111988 Bump OSX version in READMEXisco Fauli
Change-Id: I41a5be165af21c197c4f9d4f40f0ff27c80a7168 Reviewed-on: https://gerrit.libreoffice.org/55061 Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-30Add Caption property to ooo::vba::XApplicationBaseTor Lillqvist
Implementation is just a dummy, though. At first I thought that it would work to get the XModel of the "current" document (as returned by getCurrentDocument()), and then get the XFrame of that, and then use the XFrame's getName() and setName(). But, it seems that getCurrentDocument() and what it calls is tightly coupled to StarBasic, and it doesn't do anything sane in the case of Automation clients. Change-Id: I74ded5114ecce06e72862f69d0c06d963e55fd75 Reviewed-on: https://gerrit.libreoffice.org/55064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-30tdf#112034 , tdf#107266 label color on basis of persona and personaKshitij Pathania
flipping is fixed. Labelcolor not gets updated immediately but when statechanged function triggers via executemethod things workwell.(like it triggers on changing mode of notebookbar) Change-Id: I755fb4ff434d7971112d2f0beb44ca09f4a7e0f1 Reviewed-on: https://gerrit.libreoffice.org/54301 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2018-05-30Add unit test for tdf#117819Eike Rathke
Change-Id: Ice57b81106d35f5b217f0680824d1acf62ff9098
2018-05-30Remove two unnecessary forward declarationsTor Lillqvist
Change-Id: I5bf56b6216835870b4beefd588f070a127835514 Reviewed-on: https://gerrit.libreoffice.org/55068 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-30sd: allow ruler to respond to switching active cell faster.Mark Hung
Change-Id: I8647c6e820b4bac795e87d538eba822fac7ddbe7 Reviewed-on: https://gerrit.libreoffice.org/54644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-05-30tdf#104376 Adjust SvxLRSpaceItem with right distance to border.Mark Hung
Like what has been done with left distance to border, so that the ruler handle reflects the setting. Change-Id: I4ed920280aafc537ba3068f0f666778c2d723b6b Reviewed-on: https://gerrit.libreoffice.org/54618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-05-30tdf#104376 activate existing protect item for the ruler.Mark Hung
SvxProtectItems were used to protect size and position of the rulers in Impress/Draw but weren't really activated because they were missing in the sdi of the view shell. See also: DrawViewShell::GetRulerState() in drviews3.cxx. Change-Id: I576932fb45acd996a3b6f3045dcbc131b7316ece Reviewed-on: https://gerrit.libreoffice.org/54616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-05-30tdf#104376 fix positions of the ruler handles for tables.Mark Hung
Use the cell boundary to decide correct SvxLRSpaceItem values. Change-Id: I1906eaf34a7ff5f852b729114371ddb5387692d3 Reviewed-on: https://gerrit.libreoffice.org/54615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-05-30svx/sw: set ruby position correctly in the ruby dialog.Mark Hung
Change-Id: I7ddce601bd7204e5696b601c6f8cd16619017aa2 Reviewed-on: https://gerrit.libreoffice.org/54881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-05-30sc: Insert a space for consistencyTakeshi Abe
Change-Id: Ifb1429eb3ad6d1093a7b5126ea3d15c4509cf8cc Reviewed-on: https://gerrit.libreoffice.org/54981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-30Log error codeStephan Bergmann
Change-Id: I6550af7949e4838d9f23310fe5ab49fb6b466eaf Reviewed-on: https://gerrit.libreoffice.org/55053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-30Fix typos in SAL_WARNs: The class is called CXTypeInfo, not CxTypeInfoTor Lillqvist
Change-Id: Iab17340f57cf8b116d2f058661dabd3a95fb61d2
2018-05-30Add CLSID for Writer.Application and LocalServer32 for thatTor Lillqvist
For Automation clients. Provided in extensions/source/ole/servprov.cxx for an instance of ooo.vba.word.Application. Change-Id: I277f461bf6206f3516b14fabe8b27dc4c06018b5 Reviewed-on: https://gerrit.libreoffice.org/55052 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-30Fix conditionSamuel Mehrbrodt
Change-Id: I977eae208bd12886d25679d4c75308d51245766a Reviewed-on: https://gerrit.libreoffice.org/55057 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>