summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 609, 637 Change-Id: I4376e86a5484886025152a9a407b23b3d05c3911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175355 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 734, 739 V1037 Two or more case-branches perform the same actions. Check lines: 1031, 1054 Change-Id: I835ac504eadcbdd44b2ee507f40e6f40ff5e416d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175318 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 778, 793 Change-Id: I2437bbac1bc952720d4ea3c43107c9d5e1ef1655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175308 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 764, 767 Change-Id: Ia8da107d28249132b92e7cf533505b09c0037188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175310 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 574, 577 V1037 Two or more case-branches perform the same actions. Check lines: 738, 752, 759 V1037 Two or more case-branches perform the same actions. Check lines: 1949, 1953 Change-Id: I2a6b6cc16ff58d432e5a7b14a6a1d7fa4f1a15b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175313 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 767, 777 Change-Id: Ie9a6d6376f5037ee075c95e62c2c7970b720e9a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175309 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-04pdf: move encryption methods into PDFEncryptor filesTomaž Vajngerl
Moving more PDF encryption implementation into common encryption files. This will make it easier to add new encryption later on as the code will be in one place. Change-Id: Id40c2f876a2e92bb8db27024a0e251befc5059e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176030 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04pdf: move EncHashTransporter into own filesTomaž Vajngerl
Also rename to EncryptionHashTransporter. Change-Id: I20f984af4428e1182c77dbce4343d69c106063a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176029 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04pdf: move some encryption code into PDFEncryptor classTomaž Vajngerl
Refactored the code to make encryption easier to change. Change-Id: I24b831781d4acd6329838dbf2468e9df6efad41e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176028 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04move CryptTools from oox to comphelper so we can reuse itTomaž Vajngerl
Also move the relevant tests and clean-up the names a bit to make it mroe consistent. Change-Id: I929ef9c13b954fd6a506471231d1bc41e4ef9980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176027 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04pdf: Don't emit metadata for /Info, allow XMP for PDF >= 1.4Tomaž Vajngerl
Metadata written to /Info dictionary is deprecated in PDF 2.0 with the exception of /CreateDate and /ModDate, so don't write it if we are writing to PDF 2.0. Instead of this allow to write the XMP metadata all the way back to PDF 1.4 (when it was added to the specs). Change-Id: I33e29d7d52e96d34e973032d7d8b42d876282dcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176026 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-11-04pdf: add m_nPDFA_Version to simplify PDF/A versionsTomaž Vajngerl
We have a bool for each PDFA version, which is inflexible when checking if the feature is supported in a range of versions so this adds a version number which simplifies checks a bit. Change-Id: If162e305766baa61278872297c9ab1eb41cb57d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176025 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-11-04pdf: move encrypt code into emitEncrypt, add PDFStructureWriterTomaž Vajngerl
Move the encryption code into emitEncrypt and rewrite that with the newly introduced PDFStructureWriter, which is now responsible to write the PDF basic structure elements into a string buffer. The PDFStructureWriter will be extended with new features when there is demand. Change-Id: I4f4099886860b72b4f1866b19a8afb7cc8fb4ea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176024 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04pdf: initial PDF 2.0 and PDF/A-4 supportTomaž Vajngerl
Added PDF 2.0 and PDF/A-4 version to enums. Write the PDF 2.0 support for the file headers. Add the identical considitons as for the PDF/A-4 as they were for PDF/A-3. Change-Id: Iccf5afbf09c4cd0cd1ae7122c860e8cbefe3a6fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176023 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-11-04CryptTools: simplify the define conditions a bitTomaž Vajngerl
Change-Id: I6ef207eae6fbeec2ba77fa46a3274e43d02fe1e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176022 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04pdf: PDF dialog set the default member var. values in header fileTomaž Vajngerl
Just a simplification and clean-up as this is easier to read. Change-Id: I8a920849d2bac7ae89d0d7b5f90421a7fac3a0c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176021 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-11-04comphelper: move tostring to hash.hxx so it can be reusedTomaž Vajngerl
tostring to convert a vector of bytes into a hex string is useful in other tests and implementation, so move it into common hash.hxx Change-Id: Iebc71919c6209222eb01b78c307420afddc8caca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176020 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04Add experimental support for Emscripten JSPIStephan Bergmann
...which I've seen fundamentally working when building with recent emsdk against recent Qt6 trunk (and including <https://github.com/qt/qtbase/pull/108> "Update the check for WebAssembly JSPI support") and running on recent Chrome (with JSPI enabled under <chrome://flags/>) Change-Id: I98c11c5ee7e95b135ddc33c95c95752055ecd4c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176031 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-11-04tdf#147906: Use hypot in place of sqrt to avoid overflowSakura286
Change-Id: I575bc0c1b6e49ad8dc5db6b3e523ca7e0860aad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175537 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-11-04Remove commented out includesIlmari Lauhakangas
Change-Id: I7aed7953f8d101f145a4267168c90623022677f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176012 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-04Resolves tdf#160626 - Preserve sorting in SvxStyleToolBoxControlHeiko Tietze
Inserts now up to 12 default styles and adds only user styles that are not among the default Change-Id: I60ea3e46092681a932cf3fe470c2ce9fb3553917 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176011 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-11-04reduce OUString ref-counting in writerfilterNoel Grandin
Change-Id: I4a757bf3fec10722524b656b07f189629100ea74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176009 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-04Resolves tdf#163689 - Long comments must not enlarge properties dialogHeiko Tietze
Change-Id: Ic4433b8c7f27790ea070ba66ef72ab531d9670d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176008 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-11-04tdf#163736 - sc: fix searchmode cached values for lookup functionsBalazs Varga
Check the search mode option in cache for lookup functions, because different search modes can produce different results. Change-Id: I6127a644dc4eae6fad909a6bc83bde2c66e85201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175972 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-11-04Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 76fd6af8937397407aca836ce2ffcf8d08219e07 - Typos Change-Id: I18a9e94a27f6e19c26c9076b9bd6be307717169b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175987 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-11-04svx: prefix members of E3dCubeObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: I0e1dcb44cd46fdf40ae21c264017c8fc9ca96b53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175980 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-11-04check stream stateCaolán McNamara
Change-Id: Ic79b14565e4c84cfeb8ce87994ed45fcb45df4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176005 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-04android-viewer translated using WeblateWeblate
Hebrew currently translated at 100.0% (116 of 116 strings) Change-Id: I5a39070be19791e0f85ee32487bcca8a1876a9b8 android-viewer translated using Weblate Interlingua currently translated at 75.8% (88 of 116 strings) Change-Id: Iea0eb23bf7d58d78fd99668a8b057f3d9295a3fc Added translation for android-viewer using Weblate (Tagalog) Change-Id: I2f97dbf569d5eda71dfdd2a62c5563bd7918d43b Co-authored-by: Andy Flagg <libreoffice.tagalog@gmail.com> Co-authored-by: Weblate <noreply@documentfoundation.org> Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com> Co-authored-by: famese <hmcb2080@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/he/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175682 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-04delete useless parts of GalleryCodec::ReadCaolán McNamara
no point reading this to just to discard it later the only places reading this are just opening, using and close the streams afterwards, so the need to even skip over this data doesn't seem to arise. Change-Id: Ieb2498f458534770c167bbbfb3a4792162238986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-04tdf#143148 use pragma once instead of include guardsRosh
Change-Id: I44df7baf1d5bfdd45647c5b2ed99958d587ff61e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176002 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-04cui: Fix a UI string in a11y check optionsMing Hua
Commit d14e79bf7680db2180e40ba52fc3305a84c586f6 (Correct grammar in strings for A11y, 2024-09-18) fixed many UI strings in the newly introduced a11y check options with correct English grammar, but mistakely changed this string from "heading order" (which means the chapter and section headings) to "table heading order". This commit reverts the change and slightly improved the wording. Change-Id: I2957004d6b82d35841f57a76ca25fbf9b851b9b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175918 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-04Simplify a bitMike Kaganski
Change-Id: If30cac2426fe6de498066dbe9ec8465450d7ce0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176001 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-04feat(json): Allow serializing anySkyler Grey
Previously, as far as I can tell, there was no way to send a Size in a .uno command (as would be needed in, say, '.uno:InsertAVMedia'). We do, however, already have a way to send an `[]any`, and we can use a similar method to allow sending arbitrary types with `any` rather than `[]any`. To use this, the type you really want to send has to be wrapped in any, so for example... { type: "any", value: { type: "com.sun.star.awt.Size", value: { Width: { type: "long", value: 0, }, Height: { type: "long", value: 0, } } } } Change-Id: Ic33594dee955d475d81733adb21950c0458435e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174740 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit cccbf8608f3b76651993bc8576c672367c228fa2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175982 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-04feat(lok): Add extra impress export formatsSkyler Grey
Previously we had the ability to export to various formats, but these weren't exposed in a way that LOK could request them. We want to increase the options available for export, so we need to make these available. Change-Id: I1c05aeec8de32929481059bcfd02cac05a46788d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174602 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 541272d3eaa322ccdd1b926add031a39faeccf49) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175981 Tested-by: Jenkins
2024-11-04Drop requirement that there is internal/shared autotext.Caolán McNamara
A user's autotext was not examined unless there existed some internal/shared autotext. There seems to be no particular reason for that, except that internal/shared autotext happens to generally be available. Change-Id: I43a9fe5916d3a0895b175db52758104cc7fd65b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-04merge creating variable and assigning itCaolán McNamara
Change-Id: I1c8533f5adf5ab1db88dc279fc8e9a21c38c66bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175976 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-04cid#1606943 Overflowed constantCaolán McNamara
Change-Id: I056e45e19bb3794acbdf7b5c2b4ecb787e52de0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-04cid#1606699 silence Overflowed constantCaolán McNamara
Change-Id: Ib3cac90e56bd00a777871f1b07849fabd7e307a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-04cid#1607290 silence Overflowed constantCaolán McNamara
Change-Id: Ic05b5a64a3be44d8aba4c9ffaf8867a45f2422db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175973 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-04new loplugin:staticconstexprNoel Grandin
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 883, 893 Change-Id: Ie722bffb7aa8cbdb38a5b1a244f5c5a072c26c8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 815, 819 Change-Id: I86c8065de5bb83671bcc499bb46b5e5723ec01d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-04Simplify a bitMike Kaganski
Change-Id: I5c6110cc26e8fb20066374dc235677f07e79ce1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175977 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-03tdf#163486: PVS: pointer not released in destructorXisco Fauli
Since commit 7ef3b46fd5bdfb3a87e9b0a840287fdb6ff4734b Author: Gergő Mocsi <gmocsi91@gmail.com> Date: Thu Mar 7 11:57:04 2013 +0100 fdo#35546, implementing 'Create Photo Album' function V773 The 'm_pGraphicFilter' pointer was not released in destructor. A memory leak is possible. Change-Id: Iee1c4f4f3ae5232506563a219ffdec61f74fcff0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175884 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-03tdf#145538: Use range based for loopsMelvinYG
Change-Id: I1865d2fab8d29bfbc81b10a9497b47c5c94f1af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175186 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-11-03Related: tdf#163730 Avoid potential deadlockMike Kaganski
Similar to commit 43e5118496ae0c9b8f81a54574874eda7d439dbb (Related: tdf#163730 Avoid deadlock, 2024-11-03). I haven't seen this scenario myself, but seems likely to be possible. Change-Id: Ie6bb69e7ebe12a69e4dabee9103de32611235807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175971 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-03Updated getPackageName2PathMapBarry-Thomas-Paul: Moss
Update getPackageName2PathMap to use ExtensionManager Change-Id: I22c00aeb27913f138da00d304b9f238787459d28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174877 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-03tdf#163486: PVS: parameter is always rewrittenXisco Fauli
Since commit a9a665ed7a3198f4c0f6e521520491353ccfb182 Author: Szymon Kłos <szymon.klos@collabora.com> Date: Tue Jan 5 14:54:52 2021 +0100 pivot table: make partial sum message box async V763 Parameter 'pSrcErrorId' is always rewritten in function body before being used. Change-Id: I51c2d1b0d01563d66e828d3ebfaf61f620992443 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175876 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-03tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 82, 118 Change-Id: Iae91b2079c1c1d5aeb3000495364f3995266cbe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175274 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-03tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 8172, 8405, 8484 Change-Id: I85ff9c6258fc855323c1ee814b981b3453db7651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175275 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins