summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-17MM change listener from friend to a nested classJan-Marek Glogowski
Change-Id: I245a27e02816d3c96ca7777059b99c42cb64cca5
2017-01-17add COMPLEX, CONVERT testcaseZdeněk Crhonek
Change-Id: I02b997cef3cce5641b1340125c791f38c89bf7b5 Reviewed-on: https://gerrit.libreoffice.org/33084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-17add INTRATE testcaseZdeněk Crhonek
Change-Id: Ief8656c197745caf6ee2c8cc2a4c5af04d948e21 Reviewed-on: https://gerrit.libreoffice.org/33083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-17LOK: Calc: notes: on edit mode starts/ends: missing tiles invalidationMarco Cecchetti
On edit mode starts/ends, when a note is hidden, tiles, only the note tail belongs to, are not invalidated. Change-Id: I69487f428a121fc05da99d3b06786afd4f834766 Reviewed-on: https://gerrit.libreoffice.org/30101 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-01-17LOK: Calc: show/hide a note does not perform any tile invalidationMarco Cecchetti
Change-Id: Ia904b6bbe82c395299b269ddbde523d19bf486bc Reviewed-on: https://gerrit.libreoffice.org/30099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-01-17manage m_xInplaceMenuBar with rtl::ReferenceNoel Grandin
instead of both a raw pointer and an uno::Reference Change-Id: I44111694671371fac5c4207d1c46f99761bf10eb
2017-01-17manage m_xToolbarManager with rtl::ReferenceNoel Grandin
instead of both a raw pointer and an uno::Reference Change-Id: Idcdbbcd4f01c21bd32b4f00d3cfc3febd70e9194
2017-01-17use rtl::Reference in RequestFilterSelect_ImplNoel Grandin
instead of raw pointers Change-Id: I86e929d71afc1ce9852d2b01339f7623cc119fcb
2017-01-17manage SvRefBase subclass with tools::SvRefNoel Grandin
Change-Id: Ieb164a8113c7033e72feece8421dd4ef68961f7a
2017-01-17use rtl::Reference in DocPasswordRequest and SimplePasswordRequestNoel Grandin
Change-Id: If1bad2bc852712b8315e44480ee81f797736bb95
2017-01-17use SolarMutexGuardNoel Grandin
instead of manual acquire/release Change-Id: Ieb0a2c269b46004a80f77c51ce947b0daf015644
2017-01-17use rtl::Reference in ScDPDimensions/ScDPHierarchies/ScDPLevelsNoel Grandin
instead of manual acquire/release Change-Id: Id0dfa1c42e12a680ed6a6144b73d03c8f45e9f3d
2017-01-17use rtl::Reference to manage ScAccessiblePageHeaderArea'sNoel Grandin
instead of manual acquire/release Change-Id: I368530f30388cd4bba6dbc1fe6d6a5dd1e25f298
2017-01-17manage SvxPropertySetInfoPool.mpInfos with rtl::ReferenceNoel Grandin
instead of with manual acquire() Change-Id: I9fac619730df6a070c5f0d887ecf9249bd7d65a6
2017-01-17tdf#105014: Disable related buttons when there is no menu to editMuhammet Kara
Clicking the "Add Separator" or the "Add Submenu" button, when there is no menu edit, causes LibreOffice to crash. So disable them properly. Change-Id: Ibf685145a87c9e4343d83e1bb5ef6f08136c8f31 Reviewed-on: https://gerrit.libreoffice.org/32987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-17tdf#104150 DOCX import: handle <w:displayBackgroundShape/>Miklos Vajna
Regression from commit 992da0d5cf04497bad55637f6a6ebfcdaec03e16 (bnc#817956 DOCX import of document background color, 2013-05-27), <w:background> should be ignored when <w:displayBackgroundShape/> is missing from settings.xml, it turns out. This also requires generating the ooxml:CT_Settings_displayBackgroundShape token from the RTF tokenizer. Change-Id: I6d7986904cedb952998a87e7648919ae34adc360 Reviewed-on: https://gerrit.libreoffice.org/33207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-17uitest: check the different layoutsXisco Fauli
Change-Id: I08f69742569a0129d505726632f8b88eaebed953 Reviewed-on: https://gerrit.libreoffice.org/33195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-01-17Fix typo in comments: Not that -> Note thatTakeshi Abe
Change-Id: I1c143f1f8b9cdbdb11055907f55a93e4bbadd7e9
2017-01-17Resolves: tdf#103063 don't crash on importing this fileCaolán McNamara
doesn't go on to successfully open the docx, but it doesn't crash Change-Id: Ie37c115f81908695142849bd366583a5692ea806
2017-01-17starmath: Rely on the default ctors for SmRectTakeshi Abe
No need to define its copy ctor manually nor to use placement new for assignment operator. Change-Id: I679a19c1d1a87072d818cdfa4a9347edb6f4cea1 Reviewed-on: https://gerrit.libreoffice.org/33202 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-17new loplugin: useuniqueptr: forms..frameworkNoel Grandin
Change-Id: I4300a13f455148b7156ac3f444c7102d63ae6db3 Reviewed-on: https://gerrit.libreoffice.org/33164 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17cid#1398822: java.util.Properties.getProperty already returns StringStephan Bergmann
Change-Id: I056bffbdd0e3280bfbcfbb82aff73fb5bab8a0b7
2017-01-17fix bug in SfxItemSet::ClearItemNoel Grandin
resulting from commit 2757ee9fe610e253e4ccc37423fa420004d0f388 used std::map in SfxItemSet where I failed to notice that the nWhich parameter was being re-used as a loop variable. This bug was spotted by Jochen Nitschke Change-Id: Ifb43dfb84261ecbcf88e5b312b8ec24cf7c3dce9
2017-01-17tdf#105170: Ignore diacritics on precomposed charsKhaled Hosny
When ignoring diacritics, the old code just ignore combining marks which works when using decomposed forms (NFD) but does not work for precomposed forms (NFC). Instead, we now decompose, strip marks, then recompose, and use a nice icu::Transliterator that does the hard work for us. As a bonus, we should now handle surrogate pairs fine (most of the time). The new code (in ignoreDiacritics_CTL::folding()) might not be as efficient as the old code that used transliteration_Ignore::folding(), but it is less ugly and more easier to resonate with, or so I hope. Change-Id: If48c8be30527580cdd68f20b40a6533c5f258d83 Reviewed-on: https://gerrit.libreoffice.org/32826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-01-17tdf#104349, tdf#104668 MS Word compatibility trailing blanks optionVitaliy Anderson
The commits: 1c1747ac13a9d895df0fcba2fbb1bd266dccd74b and 4a410dd147f7160c1d62e3e0b67388a178d5136c make trailing spaces and their highlighting compatible with the Ms Word. The option is enabled by default for imported MS Word formats: .doc, .docx, .rtf For the ODF files the option is disabled by default Also it allows saving and loading the option state to the ODF UserData. It may be manually set in Tools->Options->LibreOffice Writer->Compatibility Change-Id: I5a86359c52d18e50bbb54b9f37c79b672591c369 Reviewed-on: https://gerrit.libreoffice.org/33046 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-01-17new loplugin: useuniqueptr: sfx2Noel Grandin
Change-Id: I544c615105d14fa258fed7f30790d305e987f523 Reviewed-on: https://gerrit.libreoffice.org/33206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17new loplugin: useuniqueptr: sdextNoel Grandin
Change-Id: Iae1dfc7f566d2f5bd1652f170218b502b5663126 Reviewed-on: https://gerrit.libreoffice.org/33205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17Set exception messageStephan Bergmann
Change-Id: I79ac4500817b31988096627056434771b5b38a59
2017-01-17tdf#105212: BASIC sets Delimiter prop to integer valueStephan Bergmann
LO's BASIC doesn't have first-class support for the UNO CHAR type, often uses integer values to represent such CHAR values (cf. <https://wiki.openoffice.org/ wiki/Documentation/DevGuide/ProUNO/Basic/Mapping_of_Simple_Types>). Since 0b07406f7147b9abbb2095d9e038b13293cb8b10 "Use C++11 char16_t for sal_Unicode" (for non-Windows, since LO 5.1) resp. e16fa715c43dcdf836ce8c400b6d54eae87b627d "Handle wchar_t as native C++11 type on windows" (for Windows, since LO 5.2), C++ css::uno::Any >>=, <<=, etc. with a sal_Unicode argument no longer silently treat the argument as sal_uInt16 instead. That means that BASIC code putting an integer value into a UNO ANY that shall hold a value of CHAR type may no longer work. (Arguably, such code only ever happened to work by coincidence. For example, if the ANY were processed by Java instead of C++ code, it would never have worked.) Luckily, the use of CHAR in the UNO API is rare (for a good reason, as a single UTF-16 code unit is hardly ever the right choice to represent "a character"). The only documented place I could find using a CHAR property is Delimiter in the css.text.TextSortDescriptor and css.text.TextSortDescriptor2 services. And the only processing of such a property that I could find across the LO code base is in the file modified here, which thus just takes a one-off special effort to take care of this problem. The direction from C++ to BASIC is left as-is. The value of the Delimiter property is now reported as a CHAR value (where in the past it was---arguably erroneously---reported as an UNSIGNED SHORT value), and BASIC is generally capable of handling such CHAR values it receives well. For example, in the BASIC code attached to tdf#105212, > MsgBox("Sort: " + SortDesc(1).Name + " = " + SortDesc(1).Value) SortDesc(1).Value will now print a (space) character instead of its numeric value (32). Also, any other uses of individual CHAR values in the UNO API apart from properties appear to already be handled well enough by BASIC, as the sample code > Sub Main > tk = createunoservice("com.sun.star.awt.Toolkit") > dev = tk.createScreenCompatibleDevice(100, 100) > descs = dev.getFontDescriptors() > msgbox("Font """ + descs(1).Name + """") > font = dev.getFont(descs(1)) > n = font.getCharWidth(97) ' 'a' > msgbox("Width 'a' = " + n) > met = font.getFontMetric() > msgbox("FirstChar = '" + met.FirstChar + "', LastChar = '" + met.LastChar + "'") > met.LastChar = 122 ' 'z' > msgbox("New LastChar = '" + met.LastChar + "'") > > trans = createunoservice("com.sun.star.i18n.Transliteration") > c1 = trans.transliterateChar2Char(97) ' 'a' > c2 = trans.transliterateChar2Char(c1) > msgbox("Transliterate, '" + c1 + "' '" + c2 + "'") > End Sub demonstrates. Change-Id: I2aec1ce374c024bfac61f6c832241dfeb561addc
2017-01-17coverity#1398817 Unintended sign extensionCaolán McNamara
and coverity#1398818 Unintended sign extension Change-Id: Id8eaffa6e19dd36dc59d7d63fabb398aefdcf433
2017-01-17coverity#1398821 Uncaught exceptionCaolán McNamara
and coverity#1398820 Uncaught exception coverity#1398819 Uncaught exception Change-Id: I68bba7043426ef5bd4146127fa115b31d03b8797
2017-01-17use rtl::Reference in AccessibleGridControlAccessNoel Grandin
instead of storing both raw pointers and uno::Reference Change-Id: Ie2306b619bec81707c5cff4debb8c7462ac2f9a1
2017-01-17use rtl::Reference in AccessibleBrowseBoxAccessNoel Grandin
instead of storing a raw pointer and a uno::Reference Change-Id: I4326cbda900e053599f1e753cb1bff122bdecc44
2017-01-17use rtl::Reference in LngSvcMgrNoel Grandin
instead of storing both raw pointers and uno::Reference Change-Id: Ie403e1e7a081bc3f91fd25be89c54ddc1d1cadd2
2017-01-17use rtl::Reference in SpellCacheNoel Grandin
instead of storing both a raw pointer and a uno::Reference Change-Id: I8764bf6b7d7745dd14f6c7548e771131354b1f23
2017-01-17use rtl::Reference in SvXMLExportNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I83774937d3556b9fed550a7f3e757dc975b4098a
2017-01-17use rtl::Reference in DropTargetNoel Grandin
instead of storing both a raw pointer and a uno::Reference Change-Id: Ia03e68ce7c0bec4b6e43e9ab32d8a918ea467f5b
2017-01-17Revert "distro-configs: disable firebird on linux_clang_dbgutil_64"Stephan Bergmann
This reverts commit 686887e2cb71e4ffc1e16179b06adf938a9dc7f9, now that <https://gerrit.libreoffice.org/#/c/33186/> "external/firebird: Backport fix for CORE-5452 causing spurious SEGV" should fix the instability. Change-Id: I9483c04de36d83233485f1280c3cada84767d696 Reviewed-on: https://gerrit.libreoffice.org/33189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-17external/firebird: Backport fix for CORE-5452 causing spurious SEGVStephan Bergmann
...while building LO. Patches from <https://github.com/FirebirdSQL/firebird>'s B3_0_Release branch; to apply, 0002 needed 0001 first (which looks like a reasonable thing to include in itself, anyway), plus a trivial whitespace modification, plus an additional #include for Windows. Change-Id: Idd2e326432fa52762742a168c7e880a9c6fb650c Reviewed-on: https://gerrit.libreoffice.org/33186 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-17new loplugin: useuniqueptr: helpcompiler..ioNoel Grandin
Change-Id: I6b394163c144e6b5540cb160abb613d56fe327de Reviewed-on: https://gerrit.libreoffice.org/33165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17tdf#35021 TabOverMargin: support center and decimal tabs alsoJustin Luth
TabOverMargin compatibility setting allows tabs placed beyond the right margin to function where they are instead of using the right margin as a hard limit. So far this has only been effective for right tabs (the most logical tab to use at the far right. This patch adds support for center and decimal tabs also. Left tabs are trickier, so they will be attempted separately. CAVEAT: Basically all of this stuff tricks the layout engine, so the amount of text allowed on a single line is still "controlled" by the right margin. So, even though the extended line could theoretically be very long, the amount of text still must fit within the limits set by the right margin. Thus large margins may cause wrapping in LibreOffice, instead of disappearing off of the end of the paper as it does in MSWord, and editing the text might get confusing - which matches the experience in MSWord. Change-Id: I1ff638eb3576ec221247e9a9823e7e082a1cba79 Reviewed-on: https://gerrit.libreoffice.org/32534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-17sw, sd: fix indentationMiklos Vajna
The indentation in these files is consistent otherwise, let's keep it that way. Change-Id: I1d73caa03425cd4d1c98ff07935512b002fb2c72
2017-01-17used std::map in SfxItemSetNoel Grandin
instead of naked array SfxItemIter ended up needing to take copies of stuff because various code likes to iterate over the items and delete items inside the loop. The gdb pretty printer is no longer quite as pretty as it was before, but it still prints useful info. Change-Id: I59b07ea42f6b1c74798a15402970b9dbd8233dbe
2017-01-17use rtl::Reference in OInstanceLockerNoel Grandin
no need to store a raw pointer and a refcount pointer Change-Id: I2dc3b87dd870c8d8128c2249a18fda30319ba08c Reviewed-on: https://gerrit.libreoffice.org/33157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17Updated coreGabor Kelemen
Project: help e40264511f6c8dfb16c284675e400080ec9a5526 Sync terminology to UI: graphic -> image, hyperlink -> link Change-Id: I852e8924024899d346b7152ef31cbc85246f0bb1 Reviewed-on: https://gerrit.libreoffice.org/33198 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-01-17Updated coreGabor Kelemen
Project: help 4dd957bf55432bc092222d405c51fb8b4a09a1ca Fix old bookmarks and ahelps for Search Attributes page Change-Id: If40d8e8b4347678fcc530ada0ab3c0b2bdefe9c4 Reviewed-on: https://gerrit.libreoffice.org/33194 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-01-17Updated coreGabor Kelemen
Project: help 884382ec3e0d40e7cb21597569a5f653c02e8921 Remove nonsensical switchinline Also sync the UI elements link and name Change-Id: I607b18357e4424fbffeb55bd932e72c91e9ff458 Reviewed-on: https://gerrit.libreoffice.org/33199 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-01-17Updated coreGabor Kelemen
Project: help 3c3239394a090a3a4376b0a963c30be7a89ed7c4 Fix connection between UI and help on Calc Statistics page File - Properties - Statistics tabpage in Calc was not linked to the help page Change-Id: Ief122e7959f3d396c2cd2d213a7a1434708b5925 Reviewed-on: https://gerrit.libreoffice.org/33193 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-01-17tdf#103574 Imagemap dialog lacks on confirmation buttonAbhilash Singh
Change-Id: I95af2542fdb29efabd2d671597837c79e6336f37 Reviewed-on: https://gerrit.libreoffice.org/32925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>