summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-19loplugin:unnecessaryparen (macOS)Stephan Bergmann
Change-Id: Ie4ae8459c0afbeac0cad1b8a30dad02535d558dd Reviewed-on: https://gerrit.libreoffice.org/48190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-1934 new autocorrect words pt_PTMarco A.G.Pinto
Change-Id: Ic5b13b2d21b7c429782a8c6cbb2be65be3a94aea Reviewed-on: https://gerrit.libreoffice.org/47405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2018-01-19Don't create database files in $HOMEMike Kaganski
Regression from commit 46b3202bf883618f1585850191c19776861013ed Change-Id: If8e0b309274ea14e996e0dde2d1ee9b49ff0f737 Reviewed-on: https://gerrit.libreoffice.org/48173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-19loplugin:useuniqueptr in SvDDEObjectNoel Grandin
Change-Id: Ia7f98a84bd42289ef0673b52e5e74a6a24554402 Reviewed-on: https://gerrit.libreoffice.org/48168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19Don't push error twiceEike Rathke
No harm was done as the stack is cleaned up afterwards, but it's wrong anyway and having to push the result downwards during cleanup is unnecessary. Change-Id: I0b2c153c9791ce5c287d340bac466c19cd6a5703
2018-01-19writerfilter: move TopContextType==Para requirementJustin Luth
This is prep work for tdf#95377. I need this function to run when there is no TopContext. This function doesn't do anything with the context, so in that regard I wonder if it is even necessary? My guess would be that it is a leftover piece from discovering the fix for n75883. However, to avoid causing a regression, I'm just pulling this test into the calling functions. (Of the three instances calling this function, two need to be contextless..) This is not truly NFC because if the followup patch is reverted, then this one will cause a change. But that is actually OK, because if my follow-up patch breaks because of these two functions changing to become contextless, then I'll be better able to pin-point the reason for the regression. Original commit adding this function was commit 2123ede032ca64f696ef54af4ad3238974ca2b5d Change-Id: I471aa852aa48527d69e0343a2ac28fa6e8acb209 Reviewed-on: https://gerrit.libreoffice.org/48062 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-01-19coverity#1427648 Dereference after null checkCaolán McNamara
Change-Id: Ib4be7b819a5ba68d78d98d8ae05d755898f3cad1 Reviewed-on: https://gerrit.libreoffice.org/48136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19refactor to look prettierCaolán McNamara
Change-Id: I3bf7ce76516f7c930e564791109ff72fb5b87d52
2018-01-19coverity#1427647 acknowledge Resource leak is deliberateCaolán McNamara
Change-Id: I9d4beccfa7ca8953360d67d08a3b2f04d2ccfed9 Reviewed-on: https://gerrit.libreoffice.org/48178 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19ofz#5483 Integer-overflowCaolán McNamara
Change-Id: If364a961f5e144cc0f3572108020c99db6febfb8 Reviewed-on: https://gerrit.libreoffice.org/48177 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19out of date 'define private public' commentCaolán McNamara
Change-Id: I21663a7eef846244f330b3236a2ff1a2efae15bb Reviewed-on: https://gerrit.libreoffice.org/48174 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19tdf#115088: Pasting multi-line text from external source behaves strangelyTamás Zolnai
Regression from: e68b6e349c31ac1376e90218013e1e7612f2b522 AppendTextNode might be sufficient for import (when there is no content in the document), but for clipboard operations better to use the original SplitNode method. Change-Id: I7de3e9bc9c5356acb0b4cc43927a0d39079522b2 Reviewed-on: https://gerrit.libreoffice.org/48124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-19-Werror,-Wunused-variableStephan Bergmann
Change-Id: I1bcfe0dabd61a2157bc4a48ea54413882ecaaabc
2018-01-19loplugin:redundantcast (after loplugin:cstylecast, macOS)Stephan Bergmann
Change-Id: I349eb6c3c2408729799d35316ab75bb05920021f
2018-01-19sw: loplugin:unreffunMichael Stahl
HTMLTable::FixFillerFrameFormat is unused now. Change-Id: Ic09d9585368ead7317325068eabb0171b76b6a9b
2018-01-19inline some definesNoel Grandin
which don't add any value anymore Change-Id: I45977d972d4d02926630b749d3ec736416138cf5
2018-01-19loplugin:unusedmethods also check for functions returning boolNoel Grandin
we were previously excluding them Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11 Reviewed-on: https://gerrit.libreoffice.org/48167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19new loplugin:emptyifNoel Grandin
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42 Reviewed-on: https://gerrit.libreoffice.org/48128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19Updated coreAdolfo Jayme Barrientos
Project: help d860405baeffb4cb6b1a32274d2c2b609ef8deea Correct Catalan spelling Typo introduced in 01879555450189381cc02517433807056b193af8 Change-Id: I9978ec8b238493a501981e192aa92547f2c1fe5d
2018-01-19Updated coreOlivier Hallot
Project: help 02e87fe2b0027c725075154f9172e9fb99ef9589 Add more localized strings for new Help Change-Id: I8c0cdcf8cf1ce64a407c98f4619a46b08c259b7d Reviewed-on: https://gerrit.libreoffice.org/48186 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-19Call new helpOlivier Hallot
With contributions from Kendy Call new help * If LibreOffice online, call help online * If no local help, call help online else call offline html help if offline help return false, call old-help * left tempfile to be deleted when LO exits (ESC) * hasHelp function now check if the right locale exist Change-Id: I14893e8ba4998773706b9cf8164636475d1f2356 Fix HIDs with a ':' inside Change-Id: I17b7c96b6b0003e8d933131b7b251f3191389a0f Call new help directly, fix locale issue Avoid passing by a html file that is necessary only in the online case. Fix path location of help/ folder Implement fall back in languages locale -> lang -> en-US. If none of the theree above, call online help with locale. fix scope Change-Id: If92673594c92e0d5a6064bc0e0bb4b66a52730ec Reviewed-on: https://gerrit.libreoffice.org/47748 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-19vcl osx: fix decimal separator key when localizedWard van Wanrooij
If you use OS X and an international locale (e.g. Locale setting: Dutch (Netherlands) and select Decimal separator key: Same as locale setting (,) in Preferences/Language Settings/Languages using the decimal separator key on the numeric keypad still results in a '.' instead of the expected ','. Tested and confirmed using latest LO build on 10.11.6 and 10.12.6 using both the wired and wireless Apple keyboard. The cause for this is that the decimal separator key sends a KEY_POINT (like the regular . key on the alphanumeric part) and the code expects a KEY_DECIMAL for the decimal separator key. Fixed by changing the combination of KEY_POINT and mask NSNumericPadKeyMask to KEY_DECIMAL. Change-Id: Iaf1ecf538c3e1a49ad512851cf16dd4dd991cb06 Reviewed-on: https://gerrit.libreoffice.org/45362 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-01-19Updated coreOlivier Hallot
Project: help ea4a7345bc1cbcbff3fb4355d0e4f4954f8afa7d Fix detection of bad help call remove single quotes Change-Id: Ia7951508cbf0a49ae029588e1d254de5f3942f12 Reviewed-on: https://gerrit.libreoffice.org/48165 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-19tdf#111747 Enabled position protection immediately after protection is checkedKshitij Pathania
Change-Id: I10409fe9e6eb7b932496346224952a7c4012cb38 Reviewed-on: https://gerrit.libreoffice.org/46192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-19sw: remove no longer building ww8toolbar dump codeMiklos Vajna
Such dumper code for other ww8 features is in the separate mso-dumper repo. If it is found really useful later, it can be still restored and fixed up to actually build, though. Change-Id: Id542fef9c0111c8bc88b943e268c9a02f3503d72 Reviewed-on: https://gerrit.libreoffice.org/48161 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-19Fix typosAndrea Gelmini
Change-Id: I98279a1f4020be95c57390fd163ebe740f8cca9d Reviewed-on: https://gerrit.libreoffice.org/48171 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-19Fix typosAndrea Gelmini
Change-Id: Icadf5cb88024b8889d49dc9c5210d0de8deaed3b Reviewed-on: https://gerrit.libreoffice.org/48172 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-19Unit test for tdf#114488Samuel Mehrbrodt
Change-Id: Ib9430d2c1cc05c7b73273270f8f96e716fc4dc3f Reviewed-on: https://gerrit.libreoffice.org/48129 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-19Remove noopMike Kaganski
IsTableNode() is true when m_pTableCursor is not nullptr. So, GetCursor() is only called when it is nullptr. In turn, GetCursor() only does something if m_pTableCursor is not nullptr. This is so from the beginning (commit 84a3db80 from 2000 already has it). Change-Id: I258129fc1bab0e3e5591702af1158c1ec2579d8d Reviewed-on: https://gerrit.libreoffice.org/48144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-19sw: HTMLTable::m_pTopTable is always "this"Michael Stahl
Ever since commit cc144e5544a41acdc703f7d243ad1747b0a2b33d fix for i#76959 the pTopTable parameter of HTMLTable was always null. Simplify HTMLTable by removing dead code. Change-Id: Ie13313f54d6ee656e56a209bc29bcc77132de269
2018-01-19SfxReqest::Done takes a SfxItemSet& or a boolean, not a SfxItemSet*Caolán McNamara
regression from commit c40dfabd56ade10fe35690dc9810955c2e99e2c0 Date: Fri Jan 12 11:57:22 2018 +0000 Change-Id: Ia97ba286a2da0584a2e806ad7396a3633f9d913e Reviewed-on: https://gerrit.libreoffice.org/48160 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19convert these to true assertsCaolán McNamara
Change-Id: Ifd602f47dd57cdecff3c175d892993072fb82891 Reviewed-on: https://gerrit.libreoffice.org/48154 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19pack these without holesCaolán McNamara
Change-Id: Idb5184e141c5a15d4d77268f8d45ee549c6e9a7f Reviewed-on: https://gerrit.libreoffice.org/47714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19ofz#5468 Integer-overflowCaolán McNamara
Change-Id: Ie2792b7dffaffe939778a1546653424ac03ea30e Reviewed-on: https://gerrit.libreoffice.org/48105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19crashtesting: failure on import with bogus valuesCaolán McNamara
regression from... commit 7d8e94444d989d0ac4a4055b207726708e9ec0da Date: Thu Jan 11 08:47:15 2018 +0200 convert a<b?a:b to std::min(a,b) cause old promotion was to the largest type, so with a large 64bit nDiff and any 32bit nRequestedBytes the nRequestedBytes was promoted to 64bit, found to be smaller than nDiff, then would fit in 32bit. newer code cast both to 32bit, resulting in a negative nDiff which was smaller than nRequestedBytes, but going on to cause havoc. Change-Id: I9eb5c61302b3dccf5333c4dfbf9ac92ce49585b5 Reviewed-on: https://gerrit.libreoffice.org/48155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19Remove include of config_global.h from sal/config.hStephan Bergmann
(where it is not actually needed), and instead include it where needed Change-Id: I107f8d4002d3001393b89834dd30a30b0c53a792 Reviewed-on: https://gerrit.libreoffice.org/48152 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19EPUB export UI: show title from the doc modelMiklos Vajna
It was a bit confusing that the doc model had a title set, it was written to the EPUB file but the UI did not show it. Change-Id: Ife408e0dabd3fe48e8acc1f09be0c86f78ed4b80 Reviewed-on: https://gerrit.libreoffice.org/48150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-19EPUB export: accept relative links for image popup from default media dirMiklos Vajna
Previously: - the user had to copy the linked image to the same dir as the doc - set a relative link on the image (in ODF, it resulted in "../foo.png") - copy the image to the media dir ("test" by default for "test.odt") - export to EPUB to have the image popup Now, additionally: - relative link may point to the default media dir (in ODF, it results in "../test/foo.png") - no need to copy the image - export to EPUB creates the popup So one less step is necessary. The downside is that this way the relative URL contain the base name of the document, so renaming the document breaks these relative links. Change-Id: I93894a28393d36a33dcec7bfe7c4a54fd83768da
2018-01-19EPUB export: handle text frame and image widthMiklos Vajna
So that an image and its caption in a text frame always go to separate lines. Change-Id: I439e370ad3bc8628f80a8db45499f8bffd84ef2b Reviewed-on: https://gerrit.libreoffice.org/48148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-19...and anotherStephan Bergmann
Change-Id: I06aa51f0f46f3708540ebb218387cb028b9e65d3
2018-01-19EPUB export: fix validation error on invalid relative linksMiklos Vajna
It's valid to have a relative link that points nowhere in ODF, but the same is not true for EPUB. Change-Id: I7884032e277a0c53d0c513cea70dd2ee29ccd85c
2018-01-19Blind fix for sal_Int32 = longStephan Bergmann
...after 252ce90e39648c47bcfdb39547d0ac82bacdbae6 "sw lokit: add page syles to header & footer" Change-Id: Ia0b3f8194d889fc1022da08bac06c85cbb22dd3b
2018-01-19Blind fix for AndroidStephan Bergmann
...after 022588bf2060a53ae70db6b0f1de713e4ba3ee6a "Include android/compatibility.hxx from ubiquitous sal/config.h" Change-Id: I58c620fd25add4758ec981c9812811916fa09db5
2018-01-19Fix callback function typeStephan Bergmann
...that got broken with c394363c84064c041391627602665ea1fa74db60 "loplugin:constparams in basctl", causing -fsanitize=function to complain: > sfx2/source/appl/app.cxx:452:28: runtime error: call to function basicide_handle_basic_error through pointer to incorrect function type 'long (*)(void *)' > basctl/source/basicide/basobj3.cxx:48: note: basicide_handle_basic_error defined here > #0 0x7ff6340234aa in SfxApplication::GlobalBasicErrorHdl_Impl(SfxApplication*, StarBASIC*) sfx2/source/appl/app.cxx:452:28 > #1 0x7ff63401cbef in SfxApplication::LinkStubGlobalBasicErrorHdl_Impl(void*, StarBASIC*) sfx2/source/appl/app.cxx:434:1 > #2 0x7ff639142148 in Link<StarBASIC*, bool>::Call(StarBASIC*) const include/tools/link.hxx:84:45 > #3 0x7ff63911f350 in StarBASIC::RTError(ErrCode, rtl::OUString const&, int, int, int) basic/source/classes/sb.cxx:1681:37 > #4 0x7ff63965aafe in SbiInstance::Abort() basic/source/runtime/runtime.cxx:518:16 > #5 0x7ff639664363 in SbiRuntime::Step() basic/source/runtime/runtime.cxx:865:28 > #6 0x7ff6392ec321 in SbModule::Run(SbMethod*) basic/source/classes/sbxmod.cxx:1141:25 [...] Change-Id: I66bd1ca720cebca4fb5fd52d86920de3fc7a604e Reviewed-on: https://gerrit.libreoffice.org/48142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19SAL_W32 is just an alias for _WIN32Stephan Bergmann
...so consistently use the latter instead of the former Change-Id: I144d5e7c472632f93b2258461510346bc85892d9 Reviewed-on: https://gerrit.libreoffice.org/48135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19Don't set autogen.sh KEY=VALUE arguments as environment variablesStephan Bergmann
> Jan 18 15:18:25 <sberg> tml__, do you remember anything about > e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a ? looks odd to add configure > KEY=VALUE args to the environment > Jan 18 15:18:27 <IZBot> core - Include environment variables already in > autogen.sh's environment - > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a > Jan 18 15:22:54 <tml__> sberg: not really any recollection, sorry > Jan 18 15:23:09 <tml__> sberg: are you sure this isn't what makes it possible > to have CC=clang etc in autogen.input? > Jan 18 15:24:07 <tml__> or maybe this is related to propagating stuff when > make re-runs autogen.sh? > Jan 18 15:24:28 <sberg> tml__, configure already takes care itself of its > KEY=VALUE command line arguments > Jan 18 15:24:36 <tml__> sad that I didn't write a better commit message > Jan 18 15:24:55 <tml__> feel free to revert it, and see if anybody notices;) > Jan 18 15:25:04 * cloph_away used it for CC/CXX and devtools repo > Jan 18 15:26:11 <tml__> cloph_away: yes, but I think sberg says that should > work anyway, even without that commit The only reading from ENV after that code in autogen.sh (both today and at the time of e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a) is the if (defined $ENV{NOCONFIGURE}) { print "Skipping configure process."; check, which would now no longer work if you pass NOCONFIGURE= as an argument to autogen.sh (in autogen.input or on the command line) instead of as an environment variable. Change-Id: If50639978190d219b063ff39f81e29d2054c0443 Reviewed-on: https://gerrit.libreoffice.org/48133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19Also strip leading whitespace from autogen.input linesStephan Bergmann
...which allows to align --enable/--disable switches on the part being en-/dis- abled, as in > --disable-assert-always-abort > --enable-avahi > --enable-breakpad > --enable-build-unowinreg > --disable-ccache for better readability Change-Id: I490402c74ea1ee535deee6ef79274b588b614820 Reviewed-on: https://gerrit.libreoffice.org/48130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19loplugin:useuniqueptr in EditFieldInfoNoel Grandin
Change-Id: I8c4cc4ab212409bce54b64d59d07d77a924ed11c
2018-01-19loplugin:useuniqueptr in SfxAppData_ImplNoel Grandin
Change-Id: Ic8b02f5c6582a992b64f31435332ee37d826ad48
2018-01-19loplugin:useuniqeptr in SbxVariableNoel Grandin
Change-Id: I788ec594589d9708e12db83a7371b5a8d9fed38c
generated by cgit (git 2.34.1) at 2025-02-07 06:17:38 +0000