summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-03Resolves: tdf#55566 opening two docs with open document macro events can crashCaolán McNamara
OfficeDocumentsManager::buildDocumentsList was set up to ignore disposed documents, but didn't ignore documents which were still uninitialized (i.e. waiting for the macro warning dialog of the other in-construction document to return a decision) Change-Id: I936e29ab6fad14a33609e8d57d11d7d0178075e4
2016-06-03Clean up Windows error reporting a bitTor Lillqvist
We have comphelper::WindowsErrorString(), so use it, in SAL_WARNs, right where an error happens. Get rid of the fairly unhelpful ImplWriteLastError() function. Avoid duplicated error reporting. Change-Id: I83374a65980b7c0ffa35fc493b4fb1f2e94f0dbb
2016-06-03Strip also a CR if there (and there seems to be such)Tor Lillqvist
Sad that it took so long for me to notice. Change-Id: I14b8a61930bb0b2dd1c5e9cce2a6c3e375dcb6ed
2016-06-03tdf#100193: Check earlier and harder whether OpenGL is good enough on WindowsTor Lillqvist
If we notice early enough that OpenGL is broken or not good enough, we can disable it and terminate with EXITHELPER_NORMAL_RESTART. Not beautiful, but works. The earlier added check whether shader compilation and loading of shader program binaries from a cached file works is now just one of the aspects that are checked. Change-Id: I9382576cc607f1916f6002f1fa78a62e23180fe3
2016-06-03loplugin:refcountingStephan Bergmann
Change-Id: I97a2d4538e0667fe7220a94589a4296c02d882a2
2016-06-03Add initial CppunitTest_framework_dispatchMiklos Vajna
Fails with commit 08cf2fd01064306eef7fdbb5b62320947c4d1089 (framework: last dispatchInterceptor gets asked first, 2016-05-20) reverted. Change-Id: I0e025a5d8996ecafa6b2fef753d6134079936b00 Reviewed-on: https://gerrit.libreoffice.org/25808 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-03loplugin:refcounting (RequestFilterSelect_Impl derives from XInterface)Stephan Bergmann
Change-Id: Iabf9b94626b599b4fe799523b3523e18df5203c5
2016-06-03tdf#89329: use unique_ptr for pImpl in accimplaccessXisco Fauli
Change-Id: Ib10088b5669695dd5e288fe043ad72056a34b1e4 Reviewed-on: https://gerrit.libreoffice.org/25745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Move page size listbox from cui to svxKatarina Behrens
make it a custom widget so it is accessible e.g. to sidebar panels Change-Id: Ic36a9a8af96a09fc76efd8e9ae75b8ebdf81717e Reviewed-on: https://gerrit.libreoffice.org/25764 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-03tdf#89329: use unique_ptr for pImpl in imageitmXisco Fauli
Change-Id: I935da01bd03a9812facf30e1d45da1c4949188ed Reviewed-on: https://gerrit.libreoffice.org/25633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Drop unused enum LATHE_PARTNoel Grandin
Change-Id: If06ee75ff6832199079b1f175f09e59a94fecf58 Reviewed-on: https://gerrit.libreoffice.org/25790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert NupOrderType to scoped enumNoel Grandin
Change-Id: If04deb1bc080679d1b71d155f7568ab89cb5888d Reviewed-on: https://gerrit.libreoffice.org/25765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert whichOfficePath to scoped enumNoel Grandin
Change-Id: If31c00ac8820e6dfce5047e997c35f5e1878db6f Reviewed-on: https://gerrit.libreoffice.org/25763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert FontRights to scoped enumNoel Grandin
Change-Id: Ib46fe9dbe4b41bfe2e85e9171e8dcf7a96ccb483 Reviewed-on: https://gerrit.libreoffice.org/25717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03tdf#89329: use unique_ptr for pImpl in embeddedobjectcontainerXisco Fauli
Change-Id: I679555e2eb51e2b9660bb035a08d8da8b1687cab Reviewed-on: https://gerrit.libreoffice.org/25747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03tdf#89329: use unique_ptr for pImpl in interactionXisco Fauli
Change-Id: I21ad7278f7978e7eebf6962fdf1fac2d3cb2bddb Reviewed-on: https://gerrit.libreoffice.org/25637 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Follow-up fix (odd missing ~TheAquaA11yFocusTracker error)Stephan Bergmann
Change-Id: I18501185f52ab4e90d16313cba299b7501106db3
2016-06-03configure.ac: allow build with Firebird 3.0Michal Kubecek
Relax the checks in configure.ac to allow building against recently released Firebird 3.0. In this version, libfbclient is also used to access local database files (embedded server mode) rather than separate libfbembed. Change-Id: Id498cbca22409f95ee299a6165cc765efa25eca7 Reviewed-on: https://gerrit.libreoffice.org/25845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-03loplugin:refcountingStephan Bergmann
Change-Id: Ia7bd500728e122f1f4c7ff4c020cc067e72613ca
2016-06-03try to avoid 'by-design' solar-mutex deadlock during ciNorbert Thiebaud
Change-Id: I9e1d79613adf6184f76c2e07aca0b78a9329838f Reviewed-on: https://gerrit.libreoffice.org/25839 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-06-02I assume these special plugins were not intended to be enabled unconditionallyStephan Bergmann
...with fa135fd0e05fc4ba784b4349d65f2e5ed26c0f55 "remove unused SID constants and associated code" Change-Id: I51b2a9e3c8ce13401818bca0c40167a4364212f1
2016-06-02Updated coreStanislav Horacek
Project: help 17405f4ca6d12814f5abc0f97028745308edca9a tdf#99637 add expert configuration property for number of undo steps Change-Id: I6ea67b95d3cc535166adbb0459a25b335f96d544 Reviewed-on: https://gerrit.libreoffice.org/24774 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-06-03sc: Don't export in case of invalid rangePranav Kant
For example, copying an empty column or row range, and then pasting as unformatted text exports all the newline characters inspite of the fact that this is an invalid data range. The problem becomes worse when someone tries to copy an entire column which implies exporting MAXROW times newline characters. Change-Id: Ie0a09890e2d0cd5f44d89d520959248e65365ad7
2016-06-02preserve ISO date+time format when editing such valuesEike Rathke
Change-Id: I6dcbe6c9aeff87d735303713f328c84203f76b60
2016-06-02add NF_DATETIME_ISO_YYYYMMDD_HHMMSS YYYY-MM-DD HH:MM:SS builtin format codeEike Rathke
Change-Id: I4fe6ef01a4c7fb795e4499e54aa55ebaaa0d433d
2016-06-02actually list additional builtin formats NF_FRACTION_3, NF_FRACTION_4Eike Rathke
Scanning only a subset span is ugly anyway, just hack that in now. Change-Id: I5a5f7a64f3b49e2f590130072a2a48c2b5af21b7
2016-06-02android: gnu-libstdc++ dir is versioned in ndk-bundleChristian Lohmaier
even with only one toolchain, so test whether path exists without version, otherwise just stick it in. Change-Id: I58c7f9e9582efdccb446e1bcf161d2c9e913a3af
2016-06-02tdf#90834 Turn in-line version control history commentskrishna keshav
cleanup in core/sw/source/core/view/viewpg.cxx Change-Id: Ie0f406db111b4418e92245a9e998e6ff99eb75fe Reviewed-on: https://gerrit.libreoffice.org/25596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-06-02Import custom Hatch background colorRishabh Kumar
Change-Id: I36593afb557f9826f2b0117cd93d2712bc676cdd Reviewed-on: https://gerrit.libreoffice.org/25784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-02[PATCH] up the free usage formatindex start from 50 to 60Eike Rathke
In preparation of adding some builtin format codes, actually already NF_FRACTION_3 and NF_FRACTION_4 needed that. Change-Id: I734a1ef5e6405aceaace7d44e8901a6183dc2a64
2016-06-02coverity#1362478 Explicit null dereferencedCaolán McNamara
and coverity#1362479, coverity#1362480, coverity#1362481, coverity#1362482, coverity#1362483, coverity#1362485 Change-Id: Ia3a32b69bcbe5ac3e7cc50dacfa02e8bf1aab787
2016-06-02coverity#1362486 Unchecked dynamic_castCaolán McNamara
Change-Id: Ia495ac1434500048ce2f6ffd8d85e3ece13d2bad
2016-06-02coverity#1362484 Dereference after null checkCaolán McNamara
maybe this is what was wanted, still looks a bit dubious, won't crash straight away at least Change-Id: I1be934af9d7ec95f3a7079f2f34a3e3661311944
2016-06-02vcl: GIF import: don't use __LP64__ to check for a 64-bit systemMichael Stahl
__LP64__ is not defined in MSVC AMD64 builds, since it doesn't have 64-bit longs. This caused the vcl_filters_test to fail because loading the file for which that check is a work-around succeeded. Change-Id: I4df48d4b196a1d08e9bd5ef61b64ec63501037c9
2016-06-02vcl: remove pointless checkMichael Stahl
This would have been more useful if it checked one of the other types that use inheritance. It would also be more useful if it actually did something to report the issue instead of silently reporting success. Change-Id: I684146244d4eec15669b499e40214b8ede70741f
2016-06-02vcl: fix "sgv" import filter on 64-bit MSVCMichael Stahl
This filter reads entire structs at a time from the SvStream, including structs that are derived from other structs. This happens to work fine with GCC by chance, but MSVC AMD64 by default aligns structs to 8 bytes, and that means if sizeof(super-stuct) = 20 then 4 bytes of padding are inserted and that ruins the import. This causes vcl_filters_test to go into an infinite loop reading SaveAsPicture.sgv. Fix this by reading each member of the structs separately, which also means that the filter doesn't need to byte-swap every member on big-endian platforms since SvStream methods already do that. Change-Id: I237725dbcde5232006728179e645776fcb79cac3
2016-06-02New o3tl::try/doGet to obtain value from AnyStephan Bergmann
...in an attempt to reduce usage of type-unsafe void const * css::uno::Any::getValue() These new functions are often more convenient to use than the existing ">>=" and Any::get<T>. Note how they are careful to provide a pointer directly into the given Any, instead of creating temporaries. As an example, replaced most calls of getValue across xmloff: * Cases that first check for a specific type (via getValueType etc.) and then call getValue can instead call tryGet. (But beware that tryGet supports some conversions, which a check for a specific type may have missed---either intentionally or by accident. Also beware the somewhat common idiom of checking for TypeClass_ENUM and then using getValue to obtain a sal_Int32; this cannot be replaced with a call to tryGet.) * Cases that seem confident that the Any is of the correct type when calling getValue (but apparently are confident due to some higher-layer protocol, as the surrounding code does not do any checking via getValueType or similar) can instead call doGet. It throws an exception if it turns out the confidence wasn't warranted. (Many of the existing calls that directly dereferenced the return value of getValue as sal_Bool look suspicious, in that the author might have thought the given code would also cover a VOID Any---which technically it even would have happened to do. If any RuntimeExceptions thrown from these doGet calls start to crop up, these changes need to be revisited. Some may even be rewritten as uses of ">>=". But at least "make check" did not show any such problems. Also note that casting the value obtained from getValue to any css::uno::Reference<X> with X being anything but the base css::uno::XInterface was always prone to producing a bad pointer, in case the interface actually stored in the Any derived from X via multiple inheritance.) * Should there ever be cases where an Any is known to be of the requested type, some additional forceGet could be introduced (which would assert instead of throwing an exception). Change-Id: I2d8739e86314eff73abfcafe01d806f5bc5c34db
2016-06-02Resolves: tdf#100191 crash: switch to Display Mode: Notes via toolbarCaolán McNamara
Change-Id: I65f5f68433940fa0b50ad951fbb96085178a42d9
2016-06-02DataAccess.xcs says xs:short not xs:int for this typeCaolán McNamara
noticed when examing tdf#96251 Change-Id: Iec8748ad323bcb59e8e1f6b4135b4a3b313a6e44
2016-06-02these overrides just call only their parent versionCaolán McNamara
looks like the sort of simplfication that could be automated Change-Id: I29ce13fe1b98e99be096e44239b971f6971c5f98
2016-06-02Accept also hex vendor id in hex in opengl_blacklist_windows.xmlTor Lillqvist
(And not just names from the hardcoded list.) Surely we want it to be possible to add a blacklist entry for a hitherto unhandled vendor to the file at a user site without having to modify the parsing code and rebuilding LO. Change-Id: I01ca45cb91df06e1634a565b3e469fb85fe4e116
2016-06-02use android app's target-sdk (22) also for owncloud libChristian Lohmaier
maybe should be set via configure, to keep them in-sync Change-Id: I3747992bb2bbdd88f3668418280bbafc8c998a02
2016-06-02allow use of android ndk 11.1.xChristian Lohmaier
Change-Id: I1ae9419383c56a026d05d6adf4adf81dc981f56a
2016-06-02tdf#99919: Blacklist that specific vendor, version, and device combinationTor Lillqvist
Change-Id: I12b45b499bdf2041d6b50fa85e30612916462b3e
2016-06-02a stab at fixing the macosx buildCaolán McNamara
Change-Id: Id50077d03c80819312ed55326d33108e24fd4e30
2016-06-02Invalidate the AutoText Dialog after selectionSzymon Kłos
Changes: - added invalidate call after entry selection and expand Behaviour before patch (Linux): 1. Open Writer 2. Open AutoText Dialog: Tools > AutoText 3. Expand/select entry Insert button is still disabled / entry is not expanded. To force repaint you had to use mouse scroll. Change-Id: I814db71dea02273998f675c3b140d554f2e109ba Reviewed-on: https://gerrit.libreoffice.org/25783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-02STREAM_STD_READ already includes StreamMode::NOCREATETakeshi Abe
Change-Id: Ib8c81056619a383cedc828b945c1802ff1ce42ca Reviewed-on: https://gerrit.libreoffice.org/25802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-02fix debugging buildCaolán McNamara
Change-Id: Idb1b1d50260a969446ac1385f93163bea6cf6b04
2016-06-02Remove SetAccessibleRelationLabeledBy calls tdf#87026Muhammet Kara
And make proper changes in the related .ui files Change-Id: Iea998b6de25831c08950a8afa725713288113bfa Reviewed-on: https://gerrit.libreoffice.org/25807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-02tdf#63272 Fix location of percent sign for TurkishMuhammet Kara
Change-Id: I6f2d1c2c947e01a686fdb7a7f175dd7541924afa Reviewed-on: https://gerrit.libreoffice.org/25805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-06 08:58:28 +0000