summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-06remove unused constants in HRC filesNoel Grandin
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use shared_ptr for pImpl in slstitmXisco Fauli
Change-Id: Icb9167f8e7612f40992e7146c0dce539c0b0eac7 Reviewed-on: https://gerrit.libreoffice.org/25632 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06Remove unneeded Pane code in Presenter ConsoleBryan Quigley
This code hasn't been touched (on purpose) in years, it appears to have been used to resize part of the console. (It's prefed off) Change-Id: Iaaeaa8a95c71ae91299bbeeea24869bf2a237b6b Reviewed-on: https://gerrit.libreoffice.org/24663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-05remove old debug outputMarkus Mohrhard
Change-Id: Icf0e38c6725a129d3afb22b1cc79f72071c8e919 Reviewed-on: https://gerrit.libreoffice.org/25934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-05add EDATE test caseZdeněk Crhonek
Change-Id: I3afc4aff71dc8a137b57f4e5fa2fc010c437bfb1 Reviewed-on: https://gerrit.libreoffice.org/25702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-05add DATEVALUE test caseZdeněk Crhonek
Change-Id: I887c03b782e6ab7ea713a68150e920c49dc71b96 Reviewed-on: https://gerrit.libreoffice.org/25703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-04Resolves: tdf#100201 crash on apply custom colorCaolán McNamara
regression from... commit 789055bc2acb4c71483fd60ea258d158bd5aec10 Date: Tue Apr 12 16:39:03 2016 +0200 clang-tidy performance-unnecessary-copy-initialization probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. This case has a comment explaining the problem that appeared post change. Change-Id: Ib0c0883c57f103656cda00e3a94399a515d7fe41
2016-06-04tdf#96516 fixup: when removing entry, entry count does not stay constantLionel Elie Mamane
Change-Id: I192a2d14787581545e66c46a84507f6dfd191c57
2016-06-04tdf#96099 Remove sfx std::shared_ptr typedefsMark Page
Removed SfxItemSet_Pointer_t and SfxStyleSheetIteratorPtr Change-Id: Ibfa6a79809fdbbe2648dacc02625e620ceaf9bf0 Reviewed-on: https://gerrit.libreoffice.org/25851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-04report the crash id back to the userMarkus Mohrhard
Change-Id: I5cc1e698294a5674d691529af8cc14e4cd87a711 Reviewed-on: https://gerrit.libreoffice.org/25865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-04don't just silently ignore the return valueMarkus Mohrhard
Change-Id: Ia65c29b61e78de4b908b11cd803d93da4b7e3a2d Reviewed-on: https://gerrit.libreoffice.org/25864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-04integrate the minidump upload into the normal LibreOfficeMarkus Mohrhard
Change-Id: Id1808ceebf6c54698f7d1656a0ce96bcaece89ac Reviewed-on: https://gerrit.libreoffice.org/25863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-04extract the minidump uploader code into a static libMarkus Mohrhard
The plan for the near future is to still ship the executable but replace the interal use if possible with using the static library. At some point when it is not needed for debugging anymore and everything works correctly we should only build the uploader executable in dev configurations. The huge disadvantage of the interal solution is that it is nearly impossible for a user to upload a crash report if LibO starts working correctly. Also LibO overwrites the file with the information after the upload whereas the executable does not. Change-Id: Ib9854946be3a34e580964c18e1a9c0cce16221d1 Reviewed-on: https://gerrit.libreoffice.org/25862 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-04initialise PointSequenceSequence directlyJochen Nitschke
this list initialisation is short enough to remove the local helper function Change-Id: I17fab47e51fc0b1a0aa0462d517d7861f8a278e0 Reviewed-on: https://gerrit.libreoffice.org/25884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-06-04Make doc validation work on WindowsVasily Melenchuk
Change-Id: I37a3c729db320abbb43664eeebaa0f46eb889197 Reviewed-on: https://gerrit.libreoffice.org/25885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-04remove use of Archive::ZipDavid Tardon
Change-Id: I7c1e0057c3c1c0b6be524d1e9ad37357259ebd7c
2016-06-04drop unused optionDavid Tardon
Change-Id: I317160ca6ffc0ff1c7db443f844f02f91fad5929
2016-06-04tdf#96099 Reduce number of typedefs used for trivial container typeskrishna keshav
Change-Id: Iecf8052d3f7ec5593205184622d53550e6a52161 Reviewed-on: https://gerrit.libreoffice.org/25836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-03fix 32bit linux buildCaolán McNamara
Change-Id: Ib42627c04b2c06e34f2dd108f8a04eaea916488a
2016-06-03accidentially reverted fix for tdf#96745Caolán McNamara
Change-Id: I52380248002f6c41f0c6f154f913b05ef32b93d3
2016-06-03add some more error checking to minidump uploaderMarkus Mohrhard
Change-Id: Ia06fec80ea67e88b8c26cdeb5bfc9cee2459ad4a Reviewed-on: https://gerrit.libreoffice.org/25861 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-03connectivity: firebird: use ODS12 test database for Firebird 3Michal Kubecek
Firebird 3.0 uses new database file format (ODS, On Disk Structure) so that we need to use either ODS11 or ODS12 version of test database for dbaccess_firebird test, depending on whether building against Firebird 2.5 or 3.0 libraries. Change-Id: Idecdc35b0ac87ab7f46cb79b5c044c65423a2c7e Reviewed-on: https://gerrit.libreoffice.org/25846 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-03tdf#96099 Reduce number of typedefs used for trivial container typeskrishna keshav
Change-Id: I1ec93e281d7c2648a150c98144905f1158502dcc Reviewed-on: https://gerrit.libreoffice.org/25835 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-03Template Manager: Ctrl + A to select all templatesAkshay Deep
Change-Id: I8398268752c78a30d5fc076d6f2b6249cbf89ec2 Reviewed-on: https://gerrit.libreoffice.org/25860 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-03tdf#100195 Enable Keyboard Navigation in Template Manager and Start CenterAkshay Deep
Change-Id: Ic5447a4af091a4e3dcab4d909fc6bfb9e559defb Reviewed-on: https://gerrit.libreoffice.org/25848 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-03A slightly better DbusIpcThreadStephan Bergmann
...that doesn't burn CPU by always directly returning again from a dbus_connection_read_write call with zero timeout. But still doesn't look like it uses DBus the way it's intended to. Help appreciated. Change-Id: I0d130adfb921409a27a847053b0b3646dc566a86
2016-06-03Reduce duplicate code in Template ManagerAkshay Deep
Remove ViewBar and put contents in ActionBar Change-Id: I6551d36503f659f076ecf2b6766c6a14db771a1d Reviewed-on: https://gerrit.libreoffice.org/25833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-03Resolves: tdf#98880 ensure backing context of DoubleVectorRefToken...Caolán McNamara
exists for the lifetime of the ScGroupTokenConverter otherwise in tdf#98880 ScDocument::InterpretDirtyCells releases that backing storage that the DoubleVectorRefToken relies on, and the ScVectorRefMatrix relies on that, so... when sc/source/core/tool/interpr4.cxx calls ::IsString on the ScVectorRefMatrix which calls ensureFullMatrix. That makes use of rArray.mpStringArray where rArray's mpStringArray is set to that rArray by FormulaGroupContext::ensureStrArray and the storage of mpStringArray belongs to the FormulaGroupContext, but that context was reset and destroyed up the stack in ScDocument::InterpretDirtyCells so the data is now invalid We could turn the unique_ptr into a shared_ptr and have the ScGroupTokenConverter take a ref to the currently active FormulaGroupContext to ensure any generated DoubleVectorRefToken/SingleVectorRefToken point to valid data during the lifetime of the ScGroupTokenConverter Change-Id: Id457934cdff18570961cb261cf5c46b6ef8ea083 Reviewed-on: https://gerrit.libreoffice.org/25815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-03Try to fix tinderbox build running in RDP session from Linux on Windows pre-10Tor Lillqvist
It is a complicated scenario, but I think something like this is going on: Before Windows 10, only OpenGL 1.1 was supported in RDP sessions. Our code detects RDP and tries to disable the use of OpenGL in that case. This code for this is in the neighbourhood of the blacklisting of OpenGL implementations. But the use of OpenGL in GLTF and chart2 does not go through code paths that would take that into consideration, so it tries to use OpenGL anyway, and eventually we end up in InitGLEW(), where the recently added check for OpenGL 3.0 or newer causes an (intentional) abrupt termination of the process. Change-Id: Ia57bfc8d2cefe4e6d7a00282973608d17967d3fd
2016-06-03Resolves: tdf#96008 crash when an extension with legacy decks is installedCaolán McNamara
ReadLegacyAddons modifies its vectors of maDecks and maPanels in this case, but a load of things have (c++) references contents of the original contents. Its such a rats nest that the easiest thing seems to be to make them vectors of shared_ptrs and hold DeckDescriptor and PanelDescriptor by shared_ptr and it all works out Change-Id: I3f628e12c7d5f4224d14d5e0769e450ce893fb54
2016-06-03CppunitTest_sal_osl_file: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Ib0594ba236284aa69d180fb72ce60435b679ea05 Reviewed-on: https://gerrit.libreoffice.org/25852 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-03Convert ComplexTextLayoutMode to scoped enumNoel Grandin
Change-Id: I257f8e15fec92f0701235a6fe4b6a2272498c4f1 Reviewed-on: https://gerrit.libreoffice.org/25667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03drop "Solar-Version not set on rIStream" messagesNoel Grandin
nothing else in our codebase seems to care if we set a version on an SvStream Change-Id: I6c0e78dade5f1e79c4b5bf1ffe2a35d5261b6008
2016-06-03Null pointer dereferences must not happenTakeshi Abe
This is a follow-up of 09981cd6383ecb99e4b6c83b98b03af5cf3ff59b. Inspired by coverity#1362478 etc. Change-Id: If5507c52552393cccbb255cbf4b7e9f4b80db917 Reviewed-on: https://gerrit.libreoffice.org/25840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-03tdf#96099 Reduce number of typedefs used for trivial container typeskrishna keshav
Change-Id: If4678b6e4b6e0724c50415679bb7188d900b5eba Reviewed-on: https://gerrit.libreoffice.org/25643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-03on switching to slide layouts panel move into slide layout contextCaolán McNamara
i.e. exit current textbox edit and shape selection Change-Id: I16a2fca158cb4caab7b6bd001742df698735dd2b
2016-06-03OpenThenSwitchToDeck actually *toggles* deck visibilityCaolán McNamara
so rename it to that and add a OpenThenSwitchToDeck that actually does that, using the Toggle varient as the callback from the sidebar button which toggles the current deck on/off which retains the features of // tdf#67627 Clicking a second time on a Deck icon will close the Deck // tdf#88241 Summoning an undocked sidebar a second time should close sidebar but means that calls to OpenThenSwitchToDeck from e.g. slide layout don't auto close it if that deck is already open Change-Id: I3e3724626b93447a7ab6bc7032e9c6839dabcf55
2016-06-03Add an assert for a good measure.Jan Holesovsky
Change-Id: I764e5c96b60705f01db9525ee02fdf9959db5663
2016-06-03notebookbar: load ui for the start centerSzymon Kłos
Change-Id: Iaf0e46436524e081edb287efd4074becaf02a98f Reviewed-on: https://gerrit.libreoffice.org/25799 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-06-03tdf#89329: use unique_ptr for pImpl in sbxvarXisco Fauli
Change-Id: I74734c34e72ba5d508830dbcff88f0d3b93a0766 Reviewed-on: https://gerrit.libreoffice.org/25742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03ignore comment WMF meta-actions in WMF writerNoel Grandin
Means nothing to this class and reduces spam in our unit test logs Change-Id: I56a1d01b98372691003410b6d7b0e5326b2ee7eb Reviewed-on: https://gerrit.libreoffice.org/25828 Tested-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03script for grouping warning messages by most commonNoel Grandin
A script to search our test logs and sort the messages by how common they are so we can start to reduce the noise a little. Change-Id: I8a6e6167c42447f9869ac700300d1b243f055e2b
2016-06-03sw: replace some OSL_ENSURE with assertMichael Stahl
... and delete a couple that are obviously dead. Change-Id: I2cef18371cc57f5fd82500d0ab6d74030004a761
2016-06-03sw: convert some OSL_FAIL to assertMichael Stahl
Change-Id: Ia5244d58b8975a371c2d74809021c2332ffa496b
2016-06-03Resolves: tdf#93971 freeze on load of specific html docCaolán McNamara
this is similar to commit 6acd5c45c764d81aea1539e66adbfadb51df0aa3 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jan 21 15:25:03 2015 +0000 Resolves: fdo#87601 specific html doc hangs on load and is a consequence of the old changeover from unsigned shorts for old string class to signed int for new string class Change-Id: I47022c641cbc329d8802765927005d43211b0d88
2016-06-03Use AtomicLong in ThreadId instead of synchronizingNoel Grandin
Change-Id: Ia10bab23b0cecb587cd3faa9c7e93b18384ecb88 Reviewed-on: https://gerrit.libreoffice.org/25827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03loplugin:constantparamsNoel Grandin
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Teach loplugin:stringconstant about RTL_CONSTASCII_STRINGPARAMStephan Bergmann
Change-Id: I8ff0e104aad045f3835dc8facc760a8339b1d088
2016-06-03Resolves: tdf#100199 crash: switch to Display Mode - Master Modes - NotesCaolán McNamara
via toolbar Change-Id: I0ad3cce6d96cede8033a05e35c934c3163d214e3
generated by cgit (git 2.34.1) at 2025-01-04 05:08:00 +0000