summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-11tdf#120993 update Add fields icon in colibreandreas kainz
Change-Id: If51ede08035c435d11b6f015b72ad656d32d2505 Reviewed-on: https://gerrit.libreoffice.org/66150 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-01-11ofz#11188 avoid timeoutCaolán McNamara
Change-Id: I3726eb249e3bc290fa9bd5e8fe6747b1ce5ce9bb Reviewed-on: https://gerrit.libreoffice.org/66149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-11Resolves: tdf#122404 unlock just the toplevels that were lockedCaolán McNamara
push what toplevels got locked to just unlock those ones. otherwise the just dismissed toplevel may still be present in the Application toplevel list. merge all the similar examples of this. Change-Id: I77c0d55d1e4b3bcc3b8d88fef00ba289edd1e831 Reviewed-on: https://gerrit.libreoffice.org/66076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-11make Insert->Header and Footer dialog asyncNoel Grandin
Change-Id: Icb2c507970c35a8ddee47912915882dede87ebca Reviewed-on: https://gerrit.libreoffice.org/66099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11make Format->Bullets and Numbering dialog asyncNoel Grandin
Change-Id: Ib69c2be7c8ddaa616c08796ad2b8c8cf20ee2db9 Reviewed-on: https://gerrit.libreoffice.org/66098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11tdf#100701 UI Enhancement: unintuitive naming changed as requested in commentsSass Dávid
Options in menus concerning Pivot Table changed to reflect their functionality as requested by Yousuf Philips (jay) in the comments. Menu: Data > Pivot Table > Create... -> Insert or Edit... Toolbar Tooltip: Insert Pivot Table -> Insert or Edit Pivot Table Context Menu: Edit Layout... -> Properties... Change-Id: I77c909a5de1606fab9e23e3e3614fcae440aa586 Reviewed-on: https://gerrit.libreoffice.org/66032 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2019-01-11Resolves: tdf#122448 Change menu Item "Slide->Master Slide"Roman Kuznetsov
Change menu Item "Slide->Master Slide" to "Slide->Change Slide Master" Change dialog name "Slide Design" to "Available Master Slides" Change dialog name "Load Slide Design" to "Load Master Slide" Change-Id: I98fab31cdce2e8ddf43f0c8b8519a95e15c13de5 Reviewed-on: https://gerrit.libreoffice.org/65860 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-01-11tdf#42949 Fix IWYU warnings in sw/inc/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. - Also fix .h / .hrc files - Remove a bit of duplication from the .yaml file Change-Id: I22145a79343497678e481d882544eb08e765312a Reviewed-on: https://gerrit.libreoffice.org/65878 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-11Drop o3tl/string_view.hxxStephan Bergmann
...now that all of its uses have been replaced with C++17 <string_view>. The LO-specific o3tl::basic_string_view ctors with OString and OUString params have meanwhile been replaced with OString and OUString conversion functions (in dac7be50cff94e0c34cdca5ac7e35c19685c40c1 "o3tl::string_view -> std::string_view (in configmgr)"), the ctor with OUStringLiteral turned out to be no longer(?) needed anyway, and the LO-specific o3tl::toOUString has meanwhile been replaced with an OUString ctor with std::u16string_view param (in 6856da30665705be6380e84cf55de954c41f15d1 "o3tl::string_view -> std::string_view (in embedserv)"). Change-Id: Ie5215b07e2387560fb7e94de8b5a963241539c64 Reviewed-on: https://gerrit.libreoffice.org/66144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-11use unique_ptr in swNoel Grandin
Change-Id: I471875142391e537a4301dfe42beb8f8803ff46b Reviewed-on: https://gerrit.libreoffice.org/66036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11ofz#11061 pick an upper bound on acceptible image sizeCaolán McNamara
Change-Id: I3386dfe5c53c07c60f8845380246fb369d970134 Reviewed-on: https://gerrit.libreoffice.org/66134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-11make insert->header/footer dialogs asyncNoel Grandin
Change-Id: I0e8eac86280d42752db2d7bde8c6aecf452bad6c Reviewed-on: https://gerrit.libreoffice.org/66089 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11make insert-section dialog asyncNoel Grandin
Change-Id: Ia48f4103b8f346a93ebe1f2c5078f21a90884e3f Reviewed-on: https://gerrit.libreoffice.org/66065 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11vcl pdf: make XRefEntry members privateMiklos Vajna
Change-Id: Id389773f5eabc326ae8d6cc08262fc45314a824e Reviewed-on: https://gerrit.libreoffice.org/66131 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-11oox smartart, org chart: handle multiple paragraphs on data nodeMiklos Vajna
This problem was similar to the one fixed in cfa76f538a44d4396574ece59e8a3953c22c6eb7 (oox smartart, accent process: handle multiple runs from a data point, 2018-11-21), but this there we handled multiple runs and this handles multiple paragraphs. It seems some smartart types allow multiple paragraphs in a diagram node, others only allow multiple runs. Org chart is in the former category. Change-Id: I281f01fdfa809d0a232d5da7fdaa23de7adcd627 Reviewed-on: https://gerrit.libreoffice.org/66066 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-11use unique_ptr in SwViewShell::ImplEndActionNoel Grandin
Change-Id: I9be790996347e191df63198de109acf973104d0d Reviewed-on: https://gerrit.libreoffice.org/66125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwNodes::ExpandRangeForTableBoxNoel Grandin
Change-Id: I31cc9d6b962c116c64789d886b82ea476f4e5144 Reviewed-on: https://gerrit.libreoffice.org/66124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwXNumberingRulesNoel Grandin
Change-Id: I7daa1fbd11c62d712b2ff70714b5e5bda63d54d8 Reviewed-on: https://gerrit.libreoffice.org/66123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwXFrameNoel Grandin
Change-Id: I3671bf7ab7913a2f07eec347c1e07d036bfca4c4 Reviewed-on: https://gerrit.libreoffice.org/66122 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11no need to allocate on heap in SwUndoSortListNoel Grandin
Change-Id: I949a9d32b18d5ccae17dee26f030173307d0b3fb Reviewed-on: https://gerrit.libreoffice.org/66121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwUndoDelSectionNoel Grandin
Change-Id: I2637872300c60f880e32b00f5f545f6145b563bf Reviewed-on: https://gerrit.libreoffice.org/66120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwLayHelperNoel Grandin
Change-Id: I6b7ee99bb38df882853e3695cd03dcc745c92318 Reviewed-on: https://gerrit.libreoffice.org/66035 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11o3tl::make_unique -> std::make_unique in xmlsecurity/Gabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Ie15220b53c6687e1d4891df668b2dedeae5e4750 Reviewed-on: https://gerrit.libreoffice.org/65795 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-11o3tl::string_view -> std::string_view (in tools)Stephan Bergmann
Change-Id: Ic3952cf0f05752813f60199b7b2c8c8e8dc27427 Reviewed-on: https://gerrit.libreoffice.org/66118 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-11Fix typoAndrea Gelmini
Change-Id: I1a8d3930c3e986ffa8cd23de7acfef2028bf8918 Reviewed-on: https://gerrit.libreoffice.org/66143 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-11tdf#69060: lock refreshing font data when loading a documentMike Kaganski
This accumulates all calls to OutputDevice::ImplRefreshAllFontData while loading document's model, to avoid multiple updates for each imported font. After loading, OutputDevice::ImplRefreshAllFontData is executed once. Change-Id: I5b23a2b8a3765dee9061b6479665d04c2ba11cbf Reviewed-on: https://gerrit.libreoffice.org/47112 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-11OSX Re-Introduce NSApplicationMain usageJan-Marek Glogowski
This restores the nested NSApplicationMain and default run loop usage. Without it the Java AWT integration will start its own event loop, effectively blocking any non-system event processing. Reproducible via "Tools - Macros - Organize Macros - BeanShell... - LibreOffice Macros - HelloWorld - helloworld.bsh - Edit". The blocking can be prevented by overriding NSApplication::run and running our own event loop using Application::Execute. But this still doesn't show the Java AWT editor window and I couldn't find any information how to fix this. Since OSX now is a VCL plugin, this can't restore the old hook mechanism, but instead adds a new function to SalInstance. SalInstance initialization happens at InitVCL() start just a little bit later in the call stack. Somehow NSApplicationMain manages to run the Java VM in an extra thread, so it doesn't block the main loop. Probably this could also be handled by LO starting the JVM as a thread. Further information for an implementation eventually can be found in the "Technical Note TN2147" "JNI Development on Mac OS X." Change-Id: I04a0c2bf7949571f1b678ada9ab3592e0fe30c1f Regression-from: 925e2edb6f3f8fffcff9eddb31ed18bc77e2a690 Reviewed-on: https://gerrit.libreoffice.org/65836 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-01-11writerfilter: import section margins and writingModeJustin Luth
Previously, only page styles got these values. But if the section is continuous, then these properties should be transferred to the section itself. This patch relies on the commit for tdf#122456. It confirms that it is a good idea for the last section to ignore the "fake" section and keep the real section properties. Otherwise these margins would be lost on export. Change-Id: I45efb0d80fb9307a57ff560b2e1a26899155f827 Reviewed-on: https://gerrit.libreoffice.org/65975 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-11Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Removed double word Change-Id: I34d554c9e42d032d46031248f68405a3f49177ab Reviewed-on: https://gerrit.libreoffice.org/66138 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-11Related: tdf#44076 use sc::power() in ScMatrix::PowOp()Eike Rathke
Change-Id: I13a47419bd57d71482793d5f9a8429101793aad7 Reviewed-on: https://gerrit.libreoffice.org/66092 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-01-11Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Removed double word Change-Id: Ia2ddedbb18ef3772be30cb1828ada0857f523848 Reviewed-on: https://gerrit.libreoffice.org/66137 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-10o3tl::string_view -> std::string_view (in svtools)Stephan Bergmann
Change-Id: Id876708444e969c27c0515d6b6897c016de53437 Reviewed-on: https://gerrit.libreoffice.org/66117 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10o3tl::string_view -> std::string_view (in sfx2)Stephan Bergmann
Change-Id: I61b40db1e75938ecf09c3c2e039be2d757fde170 Reviewed-on: https://gerrit.libreoffice.org/66116 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10o3tl::string_view -> std::string_view (in cui)Stephan Bergmann
Change-Id: I7899802f09d16cfa2c8821782feed4fdfa653dd0 Reviewed-on: https://gerrit.libreoffice.org/66114 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10o3tl::string_view -> std::string_view (in embedserv)Stephan Bergmann
Change-Id: I32bba8f45ff3b77084aa2d416126f96c051022f4 Reviewed-on: https://gerrit.libreoffice.org/66073 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10tdf#122454 Impress: Correct d'n'd animation selection in WindowsBrian Fraser
Change-Id: I0f17ff657beb2a5b3dfed91856ec45ddfca793a9 Reviewed-on: https://gerrit.libreoffice.org/65939 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-01-10Resolves: tdf#120632 consider submenus on restoring focus from menuCaolán McNamara
additionally to the menu having focus, if a submenu of that menu has focus, then restore the focus when the whole hierarchy execution ends return focus to the toplevel menu's saved focus widget Change-Id: Iefd467fb1ba67ffd0a303505a893d2453e0ffbb3 Reviewed-on: https://gerrit.libreoffice.org/66115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10DocumentSettings Writer UNO API test (converted from Java test)Tomaž Vajngerl
Change-Id: Id9a691b1aae62f37ef7f865c5ed015b7c6a13976 Reviewed-on: https://gerrit.libreoffice.org/65909 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-10Revert "Try fixing VclComplexTextTest::testArabic by rescheduling"Mike Kaganski
Apparently, this patch was ineffective, and wrong, as Jan-Marek told. https://ci.libreoffice.org/job/gerrit_windows/25682/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd https://ci.libreoffice.org/job/gerrit_windows/25549/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd https://ci.libreoffice.org/job/gerrit_windows/25531/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd https://ci.libreoffice.org/job/gerrit_windows/25489/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd https://ci.libreoffice.org/job/gerrit_windows/25434/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd This reverts commit 68259f3663ba61a5f15f04793ac32a200100a8a5. Change-Id: Ibcb804b0b52339d6977c80129b10adb309514dbc Reviewed-on: https://gerrit.libreoffice.org/66088 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-10EmptyBPixel is unusedStephan Bergmann
...since b62826ad3887305a76ee1ceabe2060f9d6e8723f "Remove more unused methods" BPixel was marked BASEGFX_DLLPUBLIC, but all its member functions are defined inline in include/basegfx/pixel/bpixel.hxx, and basegfx/source/pixel/bpixel.cxx was the only .cxx from Library_basegfx that included it. So on Windows, non- inline implementations of the BPixel member functions are no longer exported from Library_basegfx, even though code in drawinglayer using BPixel expects that (and would thus start to fail to link on Windows). So just not mark that all- inline BPixel class as DLLPUBLIC. Change-Id: I7553a7ac5a57b5d175d7c81b3908ad7b80b064c3 Reviewed-on: https://gerrit.libreoffice.org/66043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10tdf#107416 Revert "tdf#103703 Turn on single print jobs for collated prints"Gabor Kelemen
Turns out this was a wrong solution to the problem, also causing printout mixups on busy printers for the users This reverts commit 37c3e57c788fb5ad931126ea233093d87ac3dbc3. Change-Id: I8a456f4c90f48854c1f5e92dc39ed4ec8a17cf75 Reviewed-on: https://gerrit.libreoffice.org/65993 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-10Resolves: tdf#122398 max/min limits too small for scale FormattedSpinButtonsCaolán McNamara
Change-Id: I679b6cc7e4bfc4273fc438e6d1d897ba66ead77b Reviewed-on: https://gerrit.libreoffice.org/66049 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10Resolves: tdf#43220 ensure old popup is destroyed on replacementCaolán McNamara
with a new one Change-Id: I0979cea429b2d1e55835ff5a65725b84b7764201 Reviewed-on: https://gerrit.libreoffice.org/66084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10tdf#122563 DOCX import: fix OLE size after roundtripLászló Németh
Embedded XLSX spreadsheets and other OLE objects became small in Writer after a roundtrip between LibO and MSO, caused by the empty drawing path of OLE shapes. Change-Id: I4cd39d4bcd6707cc5a3b8e40dde8c6148a20cabc Reviewed-on: https://gerrit.libreoffice.org/66053 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-10PropertyValue must be a complete type here (Windows --disable-pch)Stephan Bergmann
...when instantiating implicitly defined special member functions of VCL_DLLPUBLIC FilterConfigItem Change-Id: I3128a475e9363b0dc0960fbb34e25c64c2270f69 Reviewed-on: https://gerrit.libreoffice.org/66063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10__cplusplus >= 201703L is always true now for _MSC_VERStephan Bergmann
...since 50cb96346ad54bcdb172acf11b4befe540e2b152 "Use correct __cplusplus value with MSVC" Change-Id: Ic107a8eff42b6e3961a787d1310cf4df78c26d49 Reviewed-on: https://gerrit.libreoffice.org/66064 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10Related: tdf#113205, revert add icons to extensions/source/update/uiCaolán McNamara
the packaging of these is fixed now This reverts commit 4f89c98d715592be42d8d378786d79eb27acadcb. Change-Id: Idc4a3dd3485f7eb5f9009566e431c3e2a7944cb5 Reviewed-on: https://gerrit.libreoffice.org/66077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10Resolves: ofz#12462 fix build failureCaolán McNamara
Change-Id: I6719a601b5f9e5b727406667f36a8bef93eb2adc Reviewed-on: https://gerrit.libreoffice.org/66081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10make format->page dialog asyncNoel Grandin
Change-Id: Ie2c63e2bac176002bc6616578aef2d4c763245c7 Reviewed-on: https://gerrit.libreoffice.org/66074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10make table-of-contents dialog asyncNoel Grandin
Change-Id: I839eaa820952ff39818b5ed9bd06a44eec3f39d3 Reviewed-on: https://gerrit.libreoffice.org/66069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>