summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-23tdf#120451: Use primary screen if requested screen doesn't existKatarina Behrens
Change-Id: I3e570bdeddc82f1d8cd46a362964e53527e6c152 Reviewed-on: https://gerrit.libreoffice.org/62193 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-23elementary:+ crookrotate,crookslant,^graphic, convert, smallest*, etcRizal Muttaqin
Change-Id: I8717f2b896e083712240182dc51cc79c0a001180 Reviewed-on: https://gerrit.libreoffice.org/62209 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-23clang-tidy performance-unnecessary-copy-initialization inNoel Grandin
basctl..basic Change-Id: I4009282869cd8a2f269093564bd4fafccab80ec3 Reviewed-on: https://gerrit.libreoffice.org/62212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-23Frame Contextmenu in Writer and other sw appsandreas kainz
use ObjectAlign as a Frame is an Object Change-Id: I3afd1aa08e713ae919dde8b57811a5e8cbaa4b24 Reviewed-on: https://gerrit.libreoffice.org/62198 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-23Remove redundant comparisons, copy properties unconditionallyArkadiy Illarionov
e06afb0c9546ddcde1cedd75f59001396ac6fdf2 follow-up Change-Id: Ic4449c9424c622aeabbf5be49826d68d95dd93eb Reviewed-on: https://gerrit.libreoffice.org/62195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-23tdf#120795: fix ooo2wordml_list.xsl syntaxJulien Nabet
See errors in comments from tracker Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1501df419ea4d40358d705a281fd9662088ba51e Change-Id: I9bbf970ac2b8cbf8fcc448f0847f61e8606797c7 Reviewed-on: https://gerrit.libreoffice.org/62205 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-23tdf#120773: simplify condition in sbagrid.cxx:1265Julien Nabet
Change-Id: If907fe0310f4983ddf1917c6ca88f2cebf4c45aa Reviewed-on: https://gerrit.libreoffice.org/62206 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-23tdf#100236 Implement linestyles with dash and dots.Mark Hung
Allow append dashes to have dash and dot line styles. Segment length parameters were taken from cppcanvas, also restructure the code to use the same appendDashes function. Change-Id: I17c0796dbe722c4c6d5e91d0e318570a52a2514c Reviewed-on: https://gerrit.libreoffice.org/62084 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-23Antialias drawing is part of the font selectionJan-Marek Glogowski
At least on Windows antialias-drawing has to be selected via LOGFONTW.lfQuality passed to CreateFont, so InitFont is too late. Change-Id: Ie81c5f0074fdbcf1f0e74fbff31a5df663a67884 Reviewed-on: https://gerrit.libreoffice.org/62200 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-23Implement IsUnderlineAbove in vcl::FontJan-Marek Glogowski
There was even a duplicate implementation... Change-Id: I192ac2ec8e5b8dd0e6b3ab9b9ddf0bf53df546ab Reviewed-on: https://gerrit.libreoffice.org/62199 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-22pvs-studio: V571 Recurring checkCaolán McNamara
Change-Id: I1ad7bcfa557b38488adf26b434433e6bae259f43 Reviewed-on: https://gerrit.libreoffice.org/62190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22intermediate _disposing call doesn't exist anymoreCaolán McNamara
Change-Id: Ifcc5142eaebae06634e1530abb1361cc123117f5 Reviewed-on: https://gerrit.libreoffice.org/62189 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V581 identical conditional expressions situated alongsideCaolán McNamara
Change-Id: I063bd0dbfe1d7b00e56cd4e01affa5465ae04d9a Reviewed-on: https://gerrit.libreoffice.org/62192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V560 A part of conditional expression is always trueCaolán McNamara
Change-Id: Iff61dda72f304c335a1ac6d6b56e5fce2644ee81 Reviewed-on: https://gerrit.libreoffice.org/62191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22simpler to use a vectorCaolán McNamara
Change-Id: I6acd4b042bc29dcf52d36061e897a9bae5c8cc8b Reviewed-on: https://gerrit.libreoffice.org/62188 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V763 Parameter always rewritten in function body before being usedCaolán McNamara
Change-Id: Ifd3b8b2a66a2257220f0596d31f5b545d416c748 Reviewed-on: https://gerrit.libreoffice.org/62186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22Remove ScLookupCache from ScLookupCacheMap it had been added toStephan Bergmann
...instead of removing an arbitrary ScLookupCache with a matching ScRange from the first ScLookupCacheMap that happens to contain one. 79449d73900d7a9bf061244d76f5f8eecc441198 "make VLOOKUP in Calc thread-safe" introduced per-thread ScLookupCacheMaps, so that multiple ScLookupCacheMaps can contain ScLookupCaches with identical ScRanges. For example, UITest_calc_tests6 adds ScLookupCaches for ScRange 1!R2C18:R97C18 to different threads' ScLookupCacheMaps. That causes confusion so that calling ScDocument::RemoveLookupCacheHelper to remove an ScLookupCache from a mismatching ScLookupCacheMap accesses a different ScLookupCache* pCache = (*it).second.release(); that may already have been destroyed; see failing ASan/UBSan builds like <https://ci.libreoffice.org//job/lo_ubsan/1067/>. Change-Id: I70c33b236dc502b8a98e0e313d422424eec5dbca Reviewed-on: https://gerrit.libreoffice.org/62194 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-22Look for the generated native-code.h where it now isTor Lillqvist
The makefile here was changed already some weeks ago to put native-code.h in workdir and not in the source directory, but I forgot to make sure this file still compiled, as it is used by LibreOfficeLight only. Yes, it is ugly to use the workdir/CustomTarget/ios pathname, so sue me. Change-Id: I568d933c1d1384041632f432053d0a0c64c485c2
2018-10-22-Werror,-Wunused-function (--disable-assert-always-abort)Stephan Bergmann
Change-Id: I5bdecf34dea5baf6c5ef1c48e5995c2ae8ec78df
2018-10-22tdf#119856: [Re-]activate menu before dispatching commandKatarina Behrens
Menu entry dispatchers may be cleared (after they've been initially set) when an extension comes with its own menu entries. Activating the entry sets the dispatcher again so that dispatching a command can proceed Change-Id: I3909fb5eb6e6e2fa7db0418aca17009e60f01372 Reviewed-on: https://gerrit.libreoffice.org/62180 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-22sd: Use the regular textbox popupmenu for outline text objectsMaxim Monastirsky
Having a separate menu for just one kind of a text box makes no sense. It isn't good for developers that must remember to sync changes between the two, and likewise for users which do customization, and that have to make the same changes twice. In fact both menus are identical, except that the outlinetext menu has also .uno:TextAutoFitToSize. But this commands seems to work also for other kinds of text boxes, and we actually have a request in tdf#116898 to have it in the context menu. So we can just move .uno:TextAutoFitToSize to textbox.xml, and then remove the separate outlinetext.xml. Fortunately there is no fear of losing existing user customization for outlinetext.xml, as it wasn't exposed to the customization dialog by error (no corresponding entries were added to ImpressWindowState.xcu/DrawWindowState.xcu). Change-Id: I3568cb95d862d4ab91bedfa691dcc6659a3bf86f Reviewed-on: https://gerrit.libreoffice.org/61972 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22pvs-studio: silence dodgy V763 Parameter always rewrittenCaolán McNamara
Change-Id: I4939b77dd733a6502d9a4c8e04305764ce56f3b8 Reviewed-on: https://gerrit.libreoffice.org/62187 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V670 The uninitialized class member 'm_aMutex' is usedCaolán McNamara
Change-Id: I7ac2662afe77e6e9170b004b335635f97ae03692 Reviewed-on: https://gerrit.libreoffice.org/62184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22Put quotes around a URL in a message to make it more obvious if it is emptyTor Lillqvist
Change-Id: I03fe3f70ee97066d9c2083d4ef091c501f241392
2018-10-22If we have encountered a "FATAL ERROR" we can afford writing a line to stderrTor Lillqvist
There is no guarantee that if something is wrong, the Application::ShowNativeErrorBox() will manage to show anything, is there? And this code might be invoked in a program that doesn't even have any GUI. So at least try to show the message on stderr, too. Change-Id: Ieb11a6f490c26c773af646ed7e9c3cf6ccb4a669
2018-10-22tdf#70851 render wave underlines in slideshow.Mark Hung
Change-Id: I31b2717e60b5eae6c992e27700e589938764957c Reviewed-on: https://gerrit.libreoffice.org/62035 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-22tdf#100236 implement waveline in mtfrenderer.Mark Hung
Create B2DPolygon with ::basegfx::utils::createWaveline to render the waveline. Parameters are adapted from the drawinglayer. Thickness of the line isn't really implemented yet. Change-Id: I74d05744632d5d54e439a2a3e144fa2daf4ae1bb Reviewed-on: https://gerrit.libreoffice.org/61947 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-22drawinglayer: fix bold dash dash dot overline in Impress.Mark Hung
Change-Id: Ie3fa48a6ff5cf602b1cd661e3e4053a001a4470f Reviewed-on: https://gerrit.libreoffice.org/62083 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-22cannot interact with chart sidebar as the previous deck is still activeCaolán McNamara
Change-Id: I7972ef73b8c11ae78569fa1c7dc0a244ebba3f30 Reviewed-on: https://gerrit.libreoffice.org/62181 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22Remove line commented out since 2004Tor Lillqvist
Change-Id: Icf48d2d0422dc4e757627001e4792b45208054ab
2018-10-22tdf#119596 DrawText Contextmenu in Writer, Calc, Draw, Impressandreas kainz
and all other sw modules Change-Id: Ifd7161f58170f32555134250b91e537eeada3c99 Reviewed-on: https://gerrit.libreoffice.org/61988 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-22 tdf#119625: coerce migrated Time between 0 and 24 hoursTerrence Enger
Coincidentally, remove unwarranted addition of one hour Added unit test dbaccess_tdf119625 Change-Id: I84a47c7abd4ab8e2c80d3faaf8cf4f11e1b81df3 Reviewed-on: https://gerrit.libreoffice.org/60048 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-10-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Missing space between words. Change-Id: I5731c2c00ee45d949182d17dfbebe94fa1c00be4 Reviewed-on: https://gerrit.libreoffice.org/62178 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-10-22sc: avoid checking for time formats in case of SvNumFormatType::NUMBERSerge Krot
Change-Id: I565506d58f2dd94a6c2c5e1c4a2000ce1f9752cf Reviewed-on: https://gerrit.libreoffice.org/61445 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-22pvs-studio: V716 Suspicious type conversion in return statementCaolán McNamara
https://docs.microsoft.com/en-us/windows/desktop/api/objidl/nf-objidl-irunnableobject-isrunning has IRunnableObject::IsRunning as returning BOOL unlike ::Run which returns HRESULT Change-Id: I992d8ba33502eff56b582e1cb9b73f6227c383b8 Reviewed-on: https://gerrit.libreoffice.org/62169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22Add unit test for mysqlc connectorTamas Bunth
It can be used to test the mysqlc connector whenever there is an external mysql or mariadb server running. The test runs only when CONNECTIVITY_TEST_MYSQL_DRIVER environment variable is set. This variable should contain the URL of the database, including the port number and the host name. The URL should also contain a user name password pair which can be used to connect to the external database. The URL format is the following: [user]/[passwd]@sdbc:mysql:mysqlc:[host]:[port]/[db_name] README is updated and contains detailed information about the test. Change-Id: I1bbc9369ff193a29c06de63a0f6cc975877c8da3 Reviewed-on: https://gerrit.libreoffice.org/62171 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-10-22loplugin:staticvar ignore rtfkeywd.cxx for nowNoel Grandin
Change-Id: I2bd26bcad94aa905f0c87d92b43561855409e330
2018-10-22Let CppuniTest's unoexceptionprotector handle uncaught exceptionsStephan Bergmann
(it nicely prints exceptions' messages, too) Change-Id: I66bb4fd856d0249a7dc5bc58975b6ea322f9a9ca Reviewed-on: https://gerrit.libreoffice.org/62165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-22Resolves: tdf#120785 no parent set via status barCaolán McNamara
Change-Id: Ibdc0f75b18330b77e18293f7485e165d2133290e Reviewed-on: https://gerrit.libreoffice.org/62179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22Disable loplugin:staticvar for nowStephan Bergmann
produces false positive > [CXX] svtools/source/svrtf/rtfkeywd.cxx > /home/sbergman/lo/core/svtools/source/svrtf/rtfkeywd.cxx:38:23: error: var should be const, or whitelisted [loplugin:staticvar] > static RTF_TokenEntry aRTFTokenTab[] = { > ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ Change-Id: I7cd96988218d1192ced2fadff911c7ec89088012
2018-10-22tdf#120703 (PVS): redundant nullptr checkMike Kaganski
V668 There is no sense in testing the 'pMed' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Ia630fd30d86e9b8f9ce85077edbd949274bbee70 Reviewed-on: https://gerrit.libreoffice.org/62125 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-22Resolves: tdf#120731 crash in border tabpageCaolán McNamara
Change-Id: Id11b8fdc91e552a38a78f13df410f4d364e7acbf Reviewed-on: https://gerrit.libreoffice.org/62170 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#119506 Draw Contextmenu in Writer, Calc, Draw, Impressandreas kainz
and all the other sw modules Change-Id: Ie407f858bf1d17f3af4c2948fcd4cb40bc9e8c92 Reviewed-on: https://gerrit.libreoffice.org/61963 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22tdf#119547 Media Contextmenu sync in all appsandreas kainz
similar layout to graphic Change-Id: Id97460cdeb1db62326b7cb2e7655a39af2c1ae99 Reviewed-on: https://gerrit.libreoffice.org/61962 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22NB tabbed calc: finishing correct padding and final tab reviewandreas kainz
Change-Id: Ib0bb557a2a98d8256182aab29b98b953ffc9c7a4 Reviewed-on: https://gerrit.libreoffice.org/62172 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-22tdf#120410: Disable insert/delete row/page break if sheet is protectedXisco Fauli
Follow-up on f7982d4dfa85f15a6f0c25e9795a5847ecfcbf31 Change-Id: I2defd3474fdbb0b87898df7734bb076ab95c8c08 Reviewed-on: https://gerrit.libreoffice.org/61950 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-22loplugin:staticvar ignore this case for nowNoel Grandin
Change-Id: Ic0e5e113ff16dbb3fb246c52f5a2fee8d9f52304
2018-10-22pvs-studio: silence V649 dubious Two identical 'if' statementsCaolán McNamara
Change-Id: I303b4db52e852011d45a147f3010a8f934c1f77b Reviewed-on: https://gerrit.libreoffice.org/62167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120176 - Text appears as white on first launchheiko tietze
Splash screen text should be black now Change-Id: I963ffc89c48fdc1de148586cd6f0fb4bf35d44bd Reviewed-on: https://gerrit.libreoffice.org/61924 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22tdf#120034 - Position of New > Master Document questionableheiko tietze
Item moved above Templates... Change-Id: I813544bbfb76c34dd3e73daf87d8d5ea1478240b Reviewed-on: https://gerrit.libreoffice.org/61787 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
generated by cgit (git 2.34.1) at 2025-03-15 04:18:51 +0000