summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-01tdf#54938: Adapt supportsService implementations to cppu::supportsServiceCanberk TURAN
Change-Id: I82fa5528c879f288822fe9795d7d7da19f0abbee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87485 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-01android: Set the correct path for the liblangtag data.Jan Holesovsky
Change-Id: I8b8bf76f086812c5f995c6ef513f0b7f773475ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87787 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-02-01android lok: Correct the hint in the slides from click to double-tap.Jan Holesovsky
Change-Id: I71744dc48f50115c9b4245ac2c81a6431ecbdce6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87678 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins
2020-02-01std::unordered_set<T*> -> o3tl::sorted_vectorNoel Grandin
which is much better for CPU cache, since the representation is more compact, and since we almost always do insert() in pointer order, there is surprisingly little sorting Also add a count() method for compatibility with std::set and the proposed std::flat_set Change-Id: I2a3211dc59919cfec5cac1497530a4c3600d50ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-01Skia: fix #define MemoryBarrier coming from winnt.h from pchMike Kaganski
... resulting in error message C:/lo/src/build/workdir/UnpackedTarball/skia/src/gpu/gl/GrGLGpu.cpp(3771): error C2039: 'f__faststorefence': is not a member of 'GrGLInterface::Functions' Change-Id: If69c0067abe287dd276c685cde6be3b31a1ce950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87780 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-01std:set->o3tl::sorted_vectorNoel Grandin
which is always a better choice when dealing with pointers, for 2 reasons: way more cache dense, and we very often iterate pointers roughly in-order, which means very little sorting needs to be done Change-Id: Ib38f56018b2fc16414c9af910421cc45f069e1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87782 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-01git hooks: update commit-msg to Gerrit 2.16.15Jan-Marek Glogowski
This mainly replaces the whole AWK code with the git helper "interpret-trailers", which was added in git v2.2 end of 2014. It also moves the argument checks from the original Gerrit hook to the front of our tests to verify the script arguments. Change-Id: I38c831bf7c9d399419a598d6966e48166d31ea6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87369 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-31Fix typoAndrea Gelmini
Change-Id: I7341d932b4d88cfd540056ff292b8ad003af6830 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87779 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-31tdf#129240 More date acceptance patterns for Hungarian languageKelemen Gábor
Now cell values matching these patterns are accepted as date: 2019-12-24 2019.12.24 2019.12.24. 2019. 12. 24. 12-24 12.24 12.24. 12. 24. Change-Id: Ida08deb054fd29aef5d941626c8225732e447662 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85385 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-31loplugin:unusedfields improve checking for fields guarded by existence checkNoel Grandin
which resulted in only a couple of real finds, mostly false+ Change-Id: I26058a29c27bff50e9526bedd54fb04589c2934d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87765 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31loplugin:singlevalfieldsNoel Grandin
Change-Id: I77ccf3f36363e182a644b98cdf720f1381a5cceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31tdf#45589 offapi,officecfg,sw: add option to toggle bookmark displayMichael Stahl
Create specific option to toggle display of the bookmark positions instead of relying on generic IsViewMetaChars(). Add a Bookmarks checkbox to Writer->Formatting Aids page in Options. Add property ShowBookmarks to com::sun::star::text::ViewSettings. Add config setting: org/openoffice/Office/Writer/Content/NonprintingCharacter/Bookmarks Change-Id: I998ecdc16d8e4a5baeeb1bbcff0bf5f1f5636692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87774 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-31update Skia to chrome/m81Luboš Luňák
Change-Id: I62ac293ac5fde3716b2db1421301f3a4aed0bcc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87763 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-31fix uninitialized memory in SkiaLuboš Luňák
SkRect is actually a struct without a ctor, so it's not initialized. Change-Id: Icd8fe46230502a1f7aaf7c766a251b3d27070f66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87764 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-31tdf#83248 Print using the right color for other components too.Arnaud Versini
PDF and printed documents should be the same. Change-Id: I34f43688f4ec8945c65a414bc0d955dea45dc9b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87761 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31tdf#130032 Chart OOXML Import: fix data label custom positionBalazs Varga
in case of all chart types except pie chart. Clean up commit 4223ff2be69f03e571464b0b09ad0d278918631b (tdf#48436 Chart: add CustomLabelPosition UNO API property). Note: use the correct default OOXML label placement in case of radar charts. Change-Id: I9a8f509304b3c70d879c8c6a95bc91d15ac28521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87759 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-31new loplugin:namespaceindentationNoel Grandin
check indentation of braces in namespace decls, and the comments that often appear with them. This is my penance for messing up the indentation with clang-tidy-modernize-namespaces. As such I have limited it to new-style namespaces for now, and the check is off by default. Change-Id: I4db7f10a81c79bc0eece8f8e3ee564da8bc7f168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31tdf#130287 disable orphan/widow control in Table ContentsLászló Németh
paragraph style to avoid missing text lines later in vertically merged table cells at page break. From commit 49f453755b72654ba454acc321210e8b040df714 ("tdf#89714 - enable Widow/Orphan in default style"), Table Contents got unnecessary orphan/window control. Unfortunately, recent table layout code cannot ignore these settings completely, causing known problems, see for example tdf#128959 (FILEOPEN DOCX Table row content disappears when broken between pages). Change-Id: Idd570f17b0a11af85072a65f3422535b993db306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87730 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-31Related tdf#105225 Remove unused backgroundpage.uiJim Raykowski
Change-Id: I8ddf92d9b349ed8884c971e08c124dba1efc4142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85792 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-30DOCX export: write document variablesMiklos Vajna
This means that in case a user field is exported to DOCX and the user updates the field, the result will be still correct, not empty. Change-Id: I2b52292c70aa6f597f92af95e16c773839247efa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87748 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-30cid#1458033 Dereference after null checkCaolán McNamara
pEntry isn't goint to be null, drop the null check Change-Id: I41447afe17fc69d6ca30387f1b74f23f86f6d109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-30loplugin:unusedmethodsNoel Grandin
Change-Id: Icab9a4789b0bb9187ad5393a2b8578fc4c5e401f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87736 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-30tdf#130219 change labels in Case dropdown box in Font Effects tabSeth Chaiklin
- change "Title" to "Capitalize Every Word" - change "Lowercase" to "lowercase" - change "Capitals" to "UPPERCASE" Change-Id: I67145a384b0220924184b8bc279fb702d8c9f379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87684 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-30Update ICU RegexMatcher::setTimeLimit() documentation link to new locationEike Rathke
Stumbled upon in a side step of grepping for icu4c. Change-Id: I3f9cda5239e265258c7dc7a6a0689b3bc5f052ac
2020-01-30tdf#129237: Add unittestXisco Fauli
Change-Id: Ica8942e6f165afad1ed40457ec86bd20713a1a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87744 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-30tdf#124176: Use pragma once instead of include guardsbugrakurt
Change-Id: Ia353a95df0e78e9da2b6fb95c2bc3a6e83c72fcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87738 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-30loplugin:unusedfieldsNoel Grandin
Change-Id: Ifb9c91b3e8d6c2dd3a639a239fa41e7d5c7a4ee6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87735 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-30tdf#129659 DOCX check global footnote contextJan-Marek Glogowski
Since tdf#121441 we parse custom footnotes to get at least the DOCX footnote text, even if we can't represent the formating. This might push additional contexts to the parser stack. Therefore it's now not sufficient to check the current context for a footnote, but one has to check the global parser for a footnote context. The actual bug is the unsupported footnote page break, which was not correctly ignored and added a paragraph context to the stack, resulting in the async substream input and output stack size. Change-Id: I143254e7df37a619cb4efb542b58d3eff3afffa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87114 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-01-30again finally(?) fix Skia Windows widget drawing (tdf#130051)Luboš Luňák
I was correct to see in 202146901b6fbab92 that the black bitmap was in premultiplied alpha, but what I missed what that some controls keep the alpha set at zero (and only some work properly). So go back to the algorithm of synthetizing alpha from the red channel, compute it properly (before it was using alpha channel by mistake), and treat the data properly as premultiplied. This hopefully finally makes all Windows control widgets work. Change-Id: If2716eb8ecf623fcc57ee1db5904edfaee679aa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87734 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-30tdf#45589 sw: create and paint text portions for bookmarksMichael Stahl
Add a new SwBookmarkPortion, derived from SwControlCharPortion. There is no character for the bookmark in the text so the portion has length of 0, which makes things quite a bit more tricky. Formatting: * SwBookmarkPortion is created last in WhichFirstPortion(). * In an empty paragraph the SwTextFrame::FormatEmpty() must be disabled. * If there's a bookmark at the end of a paragraph, SwTextFormatter::CalcAscent() must use the font of the previous character, not the paragraph font, because that could grow the line if it's higher. * The SwMultiPortion complicates matters, because it uses a nested SwTextFormatInfo and thus we need some extra steps to prevent duplicate SwBookmarkPortions; this is particluarly a problem for rotated text portions. - SwTextFormatter::BuildPortions() must advance the outer SwTextFormatInfo's bookmark position because BuildMultiPortion() has already created the SwBookmarkPortion. - If a SwBookmarkPortion is at the start of a SwMultiPortion, it will be created before the SwMultiPortion but must be painted inside the SwMultiPortion because its font is going to be initialised as inside the SwMultiPortion (e.g. it will be rotated) so its position must also be adapted to be inside, and only SwTextPainter::PaintMultiPortion() does the setup for that; add a hack to move it in SwTextFormatter::BuildMultiPortion(). Painting: * Using the original font seems rather difficult, hard to predict what some character is going to look like, and how it scales if the size is increased; use OpenSymbol instead. Unfortunately OpenSymbol doesn't have a good glyph that could be used for both the end of a bookmark and start of another bookmark at the same position. * SwLinePortion::PrePaint() wants to avoid moving the portion half-outside the frame but often it looks better that way (previously it was misaligned, now it's half-outside). * Not sure if it makes sense to draw a field shading in SwTextPaintInfo::DrawViewOpt() too; let's try it out, but dependent on the same IsViewMetaChars() setting as the bookmark character itself, not on the field shading setting. Change-Id: I1ab94afb417221e278dbb3afd6c978a05fc78497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87364 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30sw: fix rotation bugs in SwLinePortion::PrePaint()Michael Stahl
The sign was flipped for the 90° case, resulting in painting too far up the page, ever since this was added in 293ed704cf15107049578c2e6e5ed00dcac2d4fb. In SwControlCharPortion::Paint() rotation wasn't handled at all. Change-Id: I83a7eef8b2f6126e070d8c48f75378b6cf6d50e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87707 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30sw: reformat bit of SwLinePortion::PrePaint()Michael Stahl
Change-Id: Id088e3f73e6bda3c6b11d421a52c59c67446f8a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87706 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30sw: these SAL_WARN_IF should be assert()Michael Stahl
Change-Id: Ifddea3cd34f419d9b8b87a3f913be590ad4d5ce7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87705 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#45589 sw: split text portions at bookmarksMichael Stahl
Always create the portion, not just when the IsViewMetaChars is active. This has the advantage that nothing has to be invalidated when toggling, and the disadvantage that kerning at bookmark positions will never happen. Change-Id: I78943f337eef5c64cff33f6df6ff1a10acb1b8bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87363 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#45589 sw: add bookmarks to SwScriptInfoMichael Stahl
Add a list of bookmark positions in the text frame to SwScriptInfo. Initialising this turned out to be more complicated than expected. Change-Id: I1738186b057b0eece80177097a03826365107589 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87202 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#45589 sw: invalidate on bookmark insertion/deletionMichael Stahl
Invalidate the text frames when a bookmark is inserted or deleted; also when MarkManager::repositionMark() changes the positions. The other calls of SetMarkPos()/SetOtherMarkPos() look like they're all from code that corrects positions after text insertions or deletions so no additional invalidate should be necessary there. It turns out that one WW8 document in sw_filters_test wants to insert a bookmark on a SwGrfNode; check for that in makeMark(). Change-Id: I293e6da9042bea5992cb27091b9cff77e5c7961d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87157 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#129237 just add content checks for Input fieldsJan-Marek Glogowski
There seems to be fields with content values, which don't use it as the presentation value. So this reverts the content handling code back to the original one and just checks the content value from Input fields in addition to the SetExpression fields. Change-Id: I2abd227883035c559b1fc3f7aacf10769b0e79a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87093 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-01-30tdf#124176: Use pragma once instead of include guardsbugrakurt
Change-Id: I15f9cbce2344cebbe73a915758ce1631f46d7da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87721 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-30Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' to 35281f4c9178f373609a61f0a44e268b179c5749 - tdf#127566: don't change divcopyable border width in onclick handler Instead, define border width in respective CSS, to make it consistent in both clicked and non-clicked states, and avoid "jumping" on click. Change-Id: Ic8ab8d0fd586059e21de6aa866fef95226774acf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87718 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-30DOCX export: implement support for user fieldsMiklos Vajna
Updating the field doesn't work yet, that'll need additional markup in settings.xml. Change-Id: I562ae62cebcbd5ca474bd0f7a181773f8e515f5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87720 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-30tdf#48436 Chart: add CustomLabelPosition UNO API propertyBalazs Varga
and CUSTOM DataLabelPlacement to support custom data label positions, and its initial implementation: only UI support with OOXML import (tdf#130030), yet. Change-Id: I01d986071d78ae3e2a5f43d5711e9f60b8410c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86859 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-30tdf#42949 Fix IWYU warnings in avmedia/Gabor Kelemen
Except for MAC and WIN specific parts Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I1066aa31f45a8c81ddaa7d52d7c81aa09741c8d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87312 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-30slider.hxx has no need to include field.hxx anymoreCaolán McNamara
Change-Id: Ib612df11eda9afe5b8e5610b3caf520bf8668e6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-30mpLinkedField is never setCaolán McNamara
Change-Id: Ib774c57e9137979fc3f70d4798f1b875b99e4ea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-30Revert "SwAutoCompleteClient: SwClient no more"Stephan Bergmann
This reverts commit fa26db1c053a8510ada15fcbaa7e36ae0f6920a5 for now, as it breaks UBSan builds during e.g. JunitTest_sw_unoapi_1 (<https://ci.libreoffice.org/job/lo_ubsan/1518/>): > /sw/source/core/doc/acmplwrd.cxx:138:9: runtime error: member access within address 0x607001517be0 which does not point to an object of type 'SwAutoCompleteClient' > 0x607001517be0: note: object is of type 'SvtListener' > af 07 80 42 d0 8e 97 f4 84 2b 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 04 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SvtListener' > #0 0x2b85787e94b6 in SwAutoCompleteClient::Notify(SfxHint const&) /sw/source/core/doc/acmplwrd.cxx:138:9 > #1 0x2b84f3d5d886 in SvtBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/broadcast.cxx:128:25 > #2 0x2b84f3d5c07a in SvtBroadcaster::~SvtBroadcaster() /svl/source/notify/broadcast.cxx:96:5 > #3 0x2b857812fdc4 in sw::BroadcasterMixin::~BroadcasterMixin() /sw/inc/calbck.hxx:84:24 > #4 0x2b857af251c4 in SwPageDesc::~SwPageDesc() /sw/source/core/layout/pagedesc.cxx:127:1 > #5 0x2b857af25234 in SwPageDesc::~SwPageDesc() /sw/source/core/layout/pagedesc.cxx:126:1 > #6 0x2b8578f2c550 in SwDoc::~SwDoc() /sw/source/core/doc/docnew.cxx:466:9 > #7 0x2b857892a9c3 in SwDoc::release() /sw/source/core/doc/doc.cxx:117:9 > #8 0x2b8579d1efae in rtl::Reference<SwDoc>::clear() /include/rtl/ref.hxx:159:19 > #9 0x2b857e12fd44 in SwDocShell::RemoveLink() /sw/source/uibase/app/docshini.cxx:438:16 > #10 0x2b857e12eac7 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:366:5 > #11 0x2b857e12ff2b in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:356:1 > #12 0x2b857e130104 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:356:1 > #13 0x2b84edcb1a4a in SvRefBase::ReleaseRef() /include/tools/ref.hxx:163:29 > #14 0x2b84edcb1020 in tools::SvRef<SfxObjectShell>::~SvRef() /include/tools/ref.hxx:56:36 Change-Id: Iaf1cb698bf898efc66a3abaa1c8bfd3116b389b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87715 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-30vcl: fix UB in vcl::Cursor::ImplDoShow()Miklos Vajna
pWindow->mpWindowImpl can be nullptr here, see online.git's unit-load-torture test: vcl/source/window/cursor.cxx:204:54: runtime error: member access within null pointer of type 'WindowImpl' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior vcl/source/window/cursor.cxx:204:54 in (And one more similar case in Window::ImplGrabFocus().) Change-Id: Idd145082b58c10139be53e9b997efedeb0cec364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87709 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-30new (but unused) refassign lopluginNoel Grandin
which I wrote to check if there were any other cases where assigning to a ref local var looks dodgy, after my fixes in 0b113d6ebbaf923e11ba576bed2691bb68e95ae6, but I didn't find anything, so just leave this one in store Change-Id: Ib820924c5e8aa85206730afeb06972ef48231ec5
2020-01-30tdf#129625 Calc Navigator: Gray out content types with no contentJim Raykowski
Change-Id: I298894bbb338b97fe6891e33b23f16302acaec37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87714 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29tdf#124176: Use pragma once instead of header guardPelin Kuran
Change-Id: If7c8b03238889a084070d9e96133b5cccecbe807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87660 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
generated by cgit (git 2.34.1) at 2024-12-29 00:46:15 +0000