summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-12-28drawinglayer: improve logging for PenDataCompoundLine recordChris Sherlock
Change-Id: Ibc89724ceb52d5ad964767e844c4807d85f639c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84839 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-12-28tdf#124176: Use "pragma once" on xmlscript/*Andrea Gelmini
It passed "make check" on Linux Change-Id: Id8727da150ad1b5252fbc997ff5df28b23303fb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85882 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-28tdf#124176: Use "pragma once" on accessibility/*Andrea Gelmini
It passed "make check" on Linux Change-Id: I62f45125264e15a8edd8a48964ec78c4a9598485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-28Fix typoAndrea Gelmini
Change-Id: Iebf4da702da03d9888bad314eb401cff6a26bd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85903 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-28tdf#124176: Use "pragma once" on udkapi/*Andrea Gelmini
It passed "make check" on Linux Change-Id: Ifb37ad620ccafe568e2b2d7ab350d444b18b7b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85898 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-28tdf#124176: Use "pragma once" on svtools/*Andrea Gelmini
It passed "make check" on Linux Change-Id: I29c8f695c499652387ee2f0fffeccd46c3ec8e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85913 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-28tdf#124176: Use "pragma once" on UnoControls/*Andrea Gelmini
It passed "make check" on Linux Change-Id: I4b0427e86063de0d4b1fd916ab4dfb1505db5a04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85888 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-28UITest: fix spellDialog.SpellingAndGrammarDialog.test_tdf46852Mike Kaganski
Two problems were present: 1. If local system default locale is not en_US, then in created document, text has some other language initially; and instrted text also gets this language. This may result in no replacement suggestions for the spelling errors, and "changeall" is not active, so expected sequence of changes and clicks does not happen. Fixed by setting language at cursor before paste explicitly. 2. On Windows, the returned text has \r\n paragraph breaks, which didn't match the regex having \n. Fixed by postprocessing the text before match. Change-Id: I320fc62c3c27dfe699fb45669c081df30cb66d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85877 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-27acc. check: check document default language and style languageTomaž Vajngerl
This checks hat the defualt language of the document is set and in addition that the used styles also have the default language set. Accessibility requires the language always be set. Change-Id: I6ea36e6e8b30289cdb35311da9470f856a847b38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85854 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-27Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to d3ef8cc77967993569abb0681c2ea66a9959c830 - remove "presentation" from text not related to Impress Change-Id: I0c2922daed1c35cdc7f6bb529ea1456886e26979 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/85863 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-27tdf#129533 Calc crashes on Navigator click or moveNoel Grandin
regression from commit 5bcdbf03012e9d2754c3eb166bd5a01201406d9b Date: Fri Dec 13 20:45:33 2019 +0200 sc: rowcol: tdf#50916 convert Valid* methods Change-Id: I0357b125653821ae552cb270f0d64598feedffa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-27Fix typoAndrea Gelmini
Change-Id: Ibd3ece30c6cbb9582904adc5e329f54d41cff33b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85872 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-27tdf#129423: Make export tests export-only where applicableayhanyalcinsoy
Change-Id: Ib2ec1a6a3af553b416211180a3dc13862ef69665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85858 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-27tdf#124176: Use pragma once instead of include guardsGökay ŞATIR
Change-Id: I018548a2875936f463ae41784ef5d16cb54127bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85781 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-27tdf#125901: apply color modifiers when drawing hatchAndrés Maldonado
With this fix, the shadow of a shape with a Hatching fill is no longer the same color as the hatching (in full screen mode) Change-Id: I979866e748b5caf2ccafc8a6084ffdb46bc8122c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/73964 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-27Fix 32-bit gcc Unit Test Failuresslacka
This relaxes the tests to work around a precision error with gcc7-9. No issue with 32-bit clang. Change-Id: I0222bc91243e461408b4e611953355492975ff4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-27tdf#46037: simplify is/get methods in svtools/printoptionsJulien Nabet
Change-Id: I4358cfdbb2dbd7ad8d3cc7de82163303d403a8ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-27sal_osl_security: Windows: Handle cases with same hostname and usernameMike Kaganski
... as seen in [build CUT] sal_osl_security #Initializing ... # #logonUser function need root/Administrator account to test. #You can test by login with root/Administrator, and execute: #testshl2 -forward "username password" ../../../wntmsci9/bin/Security.dll # where username and password are forwarded account info. #if no text forwarded, this function will be skipped. # #Retrieved system information is below: Computer Name: SOMENAME Current User Name: Somename Current User Home Directory:file:///C:/Users/Somename/Documents Current Config Directory: file:///C:/Users/Somename/AppData/Roaming Current UserID: S-1-5-21-1234567890-123456789-123456789 Current User is: NOT Administrator. # #Initialization Done. osl_Security::ctors::ctors_001 finished in: 0ms osl_Security::UserProfile::loadUserProfile finished in: 0ms osl_Security::UserProfile::unloadUserProfile finished in: 0ms osl_Security::getHandle::getHandle_001 finished in: 0ms osl_Security::loginUserOnFileServer::loginUserOnFileServer_001 finished in: 3ms osl_Security::getConfigDir::getConfigDir_001 finished in: 1ms C:/cygwin/home/Somename/lode/dev/core/sal/qa/osl/security/osl_Security.cxx:139:osl_Security::getUserIdent::getUserIdent_001 equality assertion failed - Expected: S-1-5-21-1234567890-123456789-123456789 - Actual : S-1-5-21-1234567890-123456789-123456789-1001 - strUserID: S-1-5-21-1234567890-123456789-123456789, strID: S-1-5-21-1234567890-123456789-123456789-1001, bRes: true osl_Security::getUserIdent::getUserIdent_001 finished in: 0ms osl_Security::getUserName::getUserName_001 finished in: 1ms osl_Security::isAdministrator::isAdministrator_001 finished in: 0ms C:/cygwin/home/Somename/lode/dev/core/sal/qa/osl/security/osl_Security.cxx(139) : error : Assertion Test name: osl_Security::getUserIdent::getUserIdent_001 equality assertion failed - Expected: S-1-5-21-1234567890-123456789-123456789 - Actual : S-1-5-21-1234567890-123456789-123456789-1001 - strUserID: S-1-5-21-1234567890-123456789-123456789, strID: S-1-5-21-1234567890-123456789-123456789-1001, bRes: true Failures !!! Run: 9 Failure total: 1 Failures: 1 Errors: 0 The problem here is that passing a string equal to hostname (case-insensitive) to LookupAccountNameW without domain qualifier returns data for local system domain, not for user with the same name. So let's try again, this time with fully-qualified user name including local domain part. Change-Id: I15f69c01dddf15782bd11a6ed6678f0a02d79786 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85859 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-27Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to ddc11f101ee5d5173b1bae4be4024c0971608c57 - corrections in Chapter numbering help Change-Id: Id0a611048dc38a36666f1915fdda1268c96f2b89 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/85597 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-27Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 0d5e87292a0ec17d95497e9cd6d086d766f5aaae - add missing menu item for setting slide/page background Change-Id: I537809905ffa2dc5d1516cf6c4123e05be303afb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/85862 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-27Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 3536fcd42277d9bd39666f0f01dc06088c055274 - correct name of Transformations toolbar and menu path to it Change-Id: I49249de9ae0872ca2d523b11716c0a8e4cf9de39 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/85860 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-27Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to b3b2aa31c1e0759a60518a7e455687236ea33578 - corrections in help page for Numbering Style - used design guidelines for menu items and help - corrected labels to match dialog boxes Change-Id: I3900bec436135965a64c918a2b49883f83686303 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/85726 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-27acc. check: check hyperlink text doesn't contain the linkTomaž Vajngerl
The hyperlink text shouldn't be the URL too - for example the text shouldn't be "http://www.example.com" Change-Id: I69f7a742705aaa25da1a832ab05922d138b8ea0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85853 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26acc. check: detect fake numberingTomaž Vajngerl
Detect fake numbering, where numbering is not done using the Writer integrated numbering. This is done by checking the pattern how the paragraphs start. If paragraph starts with "2." (for example) and previous paragraph starts with "1.", then this is possible a fake numbering. Currently checking "1.", "(1)", "1)", "a.", "a)", "(a)". Change-Id: Ibdb725d944f50208c6c951531e291183244f38e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85847 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26acc. check: shorten var. name for acc. issue collectionTomaž Vajngerl
m_aAccessibilityIssueCollection to m_aIssueCollection Change-Id: I979d60aaf5963c0fa0fb58fc2e0a89b77858110b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85846 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26acc. check: Introduce NodeCheck for accessibility checks on nodesTomaž Vajngerl
NodeCheck responsibility is to check a node for accessibility issues. For each node there are multiple node checks executed and currently there are 2 node check implementations: - NoTextNodeAltTextCheck - TableNodeMergeSplitCheck These 2 checks are converted from the current checks in the code. Change-Id: Idde7092536f094d936aa3d353f4512949ca36a60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85839 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26Test for B2DRangeTomaž Vajngerl
Change-Id: I8a616e4bbea8ec597f94c1b179b4e2221d10fcdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85836 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26use more TOOLS_WARN_EXCEPTIONNoel Grandin
so we get more useful log messages when stuff goes wrong Change-Id: Ia55db7ab1a4d79b0f281673fbbb06c61745fa89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-26tdf#129004 Make shift+F6 cycle order reverse of F6Jim Raykowski
Change-Id: I52013b4c54ef5e457d9fa19210d08d9c042fed45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/83637 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-12-26AccessibilityCheck iface, namespacesTomaž Vajngerl
This adds AccessibilityCheck interface into svx, which also requires addition of namespaces as there is now AccessibilityCheck interface and the implementation in sw (sw::AccessibilityCheck). Change-Id: If7065cdab90b02478c57f22afb7ca716d70b8dce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85837 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26Fix typoAndrea Gelmini
Change-Id: I80aae5ad98e7275bd266e1295e6988dc202649a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85840 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-26Fix typoAndrea Gelmini
Change-Id: Ia67b44260849365c0e48b096d416bdfae4bac040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85842 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-26Fix typoAndrea Gelmini
Change-Id: I68be4291bdcd5a2ee1b6b4ec49f8eda07d7554f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85841 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-26tdf#125516: OpenGL: blacklist Intel drivers 26.20.100.6861 - 26.20.100.7463Mike Kaganski
Change-Id: I55104ac6881640ecbedfadb2316e3d10e1bea157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85833 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-26acc. check: add check for TablesTomaž Vajngerl
Tables shouldn't use splitted or merge cells. Change-Id: Ife6726413d9dd1ead098c081e03f4f82540f1012 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85827 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26Extract accessibility checks to it's own functionTomaž Vajngerl
Change-Id: I986b863d152b515927c62785bfed39354559a743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85822 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26Accessibility check dialogTomaž Vajngerl
This adds the accessibility check dialog which is responsible to show all the accessibility check issues in the current document. Currently this just shows the text message in a list that comes from AccessibilityCheck. Change-Id: I8fd27038e3d85cd31fe172eee5e391fd4b7243ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85821 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26No need to pass string literals as char* hereMike Kaganski
The point is creating OUString from ASCII anyway Change-Id: I9b1e96c41bc13d924bd6194812a7230e2dd6ab78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85830 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-26tdf#129597: Add missing group propertyXisco Fauli
Change-Id: Icb172fc1e41510f3a2f5caf9a9270bf0dbb9bb4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85783 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-26tdf#129423: Make export tests export-only where applicableOnur Yilmaz
Change-Id: I9af1c59d1c68432d7ab7c7ef24b6ddbc3e40536f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-26tdf#129423: Make export tests export-only where applicableOnur Yilmaz
Change-Id: I873b43450e82de3a908fa7726902abd09fee22a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85816 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-26tdf#129423: Make export tests export-only where applicableOnur Yilmaz
Change-Id: I7c4087535c03cd4e89e5cc983e07ac8c7b7daa79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85825 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-26sidebar: no scrollbar in LOKAshod Nakashian
Scrolling in LOK is done in the client. We render the sidebar as long as the original height is (the minimum that will fit all panels) and scroll in the client. For that, we keep the scrollbar disabled when layouting the Deck. Reviewed-on: https://gerrit.libreoffice.org/84720 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 09ddec08eaa0af1ca6a5f8a376abae9e62fe2607) Change-Id: If0d813b04af679768f80ee88fc976bce9cde46d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85785 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-26Accessibility check base functionalityTomaž Vajngerl
This adds AccessibilityCheck class to writer, which perfors the accessibility check of the current document to make the document conform to PDF/UA requirements. The first check this adds is check for the "alt" (sometimes also called "title") to be present for graphics, OLE objects (charts) and shapes. Change-Id: I98dcca787099bdb17cab9291546074cdde2ae5a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85820 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26Add accessibility check to the Writer menuTomaž Vajngerl
Change-Id: I7e4c3267288b238583822489c8098e64319dda16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85819 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 9f6f0686069ee1ae3c59d6eea0bdc5fa9374df1c - Update insert menu for Impress plus some adjustments in submenus Change-Id: I4541ddb53b85d5cde73ca46338ef0ef2d2eb57b6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/85823 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 35b7e0d6f9bf2d1c707e1c060486d57e72210e39 - Update Media submenu Select entries depending on the module Change-Id: Idebf08491ed8b6222131106fd916bc247fc2d842 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/85815 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 63ad3a08194a822ef5283f271dd6c30a06fad9ea - Update Calc Insert menu Many refactors and updates as consequence Change-Id: I931aed4a2659b7bbf3622dd33a83b2596ae6f32e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/85814 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-25tdf#125830 Change redaction toolbar to more simpleRoman Kuznetsov
Change-Id: I8d55b5abdc0168fdce3af3e9df1b5db95e82aab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85777 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-12-25sfx2: sidebar: publish created notification on Mobile tooAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/85011 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 50af967b731495be6645f065fd11b9ad832a654a) Change-Id: I59e5db039a6c1f29cb13e7c77a782659dbfb6894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85786 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>