summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-04-15starmath: Fix bounds checkingTakeshi Abe
Change-Id: I6b7eae01838eaf8138f777c0a9e84a3ad9f97082 Reviewed-on: https://gerrit.libreoffice.org/24078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-15Related tdf#88502 Add default XCommandEnvironment to ...Giuseppe Castagno
... Content::getResourceType During WebDAV operation the css::ucb::XCommandEnvironment is almost always needed. Depending on the operation, sometimes the client doesn't set it, in order to disable the exception processing that takes part in ucbhelper::cancelCommandExecution. Change-Id: Ib4bf6a7ca3a902437cab9050c3e310342c655ff2 Reviewed-on: https://gerrit.libreoffice.org/23327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-15svx: Remove unused stringsSamuel Mehrbrodt
Change-Id: Ib5e2ae7ba7ca543f0f03ce4296b60ce4bddf75b9 Reviewed-on: https://gerrit.libreoffice.org/24102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-15add CVE-2016-0122 testCaolán McNamara
Change-Id: I065f6d7c62ffa604fc5cc3e522c991068652c8bb
2016-04-15fix case when fileName lacks "/MacOS/"Douglas Mencken
Change-Id: Ic89d1c3be1939c8989ad5ee806980e8904f8e44d Reviewed-on: https://gerrit.libreoffice.org/24069 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-15remove tools/solarmutex.hxxNoel Grandin
Deprecated in favour of comphelper::SolarMutex Change-Id: I159077562660de5df25601fa471447f4b64a2cf1 Reviewed-on: https://gerrit.libreoffice.org/24079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15SVG: Add unittest for ecc7f698b5f080530f006218fa3dd82da43d9abbXisco Fauli
Change-Id: Icbfd60bd15196649011919e8dea064276e1964b0 Reviewed-on: https://gerrit.libreoffice.org/24097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-04-15loplugin:passstuffbyrefStephan Bergmann
Change-Id: I5c2883dab8045e70467c6d09a75dcb423eecf702
2016-04-15typo: Aggegration -> AggregationAndras Timar
Change-Id: Ica0bef9d0ac4a5d6a2c01a1f5abf859817713f85
2016-04-15RtfAttributeOutput::StartRuby: guard against nullptr pRubyTextMiklos Vajna
The member function checks for nullptr earlier, so check everywhere to be consistent. Change-Id: Ic357551dd95affe50ff6ef3cfdd44e36af9a0c38 Reviewed-on: https://gerrit.libreoffice.org/24101 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-15tdf#95079 added a few things to techincal.dicdanielat998
Change-Id: I1e78df2d088152194dd29114d6390fa6bfe993a4 Reviewed-on: https://gerrit.libreoffice.org/24065 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-04-15Updated coreAdolfo Jayme Barrientos
Project: help 9a2a76302f6c7143286b5c66b63eee5c7c9a1281 Repeated word Change-Id: Ice349b2a0e4aa812724dba94ae6b1f880ccf4b78
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
...where NoSymbol is apparently defined as zero in X11/X.h (though the X11 docs at <http://www.x.org/releases/X11R7.7/doc/libX11/libX11/libX11.html> are silent about that), even though XKeysymToKeycode is specified to return zero, not NoSymbol, if "the specified KeySym is not defined" (<http://www.x.org/releases/ 11R7.7/doc/libX11/libX11/libX11.html#id2813072>); lets assume NoSymbol /is/ zero, and static_assert that assumption Change-Id: Ib3db59373fb084fcd936e0c7be1b76be994e261f
2016-04-14Work around -Werror=logical-op (GCC 6)Stephan Bergmann
...when SIG_DFL happens to be defined as nullptr, by initializing the Signals array to SIG_DFL in the first place Change-Id: Ie9183540e2e8fd795aa288bf30266bc5d9af3e69
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
"logical ‘and’ of mutually exclusive tests is always false" <sberg> alg, in editeng/source/uno/unoipset.cxx:208 (wid < START && wid > END), is what's actually wanted to check for contained or for not contained in the START..END range? You touched the code last, in b0c2ec72ff171d8b4303d39f11f67497e88e2d8c, 15+ years ago (although the line itself was already like that in the initial import, fd069bee7e57ad529c3c0974559fd2d84ec3151a) <alg> sberg: sorry cannot remember - but looks correct. All values outside OWN_ATTR_VALUE_START/_END are answered with defaut. The renge should be the one from ditEngine <sberg> alg, the code as is is clearly incorrect, as the condition is always false <alg> sberg: Ah, yes! Should probably be an '||' <sberg> alg, OK, thanks, I'll give that a "make check" try (a bit scary to thus enable code that had effectively been disabled since at least the turn of the century) <alg> sberg: Yes - scary is the right word. Looking further, eState == SfxItemState::DEFAULT should result when outside, thus pItem->QueryValue would be taken which *should* get the default from the pool when not in the local ItemSet range. In theory, the same *should* happen Change-Id: I906361272dfe3f6af0e1ed3cb4e245ead7eabaec
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
"logical ‘and’ of equal expressions", as DEFAULT and INHERIT are both defined as zero in the UNOIDL css.animations.AnimationFill constant group Change-Id: I59e53fe9bf73f6eec8f7aa82a216736a79e0d47c
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
"logical ‘or’ of equal expressions" Change-Id: I156cb8f09dadb7b625585cfd28d584ba0ae7633e
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
"logical ‘or’ of equal expressions", as RTL_TEXTENCODING_DONTKNOW is defined to be zero Change-Id: I1df1579734a3b9b5ecce5a072916cd57dbcd1458
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
"logical ‘or’ of collectively exhaustive tests is always true"; apparently a typo in 63114e6d863de32e2d93f0da54caca928916d9c2 "Create SvxFieldData instance directly from the UNO textfield object" Change-Id: I9e504ccb5ebad5a42a8c07d7f16d7c316dd82cf1
2016-04-14Drawings: Fix capitalizationSamuel Mehrbrodt
Change-Id: I8372b3349c833218e2851c4248187fd0948b75f3 Reviewed-on: https://gerrit.libreoffice.org/23264 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-14tdf#70998 Termchange Graphic/Bitmap -> ImageSamuel Mehrbrodt
Bitmap refered to everything that renders into a bitmap internally while graphic can also be svg/metafile. As the common user cannot differentiate this, we'll use the term "Image" for both. Change-Id: Ibf307f8f286a7974d7967a83b85ce62ebafe4ac9 Reviewed-on: https://gerrit.libreoffice.org/23293 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-14tdf#40863 only use polygons with area for WinClipRegionsArmin Le Grand
Due to a former fix CustomShapes have extra polygons with a single point in the top-left and bottom-right corner of their BoundRect, a workaround to allow getting their correct BoundRect in slideshow. Unfortunately this makes the win command CreatePolyPolygonRgn fail to create the needed ClipRegions so that the geometry is processed without clipping. Changed to only use polygons as input that have an area. Change-Id: I0eeda5776402777ed00de92f42a55f206575f58b Reviewed-on: https://gerrit.libreoffice.org/24059 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-04-14Avoid null ToolBox::mpData deref during Frame::closeStephan Bergmann
Oh my, whatever the true cause for this SEGV in JunitTest_framework_complex (but probably the same cause as in previous 7f863e890640d0924a6e6f85cf99447dcd7836f7 "Avoid null ToolBox::mpData deref during Frame::close"), <http://ci.libreoffice.org/job/lo_tb_master_linux_dbg/6652/console>, processing an incoming URP request > ToolBox::SetDropdownClickHdl(Link<ToolBox*, void> const&) at vcl/source/window/toolbox2.cxx:1735 > framework::ToolBarManager::Destroy() at framework/source/uielement/toolbarmanager.cxx:232 > framework::ToolBarManager::dispose() at framework/source/uielement/toolbarmanager.cxx:473 > framework::ToolBarWrapper::dispose() at framework/source/uielement/toolbarwrapper.cxx:106 > framework::ToolbarLayoutManager::destroyToolbars() at framework/source/layoutmanager/toolbarlayoutmanager.cxx:654 > framework::ToolbarLayoutManager::reset() at framework/source/layoutmanager/toolbarlayoutmanager.cxx:363 > framework::LayoutManager::implts_reset(bool) at framework/source/layoutmanager/layoutmanager.cxx:413 > framework::LayoutManager::frameAction(com::sun::star::frame::FrameActionEvent const&) at framework/source/layoutmanager/layoutmanager.cxx:2816 > (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&) at framework/source/services/frame.cxx:2953 > (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) at framework/source/services/frame.cxx:1449 > (anonymous namespace)::Frame::close(sal_Bool) at framework/source/services/frame.cxx:1689 > framework::Desktop::impl_closeFrames(bool) at framework/source/services/desktop.cxx:1674 > framework::Desktop::terminate() at framework/source/services/desktop.cxx:238 and the main thread idling in Application::Yield. (ToolBox::SetDropdownClickHdl happens to be the only one among the pToolBar->Set*Hdl(...) functions called en bloc in ToolBarManager::Destroy that dereferences mpData.) Change-Id: I2c54f5deb5e132b25e577d4092d65e2069affb3e
2016-04-14loplugin:sallogareasStephan Bergmann
Change-Id: I220735e76174438d18929a9a92e289933c12fb0c
2016-04-14tdf#99251 Update AppArmor ProfilesBryan Quigley
Make them less resrictive when executing other exes This lets the splash screen work again. Modify AppArmor.sh to be more useful. Change-Id: Icf06910c845d9389b9b75c1623037e1d07489728 Reviewed-on: https://gerrit.libreoffice.org/24043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-14Resolves: tdf#73973 it's [crk-Latn-CA] and [crk-Cans-CA]Eike Rathke
Change-Id: I0da8562fc378f873e208919999bfc85f30d26778
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14don't export the same lib multiple timesMarkus Mohrhard
Change-Id: I4201246b2a1692c6edffa962de49d032fd825b70
2016-04-14turn on the passstuffbyref plugin againNoel Grandin
now that I have committed all of the changes to return types it found Change-Id: Iaee121037ce83e94001e4591d232b075dfeade7c
2016-04-14Unit test hook for online / fonts.Michael Meeks
Change-Id: I2ae50c826f7fc66367a379447ab3b99cd1f29b4d Reviewed-on: https://gerrit.libreoffice.org/24077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-14tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
Removed OSL_DEBUG_LEVEL > 1 conditionals to reduce the problem of multiple debug levels Change-Id: I453f74198e08308c3891e923ebaee58a276e34ad Reviewed-on: https://gerrit.libreoffice.org/22616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-14Race between Frame::dispose and timer-triggered LayoutManager::AsyncLayouHdlStephan Bergmann
Change-Id: I8e9ca61c2a8334697b7a0adef7a2fc20f503f299
2016-04-14Use the true exit code 77 hereStephan Bergmann
Change-Id: Ice61e770dd3cc9ac3beb7646a6fb298c1a4e46d9
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-14loplugin:passstuffbyref in vclNoel Grandin
Change-Id: I17a4dc73c3fc81b0bfebdf442021af65f8f6166c Reviewed-on: https://gerrit.libreoffice.org/24075 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14remove dead fields from WinSalSystem::DisplayMonitorNoel Grandin
Change-Id: I76254f194ac1bbd019b8c46f3f3f0f28e4e7f0ec Reviewed-on: https://gerrit.libreoffice.org/24074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14Related: tdf#65642 RTF filter: import \pgnucrmMiklos Vajna
This as a side effect also implements support for DOCX <w:pgNumType w:fmt="upperRoman" .../>. Change-Id: Ibf3bedca03c6c2a2b96eecb36ff6c4cf6e2281b4 Reviewed-on: https://gerrit.libreoffice.org/24073 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-14loplugin:passstuffbyref in cuiNoel Grandin
Change-Id: I13c2956ad5012373a41c8e6c2af70583fa18c339
2016-04-14loplugin:passstuffbyref in chart2Noel Grandin
Change-Id: Id14015b1a02047c4d2e9d4ed4a9edfd0cb409c59
2016-04-14loplugin:passstuffbyref in writerfilterNoel Grandin
Change-Id: Ia85f5a7a9846802de7a1495e70d16c9e3418dc3e
2016-04-14loplugin:passstuffbyref in ucbNoel Grandin
Change-Id: I4ba18c767c67c9c8d23aac3f8de728b7a229804d
2016-04-14loplugin:passstuffbyref in slideshowNoel Grandin
Change-Id: I6a58315ae63d543053d613a18ff769329f309c32
2016-04-14loplugin:passstuffbyref in sdextNoel Grandin
Change-Id: I954510b953dab133bcf7b37cf598757b7d8e5fca
2016-04-14loplugin:passstuffbyref in sdNoel Grandin
Change-Id: If5a68861451efe025b77f71a20e805b71240b827
2016-04-14loplugin:passstuffbyref in swNoel Grandin
Change-Id: I124bdd4f28c7d7508e77b902dfa23c398454bf38
2016-04-14loplugin:passstuffbyref in scNoel Grandin
Change-Id: I75c483972db787ea9c941eaac0df023f1929b09c
2016-04-14loplugin:passstuffbyref in reportdesignNoel Grandin
Change-Id: I6e024c3043e1fa9f618e96088581ade3c3a00c3c
2016-04-14loplugin:passstuffbyref in lotuswordproNoel Grandin
Change-Id: I2bca01e1ac3585674804b94d1cd65c18c41998ac
2016-04-14loplugin:passstuffbyref in xmloffNoel Grandin
Change-Id: I5995510c5c0686e5e69e8853d81dcba83ae96211
2016-04-14loplugin:passstuffbyref in vbahelperNoel Grandin
Change-Id: I09e6ea5cbab5b06dd284a096503b19c15b2136ce