summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-09-08Require HarfBuzz 2.0.0Khaled Hosny
Released October 2018. We want to use some newer APIs than the currently required version. Change-Id: I85f572ad3b7155926ad36a11b3afaf08a2a11714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139607 Tested-by: Jenkins Reviewed-by: René Engelhard <rene@debian.org> Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-08vcl: Drop now unused FontCharMap::GetGlyphIndex()Khaled Hosny
Change-Id: Icf687d09c2d25a3d578faf7ae574b3e655b8540f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139600 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-08vcl: Add LogicalFontInstance::GetGlyphIndex()Khaled Hosny
And use it in a few places, particularly where we get glyph ID from FontCharMap. We want to get the glyph indices from HarfBuzz like we do for shaping, to avoid any potential discrepancy (e.g. a new “cmap” subtable that our ParseCMAP() would not automatically support). Change-Id: Ie80993b35f0586d8567b6bda0ea56ba453316e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139578 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-08vcl: Make glyph IDs 32bitKhaled Hosny
To match corresponding HarfBuzz and Cairo types, and would eventually help us in supporting fonts with more than 65535 glyphs (currently supported only by HarfBuzz). Change-Id: I239421bcef6e1b26f17a4666243a239174ea4943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139576 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-07crashtesting: prevent nullptr accessEike Rathke
There's a xlsx export crash on *2nd* export with data pilot data of forum-en-38962.ods. We export without crash this .ods to xlsx *once*, but on saving again to xlsx it crashes. It also crashes with an export to .xls and then an export to .xlsx. Repeated exports to xls are crash free. Already on the first export there are loads of warning messages of ScDPMember::GetItemData: what data? nDim 0, mnDataId # ScNameToIndexAccess getByIndex failed com.sun.star.container.NoSuchElementException message: "at sc/source/core/data/dptabsrc.cxx:2267 The pivot tables are broken on both exports. This smells like some sort of data pilot cache corruption/insufficiency during .xlsx export but the root cause is yet unknown. This only fixes the crash symptom. Change-Id: Ie479f7f0abc4af284e61f6aa5a69943ccdd72eab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139611 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-07tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroTomoyuki Kubota
Change-Id: Ibd3f56f6e669a3bb1c1926aa4affdcc46623c81e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07cid#1509288 rearrange to make clearer what actually happensCaolán McNamara
similar to commit ce36d36233053cea8b5db7f39f2693726a43940a Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Sep 6 14:25:09 2022 +0100 cid#1500385 rearrange to make clearer what actually happens Change-Id: I559dab7b8570662644f6b4dac392c307bdef9a84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07cid#1509283 silence Dereference after null checkCaolán McNamara
and cid#1509253 Dereference after null check which seem to exist since: commit 42ba2b6c03a74815d2041e554fea83350d554dd1 Date: Mon Sep 19 15:37:25 2011 +0200 Text Boundaries: draw small inner corners for the columns areas Change-Id: Ibd292003349816107acf5044433c67ba6accc84b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07Be careful with failed reallocStephan Bergmann
Change-Id: I809e70487b9174ae902d3a11cc2845ec310d009f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139610 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-07Fix register clobber information and simplify in the C++/UNO bridge for iOSTor Lillqvist
Avoid the use of unnecessary local variables to temporarily keep return values from a function called by the inline assembly. Instead use the GPR and FPR arrays also to temporarily keep such return values, like the Linux aarch64 code does. This fixes https://github.com/CollaboraOnline/online/issues/5204 Change-Id: I11aac56e9c8cc8aff1a3653ced45bdf4844cbcca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139604 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-07tdf#150307, tdf#150829: sc: Add UItestXisco Fauli
Change-Id: If4a7e9fc6e4d9057f880f6b8c1dba7598597031e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139583 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-07Remove obsolete commentStephan Bergmann
...after c8fd50f9ec02a131fd4c99e80f7252b49015653a "python3: upgrade to release 3.8.13" Change-Id: I43428485e7cdffec7b3a7a575334bd886e2f26c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139609 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-07cid#1513730 Useless callCaolán McNamara
since: commit 3a8c74efa2da18f16af4f395e46ee13bfdfa76cc Date: Mon Sep 5 14:16:28 2022 +0200 use more SwPosition::Assign Change-Id: Ie6fc37f33c1c5b7ec1c65f5a880044b261f4130a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07Fix typoAndrea Gelmini
Change-Id: I4f4133ca077d69e3238aba809cd758455918bc39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139586 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-07tdf#150808: General error importing svgz fileJulien Nabet
Change-Id: I7f2a8c6ffe4eba0c9e75913bd3e4671b0727fd94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139537 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-07Revert "tdf#150555: Skia seems to fail with Windows 8/8.1"Xisco Fauli
This reverts commit e2a16489ff4a65e747e93b28d39096cb259bddd7. Reason for revert: See discussion in https://gerrit.libreoffice.org/c/core/+/138549 Change-Id: I9ad22c594478d11e1eb062f69d83ce6b55b09eaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139554 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-07cid#1500419 rearrange to silence Use after freeCaolán McNamara
Change-Id: I4529306d94c88ba6572f108f512f1521c849246c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07tdf#149547 fix "tdf#75297 sw uno: override default num char style"Justin Luth
The problem was that things like chapter numbering were creating this style on import. Interesting that it didn't do it for my use case. This fixes 7.5 commit 758945b077220fe151c1565c6d5b0bad02de6d58. Originally I left this clause "as is" because I had not yet removed the obsolete part of the condition. But now I can change anything in that .isEmpty() clause since commit 1a57418e2837e7fd07b0619804feed06e1acfe41 remove unused sw UNO_NAME_CHARACTER_FORMAT_NONE Change-Id: Ie52a0d1392d49ba6ae8a5620ab453ff7129bce7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139584 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-07tdf#150810 get visible placeholder text in GtkEntry with focusCaolán McNamara
in gtk3 focus causes placeholders to be not rendered https://gitlab.gnome.org/GNOME/gtk/-/issues/378 https://bugzilla.gnome.org/show_bug.cgi?id=657613 FWIW, currently in gtk4 they are shown when focused Change-Id: I623c81dd71f651d8b24a717a63fe428bc9d6a505 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139592 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07python3: upgrade to release 3.8.13Taichi Haradaguchi
Remove some code in external/python3/darwin.patch.0 as it was fixed upstream(https://bugs.python.org/issue45405). Change-Id: Ie6bfb2456f96a63adbf0dbcb9c902dc56f1151ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139493 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07apply ui-rulesCaolán McNamara
Change-Id: I5acc6cfe5488f8aa92ecaafa0ebdc50f2ad9758e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07we don't use urgency-hint or want any gravity hintsCaolán McNamara
Change-Id: I86255f9ba018aab7db654d91bf49043fcd4cb057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139590 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07add truncate-multiline for consistency with vcl and all the othersCaolán McNamara
Change-Id: I7ccc294308d487ce2443699a946753290344a92d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07vcl: convert ImplGetEmphasisMark() to EmphasisMark classChris Sherlock
It makes more sense for an emphasis mark to be an object that can be queried, than it is for it to be a function with lots of output parameters. I have added a unit test, note that for now something doesn't seem right with polypolygon equality checks (test fails, but the disc is generated the same way) so not testing the shape creation. Change-Id: I7597603419b69639b8d9764afdb68e266da7a56b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122601 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-09-07gtk4: caps-lock-warning is gone as a propertyCaolán McNamara
Change-Id: I66aac55f0ebb381bc2f9f1fffbdb887d4a016005 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139588 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07every other .ui is version="3.20"Caolán McNamara
Change-Id: Ifc45b74e06069855021b7c963a3e5c83c8eacfcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139587 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07Use exactly two comparisons in froundMike Kaganski
It is used extensively in drawinglayer; the typical path for values inside sal_Int32 range used three comparisons. Change-Id: Iafb09f06a746bb53a41585be4a5b1a701fa38057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139555 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-07Related: tdf#122737 A hack to keep backing window opaque on context destructionMike Kaganski
Also this incidentally improves OpenGL frame rate, which could decrease the problem visibility (but indeed, this is not a proper fix). Change-Id: If1d0eec78cad14548a51be7da76f16a3ecfcddb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139581 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-07sd: rename WriteAnimationNodeAudio to MediaMiklos Vajna
Because XAudio means both video and audio, see <https://gerrit.libreoffice.org/c/core/+/139265/comments/479934b4_978756a7>. Change-Id: I4d631d55ec1694c11e24c65b0826771c87457cdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139579 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-07use o3tl::span in SvXMLItemMapEntriesNoel Grandin
which means we don't need to calculate the size of the map at construction Change-Id: I295defd7c4609b22a994928f6442fadadd9df66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07convert PreviewMode to scoped enumNoel Grandin
Change-Id: I36d6153e5bc65311ec5708839e640cf104b3f035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139546 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07tdf#150569 Modify hardcoded dates to extend the range of accepted datesjucasaca
Replaces date range limits to allow entry of dates between 1/1/0001 and 31/12/9999, which is the normal date range in most database manager May need some discussion Change-Id: Ide8dfc64663d2ef2a66d8b7e1af3ef8ed3bb0af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138845 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07tdf#150666 sw: allow to delete tracked table row insertionsLászló Németh
It was not possible to delete tracked table row insertions, if only those were selected, or if they were own insertions. Regression from commit 95213407dfcbf34056037d60243ff915340d1a2e "tdf#146622 sw crash fix: don't delete already deleted rows". Change-Id: Idd3bc78bca1c76bceba63cf339c6d8c73f8f9508 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139575 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-09-07convert ElementOpenMode to scoped enumNoel Grandin
Change-Id: Ib1b714c377ce0d4935ba5ead68163d69fa091cfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07ONavigator doesn't need a pimplNoel Grandin
it is module private Change-Id: I21779fe8ac50aa4602e4c3d7798d0ced1ddab066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139541 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07ofz#50118 TimeoutCaolán McNamara
Change-Id: Idf0669d62b8bb6d21a6b5ad22f698449bb66e531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07sw: clean up DocxAttributeOutput::EndContentControl()Miklos Vajna
This always felt dirty, and seems it's no longer needed. Remove the fly frame condition before somebody starts depending on it. Change-Id: Id286ab37981fd1890ca88bf5a17cb78876bcd2ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139574 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-07ConvertToBitmapEx slightly too bright if transparency involvedArmin Le Grand (allotropia)
Stumbled about this error when working on re-designing the blend primitives for shapes. Using convertToBitmapEx is the base for these (also for the UNO API conversion from Primitives to BitmapEx). Use a VirtualDevice in the Alpha-mode now to solve it. This creates the needed alpha channel 'in parallel'. It is not cheaper though since the VDev in that mode internally uses two VDevs, so ressoure-wise it's more expensive, speed-wise pretty much the same (the former two-path rendering created content & alpha separately in two runs). The former method always created the correct Alpha, but when transparent geometry is involved, the created content was blended against white (COL_WHITE) due to the starting conditions of the content creation. There are more ways than using a VirtualDevice in the Alpha-mode, to do this correctly, but this is the most simple for now - and I was persuaded by the following argument: Due to hoping to be able to render to RGBA in the future anyways there is no need to experiment trying to do the correct thing using an expanded version of the former method. Change-Id: I23e005f9c3723059e2b88660fede09aa83844b38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139272 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-09-07SvXMLItemMapEntries does not need an implNoel Grandin
it is module private Change-Id: Iaceb84b6868fe1450eab748f34f131a3867d38cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139542 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07filter: remove no longer needed back-compat of the svg presentation engineMiklos Vajna
This was added in commit 4063dcdc7305177b167bd20b009b1dfede8b25ec (Revert naming back to lool to fix break with LibreOffice Online, 2022-08-26), to give consumers of that API time to switch from the product name to the API name. Now this patch removes the product name, only on master. Change-Id: I27e2fd03c8ca646ffb0e0df541b7f94bd9ad3516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139551 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-07OXReportControllerObserver does not need a pimplNoel Grandin
it is module private Change-Id: I50bd06aa1b75d7561aee788c69c0482c6293db16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07convert ObjectType to scoped enumNoel Grandin
Change-Id: I1c103aebe02a41ed4fa59a72950cb55d3c6c93d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07tdf#150604 Writer Navigator: Make delete shortcut key delete IndexesJim Raykowski
Change-Id: I651159794790972b430c9a420d6eaa1ed77e5718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139550 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-09-07CppunitTest_sw_ooxmlencryption: remove not needed mustTestImportOf()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. All the tests in this suite are docx files, so this was an unnecessary override. Change-Id: I519599abd5081ec68c9603befbb16794dd5696b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139532 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-07Resolves: tdf#150829 Broadcast missing ScAreasChanged hint on sheet copy UndoEike Rathke
Change-Id: I354b1e395079067cd4cc9299501b3936dea00cd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139538 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-07tdf#147646 Auto numbering is wrong when the row has split/merged cells.Satya
The fix is to,walk through the paragraphs in the cells that are vertically merged(PROP_VERTICAL_MERGE)and remove the numbering rules property from underlying text of those paragraph properties of a cell. Note that,there was a similar bug for DOC files,and it was fixed with tdf#49102,we need to provide a seperate fix for DOCX files as the DOCX filter is different than DOC. Change-Id: Ia1cc22cbc04448a11ae0d136519681d9363e2828 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139401 Tested-by: Jenkins Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-07Use XCharacterClassification::getCharacterType() instead of getStringType()Eike Rathke
Change-Id: I0bbd196a8691fb72a1f091af8825df749bfc7cb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139535 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-07Always enquote ColRowName (label) as SingleQuotedEike Rathke
It's anyway required by ODFF and also in UI prevents confusion between defined names and labels of the same name. Change-Id: Iba03f15f1f778132696101507e61cc0ef8de6c6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139533 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-06Add note to XCharacterClassification::getStringType() about meaninglessnessEike Rathke
Given how it works that's almost deprecated, almost.. Change-Id: Ife2fe012db5568e4646b98b0ba55df8418069062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139534 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-06svx: set vars to initial values in constructor init for SdrTextObjTomaž Vajngerl
Change-Id: Id3fb342a4273b617ac2975bff3dd79159ab8df75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139531 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-03-10 14:58:30 +0000