summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-04-05tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in sc/source/core and sc/source/ui Change-Id: I214565e73893688963d99c0f0ddfc356b5ad63be Reviewed-on: https://gerrit.libreoffice.org/36107 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-05Add another FIXMETor Lillqvist
Change-Id: I60a3978454fb4e6c39b3c35705fd5d503c75860c
2017-04-05-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Iab661fad3892c72ef042016085db553819307c56
2017-04-05Add FIXMETor Lillqvist
Change-Id: I84c6e605f012dd563f41631bc3c2b8631c1428e8
2017-04-05tdf#39468 Translate German commentsJens Carl
Translate German comments in sc/sdi Change-Id: I560f7b80201f1117e93efd2a9a3068976d1cb4d6 Reviewed-on: https://gerrit.libreoffice.org/36104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-05fix shadow warning with latest clangNoel Grandin
Change-Id: I0640d4e816ba73f900ad21d7603743e0e9695a70 error: declaration shadows a typedef in 'bridges::cpp_uno::shared::VtableFactory' [-Werror,-Wshadow] Reviewed-on: https://gerrit.libreoffice.org/36127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05sType and sSubType are already normalized to ASCII lower caseMike Kaganski
... upon successful return from INetContentType::parse Change-Id: I8a0c50c1c655477138578e59031b64fb6b2b7218 Reviewed-on: https://gerrit.libreoffice.org/36129 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-04-05coverity#1404783 Dereference null return valueCaolán McNamara
Change-Id: I6bc3cc6ad5344756a65dceaf53a9f14abe9c69e3
2017-04-05ofz: stay within available dataCaolán McNamara
Change-Id: Ic959cf5b2cd92ba5bc297e686beb1fd50427a994 Reviewed-on: https://gerrit.libreoffice.org/36102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-05There is no MM wizard page after Layout page nowGabor Kelemen
Change-Id: Ifd15dada56581ccae704452f6c98f5b476ca15f5 Reviewed-on: https://gerrit.libreoffice.org/36094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-05Fix typo: inticator -> indicatorXimeng Zu
The related code is not being used now... So, it's safe to just correct it before it is put to use. Change-Id: I1ba5f1d6d511c965c0ce08dd08bfcabc567da2c3 Reviewed-on: https://gerrit.libreoffice.org/36103 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-04-05sc: remove redundant castsJochen Nitschke
surprisingly GetDouble() already returns a double Change-Id: I1561f3d20e42531adad4d51b2d48ce92b126ffc2 Reviewed-on: https://gerrit.libreoffice.org/36068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05sc: use std::reverseJochen Nitschke
Change-Id: I16505d15cc7e1d82409f15107d1c5af3bf811c11 Reviewed-on: https://gerrit.libreoffice.org/36069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05teach constantparam plugin to find always on and always off bitmask valuesNoel Grandin
Change-Id: If56a483494bd3d7feb3fa67c01000dddd0d34421 Reviewed-on: https://gerrit.libreoffice.org/36085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparam part2Noel Grandin
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparamNoel Grandin
Change-Id: I1996319e5b664dff95f7a9b2346aea6092d333ec Reviewed-on: https://gerrit.libreoffice.org/36070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05tdf#106868: fix crash when modify external linkNoel Grandin
The EndDialog callback Hdl was disposing the Dialog, which is a little troublesome since the stack wants to go back through the Dialog code when the callback is done. Rather just the more normal synchronous Execute() style of Dialog execute, instead of the asynchronous StartExecuteModal. Change-Id: I14933bd475da228c9648a6fa0564bda4a60d9d12 Reviewed-on: https://gerrit.libreoffice.org/36074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05tdf#106955: Detect XML by MediaTypeMike Kaganski
According to Extensible Markup Language (XML) 1.0 (see https://www.w3.org/TR/2008/REC-xml-20081126/#sec-prolog-dtd), all parts of XML prolog (including XML declaration) are optional, so XML stream without <?xml ... ?> is well-formed (though not valid). XMLFilterDetect uses only XML declaration to detect if the file is to be processed further. However, this creates problems with said documents. This commit checks if the document has MediaType set to one of known XML media types, in case when the check for XML declaration failed. Change-Id: I31627c0e3a39bee241f609650280ebac3f1cede8 Reviewed-on: https://gerrit.libreoffice.org/36101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-04-05tdf#106955: Open WebDAV resources on which PROPFIND failsMike Kaganski
When PROPFIND fails on a WebDAV resource, its IsDocument property stays undefined, and so stream creation fails. Proposed solution is to default to IsDocument=true for all WebDAV documents where we cannot get the property from server. Such resources also fail to return their locking options, so defaulting to server properties. When later locking is attempted on it, the attempt fails with user notification (a dialog saying that getting information from server failed). Proposed solution is to check Content-Disposition header in such resources, and in case it's attachment, disable lock on this resource. The rationale for this is that "In a regular HTTP response, the Content-Disposition response header is a header indicating if the content is expected to be displayed ... as an attachment, that is downloaded and saved locally" (see MDN: https://developer.mozilla.org/en/docs/Web/HTTP/Headers/Content-Disposition Also, Content::getProperties wasn't ready for PROPFIND returning empty result. Change-Id: I91dbffa8bdf0fe900c11d2f8c9c9394d2104bb49 Reviewed-on: https://gerrit.libreoffice.org/36090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-04-05tdf#106525: Implement an XSLT import filter for ADO rowset XMLMike Kaganski
There are online services and management systems (like SharePoint) that allow to export datasets in ADO rowset XML format ([MS-PRSTFR], https://msdn.microsoft.com/en-us/library/cc313112). Usually they are intended to be open with MS Excel as a spreadsheet (with autofilter). This allows to open this data in Calc. Change-Id: I495cd790138bdd6bd24630c0f422a0c8b4e3d0fb Reviewed-on: https://gerrit.libreoffice.org/35159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-04-04ofz#984 better match post-creation aBitmap.HasGreyPalette() logicCaolán McNamara
i.e. Bitmap::HsGreyPalette checks that the palette has entries before calling Palette::IsGreyPalette Change-Id: I287647869ad615327f3119b7798f410e22140302
2017-04-04ofz: check olst sprm for valid ANLD payload lenCaolán McNamara
Change-Id: Ic1b6681a3f48ef0fe3f52eda9db8b7bc003ded55
2017-04-04ofz#770 JOHAB_73 table starts at 0xA not 0x2Caolán McNamara
the start value is out by one row Change-Id: I77ed154358516ccd47a090cf7ed45bb609bc81a3 Reviewed-on: https://gerrit.libreoffice.org/34992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-04Resolves: tdf#106725 paint default window bg before spin button bgCaolán McNamara
Change-Id: I0c7f982c3a47f45d022271eba69ebed896288d78
2017-04-04forget the TODOCaolán McNamara
Change-Id: I81c8b97e8cd958933caac475145e3b3bcee46d6a
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04Workaround VCL complextext failure on Win7 KVM QXLJan-Marek Glogowski
My Windows 7 KVM QXL VM fails the bounding rect test with: complextext.cxx:98 VclComplexTextTest::testArabic equality .. failed - Expected: 71x14@(0,1) - Actual : 70x14@(1,1) This doesn't happen using a SSHd on Cygwin64 based session. Adding a SAL_DEBUG to WinSalGraphics::GetGlyphBoundRect shows many different glyph rects, which - probably by pure chance - almost add up to just a single pixel line missing on the left. So this simply drops the first pixel column, if the bounding rect starts with an offset. Works for me. Change-Id: Ia496a208523a9c358d4128ecad887b5c77283fbc Reviewed-on: https://gerrit.libreoffice.org/35647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-04-04tdf#104686: do not crash if Menu has been somehow disposedAron Budea
The rare crashes in MenuFloatingWindow::ImplGetStartY() and MenuFloatingWindow::ImplScroll(bool) likely happen because of a disposed Menu. Let's guard against invalid accesses. Change-Id: Ie31240abbc48c06edd40d0a95f319725cdb3db16 Reviewed-on: https://gerrit.libreoffice.org/36026 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-04-04Make HangingIndent a commandSzymon Kłos
New command .uno:HangingIndent. Code moved from the sidebar to slots. Change-Id: Ib389f9fb3368409a90cf90ad8b19f1be322fa120 Reviewed-on: https://gerrit.libreoffice.org/35930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04Notebookbar: Separated paragraph spacing controlsSzymon Kłos
One big paragraph spacing control was splitted to separated widgets. It will be possible to reuse that in the sidebar. Also layout is better because explicit size setting is no longer needed. Change-Id: Ieb200af4a9a6120ae03b22b27da56256aa816193 Reviewed-on: https://gerrit.libreoffice.org/35801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04Fix group for .uno:EditAnnotationSamuel Mehrbrodt
Change-Id: I3a62e37d866235728abf6b4ad3a5338222d02088 Reviewed-on: https://gerrit.libreoffice.org/36081 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04add *.vcxproj* to .gitignoreBernhard Widl
these files are generated by make vs2015-ide-integration. Change-Id: Iaae5931289bd2f27415c401b6ac253d43dc39007 Reviewed-on: https://gerrit.libreoffice.org/36073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04Updated coreOlivier Hallot
Project: help ad25b453307e0a88ac208aa3b178805846988045 Fixes in HC after translators review. Change-Id: Id2384cb6f1917c7e1f11c97ef9b05a3dfff08c9a Reviewed-on: https://gerrit.libreoffice.org/36050 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-04-04well, its on the main trunk nowCaolán McNamara
and we're not changing it at this point Change-Id: Icb0cbe4728f64c2070780ad63b888e5d229c6216
2017-04-04intendend->intendedCaolán McNamara
Change-Id: I6f066493600cec2af586c3ff4df1f32faa303060
2017-04-04tdf#99352: assert on stray VclPtrs past DeInitBjoern Michaelsen
- ignore on Windows for now, as it is acting up Change-Id: I98dbb887ed556b58188870c3eb3de1327bc58109 Reviewed-on: https://gerrit.libreoffice.org/35816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-04-04std::unique_ptr<[]> -> std::vectorCaolán McNamara
Change-Id: I7fd4275664fab42c61941a4ea21750a653b437d3
2017-04-04ofz: avoid oomCaolán McNamara
Change-Id: Ie700676c8470b6764a38f4e2989dc14819244872
2017-04-04xmlscript: fix -Werror=maybe-uninitializedMiklos Vajna
Change-Id: Ifcde2202fcb2cfa1dd226697910c1fbd219a3f83
2017-04-04Missing str(...) when an arg is itself a css::uno::Sequence<...>Stephan Bergmann
Change-Id: I54529e7086014a2feba89eb73f3b368d36f758b8
2017-04-04tdf#83257 [API-CHANGE] Pivot chart implementationTomaž Vajngerl
This is a squashed commit of the pivot chart implementation. Some of the changes: - Add pivot chart specific (pivot table) data provider which provides the data from a pivot table to the associated chart. - When inserting a chart and the cursor is in a pivot table, in that case insert a pivot chart - Modify the pivot chart when the pivot table changes - Collect and set the number format for the values - isDataFromSpreadsheet check for the creation wizard - In ChartView (and VLegend) check if the data provider is a pivot chart data provider and get the pivot table field names to create the buttons on the UI. - Adds the functionallity to show a filter pop-up (from calc) when clicking on row / column / page field buttons. - Remove (X)PopupRequest as we won't need it. - Add ODF import/export for pivot charts: + Added loext:data-pilot-source attribute on chart:chart which is the internal name of the pivot table with which the pivot chart is associated with. If the element is present, then the it means the chart is a pivot chart, else it is a normal chart + Added service to create pivot chart data provider through UNO + Add new methods to XPivotChartDataProvider to create value and label data sequences separately from the data source, which is needed for pivot chart import + When importing defer setting the data provider until a later time when we know if we are creating a chart od a pivot chart - Pivot chart ODF round-trip test - Add table pivot chart supplier API: This adds the XTablePivotChartSupplier and related interfaces so we can access, create, delete pivot charts from UNO in a sheet document. With this we now distinguish between normal charts and pivot charts. This was mainly needed because we can't extend the "published" interfaces of TableChartSupplier. - Added an extensive test, which uses the API to create a new pivot chart when there was none, and checks that the pivot chart updates when the pivot table updates. Change-Id: Ia9ed96fd6b1d342e61c2f7f9fa33a5e03dda21af Reviewed-on: https://gerrit.libreoffice.org/36023 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-04can simplify nowCaolán McNamara
Change-Id: I234e630f3af1acfa39900464abd7e06efc47a671
2017-04-04Resolves: tdf#106935 restore traditional toolbar labelsCaolán McNamara
Change-Id: I00cf16e9ce429f9186cc900a07f4d386e33b8f7b
2017-04-04ofz: guard harder against bogus sprm lenCaolán McNamara
Change-Id: Ic82526e1454b24f094d3deee89647e88760bc44b
2017-04-04tdf#39468 Translate German commentsJens Carl
First run of translating German comments and terms in sc/ Change-Id: I9802df334259edcea148bead95cc98a8057b91a1 Reviewed-on: https://gerrit.libreoffice.org/35994 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-04More commit resurrectionStephan Bergmann
(why do people do such silly reformatting?) Change-Id: Ie9d45d7dfccb000f53fa5e8dc456f1e7c033af18
2017-04-04Move comment back to where it makes senseStephan Bergmann
It appertains to the preceding code, not the following, so it was indented for a subtle reason. Change-Id: I032033f04a1ca3a91024c11de74ef96527562b41
2017-04-04Keep list sortedStephan Bergmann
Change-Id: I680be319b6c2d87a8fba0e07a3b24d0a2ed478b7
2017-04-04scaddins: silence -Werror=maybe-uninitializedMiklos Vajna
Change-Id: Idbbd6490c954f50d3baa7a72cd89f081d1316e6b
2017-04-04Work around clang-cl issue with MSVC's safeint.h for nowStephan Bergmann
At least some C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\ safeint_internal.h, in the specialization of LargeIntRegMultiply::RegMultiply for signed __int64, contains an (unnecessary) C-style cast from l-value unsigned __int64 tmp RegMultiply( ..., ..., (unsigned _int64)tmp ) == SafeIntNoError ) which clang-cl correctly identifies as producing a prvalue (so cannot bind to the third 'unsigned __int64& ret' parameter of that RegMultiply call), while MSVC apparently has a non-standard mis-feature of treating such a "self-cast" as an lvalue. Until clang-cl learns about that mis-feature too, use the fallback implementation of o3tl/safeint.hxx when compiling with clang-cl. Change-Id: I7a454134589d958ad7ba845c37584b3aa7b94926 Reviewed-on: https://gerrit.libreoffice.org/36066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-11 21:27:30 +0000