summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-12-20use unique_ptr in ucbNoel Grandin
Change-Id: I613069e9a04b2afa06486507c857c9135694ac23 Reviewed-on: https://gerrit.libreoffice.org/65445 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20missing test dependenciesStephan Bergmann
Change-Id: I6dd52a9116d7d6f692e6f1a080c7169a92b265ea Reviewed-on: https://gerrit.libreoffice.org/65463 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-20Enable --help=html for flatpakStephan Bergmann
To not increase the size of the main org.libreoffice.LibreOffice app further, the plan was to realize this as an org.libreoffice.LibreOffice.Help extension. Ideally, this would be a localized extension, so that, by default, only a relevant subset of the extension would be downloaded and installed. (But see below.) There are multiple technical problems, as discussed at <https://github.com/ flathub/org.libreoffice.LibreOffice/issues/35#issuecomment-447295308> "Add integrated LibreOffice Help offline": * LO can't pass a file URL with query part to xdg-open, so uses a temporary wrapper .html file that redirects to the target URL. But for the flatpak case this wrapper can't be in /tmp (which isn't visible from outside the flatpak sandbox), but is instead stored in a new temp dir under $XDG_CACHE_HOME (which is always set for flatpaks and /is/ visible form the outside) that is removed on LO exit. * The file URL stored in the temp file must be rewritten from the internal path (/app/libreoffice/help/...) to the path as seen outside the flatpak sandbox. While the path for the org.libreoffice.LibreOffice /app is stored in /.flatpak-info, the external path for the org.libreoffice.LibreOffice.Help extension is different and not stored there. So use a hack trying to construct that path from what information is available in /.flatpak-info. * But the help content consists of locale-specific and shared files, and those reference each other with relative links. But a localized flatpak extension cannot contain shared files, it can only contain per-language sub-dirs. And if the shared help files were kept out of the extension, as part of the app itself, the relative paths among these files inside the flatpak sandbox would differ from those outside of it, so would be broken when viewing the content in the external browser. A solution would either (a) need to somehow rewrite the content of all the help files being served from LO to the external browser, or (b) replicate the shared help files in all the extension's per- language sub-dirs (and if some localization uses en-US content as a fallback for only part of its translated content, e.g., in the case of media files, would need to also replicate that en-US content), or (c) use a non-localized extension that always contains the content for all localizations. For now, I chose the third approach. This makes the org.libreoffice.LibreOffice.Help extension relatively large (the current /app/libreoffice/help tree has a size of ca. 100MB), so that I decided to not have it downloaded and installed automatically ("no-autodownload": true in solenv/flatpak-manifest.in). (I checked with Flatpak 1.0.6 that if the extension should be changed to a localized one with the same name in the future, updating from an older version would work. If the old extension was not installed, just the relevant localizations of the new version will be downloaded and installed. If the old extension was installed, the full set of localizations of the new version will be downloaded and installed.) (As also mentioned at <https://github.com/flathub/org.libreoffice.LibreOffice/ issues/35#issuecomment-447295308>: "A second, minor, nuisance is that, for security reasons, an `xdg-open file:///...html` call from a flatpak leads to an intermediate popup dialog letting the user chose which application to use to open the URI, while e.g. an `xdg-open http:///...html` is allowed to go directly to the user's preferred browser. So accessing help content from LO flatpak would present that popup dialog first, forcing the user to select a browser to proceed.") Change-Id: I35f5a23947dd551dc1b9bff1dd2abd6710073b5f Reviewed-on: https://gerrit.libreoffice.org/65451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-20use unique_ptr in svxNoel Grandin
Change-Id: Ib0dd1edf05470783da41f08767020a9009f356ad Reviewed-on: https://gerrit.libreoffice.org/65444 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20use unique_ptr in sfx2Noel Grandin
Change-Id: I4e0bba9b8bebdeb9263ad71d3ab505d8beed17b7 Reviewed-on: https://gerrit.libreoffice.org/65441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20weld SwTOXEntryTabPageCaolán McNamara
Change-Id: Ib093fbb78a73b26060613ea72030e92f7d3681a5 Reviewed-on: https://gerrit.libreoffice.org/65325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-20use unique_ptr in xmloffNoel Grandin
Change-Id: I98fc0630308e51fcc5eb0224af77881eebf0ff0f Reviewed-on: https://gerrit.libreoffice.org/65443 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20Restore original behavior of MasterScriptProvider::hasByNameMike Kaganski
Commit f3ce30ec75a4d7116b9cd4d7b21d9aaa0e237eeb changed this to return after first non-throwing XNameContainer::hasByName, regardless if it returned true or false. This changes it back, to iterate over all the providers again. Change-Id: I74fa4d4aa8760cad509442226601ab4842312b80 Reviewed-on: https://gerrit.libreoffice.org/65471 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-20starmath: create SmFilterDetect instances with an uno constructorMiklos Vajna
Change-Id: I11ffe5153bc9ea263cde63093544584f01a344d2 Reviewed-on: https://gerrit.libreoffice.org/65464 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-20Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I577f6ff01e8216ed85556ce4b3365fd924f75608 Reviewed-on: https://gerrit.libreoffice.org/65468 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-20Fix typoAndrea Gelmini
Change-Id: I211b3deb6089835486744eaea5879392994cc66e Reviewed-on: https://gerrit.libreoffice.org/65467 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-20Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I8d05cf7480d83d71c015bd21d3d78fca56f779e7 Reviewed-on: https://gerrit.libreoffice.org/65466 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-20use unique_ptr in SvxOnlineUpdateTabPageNoel Grandin
Change-Id: I7f93f686438c1922797a10f2510db71dc4a06ff1 Reviewed-on: https://gerrit.libreoffice.org/65442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20Simplify containers iterations in scaddins, sccomp, scriptingArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I21ec2eea8f322e2792097d352fc352dc6099c7b7 Reviewed-on: https://gerrit.libreoffice.org/65461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20use unique_ptr in SdrPaintViewNoel Grandin
Change-Id: If4ae6eb38351a9d7dec547d02bbb5a700af5ec64 Reviewed-on: https://gerrit.libreoffice.org/65397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20Fix typoAndrea Gelmini
Change-Id: I95c7fd5a7241c120395c897af4fc2742528e2166 Reviewed-on: https://gerrit.libreoffice.org/65391 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-20sw filter/ww8 code cleanup: remove duplicate variableJustin Luth
Change-Id: I2be36438ca1ab0646aa8f89dfcb317d6a162b072 Reviewed-on: https://gerrit.libreoffice.org/65266 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-20Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' - Dissolve contraction, don't -> do not This was already fixed for 6-2 with commit d08d1c486558d6c113863d579f89e1faf8d89572 Change-Id: I00e67478ae41cd5724d2df8abe105faef4343c21
2018-12-19tdf#99631 DOCX export: keep zoom of embedded XLSXLászló Németh
OLE objects by exporting their VisibleArea settings Change-Id: Iaedc1901999dd203fc9961a4775f8d2452f3ccda Reviewed-on: https://gerrit.libreoffice.org/65435 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-12-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix code formatting in validity help pages Change-Id: I9b0558bb805512c98223eaf2305d37861e10c82c Reviewed-on: https://gerrit.libreoffice.org/65458 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-12-19Resolves: tdf#121555 sometime crash on menu hierarchy changeCaolán McNamara
seems menubar gets set to dirty due to some menu activity that needs a refresh, but then the hierarchy changes and as its already dirty the maUpdateMenuBarIdle doesn't get launched the placement of the mbMenuBar test inside the loop through parents shows some confusion as to what which mbMenuBar might be met, the one belonging to this, or that of the parent being traversed, but it does seem to be the one belonging to this. Change-Id: I0b9dceadf64f7adf18eb1aa2dbda9bbfbcb66e0a Reviewed-on: https://gerrit.libreoffice.org/65452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19framework: allow loading a component on the main threadMiklos Vajna
The user-visible problem was that embedded (OLE) objects contained in a document that was loaded on a thread were not editable. This works in the loaded-with-UI case because the Windows version of the SalData constructor in vcl calls CoInitialize() (which sets the concurrency model of the main thread to STA) and then later the OleComponent constructor in embeddedobj calls OleInitialize(), which just realizes that the concurrency model is already set, and OLE editing works. However, if the document is loaded on a thread, things are different. The concurrency model of the thread is set to MTA in oslWorkerWrapperFunction() in sal, so the later OleInitialize() will fail with RPC_E_CHANGED_MODE, as it's not possible to set the concurrency model of a thread once it's set. Solve the problem by providing in opt-in way to execute the actual import on the main thread, since remote UNO clients always invoke Desktop::loadComponentFromURL() on a thread. Change-Id: I94f2721b599c3ae3e2ebc1c90dea649a69d51ef7 Reviewed-on: https://gerrit.libreoffice.org/65453 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-19shrink assign style dialog to minCaolán McNamara
Change-Id: I204b239c4898ab6a7b25a7e935eb0d81e470f08c Reviewed-on: https://gerrit.libreoffice.org/65430 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19Add XServiceInfo tests to ScTableRowsObjJens Carl
Change-Id: I9ebf0c3664c56f99a4e423c409c5d1621b8ea082 Reviewed-on: https://gerrit.libreoffice.org/65402 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19Fix typo in QA pathAndrea Gelmini
Change-Id: I866611929f75dd322ce81ec54a63ec08002f55cc Reviewed-on: https://gerrit.libreoffice.org/65401 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#45904 Move XTableRows Java tests to C++Jens Carl
Move XTableRows Java tests to C++ for ScTableRowsObj. Change-Id: I765d213e0a3e95a3925f1fc179a8a3f6c6611739 Reviewed-on: https://gerrit.libreoffice.org/65398 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' - http -> https Turns out the https://www.oasis-open.org/standards#opendocumentv1.2 page has linked them badly with http ... Change-Id: I64d26f79f4503a6b795c4990cf92327d20fbb08a Reviewed-on: https://gerrit.libreoffice.org/65459 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-19Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' - Point to the OASIS Standards page at #opendocumentv1.2 Change-Id: Idb6c0839694337855b42b22d0ab1d98c8ae30892 Reviewed-on: https://gerrit.libreoffice.org/65455 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-19Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' - Point to the correct ODFF 1.2 specification download link The previously pointed to office-formula page is the collection of working drafts. Change-Id: Id8bc75e2192ce8da26ca1af1d8779560ace14b6b Reviewed-on: https://gerrit.libreoffice.org/65454 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-19update emoji autocorrect files from po-filesChristian Lohmaier
Change-Id: Id1ae1c7cd7beb88c0dcb9ec9c36fc3a06920def1
2018-12-19tdf#121726 add Lower and Upper Sorbian autocorrect files (emoji input)Christian Lohmaier
Change-Id: I628631f4bba4952bfa5f6e03e58cc4ab2c9c3c69
2018-12-19Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations for 6.2.0 rc1 and force-fix errors using pocheck Change-Id: Iccf11f743d0aa5c3f7fd2f0fcc12dfe105d1c071
2018-12-19FAST_ARGB_BGRA has been #defined since 2006Tor Lillqvist
Change-Id: Ia031c95c5a211f655c32afdd351afb182349e065
2018-12-19fallback to first entryCaolán McNamara
Change-Id: Ib9fb979584818d1c76be730975c57b549f372dca Reviewed-on: https://gerrit.libreoffice.org/65431 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19tdf#120859 bad column span in .ui leads to overlapping checkbuttonsCaolán McNamara
possibly(?) since... commit d999b55e28d0445df870f69b3a269964e3635def Date: Sun Dec 10 10:56:38 2017 +0530 tdf#114200 : added 'Trim space' feature in 'Text Import' made a checkbox to Trim extra white spaces from both ends while using seperators in 'Text Imort' Change-Id: I280c5daacdc823ea26d02890ddbc4685a5382e6c Reviewed-on: https://gerrit.libreoffice.org/65427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' - superfluous character Change-Id: I2c7641a6c7431a3b82b449364519f4f34bf8a8c9 Reviewed-on: https://gerrit.libreoffice.org/65446 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-19Resolves: tdf#105602 fix extended help for non-dispatchable toolbox commandsCaolán McNamara
Change-Id: I832a043ca5ae3a4030b9ac22447cecfabd3650c0 Reviewed-on: https://gerrit.libreoffice.org/65422 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19sw: fix assert in SwViewShell::FillPrtDoc()Michael Stahl
The point node isn't necessarily the start node; this will assert in SwTextFrame::MapModelToView: Assertion `SwFrame::GetDep() == pNode' failed when selecting a table and then File->Print->Print Selection. Thanks Samuel for the hint. (regression from 067a53bbcd209d7458b04142f989e1ff7ec1f785) Change-Id: I7f58b79e068e8b7817261e81f999721ebfcfdcf1 Reviewed-on: https://gerrit.libreoffice.org/65421 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-12-19tdf#122171 block closing final window while xslt filter dialog is modalCaolán McNamara
Change-Id: Ic40d4074bad7c06d1c1e395de74442f2a3bca5cd Reviewed-on: https://gerrit.libreoffice.org/65419 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19tdf#122119 make fontfeature dialog size unlimitedCaolán McNamara
Change-Id: Iacfcce9ec3a71f43fb5ce491d23184691c269944 Reviewed-on: https://gerrit.libreoffice.org/65417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19set explicit color for font feature preview bgCaolán McNamara
Change-Id: Ia7e8e6e6d7b8297063798aaf63111490f356c5c9 Reviewed-on: https://gerrit.libreoffice.org/65411 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19-Werror=class-memaccess (trunk towards GCC 9)Stephan Bergmann
..."‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type"; instead adding default member initializers to the members of WW8Fib and WW8Dop, where all ctors called memset. Unfortunately, C++17 doesn't yet allow default initializers for bit-field members, so those still need to be covered by per-ctor initializer lists for now. Change-Id: I0f4b5130d92abed2f808084813ff1089d390c809 Reviewed-on: https://gerrit.libreoffice.org/65376 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-19use ccache for jenkins/linux_clang_dbgutil_64's compilerpluginsChristian Lohmaier
Change-Id: I4a4c4ee111d6a22c899ae0d288ae04d760ec996a Reviewed-on: https://gerrit.libreoffice.org/65272 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-12-19use unique_ptr in StringResourceImplNoel Grandin
Change-Id: Id7a44c4ac5643aae96cb707d2cca217f8535ee63 Reviewed-on: https://gerrit.libreoffice.org/65404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19use unique_ptr in connectivityNoel Grandin
Change-Id: I333a3bc21d4afade6d29f096390b5edbd4e78bf9 Reviewed-on: https://gerrit.libreoffice.org/65403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19simplify OContentHelper::notifyPropertiesChangeNoel Grandin
Change-Id: I7b61b39d1057d4dd68887a2a0254592d8bdab33c Reviewed-on: https://gerrit.libreoffice.org/65405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19Removed duplicated includeAndrea Gelmini
Change-Id: Ibefbb2cc191061c8ae08c7cdf446a2ee78b43e06 Reviewed-on: https://gerrit.libreoffice.org/65301 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-19Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I4af38dbe7c54e01c3a9c0d11300a8492d68c64b5 Reviewed-on: https://gerrit.libreoffice.org/65388 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-19Fix typo in testAndrea Gelmini
It passed "make check" on Linux Change-Id: I7c7f3f39b6858d81a7e29d2df8e6703f77b6653c Reviewed-on: https://gerrit.libreoffice.org/65389 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-19Replace a macro with default member initializersMike Kaganski
Unfortunately, this doesn't work with bitfields (yet). Change-Id: I72fa3dc96324847a3dd732c3246dfe2851f93c09 Reviewed-on: https://gerrit.libreoffice.org/65392 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-07 19:08:26 +0000