summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-12-02intended to use floating point for the divisionCaolán McNamara
Change-Id: I7922d835e94ea06e519a7ff9fd212dc509e49e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-02Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to d700f1fe9e6e265d0f0125a0fb734fb2c201ce1a - tdf#134377 Refactoring built-in file dialogs Following use cases are covered: File - Save A Copy File - Export Change-Id: Id32418e944dc968cbd16100083cb2b9835084fd5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143576 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2022-12-02Resolves: tdf#152284 pull Shadow and DarkShadow from themeCaolán McNamara
Change-Id: Idd5031aa2744d5b04f9f656fcab9fe6f21e2ddcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143594 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-02tdf#152094 retain more accuracy from RefDevMode::MSO1Caolán McNamara
do it like this to avoid adding another mapmode and to keep things "the same" as much as possible Change-Id: I1965aa545646f2d27b950d6335b2f608c3e4e04b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143475 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-02Related: tdf#152284 use a different macOS DarkShadowCaolán McNamara
Change-Id: Ibea0f567e4007eda007f8f606cd0bbe5b9c6d0df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143573 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-02tdf#151842: starmath_import: Add unittestXisco Fauli
Change-Id: Iaae4880324872786f956d112a71c4f0870853f90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143568 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-02crashtesting ooo84576-1.odtNoel Grandin
fixes the SEGV crash, but not the massive memory leak Change-Id: I9d995bb9ba29b2e60386eb61e4a3b05b586c922c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-02tdf#151842: Revert "Connect new import / export to starmath"Xisco Fauli
Will create a unittest in a follow-up commit This reverts commit 9b7600f547cec9ed1bacca3a1b995b3c33fd5723. Change-Id: I10b28c3ae15f60da41a16136f3969ed6917d8a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143534 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-02Replace some uses of static_type with UnoTypeStephan Bergmann
(which is what that static_type scaffolding calls internally, anyway) Change-Id: Ibd8097de0d6a9cd0040c34e5070dafa8db256b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143566 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-02cairo_surface_t shouldn't appear in outdev.hxxCaolán McNamara
Change-Id: I906fb6525e20933f4611b3e2d81bf3524fbaf0a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-02svx: extended SvxHyperlinkItem to have a new property sReplacementTextrash419
this property is use to pass text that needs to be replaced when executing uno:SetHyperlink command in online for inserting the mention Signed-off-by: rash419 <rashesh.padia@collabora.com> Change-Id: I48fba347bda0652f7b657524f23c2dd837cd8186 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140015 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143556 Tested-by: Jenkins
2022-12-02jsdialogs: enable row/column dialogs in calcSzymon Kłos
Change-Id: I920c29b3f5afef8f37224165e6b18335b3dd50d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142974 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143554 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-12-02jsdialogs: make Content Control List Item Dialog asyncSzymon Kłos
Change-Id: I9801fb1cbcfed6b38a94a567e66f1a3f275454c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143148 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143555 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-12-02loplugin:unusedfields make some fields privateNoel Grandin
Change-Id: I1dfa1818f607fbc35a17bf13590fae47994df89d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143530 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-01tdf#151548 ContentControls: Add Delete()Justin Luth
Needed a function to delete a control, so it seemed to make sense to include it here. [I saw a nice bExact flag, but it doesn't work because RES_TXTATTR_CONTENTCONTROLS is outside of a certain range. Oh well.] make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba Change-Id: If7da3d4d614d9dfd20f539f651477cbd18d25e20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143195 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-12-01loplugin:unusedfields make some fields privateNoel Grandin
Change-Id: Ia30e3b7f10ae11c7a74e6860ac0a6115caaa439f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-01loplugin:unusedfields make some fields privateNoel Grandin
Change-Id: I7eea4baf65c0b49d0edf2516d84914f94c5194d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-01tdf#145599 Charts gets corrupted when you draw a line inside themNoel Grandin
This reverts commit 2ed8c34bca56c1a30d727b21d9096cb77e88197a use a single global item pool for chart2 draw model Change-Id: I640a981a2cbbed1cb9e6c0b0c239c78bb481e12e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-01sc: remove unused includesXisco Fauli
Change-Id: I1c108815d3f4e2de51edfd799f8c1e710fe7b1a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143532 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-01tdf#151548 ContentControls: improve GetSelectedListItemJustin Luth
Before there was only an option to get the temporarily selected list item that had not yet been committed to text. Add a function that checks whether there is a valid selected item, regardless of whether it has been written out or not. Change-Id: I1199bdccd2e665089750eefa5c3a445d56935556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143420 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-12-01drawinglayer: add StructureTagPrimitive to XML dumpMichael Stahl
Turned out to be unnecessary but why not add it. Change-Id: I8dac0f0d6ec47f98d540eb4f8c42830cd652f344 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143536 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-01Avoid dynamic cross casts to WinSalGraphicsImplBaseStephan Bergmann
Change-Id: I1102c5525f47d3e07cadc602dd55f7b78118a709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143535 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-01ofz#53873 AbrtCaolán McNamara
Change-Id: Iff720fb92f6b385003d328b73e8ebe09da3650f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-01(related: tdf#135192) svx: PDF/UA export: tag background as ArtifactMichael Stahl
ISO 14289-1:2014, Clause: 7.1, Test number: 3 Content shall be marked as Artifact or tagged as real content This needs to have an effect on ViewObjectContactOfSdrPage etc. but let's put it in ViewObjectContact and hope anything that's not SdrObject can be tagged as Artifact. Also VclMetafileProcessor2D::processStructureTagPrimitive2D() has a very peculiar habit of ignoring any obvious way to create an Artifact, which should perhaps be fixed? Change-Id: I8d22c36a8e31692d3ee24af692026e02b8faa70a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143502 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-01tdf#135192 svx: PDF/UA export: table tag primitives only if necessaryMichael Stahl
Introduce a ViewObjectContactOfTableObj which is able to check that a tagged PDF export is in progress. For the non-PDF case, for performance, fall back to calling ViewContact::createViewIndependentPrimitive2DSequence(). Change-Id: I87c86cc862c96868858f9f8617efeeab3846020f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143522 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-01tdf#135192 drawinglayer,svx: PDF/UA export: also tag TH for SdrTableObjMichael Stahl
There isn't really an indication of anything being a header row, but the table template application has a flag to apply special formatting to the first row, so let's use that as indication that it's a header row Change-Id: Ic361c84d9a1a4e91109d6f9d2cd626c9633b311f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143500 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-01tdf#135192 svx: PDF/UA export: implement tags for SdrTableObjMichael Stahl
There seems to be no way to check for isExportTaggedPDF() in ViewContactOfTableObj::createViewIndependentPrimitive2DSequence() so simply always add the tags. Change-Id: I816ed1f3811c4efad6ca28366591d135bf823c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143499 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-01CppunitTest_xmlsecurity_signing2: inherit from UnoApiXmlTestXisco Fauli
for some reason, if xmlsecurity/qa/unit/signing/signing2.cxx is executed with CppunitTest_xmlsecurity_signing, it makes testPreserveMacroTemplateSignature10::TestBody to crash, which is weird. Split them in two Change-Id: If43085dac60f197205d70294ec22ddfc86990784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143527 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-01Use cppuhelper::ImplInheritanceHelper for toolkit VCLX window classesStephan Bergmann
Change-Id: I102b49608b62b351d6a458b3fd56167b136b24e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143525 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-01sd: check files are loaded without any warning errorXisco Fauli
Change-Id: I76b4d657ab3c5606b137ab745f789156dfb9af44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143523 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-01OutputDevice::GetTextArray will always set the size of the vector anywayCaolán McNamara
Change-Id: I52f24e50455c0d480f8976ee63e442008c05c192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143520 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-01tdf#149221 Handle HID on Database Wizard dialogRafael Lima
This patch sets a help ID (HID) for the Wizard roadmap, so that when the focus is not on any specific page the general dialog help page is called. To finish this patch I'll create an additional patch in the "help" repo to define the target HID. Change-Id: I0fdce25f3b1a92836190e5a03d70a0832e0f1feb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140332 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2022-12-01we only need aOffsets if maLogicalAdvancements.hasElements() is trueCaolán McNamara
Change-Id: I79a1d406ed4f066e26bd9b2b090ce9b444e66a7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143521 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-01ofz#53904 Indirect-leakCaolán McNamara
Change-Id: Idc688c5afc14d2ba83b6af30ee6bb30c90f53ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-01tdf#144786 Implement XML_hiddenButton functionalityofftkp
Now hides autofilter button when there's an XML_hiddenButton=true or a XML_showButton=false attribute Change-Id: I911ef23fb5e4feff8c7de0ec154bff871a29f2e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143300 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-12-01sw: check files are loaded without any warning errorXisco Fauli
Change-Id: Ie48b33a93b7c2201c73418c625b63fdb2f1aec7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143519 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-01sc: check files are loaded without any warning errorXisco Fauli
Change-Id: I9163171d76e684835aff17d4777f8df88c848724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143517 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-01sc: move test back where it belongsXisco Fauli
This test was moved from sc/qa/unit/subsequent_filters_test2.cxx to sc/qa/unit/filters-test.cxx in ad40ad91c5400391a0848832e91c596be8fbd811 "CppunitTest_sc_subsequent_filters_test2: inherit from UnoApiXmlTest". As the commit message says: I couldn't find a way to test testTooManyColsRows, move it to sc/qa/unit/filters-test.cxx for the time being The problem is that using loadFromDestkop resets the Error in sfx2/source/doc/sfxbasemodel.cxx:2005 - m_pData->m_pObjectShell->ResetError(); so add a way to log the WarningError in SfxMedium Change-Id: Ieda9bdc9de856b75d4b162248da41d637305e28d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143506 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-01tdf#152078 Add a Zoom slider to the Basic IDERafael Lima
This patch adds a ZoomSlider to thee Basic IDE. It has the following characteristics: - The Zoom varies from 50% to 400% considering that 100% is the font size defined in Tools - Options - Fonts dialog. - All open editor windows use the same Zoom factor - The zoom level is saved and restored across sessions Change-Id: I63df02d0dc828fca4360d61b8aa2c7af6610d4db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143159 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-12-01Resolves: tdf#152329 Caption preview font is black when using OS dark modeCaolán McNamara
Change-Id: I2ed9ae77ecb9a5a83d88dce5a2834e6c882cfec1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143515 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-01sd: sensible naming for created cell stylesMaxim Monastirsky
Instead of "user1", "user2" etc. now we have <table-style-name>-<cell-role> e.g. magenta-dark-first-row, which makes them a lot easier to identify. Change-Id: I2db5e20f5f1d46d14034acb15b0f95c58a3f7611 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143514 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-12-01tdf#92717 Presenter screen on one monitorDaniel Lohmann
If the presenter screen should be shown as normal window (not a full screen window) the presenter screen can also be shown on one monitor, as then the presenter screen can be minimized. This is a follow up to a15bcda0e21be04bec424172192f2416b7f52422 Change-Id: I6fd19aa120a0b0e894b156b4bd10059741f91dc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143355 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-12-01Handle PolyPolygonGraphicPrimitive2D with used DefinitionRange correctlyArmin Le Grand (allotropia)
If the range which defines the bitmap fill is defined and different from the range of the defining geometry (e.g. used for FillStyle UseSlideBackground) this cannot be expressed in a SvtGraphicFill data package. Thus, just use decomposition here directly. See also tdf#149754 in drawinglayer/source/processor2d/vclpixelprocessor2d.cxx and the comment there for more info. Change-Id: I8e1b26fb2bf523e6fd7af1040166f8197747e7ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143503 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-12-01vcl: remove unnecessary includesChris Sherlock
Change-Id: I41cb0b38857ddeef7cb7f82c1b523a9c7fcf2413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143324 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-30Add LOKit functions and whitelist export for it to WASMThorsten Behrens
For calling into LOWA from native JS, make lokit functions available Change-Id: I6458806f33131e48692f35f2a2438b35efb1f06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143497 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-11-30WASM: need sw/../translatehelper.cxx backThorsten Behrens
..since that now contains helper methods like PasteHTMLToPaM Change-Id: Ib8752e93ca52b17c173d0e18dd727a426fde893e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143483 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-11-30Avoid a dynamic cross cast on macOSStephan Bergmann
...now causing > In file included from vcl/osx/a11ytextattributeswrapper.mm:23: > vcl/inc/quartz/salgdi.h:283:22: error: suspicious dynamic cross cast from 'AquaGraphicsBackendBase *' to 'SalGraphicsImpl *' [loplugin:crosscast] > mpImpl = dynamic_cast<SalGraphicsImpl*>(this); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I0c9a4af0690c195c693f986e02284a48fe753a07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143505 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-30Resolves: tdf#152317 macOS Calc highlighted sheet name unreadableCaolán McNamara
Change-Id: Ib6af275b055dbfdcce615df5de61cb2233b8797c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143509 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-30related tdf#152305 writerfilter: avoid comment-related exceptionsJustin Luth
a comment anchored in a table sees m_nTableDepth, but while in the comment it shouldn't affect the table itself. I did a search for m_nTableDepth and added !m_bIsInComments everywhere that looked reasonable. Change-Id: Iaaaf2f2b5a9f409146111b2e8546573c264e75ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143510 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-11-30flat-odf-cleanup.py: remove some presentation related stylesMichael Stahl
Change-Id: I385941f83237464eb02e4e543a67e24f22bddac7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143498 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>