summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-19Fix typosAndrea Gelmini
Change-Id: Ica623a5312196ff6a3538027e7c72ba4afe92f5c Reviewed-on: https://gerrit.libreoffice.org/57604 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19tdf#118800 fix rounding error in Calc function HOUR, MINUTE, SECOND.Winfried Donkers
Change-Id: I7a875b172493112b66fca8f70d2061371a05486c Reviewed-on: https://gerrit.libreoffice.org/57721 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-19Fix typosAndrea Gelmini
Change-Id: I7d12fe95d1c65a431325273c6e95943166e2ec58 Reviewed-on: https://gerrit.libreoffice.org/56941 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19Fix typosAndrea Gelmini
Change-Id: If7365b05c8f4fd1bf130678cb28f05c9a1add4c7 Reviewed-on: https://gerrit.libreoffice.org/57598 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19Fix typosAndrea Gelmini
Change-Id: Iceeef5a003f8550063a0163d39e73de91a6378d2 Reviewed-on: https://gerrit.libreoffice.org/57601 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19Fix typosAndrea Gelmini
Change-Id: I2aa5448869bf60e9c8d9b1ebabd0d0932d28f3a1 Reviewed-on: https://gerrit.libreoffice.org/57606 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19tdf#117038 set button width to max possible content widthCaolán McNamara
Change-Id: I97e7c27523d213cb06cdf87a8ed0124d1ea8d5ba Reviewed-on: https://gerrit.libreoffice.org/57717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#118330 Terminology change of CONTENTS sidebar Change-Id: Ibb7b5d85f39e1a097ff85e74f2f2be69ab48bc57 Reviewed-on: https://gerrit.libreoffice.org/57018 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-19tdf#108012 - Clicking in the font field should select the contentsNickson Thanda
Change-Id: I1276976e031b419ca5cc3cc8e848f2af58ce4cfb Reviewed-on: https://gerrit.libreoffice.org/56865 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-19tdf#118816 recover initial intent of enabled possibility of tristate as a flagCaolán McNamara
Change-Id: I0150b96e063818cc20e2404081b906ccc5ff0be6 Reviewed-on: https://gerrit.libreoffice.org/57712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19Avoid gcc: "specified bound depends on the length of the source argument"Tor Lillqvist
Just use memcpy(). Change-Id: Icb705acb6c12baf28684c763a77da7abc514ea6d Reviewed-on: https://gerrit.libreoffice.org/57714 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-07-19loplugin:useuniqueptr in SwUndoMergeTableNoel Grandin
Change-Id: I5c75bc85019be1e4bd25b955f873e230c0ffe132 Reviewed-on: https://gerrit.libreoffice.org/57695 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19Resolves: tdf#118115 add missing help response idCaolán McNamara
Change-Id: Ie050285cc10d82cf80e560be3f1766c50dd1527c Reviewed-on: https://gerrit.libreoffice.org/57715 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19loplugin:useuniqueptr in SwUndoSplitTableNoel Grandin
Change-Id: I364d57e30a3b8470d1b4739096f13248e1389a08 Reviewed-on: https://gerrit.libreoffice.org/57694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:useuniqueptr in SwHTMLParserNoel Grandin
Change-Id: I2be859198aa176d239dbfa5684f25ab2be8d517e Reviewed-on: https://gerrit.libreoffice.org/57689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:useuniqueptr in SwUndoTableCpyTableNoel Grandin
Change-Id: I819c96ed7aec51f546cdc8442154dbba7110d961 Reviewed-on: https://gerrit.libreoffice.org/57693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:useuniqueptr in SwUndoTableNumFormatNoel Grandin
Change-Id: I6e27bdad49ec22708cf27599e9e4d54a13a160c3 Reviewed-on: https://gerrit.libreoffice.org/57692 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19Related: rhbz#1602589 null_check: 'xComponent'Caolán McNamara
Change-Id: I591f9fa611c0ad0d1631d179b7263f83613badfb Reviewed-on: https://gerrit.libreoffice.org/57640 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19xmlsecurity: stop linking to libxmlsec's mscrypto backendMiklos Vajna
This was only useful when the mscrypto to mscng porting was in progress. Change-Id: I5a062cae744489e5ad311ab6b531d00ea21f4e0a Reviewed-on: https://gerrit.libreoffice.org/57699 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-19Remove unused parameter bBrowseRegina Henschel
The parameter bBrowse in ReadUserDataSequence and WriteUserDataSequence was only forwarded in the call chain and finally ignored in class ViewShell. Change-Id: Ibc8fd6ce92dd700e70e5bcf11de5bd93e5e14986 Reviewed-on: https://gerrit.libreoffice.org/56034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:useuniqueptr in SwHTMLWriterNoel Grandin
Change-Id: I7017cbd4e572865353e10cea1463aeaba7adf439 Reviewed-on: https://gerrit.libreoffice.org/57690 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:useuniqueptr in SwUndoTableMergeNoel Grandin
Change-Id: I0c528c2b12d219f37a2c2fdf2211fce3c51ad9e4 Reviewed-on: https://gerrit.libreoffice.org/57688 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:useuniqueptr in SwViewShellImpNoel Grandin
Change-Id: Ied98688ca83652d92838f1ad01861068cd438c66 Reviewed-on: https://gerrit.libreoffice.org/57687 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:useuniqeptr in SwUndoTableToTextNoel Grandin
Change-Id: I8c888db9190b1938c0375deb09868951fc9d7aa9 Reviewed-on: https://gerrit.libreoffice.org/57686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:useuniqueptr in SwUndoTextToTableNoel Grandin
Change-Id: Ifa873c977b925ca446ba547ec59ddde2345eb0e2 Reviewed-on: https://gerrit.libreoffice.org/57685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:constantparamNoel Grandin
Change-Id: I8e2e9009f0a70d2fa390e03688a988ac935d5f36 Reviewed-on: https://gerrit.libreoffice.org/57643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:unusedmethodsNoel Grandin
Change-Id: I2b7a055a44c63bfc072b82580811898e177fbb8e Reviewed-on: https://gerrit.libreoffice.org/57628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19tdf#98477 convert to, from, by of AnimScaleContext.Mark Hung
To, from, by of AimScaleContext used to use return value of oox::draingml::GetPointPercent(), which is in 1000th of a percent, but slideshow need ratio to work. Make a conversion here, also fix the obvious error in oox::draingml::GetPointPercent() that y coordinate is always converted incorrectly. Change-Id: I061d2ce89341a4e88f3ffada03954734fafad985 Reviewed-on: https://gerrit.libreoffice.org/57434 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-18Do not force all string results to be recalculated if no style setEike Rathke
Results are forced to recalculate for cells with General format in case they need to inherit a format that then can be set. However, a General format will never lead to some other format being set for any string results and almost all string result cells will have General format because the string is already what is being displayed. So for formula cells with a string result available do not allow to use ScFormulaCell::SetNeedNumberFormat() forcing the need to recalculate. This popped up during intercepting for tdf#118735 when the formula cell containing a WEBSERVICE() call is set dirty, through CompileXMLHandler::operator()(...) if (pCell->NeedsNumberFormat()) pCell->SetDirtyVar(); Which again, as WEBSERVICE() has to be recalculated to populate the link manager, made it necessary to add that to ScRecalcMode::ONLOAD_LENIENT (which it should already had been before (when that was ONLOAD), but no harm in this case). Change-Id: I0dc2cdfe35c56d9843f0edd24a6d14e3de79f7ef Reviewed-on: https://gerrit.libreoffice.org/57700 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-18Allow the comphelper threadpool to be reset after construction.Michael Meeks
Otherwise some pre-init components can start it, and threads get stranded in the forkit process causing grief. Change-Id: Ib1846f8b329b4c6b84645999dafba1252c5129c7 Reviewed-on: https://gerrit.libreoffice.org/57631 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-18tdf#118579 ignore body in body instead of flagging as an errorCaolán McNamara
Change-Id: Ie6626a320a5264aea004f7c57244643798703de8 Reviewed-on: https://gerrit.libreoffice.org/57652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Resolves: tdf#118802 map GTK_RESPONSE_DELETE_EVENT to RET_CANCELCaolán McNamara
Change-Id: I8285f329e4672c90f47d96ccffe60c21c565dde7 Reviewed-on: https://gerrit.libreoffice.org/57655 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Related: tdf#118735 WEBSERVICE preserve the hybrid string result, if possibleEike Rathke
Possible only for constant literal URI arguments, as otherwise we wouldn't know whether the hybrid string result actually matches the call, and possible only for the very first recalc as the hybrid string result will be replaced by the calculated result. However, executing an initial recalc is necessary to add the (then determined and maybe calculated) URI to the link manager after having loaded a document. Change-Id: I67738c13ecce54b43ebb52ea8a8282aebee5f03a Reviewed-on: https://gerrit.libreoffice.org/57696 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-18tdf#118528 sw layout: only direct formatting for EmulateTableKeepJustin Luth
Emulating MSWord's way of keeping a table with the next paragraph has caused a few complaints, but never anything that seemed to clearly indicate a real problem - usually just badly designed documents. But a common theme has been the keep attribute coming through styles. Since our export-emulation writes directly to the paragraph properties, lets make the emulation dependent on direct formatting to avoid some of these complaints. Change-Id: I008fc7b6a7083292463c20972ad209761ec97601 Reviewed-on: https://gerrit.libreoffice.org/57613 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-18Resolves: tdf#118562 set correct help button placementCaolán McNamara
Change-Id: Ia7e5a5ba549c5824b43b36e6b3350b4b5f6c9118 Reviewed-on: https://gerrit.libreoffice.org/57657 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-18uitest Calc - key F4Zdeněk Crhonek
Change-Id: I3c16c41a797b219811d37bbae97f7b176bb5782e Reviewed-on: https://gerrit.libreoffice.org/57650 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-18Related: rhbz#1602589 copy_paste_error: 'global_image_list'Caolán McNamara
Change-Id: I4151819d5c628a85f487f7d9a8358e92553aaf03 Reviewed-on: https://gerrit.libreoffice.org/57639 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18sw HTML export: force PNG output harder in reqif modeMiklos Vajna
Need to disable one more flag to avoid GIF for transparent images. Also start asserting reqif-xhtml output with an XML parser. Change-Id: I1395812a5ddfd56cee4acacf6dea46c6e413b736 Reviewed-on: https://gerrit.libreoffice.org/57630 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-18lokdialog: no invalidation when in init showPranav Kant
This improves LOK dialog opening time considerably. libreofficekit/tilebench results: Before: profile run: initialization - 346.5185(ms) load document - 2162.5881(ms) open dialog - 7077.8980(ms) wait for dialog - 52.7742(ms) render dialog - 256.9597(ms) post close dialog - 523.7811(ms) destroy document - 58.3723(ms) Total: 10.4789(s) After: profile run: initialization - 336.5867(ms) load document - 2155.5481(ms) open dialog - 1151.4130(ms) wait for dialog - 51.5332(ms) render dialog - 260.3197(ms) post close dialog - 519.8729(ms) destroy document - 56.7322(ms) Total: 4.5320(s) Change-Id: I6345aca33c5881aba33c8a5f74765b99fe098711 Reviewed-on: https://gerrit.libreoffice.org/57561 Tested-by: Jenkins Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-07-18Related: rhbz#1602589 null_check 'guiRow'Caolán McNamara
Change-Id: I0c93e6a721646363e5b71ec0e9db6199e7cce006 Reviewed-on: https://gerrit.libreoffice.org/57641 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18tdf#104277 - Added restart buttons to OpenCL restart dialogNickson Thanda
Change-Id: Icf31d0516deb7844c8be1003219cbacae1cdc5ec Reviewed-on: https://gerrit.libreoffice.org/57537 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-18tdf#112261 - Recent characters are now fixed widthNickson Thanda
Change-Id: I4a36e4e2e76fc2935c57b00b5f47d33c15b557d1 Reviewed-on: https://gerrit.libreoffice.org/57558 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-18Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I73ea0f836852dc40c81f167d409ca0294100676e Reviewed-on: https://gerrit.libreoffice.org/57610 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-18Access2Base - tdf#118680 Fix VARCHAR_IGNORECASE errorJean-Pierre Ledure
Precision property of com.sun.star.sdbcx.Column service is set to the maximum length for VARCHAR database fields while it remains at 0 for VARCHAR_IGNORECASE fields. Access2Base reported erroneously an overflow error.
2018-07-18Related: rhbz#1602589 dead_error_line: Execution cannot reach this statementCaolán McNamara
Change-Id: If0e4ea982ede92d564aafb247c789cc6cc3013ca Reviewed-on: https://gerrit.libreoffice.org/57638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Resolves: tdf#118520 insert sheet list not horizontally expandedCaolán McNamara
Change-Id: I0004602631fb82ed13d925a1911ea4ada544462d Reviewed-on: https://gerrit.libreoffice.org/57632 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' - Related: rhbz#1602589 unreachable code Change-Id: I420ed94f178dcdb7bbaba6078b7b3c6730053a34 Reviewed-on: https://gerrit.libreoffice.org/57647 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Related: rhbz#1602589 copy_paste_error: 'getKeyTimes'Caolán McNamara
Change-Id: I2b48d8c75af42429ce41a8f809fc3ac82cb354de Reviewed-on: https://gerrit.libreoffice.org/57636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18tdf#118355 Repl Default / Text Body in Style menuOlivier Hallot
Replace Default Paragraph Style by Text Body, as justified in bug report. Change-Id: Idca1bf437af7d3df838b65bf9991f08e18260c85 Reviewed-on: https://gerrit.libreoffice.org/56709 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-18tdf#118354 Do not dereference non-exsisting ObjectArmin Le Grand
Change-Id: Ie7323302f3b29dfc19b26e2185321c2e609cab2b Reviewed-on: https://gerrit.libreoffice.org/57629 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>