summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-10-24assert on invalid param in OPropertyContainerHelper::getFastPropertyValueNoel Grandin
which flushes out a bug in OPropertySetHelper::getPropertyValueImp Change-Id: I5d3928e55eb9f019629896ad6478011520318fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-24slideshow: improve grammar for repeat slideshow in sidebarJaviya Vivekkumar Dineshbhai
Change-Id: Ibe3ca1c11a9dcbb82cadc0ab531e9a69fe275769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175535 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-24Resolves tdf148513 - Illustration for line break optionsHeiko Tietze
Change-Id: I729c4a1e5c4b2a73cdb8d3a5c4969e3b43510deb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174038 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-10-24Reapply "Prevent cursor invalidation if the cursor position doesn't change."Gülşah Köse
This reverts commit 8da753752898984425c98a7f3db02b1aa69b74c8. Merge cells case were failing. Fixed now. Change-Id: I1dfd7e939c5590d64d096707edff40cb414ef3cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174813 (cherry picked from commit a260cc52b2fae1382805b4389c95f29ed8671f42) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175302 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins
2024-10-24tdf#130857 qt weld: Handle entry for editable comboboxesMichael Weghorn
An editable GtkComboBox has a "has-entry" property of "true" and an internal GtkEntry child. Make the QComboBox editable depending on that "has-entry" property. Mark the QLineEdit object created for the "GtkEntry" for deletion again, as the QComboBox already has a QLineEdit by itself if it's editable, and the one created for the internal child would otherwise be useless and oddly overlap the combobox. (Seen e.g. with the "Tools" -> "Options" -> "Languages and Locales" -> "Writing Aids" -> "New" dialog" in a WIP branch where that dialog's .ui file ("cui/ui/optnewdictionarydialog.ui") was added to the list of supported files for QtInstanceBuilder. More work is needed on other aspects still.) Change-Id: I25ea74c732e60f50035604a4fc75dad50f4cf55f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175531 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24tdf#130857 VclBuilder: Make extractEntry a static helperMichael Weghorn
... in the base class BuilderBase, in order to reuse it in QtBuilder in an upcoming commit. Change-Id: Ia115804a9d2bf22b47afb94d97109e9495b21cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175530 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24tdf#130857 qt weld: Implement QtInstanceComboBox::insert_vectorMichael Weghorn
Change-Id: I71b1e8c596ca1f6790e93bdd7d73a9e5c583c278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175529 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24tdf#130857 qt weld: Implement QtInstanceComboBox::insert_separatorMichael Weghorn
As can be seen in the SalInstanceComboBoxWithoutEdit::insert_separator implementation, -1 for the index means "Insert at the end", so do likewise. And also ignore the ID parameter, as QComboBox::insertSeparator (other than (QComboBox::insertItem) doesn't take a QVariant for user data. Change-Id: I98959abf61ec670d78bf341a726b9854127d95e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175528 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-24tdf#130857 qt weld: Implement ID handling for combobox entriesMichael Weghorn
Implement methods related to IDs for combobox entries by handling OUString ID as a QString variant for the user data of the combobox item. Change-Id: I57750df203c333aa9dcc99c960c64de5f4ff50d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175527 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-24qt: Have just a single toQString(const OUString&)Michael Weghorn
Move the `toQString` helper function to include/vcl/qt/QtUtils.hxx where it can be used from multiple modules, instead of defining it twice for both, avmedia (avmedia/source/qt6/QtPlayer.cxx) and vcl (vcl/inc/qt5/QtTools.hxx). Change-Id: I7ffe06eaa3aaf3e7c8cc7aa1a4ac41b14db5c20c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175526 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-24tdf#130857 qt weld: Implement QtInstanceButton::set_from_icon_nameMichael Weghorn
Make use of the `loadQPixmapIcon` helper function introduced in previous commit Change-Id: I9f25aa5ca8f00da97d06ecdd164a8fae10e492dd Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Oct 23 23:21:23 2024 +0200 tdf#130857 qt: Move pixmap helper to new include/vcl/qt/QtUtils.hxx With this commit, the native Qt version of Calc's "Tool" -> "Goal Seek" dialog looks OK at first glance (buttons have the icons set) in a WIP branch that adds that dialog's .ui file ("modules/scalc/ui/goalseekdlg.ui") to the list of supported files in QtInstanceBuilder::IsUIFileSupported. (But clicking a button doesn't yet behave the same way as in the non-welded/VCL version, so more work is needed before that can actually be enabled.) Change-Id: Icc83e874a76b7ccd600bd6741a9e02958759f4d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175525 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-24tdf#130857 qt: Move pixmap helper to new include/vcl/qt/QtUtils.hxxMichael Weghorn
Introduce include/vcl/qt/QtUtils.hxx as a new header for Qt-specific utility functions that can be used in multiple modules, e.g. avmedia and the Qt VCL plugins in vcl. This is meant to be used only by code that already links in Qt. There's already vcl/inc/qt{5,6}/QtTools.hxx for helpers needed in vcl only. Initially, add a `loadQPixmapIcon` helper function that can be used to retrieve a QPixmap for an icon name and is extracted from QtPlayer::createMediaPlayerWidget in avmedia. It will be reused to implement the QtInstanceButton::set_from_icon_name logic in an upcoming commit. Change-Id: I9f25aa5ca8f00da97d06ecdd164a8fae10e492dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175524 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24tdf#130857 printersetupdialog.ui: Define focusable widgets in orderMichael Weghorn
Align the order in which the focusable widgets (combobox, "Properties" button) are defined in the .ui (XML) file with the order in which they should receive focus. While the position in the GtkGrid is defined by the "left-attach" and "top-attach" packing properties and QtBuilder evaluates those, the tab order in Qt by default matches the order in which widgets are created (s. e.g. [1]). Without this commit in place the "properties" button was constructed before the "name" combobox (because it was further up in the .ui file, i.e. the XML parser processed it earlier), resulting in an unexpected order when using the Tab key to navigate through the "Tools" -> "Printer Settings" dialog: From the "Options" button in the button box, focus would jump to the "Properties" button, and only then to the combobox, and from there, it would jump to the "Help" button in the button box. Now, it jumps from the "Options" button to the combobox, and after selecting the printer there, pressing Tab another time moves focus to the "Properties" button as expected, which can be used to open another dialog that allows to change properties of the previously selected printer. A potential alternative to adjusting the .ui file could be to explicitly set the tab order using QWidget::setTabOrder [2] in QtBuilder. [1] https://doc.qt.io/qt-6/designer-tab-order.html [2] https://doc.qt.io/qt-6/qwidget.html#setTabOrder Change-Id: If3aa014e20b97fe8bb772ef212741af1433b0244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175523 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24tdf#130857 qt weld: Declare support for "Printer Settings" dialogMichael Weghorn
Add .ui file of the "File" -> "Printer Settings..." dialog available e.g. in Writer to list of files supported by QtInstanceBuilder, so that native Qt widgets are used for that dialog now when using the qt5/qt6 VCL plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set. Change-Id: I7806688102f690faa02fb5e712943d6ae216ff9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175522 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24tdf#130857 qt weld: Signal when current combobox item changesMichael Weghorn
Connect to the QComboBox::currentIndexChanged signal and call `weld::ComboBox::signal_changed` to notify of that change. This is in preparation for upcoming Change-Id: I7806688102f690faa02fb5e712943d6ae216ff9a Author: Michael Weghorn <m.weghorn@posteo.de> tdf#130857 qt weld: Declare support for "Printer Settings" dialog and causes the infos for the printer previously selected in the combobox in the "File" -> "Printer Settings" dialog to be shown after selecting a printer other than the initially selected one in the combobox, then clicking the "Properties" button in that dialog. (Without this, properties of the initially selected printer would always be shown.) Change-Id: I9a8609e172fd1d6783a86395ff58e64b7cf5c4d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175521 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24tdf#130857 qt weld: Implement combobox entry sortingMichael Weghorn
Implement sorting for combobox entries by adding a QtInstanceComboBox::m_bSorted member that gets set to true when QtInstanceComboBox::make_sorted gets called, and sort entries then and whenever a new entry gets inserted afterwards. This is in preparation for upcoming Change-Id: I7806688102f690faa02fb5e712943d6ae216ff9a Author: Michael Weghorn <m.weghorn@posteo.de> tdf#130857 qt weld: Declare support for "Printer Settings" dialog Change-Id: I54140db4310c7b288fe3be0e73000860410068fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175520 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24tdf#130857 qt weld: Fix condition for not implemented combobox caseMichael Weghorn
The case where `pImageSurface` is non-null needs special handling, and that isn't implemented yet. (The assert would be triggered for the "File" -> "Printer Settings" dialog otherwise once declared as supported in an upcoming commit.) Change-Id: I1a7d352e24de13417aac28d1d4b514709a8e97d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175519 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24framework: Deduplicate code setting menu accelerator keysMichael Weghorn
Introduce new helper method MenuBarManager::SetAcceleratorKeys and call that from both places that are setting accelerator keys, to deduplicate code and simplify future maintenance. The use in MenuBarManager::FillMenuManager was introduced in commit 08fe2669a0ed807812d005195b54cc41f092d09a Author: Rüdiger Timm <rt@openoffice.org> Date: Fri May 13 06:29:54 2005 +0000 INTEGRATION: CWS tbe22 (1.25.30); FILE MERGED 2005/05/04 14:21:00 tbe 1.25.30.1: #i48612# Opening a menu with GOK shows Tips instead of entries (fixed by CD) and looks like it was primarily copy-pasted from the other place. Change-Id: I2097619740d45260e534ce06f9941337177f1bde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175509 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-24framework: Move var declaration close to use, drop another oneMichael Weghorn
Move variable/code from the beginning of MenuBarManager::Activate to where they're actually used, to increase readability. Change-Id: I885c6039fd77a023204b60bfc8ef97089d98716a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175508 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-24framework: Drop extra scope for setting accelerator keysMichael Weghorn
This is in preparation of deduplicating code in an upcoming commit. (Use `git show --ignore-space-change` to see the "actual change" more clearly.) Change-Id: Ibc9b8d8f77c2b2182c359a287eb604a92ed9c4e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175507 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24sw a11y: Don't prevent zooming into print preview when AT activeMichael Weghorn
In Writer's print preview ("File" -> "Print Preview"), allow zooming in or out using Ctrl + mouse wheel regardless of whether assistive technology is enabled (on Windows) or not. I see no reason to prevent this when AT is active. This was originally introduced in commit 70de0c38fd177b3c95837118c5fb35e380c87e90 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Thu Mar 27 14:45:43 2003 +0000 MWS_SRX644: migrate branch mws_srx644 -> HEAD with a //#106746# zoom has to be disabled if Accessibility support is switched on comment, but that unfortunately only refers to a ticket in the StarDivision internal issue tracker, so the reasoning from back then remains unclear. (`git show --ignore-space-change` to see the "actual change" more clearly) Change-Id: Iccec17a334dbe19de14cf7889d7f70f0051f152e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175502 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-24win a11y: No longer read/write registry keyMichael Weghorn
No longer attempt to write a registry "SupportAssistiveTechnology" in "HKEY_CURRENT_USER\Software\LibreOffice\Accessibility\AtToolSupport" when assistive technology support gets enabled (e.g. because a screen reader is running) and no longer try to read that registry key to determine whether or not AT tool support is requested. While the comment // Check in the Windows registry if an AT tool wants Accessibility support to // be activated .. seems to suggest that this is something requested by an assistive technology, it looks more like a way to persist whether the a11y bridge was ever used in LO, as LO itself writes that value. I don't really see the point, but think it makes much more sense to enable the a11y bridge if an AT is active *at the moment*. In addition, in my Windows 10 setup with LO 24.8 installed, there's no "HKEY_CURRENT_USER\Software\LibreOffice" in the registry, only a "HKEY_CURRENT_USER\Software\The Document Foundation\LibreOffice 24.8", so the code wouldn't have any effect in practice anyway. Maybe this was necessary at some point in the past when the Java Access Bridge was still in place, instead of supporting the platform API via today's MSAA/IAccessible2 bridge Note that before commit bfbaeb8192447265bdd78d1be4990947d135eb6e Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Oct 18 17:01:43 2024 +0100 tdf#160982 wina11y: Drop extra screen reader check to enable a11y bridge , the presence or absence of the SPI_GETSCREENREADER param or a SAL_FORCE_IACCESSIBLE2 environment variable would additionally have played a role. Change-Id: I4dddb599eedb4b29c9709fbb41093ef615e60b8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175501 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24win: Drop local var assigned to but never readMichael Weghorn
Change-Id: I302e014134d5f91a4d454d3b137743af3c455997 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175473 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24Fix typoAndrea Gelmini
Change-Id: Ib40f9fa2d618cf4400a814d1d6e222768bf7bba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175505 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-10-24tdf#163580 Open online Help, if warn option is not checkedIlmari Lauhakangas
Change-Id: I438032955f399a8b4737d100bee8a3db54427525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175468 Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Jenkins
2024-10-23tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 277, 297 Change-Id: Ie30c5da744cb29de5db4a2b1e0f4096daf8b6bd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175425 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-23tdf#157222 swap info texts of connector end pointRegina Henschel
Change-Id: I3d1d1ed27afbdf7700882a12bcd25643e37c3564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175513 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-10-23Following 250e00a51dcf60ac2e028983f5d29c0f68748b38 (JDBC4.3)Julien Nabet
Change-Id: I08b71b9c0504af7ed4af84456ce49dc2fe7274af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175472 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-10-23tdf#163486: PVS: check mpViewShXisco Fauli
V595 The 'mpView' pointer was utilized before it was verified against nullptr. Check lines: 719, 720. Change-Id: Ie1bda82df979fd5f293fb6eb9623917371e9da34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175113 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-23unoxml: port testXText from java to c++Xisco Fauli
Change-Id: I548bfde6a78832dbb53f3b154ae79223fdc69454 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175510 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-23tdf#163486: PVS: check pTabWinTmpXisco Fauli
V595 The 'pTabWinTmp' pointer was utilized before it was verified against nullptr. Check lines: 496, 499. Change-Id: Ie263524d6a06adaf7f99555d7aa872e815cab96c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175504 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-23tdf#163486: PVS: Expression is always trueXisco Fauli
V547 Expression 'eFunc == KeyFuncType::DONTKNOW' is always true. Change-Id: Ia88333958bfc80555ecabd7113ef6a1805714c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175506 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-23tdf#130857 qt weld: Add initial combobox handlingMichael Weghorn
* Add new class QtInstanceComboBox as a weld::ComboBox implementation using a native QComboBox. Implement some of the most important and straightforward methods and trigger an assert for all others for now. * In QtBuilder::makeObject, handle the "GtkComboBoxText" case and create a QComboBox for that. * Implement QtInstanceBuilder::weld_combo_box to return a QtInstanceComboBox instance. Change-Id: I2ac2d0f55a948ea2f090c81096484e22899ddcbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175443 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-23tdf#131728 sw inline heading: fix missing/broken DOCX exportLászló Németh
Fix layout interoperability during DOCX round-trip by grab- bagging w:p/w:pPr/w:rPr/w:specVanish, i.e. the style separators. Note: use FrameInteropGrabBag to select the text frames, which are inline headings, exporting only their text content (a single paragraph), and use also ParaInteropGrabBag to export w:specVanish. Note: specVanish lost completely originally, converting inline headings to normal paragraphs. After commit 56588663a0fddc005c12afaa7d3f8874d036875f, text frames (the workaround for inline heading/ToC/bookmark support) were exported instead of plain paragraphs, which were broken at least in LibreOffice. Follow-up to commit 56588663a0fddc005c12afaa7d3f8874d036875f "tdf#131728 sw inline heading: fix DOCX paragraph layout interoperability". Change-Id: Ic61617f9c9652c9364f8262914c66dec093d6910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175372 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-10-23add Tagalog (tl) langauge- & helppackChristian Lohmaier
Change-Id: I9fdb30215f6b64ae025a7e8e468e84426044ff80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175503 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-10-23tdf#163486: PVS: check stream read instead of EOFXisco Fauli
V1024 The 'aIfstream' stream is checked for EOF before reading from it, but is not checked after reading. Potential use of invalid data. Change-Id: I253513c47ec1482882bbfb1c6e32e25c15ace99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175475 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-23tdf#163486: PVS: enum type as boolXisco Fauli
V768 The variable 'eS' is of enum type. It is odd that it is used as a variable of a Boolean-type. Change-Id: I959f58e80cd0a2d82e6c9fffe140a442cf4dbb0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175477 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-23Try to apply indents a bit sanerMike Kaganski
It was too convoluted; the three properties that were set there all used different logic (PROP_PARA_FIRST_LINE_INDENT was only set when the parent style id was present; PROP_PARA_LEFT_MARGIN was set when it was found either in the entry or in its parent; PROP_PARA_RIGHT_MARGIN was only set when parent style was found, and it had properties). It seems to be just some leftovers from iterative partial changes of the code. This makes the code more uniform. For PROP_PARA_RIGHT_MARGIN it keeps setting PROP_PARA_FIRST_LINE_INDENT/PROP_PARA_LEFT_MARGIN from getNumberingProperty; but otherwise, all three are handled similarly: if the property is set either in the entry itself or in its parent, it is processed. This changes the logic slightly, but hopefully in the correct direction. Change-Id: I1a8fb95d055101dcbc3aaec6207721146c94cc21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175437 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-23Deduplicate a bitMike Kaganski
Change-Id: Iace3fdfdaed79054fda2894b5d9f4275f80a5e0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175440 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-23tdf#163486: PVS: enum type as boolXisco Fauli
V768 The variable 'eType' is of enum type. It is odd that it is used as a variable of a Boolean-type. Change-Id: I38f0302d8edcaef144f6071dc86500937d305591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175478 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-23tdf#163486: PVS: check stream read instead of EOFXisco Fauli
V1024 The 'aInput' stream is checked for EOF before reading from it, but is not checked after reading. Potential use of invalid data. Change-Id: Ie0c6d1928dad804b21d3c9920cc1de8035ea0367 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175476 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-23tdf#152943: Add NaN payload check at the start of sc_ucalc test sequenceSakura286
Some archs does not support NaN payload(e.g. riscv64). It would be meaningless to continue building a test related to NaN payload if the builder doesn't support this feature. Change-Id: I895a8647bf7ff68f645faa7428d30b1c741669f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175293 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2024-10-23tdf#90341 Clean up excessive const_cast'ingUsman Akinyemi
These changes improve const-correctness and reduce the need for const_cast usage. Change-Id: I1275edfbc0ca5d49a5e8339d1ed11148f6decd1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174701 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2024-10-23Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 7ee58e4082404ba303bae416befc5022de55fce4 - add Tagalog (tl) translations Change-Id: Ifa0fcaea9ea720297ba6957c3dacce8513344266 - update translations for master and force-fix errors using pocheck Change-Id: Ibbe54e16a51701c8559fbfa2b7619640e517c0e1
2024-10-23tdf#163486: PVS: missing while loop iteratorXisco Fauli
Since commit c5db3b93ee1058bd20ebcde2e757b52b9a67b74a Author: Michael Stahl <mst@openoffice.org> Date: Thu Feb 10 16:45:02 2011 +0100 xmlfix3: unoxml: prevent invalid child-parent relationships: V1044 Loop break conditions do not depend on the number of iterations. Change-Id: I611911bdcdb812ed46a529a217ab6612a254f441 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175174 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-23xmlsec: upgrade to 1.3.6Xisco Fauli
Downloaded from https://www.aleksey.com/xmlsec/download/xmlsec1-1.3.6.tar.gz Change-Id: I29714d220a07b600ea74e89ad62be8b50249c158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175471 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-23Simplify a bitMike Kaganski
Change-Id: I7d24774fb591fe2090523da29a2a0aa7608deccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175435 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-23Avoid signed integer overflowStephan Bergmann
...as seen at > /tools/source/misc/fix16.cxx:79:53: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int' > #0 0x7fc2f9f50a60 in mask(int) /tools/source/misc/fix16.cxx:79:53 > #1 0x7fc2f9f505fd in fix16_div(int, int) /tools/source/misc/fix16.cxx:122:34 > #2 0x7fc2f00d12e0 in vcl::fixedDiv(int, int) /vcl/source/fontsubset/sft.cxx:127:12 > #3 0x7fc2f00d11c1 in vcl::fixedMulDiv(int, int, int) /vcl/source/fontsubset/sft.cxx:135:12 > #4 0x7fc2f00d0851 in vcl::GetCompoundTTOutline(vcl::AbstractTrueTypeFont*, unsigned int, std::__debug::vector<vcl::ControlPoint, std::allocator<vcl::ControlPoint> >&, vcl::(anonymous namespace)::TTGlyphMetrics*, std::__debug::vector<unsigned int, std::allocator<unsigned int> >&) /vcl/source/fontsubset/sft.cxx:544:91 > #5 0x7fc2f00af5f1 in vcl::GetTTGlyphOutline(vcl::AbstractTrueTypeFont*, unsigned int, std::__debug::vector<vcl::ControlPoint, std::allocator<vcl::ControlPoint> >&, vcl::(anonymous namespace)::TTGlyphMetrics*, std::__debug::vector<unsigned int, std::allocator<unsigned int> >*) /vcl/source/fontsubset/sft.cxx:621:15 > #6 0x7fc2f00aea34 in vcl::GetTTGlyphPoints(vcl::AbstractTrueTypeFont*, unsigned int, std::__debug::vector<vcl::ControlPoint, std::allocator<vcl::ControlPoint> >&) /vcl/source/fontsubset/sft.cxx:1239:12 > #7 0x7fc2f00b92de in vcl::GetTTRawGlyphData(vcl::AbstractTrueTypeFont*, unsigned int) /vcl/source/fontsubset/sft.cxx:1667:9 > #8 0x7fc2f00b23ed in vcl::CreateTTFromTTGlyphs(vcl::AbstractTrueTypeFont*, std::__debug::vector<unsigned char, std::allocator<unsigned char> >&, unsigned short const*, unsigned char const*, int) /vcl/source/fontsubset/sft.cxx:1374:32 > #9 0x7fc2f00bc71a in vcl::CreateTTFfontSubset(vcl::AbstractTrueTypeFont&, std::__debug::vector<unsigned char, std::allocator<unsigned char> >&, unsigned int const*, unsigned char const*, int, FontSubsetInfo&) /vcl/source/fontsubset/sft.cxx:1549:13 > #10 0x7fc2eff57836 in vcl::font::PhysicalFontFace::CreateFontSubset(std::__debug::vector<unsigned char, std::allocator<unsigned char> >&, unsigned int const*, unsigned char const*, int, FontSubsetInfo&) const /vcl/source/font/PhysicalFontFace.cxx:367:12 > #11 0x7fc2ee4e0472 in vcl::PDFWriterImpl::emitFonts() /vcl/source/gdi/pdfwriter_impl.cxx:3152:24 > #12 0x7fc2ee4e9cb9 in vcl::PDFWriterImpl::emitResources() /vcl/source/gdi/pdfwriter_impl.cxx:3363:10 > #13 0x7fc2ee53f91d in vcl::PDFWriterImpl::emitCatalog() /vcl/source/gdi/pdfwriter_impl.cxx:5288:10 > #14 0x7fc2ee567ae3 in vcl::PDFWriterImpl::emit() /vcl/source/gdi/pdfwriter_impl.cxx:6341:10 > #15 0x7fc2ee3d3f2a in vcl::PDFWriter::Emit() /vcl/source/gdi/pdfwriter.cxx:53:29 > #16 0x7fc249b4b82a in PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /filter/source/pdf/pdfexport.cxx:1127:39 > #17 0x7fc249bb2782 in PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /filter/source/pdf/pdffilter.cxx:182:24 > #18 0x7fc249bb342b in PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /filter/source/pdf/pdffilter.cxx:247:23 > #19 0x7fc2a51ebec6 in SfxObjectShell::ExportTo(SfxMedium&) /sfx2/source/doc/objstor.cxx:2945:25 > #20 0x7fc2a51d7bec in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) /sfx2/source/doc/objstor.cxx:1943:19 > #21 0x7fc2a5213f83 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:3459:39 > #22 0x7fc2a520b709 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:3249:9 > #23 0x7fc2a5147a8b in SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t> >, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objserv.cxx:320:19 > #24 0x7fc2a543024c in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) /sfx2/source/doc/sfxbasemodel.cxx:3231:42 > #25 0x7fc2a54374f4 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1813:13 > #26 0x7fc2c74053ae in ScPDFExportTest::exportToPDF(com::sun::star::uno::Reference<com::sun::star::frame::XModel> const&, ScRange const&) /sc/qa/extras/scpdfexport.cxx:179:16 > #27 0x7fc2c7437e0f in ScPDFExportTest::testForcepoint97() /sc/qa/extras/scpdfexport.cxx:915:5 during CppunitTest_sc_pdf_export (<https://ci.libreoffice.org/job/lo_ubsan/3346/>) Change-Id: I3074479ea3267417a73ecafa81b4a9898f19d1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175469 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-10-23tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 152, 194 V1037 Two or more case-branches perform the same actions. Check lines: 565, 592 Change-Id: I52ec0921c898ca74473631ba36a76f6444ce07d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175358 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-23tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 289, 293 Change-Id: I9828b4d5b7faca449c5377a0bd8223cddf883a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175423 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-10 03:22:54 +0000