summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-01-14Replace gtk-close to gtk-cancel (sw TOC dialog)Julien Nabet
In sw/uiconfig/swriter/ui/tocdialog.ui we got: id="cancel" <action-widget response="-6">cancel</action-widget> In sw/source/ui/index/cnttab.cxx we got: SfxTabDialogController(pParent, "modules/swriter/ui/tocdialog.ui", "TocDialog", &rSet) which contains std::unique_ptr<weld::Button> m_xCancelBtn; and finally if you change some options in the TOC dialog and click on "Close" then open again the dialog, all the changed options are reverted. => UI impact, the button is renamed "Cancel" instead of "Close" Change-Id: Ia99e7c8a10da51f258faf0833ea1931ce62364bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109301 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Drop some unused "using" directivesMike Kaganski
Change-Id: Ibc071f7b3d21c24e119fdc4e0db5351f80813287 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109279 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-14tdf#138544 sw LoadUserSettings: default EmptyDbFieldHidesParaJustin Luth
This is the fourth patch in the series. When you start a new document, Writer compat setting "Hide paragraphs of database fields with an empty value" is on. Now, when saving and reloading it with LoadUserSettings disabled, it is still the program default of "on", instead of "off". This one was a bit different because it didn't initialize in the standard way. // for some properties we don't want to use the application // default if they're missing. So we watch for them in the loop // below, and set them if not found So I'm changing it to match the standard way, and adding the now familiar clause to cover the case when the LoadUserSettings is disabled. Change-Id: I979b01340000056567a4baa9ace27f9f9d15e9b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108548 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-01-14cid#1471346 Uncaught exceptionCaolán McNamara
Change-Id: I535affd6597636aa32e1cf9c6005238f9503ef6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14drop newly added deprecated GtkAlignment instanceCaolán McNamara
Change-Id: Iad8d15ffc89b48aca698553329cda643dd0b4406 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 4668a661bfdc743bb88bfc5b7fbc83383974d733 - update translations for master and force-fix errors using pocheck Change-Id: I5a86a2cfa383bbd34bd95ea0008959518a230793
2021-01-14tdf#39721 sw change tracking: fix move downLászló Németh
When moving list items by Move Down (see Bullets and Numbering toolbar) to a non-content node (e.g. tables, images or end of the document), tracked deletions of the inserted paragraphs reappeared as non-deleted text. Note: disable unit test on Windows because of a not reproducable problem of the Jenkins build (moreover, reverting the patch, and modifying the unit test according to the revert has still resulted the same problem on the Windows test machine). Change-Id: I3fb49061a81f832e1070da0f78cf7c5b3bd7d2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108888 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-14Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 0a848766232d6516f2af5a7605373b2ab8ca193e - tdf#130170 update change in dialog box label tdf#139017 changed a label in the "New Style from Selection" dialog box. This patch updates the label. Change-Id: I830cec29fdf1a358ae0a217ee53688059a193f67 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109286 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-01-14Make SotExchange::GetFormat() accept a MIME type with additional parametersTor Lillqvist
For instance, if SotExchange::GetFormat() is passed a flavor with MIME type "application/x-openoffice-objectdescriptor-xml;windows_formatname=\"Star Object Descriptor (XML)\";typename=\"LibreOffice 7.2 Spreadsheet\"" we do want to recognize it as SotClipboardFormatId::OBJECTDESCRIPTOR, even if the MIME type in the entry for it in the array in ImplFormatArray_Impl only has the windows_formatname parameter. This is part of fixing https://github.com/CollaboraOnline/online/issues/849, but it will help for corresponding problems with LibreOffice on macOS, too. Note that on Linux, SotExchange::GetFormat() gets called with a flavor with a MIME type that does *not* have all the extra parameters (classname, typename, displayname, viewaspect, width, height, posx, posy) (See the GitHub issue mentioned above.) This change does not remove any checks for classname, typename, etc. There are/were no such checks in SotExchange::GetFormat(). But, in the (much different) code path for macOS (and iOS), with my work in process in vcl, SotExchange::GetFormat() gets called with a flavor with a MIME type that *does* contain those extra parameters. I don't see the point in introducing checks of the "sanity" of those into SotExchange::GetFormat(). Change-Id: Ie65ed1ab922cdaa6557eb65d980b9e886d3c6971 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109254 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-14Introduce startsWithAsciiL() to match endsWithAsciiL()Tor Lillqvist
Will be used in an upcoming change. Unit test included. Change-Id: I777a755cab543ea277b84fb5ad021d0b91725764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109264 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-14Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 319b987c6acfd51ba009e6c2e63284bf2eec92c7 - tdf#107229 (related to tdf#138846) update "settings" label to "tools" tdf#138846 changed the "settings" label to "tools" in the template manager This patch makes the necessary updating in the template manager help Change-Id: I2b20ccfe2919c4d6a15ed12ccf33fc98d003825f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109008 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-01-14Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 434d763ddb4a8bb32e3896eb967c93c74479a873 - Gimmicks Basic shared library help page - entry points - loaded libraries - related topics Change-Id: I762b4985a943a88ef31843c55fdfe98f1badf639 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109282 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-14Asian phonetic guide dialog uses "close" widgetJulien Nabet
and not cancel one. widget response = -7 corresponds to GTK_RESPONSE_CLOSE See https://gtk.developpez.com/doc/en/gtk/GtkDialog.html label is "gtk-close" and the variable name is "m_xClosePB" Change-Id: I6ac8e1814ff3c594498d81e99e864939b6a2c23a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Bump MSVC baseline to Visual Studio 2019 version 16.5Stephan Bergmann
After b4b7e92cbf5a212cc1c648af86df2dee364d48c8 "Use MSVC's /permissive- to make it more standards conforming", vmiklos reported that his 16.4.6 build started to fail with > C:/lo/master/connectivity/source/drivers/odbc/OStatement.cxx(411): error C2760: syntax error: unexpected token 'identifier', expected 'type specifier' > C:/lo/master/connectivity/source/drivers/odbc/OStatement.cxx(411): note: This diagnostic occurred in the compiler generated function 'T connectivity::odbc::OStatement_Base::getStmtOption(SQLINTEGER) const' > C:/lo/master/connectivity/source/drivers/odbc/OStatement.cxx(418): error C2760: syntax error: unexpected token 'identifier', expected 'type specifier' > C:/lo/master/connectivity/source/drivers/odbc/OStatement.cxx(418): note: This diagnostic occurred in the compiler generated function 'SQLRETURN connectivity::odbc::OStatement_Base::setStmtOption(SQLINTEGER,T) const' > [build CXX] connectivity/source/drivers/odbc/ODatabaseMetaData.cxx > make[1]: *** [C:/lo/master/solenv/gbuild/LinkTarget.mk:301: C:/lo/master/workdir/CxxObject/connectivity/source/drivers/odbc/OStatement.o] Error 2 > make[1]: *** Waiting for unfinished jobs.... > C:/lo/master/connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx(161): error C3861: 'checkDisposed': identifier not found > C:/lo/master/connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx(161): note: 'checkDisposed': function declaration must be available as none of the arguments depend on a template parameter > C:/lo/master/connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx(161): note: This diagnostic occurred in the compiler generated function 'T connectivity::odbc::ODatabaseMetaDataResultSet::getInteger(sal_Int32)' > make[1]: *** [C:/lo/master/solenv/gbuild/LinkTarget.mk:298: C:/lo/master/workdir/CxxObject/connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.o] Error 2 while it succeeded after upgrading to 16.8.4. That change had been seen working with 16.5.4 (on tb73, see <https://lists.freedesktop.org/archives/libreoffice/2021-January/086635.html> "Heads up: Use MSVC's /permissive- to make it more standards conforming"), so lets hope that bumping the baseline from 16.4 to 16.5 is all that is needed. Change-Id: I7446f778a94e15e7ea5c8ef0780bf10831a2d4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109293 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-14Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to fb2118d675e4c6a7b19b6b27c1cbe56c32e9e41e - typo correction Change-Id: I15d9f396f7d2879bf48c79761e5b4c1ff9de1972 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109283 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-14Add an option to dump pasteboard data for a type to stdoutTor Lillqvist
Change-Id: Iafa24799c5c18abef93f032a2f637c39f4a9cf5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109296 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-14Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to a8d509f67da36c7e5a0db4dd3679be8a9b6bf8ba - tdf#139542 remove "Data Area" from Sort options help * correct control name to "Case sensitive" * update to <h1> and <note> Change-Id: I8980bda5daaeaac04c5116de083a8b24a9bbdf53 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109276 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-14Use comphelper::ContainerUniquePtrEquals hereMike Kaganski
This restores correct comparison of pointed values, that was broken since commit df3e716b3c4313d9c495c64aa7d84082fb9596e7. Thanks Noel for investigation :-) This restores operator== dropped for being unused in commit 1d25e1de0b9498e469cb052b2d86bf7f7ae6adae. Change-Id: I5614be004c0a98f5dc6f22febc3a51de08e75664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109116 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-14Update git submodulesBalaharipreetha Muthu
* Update helpcontent2 from branch 'master' to d3699ebe29792a680cc965f5bdaa5b8a9432b8aa - tdf#139436 Add Help page for Format - Conditional - Data bar - More Options dialog Change-Id: I83faa2d1edb8f5cba08a7b1054bd66fc17f835b9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109129 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-14cid#1471680 help coverity see that "Division or modulo by zero" is bogusCaolán McNamara
Change-Id: I3c349b2cc274de6a74cb1de71b630c4fcb64231e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14cid#1470700 try to help coverity see 'Using invalid iterator' is falseCaolán McNamara
Change-Id: I04f3d2779db32cc5ca3d6303d146d017aa4f5ef4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14cid#1471674 help coverity see that "Division or modulo by zero" is bogusCaolán McNamara
Change-Id: I82fc94d242e446d434c257471e80a6db2536e8aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Make lambda auto parameters explicitly constMike Kaganski
Change-Id: Ie8fe7738476f31ea3670987842f552782e9624da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109273 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-14Add a tiny program to list the contents of the macOS pasteboardTor Lillqvist
Change-Id: I78933f18a80140e9ccacabd6243716205b530c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109271 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-14Add more source files for breakpointing convenienceTor Lillqvist
Change-Id: I130273b7b5e812df1eeb904f652d23a492398636 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109270 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-14flatten formats data in SotStorageNoel Grandin
there is no need for all this indirection. Change-Id: Ie44723b54313b1103fe33a00ed014e2b28a59638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109225 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-14lok: send sheetGeometry invalidation after sortDennis Francis
...just for the rows to let the client know the row sizes/spans have changed. Change-Id: I26f985ab0ba4eb5b21db5783a8ac3957c64c2f22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109207 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit cca01519c7e778d3cf9208e642073d939d9fdac0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109272 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-01-14tdf#133858 reduce the double-ref range to data contentDennis Francis
in certain matrix formulas like SUM(IF(A1=G:G, H:H)*B1/B2) where whole columns are used for comparison in the condition of IF ultimately followed by a reducer like SUM. In such cases we can safely reduce the double-refs involved in the comparison to the sheet area where there is data before converting the data to ScMatrix. This is a more restricted version of Noel's fix in 37ffe509ef011357123642577c04ff296d59ce68 Change-Id: I1c2e8985adedb3f4c4648f541fb0e8e7d0fae033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109050 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 65167a9265acfea04733b5ff6ee3220a9da624f4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109118 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-01-14Add some more source files and drop dead onesTor Lillqvist
Change-Id: Ie669750404dd9b73881a9e217e3cced0bf21e42b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109263 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-14Make Fontwork gallery dialog asyncSzymon Kłos
Change-Id: I156dc1b505b01dc7520ccfe80bbf97eba881d653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109092 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109258 Tested-by: Jenkins
2021-01-14jsdialog: execute IconView actionsSzymon Kłos
Change-Id: If94df547096a5adb15ace432695f91ee7e879bb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109078 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109257 Tested-by: Jenkins
2021-01-14jsdialog: dump IconViewSzymon Kłos
Change-Id: I82df1f5e5f966e764b768044526b3401d55fc394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108984 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109256 Tested-by: Jenkins
2021-01-14jsdialogs: implemented IconViewSzymon Kłos
Change-Id: I05f5009efc879aaf3fc6055ff8dfa7c26aa33d1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108983 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109244 Tested-by: Jenkins
2021-01-14Move SalInstanceIconView decl to header fileSzymon Kłos
Change-Id: I179f044b3db38ee51f539ef4023b136eac55f4ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108982 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109182 Tested-by: Jenkins
2021-01-14UITest: add IconViewSzymon Kłos
Change-Id: I6971d73e65f0a1f60203ea1010ed8ad3ba176755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109243 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-14Fontwork dialog: use iconviewSzymon Kłos
Change-Id: I5bb35407ca83c9b0cda6f6355e6e25c21fecb459 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108960 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109181 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-14tdf#139566: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I60fb8411ec3c69159998120e40d7db5291f87674 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109224 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14Rename m_xBtnCancel->m_xBtnClose (sc/optsolver)Julien Nabet
Since it corresponds to id="close" gtk-close, response close in sc/uiconfig/scalc/ui/solverdlg.ui Change-Id: I909f8f7a5d08784bda786eb86d92f88831749f23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Resolves: tdf#138675 crash on checking if focus is in OFieldDescControlCaolán McNamara
use has_child_focus instead, which didn't exist at the time of... commit 3fc63a7463149685b04c676968a82bc00a48a9af Date: Fri Aug 28 10:29:55 2020 +0100 weld OTableBorderWindow and so sidestep that m_pActFocusWindow has always fallen out of sync when OFieldDescControl clears its contents Change-Id: I274131c314a00bdfec2e877a2baa3758d45c325f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Resolves: tdf#139299 crash on gaining focus during disposeCaolán McNamara
Change-Id: I5fd2b3cec7dd0c2c10c88006ef1812e57b547e0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14tdf#139567 set no-show-all to TrueCaolán McNamara
so changing child vis to false before parent is shown 'sticks' as a final visibility of false Change-Id: Ieee4e4c7f7bddf6204c61ca788d316d52ef5a6dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14fix .ui indents and trailing whitespace on recent commitsCaolán McNamara
Change-Id: I45b706c99efef2e74b7c34a9d09459f2d20f6edf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Resolves tdf#139343 and tdf#139335 - Community/Enterprise flavorHeiko Tietze
* Switch CE/EE per --disable-community-flavor internally use HAVE_FEATURE_COMMUNITY_FLAVOR * Version info in about dialog shows text depending on this flavor * Start center also shows the brand image now * TDF builds use a brand image with TDF tagline in the about dialog * Brand images with just "Community" (no Edition) Change-Id: I363dd2b39df9aad951c9d79addf9bdedfc4a3495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108980 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-14pdfium: add an FPDFPageObj_GetStrokeWidth() wrapperMiklos Vajna
Change-Id: If411b788b3ea07c29377e01052ee6a48893ca482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109250 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-14-Wdeprecated-copy-dtorStephan Bergmann
Change-Id: Ia0875cc409779dd0c5479e314ccc8aae7abd4d94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109253 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-14tdf#139580: sw_ooxmlexport16: Add unittestXisco Fauli
Change-Id: I635909b62239e2afb72038c21091b65e22ce8d43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109227 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14uitest: sc: factor out common code ( part 2 )Xisco Fauli
Change-Id: Ia2a707f1df513e067c8e34b263ad336fed6d14dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109235 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14remove unnecessary macos cursor codeNoel Grandin
certainly on my Catalina macOS install it makes no difference with or without this code. I could have sworn it was necessary back when I added it, but since I'm going on snippets of hacking scattered around the net (because Apple 's documentation is rather lacking), who knows. Change-Id: I8a66a5179ab7ca8138e54a57564b8d453848c0e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-14loplugin:unsignedcompareStephan Bergmann
Change-Id: I007400f745708087f793f37cd081652e07bcd1b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109251 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-14Use o3tl::temporary in one more call to OUString::iterateCodePointsStephan Bergmann
...similar to 0701aca589b819b845d08ea60263ad89718cfd7f "Use o3tl::temporary in calls to OUString::iterateCodePoints", after 6ce3e7b615193f610add5428d2157f31600dec52 "Verify o3tl::temporary of a copied lvalue works as expected" has been covered Change-Id: I6a21acb0d1a6436ea57d670a2922778034edd4df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109248 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>