summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-21weld FontNameBoxCaolán McNamara
with custom row rendering Change-Id: Ia909b5b9ad56b6ea4611e9ea0a1e2cb0064a8cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21work around copy-to-self SkSurface::draw() being buggy (tdf#132051)Luboš Luňák
This may become the actual fix or may be removed later depending on the outcome of https://groups.google.com/d/msgid/skia-discuss/202004151937.05051.l.lunak%40collabora.com . Change-Id: I709f3e7bffbe86ddb2f6d75724bf30e4b0f0116e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92587 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-21tdf#131775 DOCX DrawingML shape import: fix missing spacingTibor Nagy
Character spacing of grouped shapes wasn't imported. Co-Author: Balazs Regenyi, Szabolcs Toth Change-Id: I9c4f204a5ab7c7e55e26968a71b315d84e5d8515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91490 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-21tdf#131446 DOCX import: restrict IncreasedAnchoredObjectSpacing furtherMiklos Vajna
Regression from commit 8b73bafbc18acb4dd8911d2f2de8158d98eb6144 (tdf#115719 DOCX import: increase paragraph spacing for anchored objects, 2018-02-14), this is another case where the workaround for the Word layout bug is not needed. tdf115719.docx and tdf115719b.docx are tweaked to have <wp:anchor ... behindDoc="1"> for 1 shape, as the original bugdoc has it. This allows us to render both the tdf#115719 and tdf#131446 bug documents the same way as Word does. Change-Id: I0c3f197c3360882cd64f8dcf286c6051dc11d674 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92599 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-21tdf#132039 Image Dialog: The field file name is to shortandreas kainz
Change-Id: I758a43b207186e98501eb8c58d3e6435463a451c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92576 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-21Fix storage access after savingSamuel Mehrbrodt
Change-Id: I2cd664ac2ca5e80c566efee35bd34e7223501d75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92605 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-21Sukapura: Update indentation iconsRizal Muttaqin
Change-Id: I9d676e6b554e96b0422c1b0e7c9e59087db5482b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92604 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-21tdf#42982: Improve UNO API error reportingIan Barkley-Yeung
Add more info to the exception in AccessibleIconChoiceCtrl::getAccessibleChild() Change-Id: Ie6e778f76719eb463508647f0367e089ab0ae8ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-21CreateDocumentInfoDialog should return shared_ptrNoel Grandin
which is what it's only call site wants Change-Id: I1c2c2ed3a91a3376af142ac9a5d6993a2186d660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92590 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 8bc7adda21caae983a74b72dbbc23bc805de0580 - tdf#132227 Add MySQL direct connection help page Change-Id: Icc0393d89799349701136d6b8e98519732ec0fa5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92601 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-21Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 4780abb01dd5fa2356f64bb096d99288b019160a - tdf129366 add Resume in 'Error handling' funcs Change-Id: I48557474f6cedd357f03e767eabd09b6df8cd5b1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92440 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-21Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 2bfb8b82791bbe87e26955faa8d3674ba8c48faf - tdf#131416 Type statement diagram - main diagram - subsequent fragments Change-Id: I5463aeac7257394cac826fbc36a819b4ddd8ced3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92435 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-21tdf#99674 update flowchart gallery now with themes supportandreas kainz
Change-Id: Ibbb4d34ce76b18bfc0eb08c31fd85397bb73dc39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92602 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-21Fix macro signature getting lost when inserting data into tableSamuel Mehrbrodt
Change-Id: Iec514bfc0edd4f10a09809c68b8501667d978e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92573 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-20Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to 849d86762b4db20bbe7ce00ee3603a081f4872ff - Update syntax section of Help for Calc's DCOUNT and DCOUNTA functions to indicate how to omit middle parameter (see bug 131362). Change-Id: Ib1fd850371c1876f16c10905994a92ac83a5a351 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92443 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-20tdf#119187 fix: Top-aligned text in PPTX becomes bottom-alignedSerge Krot
Change-Id: Ic6c03e512ce3f6e240d86186fb16e24c86942343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92051 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-20flatten some code in ImpGraphNoel Grandin
Change-Id: Iee30822dd977ff380e01c7564a2d211d9a3542cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-20fix regressionNoel Grandin
from commit c5424e19338a3edaec3f0459c8ac5d53ca92d9fe loplugin:useuniqueptr in i18npool which would have resulted in the block at line 245 inside #if (U_ICU_VERSION_MAJOR_NUM < 58) never doing anything spotted while doing improvements to my make_shared plugin Change-Id: I79c664c7e4a051f3c764cb49d99870b51b19ce55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-20Restore this header for Windows onlyMike Kaganski
... after commit 644db9df9ccce3d10c92ff365d0ac2e1b1fa33de Change-Id: Iecaaacaffd494afafcb779c41d59af8e9dbbc6c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92529 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-20drop EnableSelectAllCaolán McNamara
Change-Id: I57dcca28daf7fe8544ee524b8b41bbc1fe591fac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92489 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20add selected state to UserDrawEventCaolán McNamara
Change-Id: If01e0ec3871d0299e1e24e9f7d55893d4afca688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92491 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20effectively unused mnStyle memberCaolán McNamara
Change-Id: Ieb579c9440810a937c7da0f9dd8e3b79a2e0e5b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20weld SvxFontSizeBox_ImplCaolán McNamara
Change-Id: Ied8ef61226a720acac74db78ae5852cd4e624d14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92562 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20set popup for a welded TextCharacterSpacingPopupCaolán McNamara
Change-Id: Ic21e1fa8c3c384987856a185c000bc9d846deecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20Various typos in vcl OpenTypeFeatureJulien Nabet
Name of files: vcl/inc/font/OpenTypeFeatureDefinitonList.hxx vcl/source/font/OpenTypeFeatureDefinitonList.cxx Class names: OpenTypeFeatureDefinitonListPrivate OpenTypeFeatureDefinitonList.hxx Change-Id: I5feb8ccc818b84b1b777b5b1e82c0a32a898aa72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92581 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-20tdf#128209: sw: uncomment commented assertsXisco Fauli
Fixed in 66b39ca79b36da8d5e151deab17a0fb7690eebe6 Change-Id: I2d805061ffd3efa455b0b4eecc02a77fb197ba68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92580 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-20Revert "Revert "make: map slowcheck to gbuild's build and slowcheck""Luboš Luňák
Jenkins Mac buildbots still haven't been updated to use explicit make targets instead of plain 'make'. This reverts commit 59d0a42639b5e569890ae00a2deef620c4e5c258.
2020-04-20uitest: fix wrong class nameXisco Fauli
since 8f2f7befd166d0ad72622cb3545934bee5b0fef6 Change-Id: I18a9255235bb03468fb94b14e5eb62bcd912d6d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92574 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-20fix --enable-64-bit Windows build with Clang for SkiaLuboš Luňák
Change-Id: Ia55e0b6ab6b970cbafe2c8283b255eae0ad66567 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92577 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2020-04-20Revert "make: map slowcheck to gbuild's build and slowcheck"Luboš Luňák
This does not actually ensure everything is built before tests are run, so this doesn't fix the test failures it was intended to fix. This reverts commit 4054a30e2b2fa254dfb20718ce757ceb2f638fd5. Change-Id: Id0a81179327d42a7b608a67813db53ca7a5c71d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90788 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-20tdf#129525: sw: Add unittestXisco Fauli
Change-Id: I8242b45f406d97cb0bf62f7290ffddf47f18a869 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92572 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-20tdf#131147 don't store redline ExtraData during UndoLászló Németh
to avoid of unwanted redline changes and assertion. Breaking redlines and storing extra data (formatting changes) need only for change tracking during editing, not in an ongoing Undo process. Regression from commit dc9a0b124272a6dc0a8d875d51b6f882e60a8a04 (tdf#127101 Change tracking: reject format at paragraph join). Change-Id: Id78251bc14821cc82d8f3d34eec63ba7bac68df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92559 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-20allow bare GtkToolItems in the mapCaolán McNamara
for the combobox item windows, e.g. font size and font name Change-Id: Idde4be9f406a426b80a7a9b19d3e782a58dabf89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20Resolves tdf#132180 - Stretched brand image at the ABout dialogHeiko Tietze
Explicitly centering the image solves the issue Change-Id: Ib5c4a7e772f01de72c19d74490f6a802378885ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92565 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-20Sukapura: Fix for tdf#128689 Add more Korean iconsRizal Muttaqin
Change-Id: I084be3cfefe3b7fb6a113b162bdce39915f734bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92563 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-20Add --with-latest-c++ to explicitly opt in for -std=c++20/-std:c++latestStephan Bergmann
cd472d1d8489f30797f47d3f6dafede28c1feb90 "Compile as C++2a, where available" had started to unconditionally check for support of -std=c++2a (and later also -std=c++20) for Clang and GCC, but that can cause occasional issues especially for Linux distros, see e.g. 55c724b93dfd4c9a1afb10d60fbc2d7a9a66cf61 "replace boost::bimap in sdext pdfimport" or <https://bugzilla.redhat.com/show_bug.cgi?id=1818723> "/usr/include/boost/format/alt_sstream_impl.hpp incompatible with -std=c++20 (std::allocator::allocate hint argument)" (where 677c8de4fa79cd9b278b142013ba7f1c9e4e41c3 "external/boost: Adapt to std::allocator parts removed in C++20" is not picked up due to --with-system-boost). So better require an explicit opt-in via a new --with-latest-c++. And while at it, also make that enable -std:c++latest for MSVC. Change-Id: I2d1f03144fad9a7884562e56b1b76cab5eb8f080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92555 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-20batch Skia xor drawing (tdf#132241)Luboš Luňák
The code previously applied the xor operation after each drawing, but the bugdoc draws a large number of polygons in xor mode, so the xor drawing was done repeatedly. Do the xor drawing just once when leaving the xor mode. Change-Id: I6c8d1c2f01688dc957a0af75232ee9fb69fe5d1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92558 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-20tdf#42949 Fix IWYU warnings in dbaccess/source/ui/[a-d]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ifd96569ecdbbcde3c7fc9462a29e42386d1ae3a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92401 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-20Resolves tdf#132179 - Improve accessibility for the About dialogHeiko Tietze
Button added to copy version info Static text made non-selectable to avoid uncommon tabbing Change-Id: I4c2107b8120797a7cd532b59ca5ccb58ab61a2ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92418 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-20should be using make_shared hereNoel Grandin
Change-Id: I295eaef9309c0cfbe3aa6fd8386dd12fbb8d1a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92525 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-20Breeze,elementary,KJ,Sifr: Fix for tdf#128689Rizal Muttaqin
- KJ: Update Group related icons Change-Id: Icdb23409a8026afd9acf7c6188353cd59cb7a0cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92553 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-20prefer building Skia with Clang if possible (tdf#131697)Luboš Luňák
I.e. try to find and use Clang even if the default compiler is something else. Skia is optimized to be built with Clang(-cl) and in CPU-based raster mode some operations are several times slower if built with something else (e.g. fmax/fmin do not get optimized to inline assembly). It is enough to select Clang to be installed in the MSVS installer. At this point it unclear how to handle release binaries, if it should work this way and enforced, or maybe Clang could be used for building everything, or maybe some other way. Change-Id: I6b95a0f2d5cbf176942d9e01136990b14be6dba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92415 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-20tdf#123346 DOCX VML shape export: fix arrow markerSzabolcs
In some cases at import there are extra space separated numbers at the end of the names of arrow objects. Remove these extra numbers before they could interfere with the choice of markers. See commit 2d3b7a07c02c90d2d64a630ab84886ef3096edfc (tdf#100491 fix DOCX import shape line with arrow marker). Co_Author: Balázs Regényi Change-Id: I2156502b0ce5cd755a731359398a40edabb603a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91375 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-20tdf#78749 DOCX: import VML background imageAttila Bakos
of text boxes. DOCX relationship identifier wasn't handled earlier, only XLSX. Co-developer: Tibor Nagy Change-Id: I72f246e6f69d70d1e203087516ee93a57563f777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91933 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-20add tools::Rectangle::JustifyNoel Grandin
so rectangles can be constructed already valid Change-Id: I3ae5e24add3c81f79dcdf863f855dca439876f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-20set popup for a welded TextUnderlinePopupCaolán McNamara
Change-Id: I5388be71e102065e89f0d5489fbb1af34fa1a2ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92510 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20cid#1462315 Division or modulo by zeroCaolán McNamara
Change-Id: If4e5624675250cf288227b46514e432c3c662ca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92522 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20tdf#131814 Remove Close button from Table Data toolbarGabor Kelemen
Change-Id: I3e387da217fdbbbb37db1f61f85fc957c5969c51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92327 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-20tdf#130924 [vcl] replace `*printf`s with `SAL_*` logging macros.Yukio Siraichi
Change-Id: Ie3ec1e1767478bce12eecf7bfee02ed2d45fe58c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92331 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-20remove direct access to Size field on SwRectNoel Grandin
so I can add asserts to prevent construction of invalid rectangles Change-Id: I01ac97b3cc780acbd182a646f0e072e518a45bee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>