summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-09std::tuple -> std::pairAshod Nakashian
Change-Id: I2f11436a5c9691c2a0aac3655bc2c543d1c3d684 Reviewed-on: https://gerrit.libreoffice.org/24566 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 8a6dab5da851f38a8ecef633e06e3cb2ac5e7849)
2016-05-09More LOK callback notification compressionAshod Nakashian
SET_PART, CELL_CURSOR, CELL_FORMULA, and CURSOR_VISIBLE are now deduplicated. Change-Id: I4c17307c6f8b7c68bdfe55b4e90da4d34c55d085 Reviewed-on: https://gerrit.libreoffice.org/24565 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit a9771e1f4d0d2602713983ab1f3e743784e9ae72)
2016-05-09Improve two informative messagesTor Lillqvist
Use 'enable/disable' terminology consistently: don't mix 'enable' and 'set' in the same phrase if they both actually refer to the same thing. Also, don't say that it is 'already set' when it is already 'disabled'. Change-Id: If4cea9845b47cdf678d5591f05ac08cc086c9a0b
2016-05-09fix windows build, ambiguous symbolNoel Grandin
Change-Id: Ib3a2419198a6e2b1ee5330f99bc526f2d63edd7c
2016-05-09Update the wmf filter to simplify object ownershipMark Page
Changed the GDI style structures to use inheritance, thus object deletion no longer requires a static_cast Used std::unique_ptr for GDI objects to enforce object ownership Modified the WMF Writer to use std::vector, instead of a raw pointer array when processing handles Change-Id: Ic635ff9d641427b901eb18468529ea6367859b53 Reviewed-on: https://gerrit.libreoffice.org/24634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09fix windows and android buildNoel Grandin
Change-Id: I4644c1e5ac143efc6b1e75d041f71fe7d9156f0c
2016-05-09cid#1358836 reorganize to silence Resource leak in objectCaolán McNamara
Change-Id: I4cb51f537cf6b40748dd8902dc39362d8846ba22 Reviewed-on: https://gerrit.libreoffice.org/24708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-05-09tdf#98290 Cmd + G as Find Next shortcut for Mac and GnomeYousuf Philips
Change-Id: I8ad22fb9d48a0b9bdaa7981d83afe0097ea44f70 Reviewed-on: https://gerrit.libreoffice.org/23407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-05-09gtk3: always update on UpdateFullCaolán McNamara
e.g. templates menubutton button which isn't torn down and recreated each time, but hidden/shown Change-Id: Ib80e0dc0ca5abfb5efa2966283034b7ba1840978
2016-05-09fftester: subtable is a subtable of itselfCaolán McNamara
Change-Id: I9de983e3c9436ab3a37d3482b0f18f04c7cdaaca
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09tdf#99589 tolower / toupper - dangerous to Turks ...Krishna Keshav
Used toAsciiUpperCase() from character.hxx Change-Id: I79f4638866daf8952103c8a521db925150e8dcda Reviewed-on: https://gerrit.libreoffice.org/24709 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-09Fix call to deleted Any constructorLuke Deller
A recent commit 6e70103d deleted some Any constructors and methods, and updated all the places where these had been called - except it looks like one call was missed, active only when building against Python 2. Adjust this call following what was done for the Python 3 case. Change-Id: I0f92b7476b617d9fdf0e5f698e363360497d115e Reviewed-on: https://gerrit.libreoffice.org/24759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-09tdf#99479: Delete column with styles resets the 'Apply Style' drop downJulien Nabet
To start, the problem appears in SvxStyleToolBoxControl::FillStyleBox() pStyleSheetPool->First() returns null to pStyle because pStyleSheetPool is empty so we don't enter in while ( pStyle ) and can't add non default styles So why pStyleSheetPool is empty? pStyleSheetPool comes from pPool (SvxStyleToolBoxControl::Update()), pPool is retrieved from pDocShell->GetStyleSheetPool() (=> static_cast<SfxStyleSheetBasePool*>(aDocument.GetStyleSheetPool())) which is retrieved from xPoolHelper->GetStylePool(); ScDocument::GetStyleSheetPool() Let's move on, why xPoolHelper is empty? it's because when we delete the column, it does this: 0 ScPoolHelper::SourceDocumentGone (this=0x2c006c0) at /home/julien/lo/libreoffice/sc/source/core/data/poolhelp.cxx:116 1 0x00002aaad4e28eae in ScDocument::~ScDocument (this=0x8d6ac40, __in_chrg=<optimized out>) at /home/julien/lo/libreoffice/sc/source/core/data/documen2.cxx:426 2 0x00002aaad57a85f8 in ScDocFunc::DeleteCells (this=0x2c04bb0, rRange=..., pTabMark=0x3231ad0, eCmd=DEL_DELCOLS, bApi=false) at /home/julien/lo/libreoffice/sc/source/ui/docshell/docfunc.cxx:2415 3 0x00002aaad5cfa0f3 in ScViewFunc::DeleteCells (this=0x3230fd8, eCmd=DEL_DELCOLS) at /home/julien/lo/libreoffice/sc/source/ui/view/viewfunc.cxx:1512 But calling delete on pRefUndoDoc shouldn't call SourceDocumentGone since it's been created as a ScDocument with SCDOCMODE_UNDO eMode not with "SCDOCMODE_DOCUMENT" eMode. Since xPoolHelper is instantiated when only "SCDOCMODE_DOCUMENT" eMode (see http://opengrok.libreoffice.org/xref/core/sc/source/core/data/documen2.cxx#224), only destructor call of a document with eMode "SCDOCMODE_DOCUMENT" should be able to destroy xPoolHelper So the fix is only to call PoolHelper->SourceDocumentGone(); when (xPoolHelper.is() && !bIsClip) but also if !bIsUndo Change-Id: I1089d20264d0594c7e8ebe9263ebad6e68485c12 Reviewed-on: https://gerrit.libreoffice.org/24345 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-05-09convert SFX_SLOT_INFO to scoped enumNoel Grandin
Change-Id: Ib640fc2cfce23bf8ce92ec1549034078123c06aa Reviewed-on: https://gerrit.libreoffice.org/24752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert SFX_STYLE_ITEM to scoped enumNoel Grandin
Change-Id: I929603a12c29931074a467d1472ef686c1d4e8ee Reviewed-on: https://gerrit.libreoffice.org/24751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09modernize loopsJochen Nitschke
use one style (reverse_iterators) for reverse loops and use range base loops if possible Change-Id: I231572bc5923e450d7a54bb88c7d8ef63d04f41d Reviewed-on: https://gerrit.libreoffice.org/24758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-05-09Work towards tdf#72606 EasyHack _tstring/TCHAR eliminationskswales
Built and tested Windows MSI installer Change-Id: Id49f7df80e01aaa608fe80687002f44d22bd3200 Reviewed-on: https://gerrit.libreoffice.org/24707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09tdf#96348 Get rid of unnecessary DLLPUBLIC decorations - VclEventListenersTomofumi Yagi
No need for VclEventListeners to be VCL_DLLPUBLIC Build passed "make check" on linux and Windows. Change-Id: Ib3330b3af434ee4d3622c6e0d6ac705c3087c672 Reviewed-on: https://gerrit.libreoffice.org/24766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09use existing functionDavid Tardon
Change-Id: I130e701902a22016cd06649e1c9ba3d932d64e1c
2016-05-09loplugin:redundantcastTor Lillqvist
reinterpret_cast from 'void *' to 'std::vector<std::tuple<int, std::string> > *' can be simplified to static_cast. Change-Id: I1899a1c570c4c56d8c7fe73745eac45061fb8bae
2016-05-09Desktop compresses text selection start/end notificationsAshod Nakashian
Change-Id: Ia85ded04d0eaf9d9b846fab6d86a44a758fccb69 Reviewed-on: https://gerrit.libreoffice.org/24320 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 45037438d84485356a5ceb820ecc3e0bae4b112e) Reviewed-on: https://gerrit.libreoffice.org/24380 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-08tdf#92768 Support hiding title objectsFeyza Yavuz
Change-Id: I879fc3d81a8fe8ca2f928305f5dc7fd9ebcfd294 Reviewed-on: https://gerrit.libreoffice.org/24564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-08Desktop compresses mouse pointer notificationsAshod Nakashian
Change-Id: Id76f4e2952c4c551b626d094c11eb3339d76e50c Reviewed-on: https://gerrit.libreoffice.org/24319 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 7c01cf652850a8b8d3fd5ef6eb0a12ca6e725943) Reviewed-on: https://gerrit.libreoffice.org/24379 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-08cppcheck: fix some redundantAssignment reportsJulien Nabet
Change-Id: I8e93fc0bff95c5c7a15ccecaaf19fce12e69ca6d Reviewed-on: https://gerrit.libreoffice.org/24765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-08fftester: fail on double parse of the same tableCaolán McNamara
Change-Id: I3e462cdc8812d0ac55d9896d2b04ace34a6c4670
2016-05-08Test desktop notification compressionAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/24314 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit bb52a54aa49cbb75820f8ddbfc8e9e94b63281cd) Change-Id: Ibb9a62bb5e1500a068c24346d6d433012a1bc7dd Reviewed-on: https://gerrit.libreoffice.org/24378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-08Resolves: tdf#96604 remove and restore full stack of grabsCaolán McNamara
Change-Id: I51b5943f52ccdce6b4b50131f5f2b7d2c1ff7368
2016-05-08BASIC : Remove an useless static_cast and use make_uniqueArnaud Versini
Change-Id: I32ec7e02ebf5a469db87bd2206d5fcd604b86795 Reviewed-on: https://gerrit.libreoffice.org/24720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-08starmath: Drop useless last entry of aTokenTableTakeshi Abe
Change-Id: I3189c875cc8b2046f5a0353fb641a7d6ea9fdd9a Reviewed-on: https://gerrit.libreoffice.org/24692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-08Translate German commentJulien Nabet
Change-Id: I7a6481370cacd1c33510654d17b20d254e753476 Reviewed-on: https://gerrit.libreoffice.org/24754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-08Updated coreOlivier Hallot
Project: help 91e86eaee7102c538c432140a4ab6b44c25a9cd2 HC3: XSL to extract bookmarks from XHP files Change-Id: Idaf6e4e890a1be1a44d96a5a36786fd480dc01f9 Reviewed-on: https://gerrit.libreoffice.org/24756 Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk> Tested-by: Olivier Hallot <ohallot@collabora.co.uk>
2016-05-08tdf#99258 bail out if we fail to reserve the textureTomaž Vajngerl
Change-Id: I830e313352b69a7665bff953aadb1334be0dc847 Reviewed-on: https://gerrit.libreoffice.org/24509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-05-08Updated includes pathAndrea Gelmini
Change-Id: I4ba692b73ce7d6cf84fdf528b6d410e07cbc36ca Reviewed-on: https://gerrit.libreoffice.org/24719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-08Updated file path.Andrea Gelmini
Since commit 6c7659b584ea7ed3652ca4eb9a2297f36310c365 the new path is include/sal/types.h Change-Id: I742ea2f6df06ff7345f3bbed0c90af13acafdbd7 Reviewed-on: https://gerrit.libreoffice.org/24718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-08Remove useless typedef DescriptorContainerJulien Nabet
Change-Id: Ie5463de6946d1682e28ff8359c3274980af8a1da Reviewed-on: https://gerrit.libreoffice.org/24736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-08loplugin:redundantcastTor Lillqvist
Reinterpret_cast from 'void *' to 'desktop::CallbackFlushHandler *' can be simplified to static_cast. Change-Id: I648e91d0ca234162833f19595ae60838f81963bc
2016-05-07tdf#84394: add testcase and unit testGiuseppe Bilotta
The testcase for tdf#84394 is quite interesting as it exposes a lot of issues with import/export of nested objects in Calc. Add it to the repository (I happen to be the author of the test case, so I give myself permission for it) and add a unit test to validate that the previous patch fixes at least one of the issues that plague its import in LO Calc. Change-Id: I996ea0f694d78faede77fce84838d2dd0831353e Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-07tdf#84394: xls load: delay cell-anchoring of object groupsGiuseppe Bilotta
When cell-anchored object groups are loaded, their anchoring must be delayed until all nested objects have been loaded, lest the invalid rectangle dimensions lead to incorrect positioning of the object. To achieve this, we keep track of the DffObjectData of the pending group, and move the anchoring to a FinalizeObj() method. Since DffObjectData has a const reference to a DffRecordHeader (which we need when setting the object anchoring) whose scope has closed by the time we call FinalizeObj() on the parent object, the stack of pending DffObjectData has references to clones of the original DffRecordHeader held in shared pointers. (This is to minimize the invasiveness of this patch wrt the Import* API.) Change-Id: Id23f5549dbc82306271cc02afc750f37eeea3ca2 Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-07New LOKDocument callback queue to flush events lazily on idleAshod Nakashian
Since desktop now queues up callback notifications and flushes them to the client on idle, the unit-tests must yield and process all tasks before they validate post-conditions. (cherry picked from commit e6a429770bde5da75239961ae88c06c78cfa5686) (cherry picked from commit 1f278848117080cd6e819f04ba428be52416af7c) (cherry picked from commit 6ca6f22777eb3651109cbf403577d0022a735c9b) (cherry picked from commit 548faf728cf097d93c3f6478ceea5f8747e789c6) Change-Id: I78307db29a9ce647ffaed3539f953227c605968e Reviewed-on: https://gerrit.libreoffice.org/24377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-07Typo: SYSTEN_LIBGLTF->SYSTEM_LIBGLTFJulien Nabet
Change-Id: Idf81e7b6d3629ae1170d52ca23dbab4db63eebae Reviewed-on: https://gerrit.libreoffice.org/24733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-08No need to cast the same thing twiceMaxim Monastirsky
Change-Id: I47e2ac07f811a2ce4bed7f732c37aedab16bc00d
2016-05-07Updated coreChristian Lohmaier
Project: translations 4fd90ce7f236732dca67322d4d5a9e0c9f632ea5 update translations for master and force-fix errors using pocheck Change-Id: I4aa086b8281e7bdce41590d33caaeb79dfdee46d
2016-05-07tdf#88502 Firefox Theme URL in custom theme searchSusobhan Ghosh
Removed "suggested" from categories label. Fixed URL checking. Change-Id: Ifbea40cf724c91f6af72c485d9ae7eb599afff65 Reviewed-on: https://gerrit.libreoffice.org/24716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-05-07tdf#89466: Switching between different fill types work nowKatarina Behrens
... somehow ... Change-Id: I6a9ccc60f35a2be092a60c01db04018b736a18b7 Reviewed-on: https://gerrit.libreoffice.org/24706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-07clang-tidy modernize-loop-convert in scNoel Grandin
Change-Id: I620028d69b11ea0469efd7b02ac7bbc7edab1066 Reviewed-on: https://gerrit.libreoffice.org/24690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-07BASIC: SbiParser Remove useless static_cast and indent the code correctly.Arnaud Versini
Change-Id: I8c7a01c3023f998785c8b719f7ae53da57ff3e47 Reviewed-on: https://gerrit.libreoffice.org/23939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-05-07Updated coreAdolfo Jayme Barrientos
Project: help 6bf8d987d05e14c5efaf9f7ab6da79642d227307 tdf#99715 AutoCalculate has been moved to the Data menu Change-Id: I4fc9162aa46cdad1af6052d02fd6e3da73a3bfb8
generated by cgit (git 2.34.1) at 2025-01-28 05:29:32 +0000