summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-05-17not much point setting the checkbox on each insertionCaolán McNamara
Change-Id: Ibc12e52d075c7bc7c33b7c25841cfd122d6c014e Reviewed-on: https://gerrit.libreoffice.org/72421 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17cache mdds position in ScAttrArray::RemoveCellCharAttribs() (tdf#108298)Luboš Luňák
Once more, mdds normally starts a container search from the beginning, so this is quadratic. Doesn't happen with the bugdoc after Ctrl+A, ScAttrArray::SetPatternAreaImpl() special-cases that, but with explicitly giving a range this triggers. Change-Id: Ic1177c1a115ffde23d7e11a90156ae05e02d067d Reviewed-on: https://gerrit.libreoffice.org/72416 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-17weld SvxIMapDlgCaolán McNamara
Change-Id: I5418176a015e61ef8eee4c2acd8e84b008f76f82 Reviewed-on: https://gerrit.libreoffice.org/72249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17avoid two lookups in ScDocument::GetLookupCacheNoel Grandin
doing an emplace_hint when the iterator points to end(), doesn't really help, so rather attempt to insert a fake value Change-Id: I44b89858284c6bebaa0e36daf0a4094fe06493c4 Reviewed-on: https://gerrit.libreoffice.org/72419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-17Use hasElements to check Sequence emptiness in [l-r]*Arkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: Idd67f332b04857a39df26bad1733aae21236f105 Reviewed-on: https://gerrit.libreoffice.org/71764 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-17allow closing welded dialogs to be cancelledCaolán McNamara
from both directions of window manager close button and esc Change-Id: I3c7bd6f67e3100f5dd3ab04456ad9aa5100c472c Reviewed-on: https://gerrit.libreoffice.org/72319 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17tdf#125267: relax the requirement of fixed value of current filterKatarina Behrens
In a filepicker, user can select any file filter ('All files' for example) and still choose to open .odb file. Specific UIName of the current filter ('ODF Database' in this case) shouldn't therefore be a hard requirement, the correct file extension is enough. Change-Id: I641a267c545c66aa4d34954922783cc5ff7efd24 Reviewed-on: https://gerrit.libreoffice.org/72377 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-17Resolves tdf#87965 - Make 'Search Results' dialog optionalheiko tietze
* Option introduced at Tools > Options > Calc > View (Windows) * Convenience checkbox added to the dialog Change-Id: Ic30fb302e61e77b0eefacd504f61f955bcf6e595 Reviewed-on: https://gerrit.libreoffice.org/71910 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-17Resolves: tdf#69042 - Add a "What's New" infobarheiko tietze
Shows an infobar with a link to the respective wiki page Adds a button to the About dialog Replaces If6eb1542d2ad310226f76850f480f2f99070b803 Change-Id: I1eeb504994a6364feb90cfa447029875e0ec1969 Reviewed-on: https://gerrit.libreoffice.org/72218 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-17handle CG state save/restore in ContextHolder classTomaž Vajngerl
Change-Id: I44ee257a8a196e8f2372dd01776c0c7c5193ad0a Reviewed-on: https://gerrit.libreoffice.org/72436 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-17Wrap CGContext into a ContextHolder classTomaž Vajngerl
Change-Id: I3088e0b2f6c54f272fd29d7a6069e8231b207666 Reviewed-on: https://gerrit.libreoffice.org/72435 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-17Replace list by deque in dbfindex (dbaccess)Julien Nabet
Change-Id: I9503cce6eff31f08c2762940b881ba1dc8633288 goal: to get rid of std::list when not mandatory Reviewed-on: https://gerrit.libreoffice.org/72434 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-17sw btlr writing mode: implement UI for fly framesMiklos Vajna
Change-Id: Id183dccb5802a1be0180471140266f3dd7a8123d Reviewed-on: https://gerrit.libreoffice.org/72428 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-17allow a OutputDevice parent where that is sufficientCaolán McNamara
Change-Id: I2920ea1a82de5eacbfeceafbb3c63693dd4365db Reviewed-on: https://gerrit.libreoffice.org/72414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17recipients just need OutputDevicesCaolán McNamara
Change-Id: Ia4b2fae44a873323444faf558d831b31635a8ee1 Reviewed-on: https://gerrit.libreoffice.org/72411 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17split out toplevel window area invalidateCaolán McNamara
Change-Id: I840ed6cbb3f7950230b1f7169ae3245a4a669249 Reviewed-on: https://gerrit.libreoffice.org/72410 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17allow overruling treatment as not-WindowCaolán McNamara
Change-Id: I26f987b1c2993f50cb67d89a68daf4ec82641700 Reviewed-on: https://gerrit.libreoffice.org/72383 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17tdf#42949 Fix IWYU warnings in UnoControls/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id088a2c8a91c2fe7c8ff9e05d910d5b5e9383b7c Reviewed-on: https://gerrit.libreoffice.org/72095 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-17tdf#125325: fix crash about index managements for dBaseJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=151468 Pb is aSearch becomes invalid after _rList.erase(aSearch); line 101 so just test aReturn.GetIndexFileName() isn't empty Change-Id: Iae5b3a7f76fe565f890bd23bfb2ce5d9c6134986 Reviewed-on: https://gerrit.libreoffice.org/72427 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-17uitest repair test 124829Zdeněk Crhonek
Change-Id: I8b31da520f1cc609f97488a0c10c19bfe3b3b8e6 Reviewed-on: https://gerrit.libreoffice.org/72420 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-05-17Some additional manual formatting.Todor Balabanov
Change-Id: Ie5590535d013aa2f747dd034fa2fcd2ae5c3956b Reviewed-on: https://gerrit.libreoffice.org/72226 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-16Temporarily disable broken part of xwindow.py testStephan Bergmann
Apparently, at least for many builds there is am additional mouseExited/ mouseEntered event pair (making mouseEnteredEventsIntercepted = 2 and mouseExitedEventsIntercepted = 1) initiated by the xToolkitRobot.mousePress(xMouseEvent2) when the mouse pointer moves from the "Standard" window to the "writer_edit" sub-window. This needs further investigation. Change-Id: Iecebdb8db2b0d0a051072ff1a20ac00e4dfcb06c Reviewed-on: https://gerrit.libreoffice.org/72433 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-16Make xwindow.py test more robustStephan Bergmann
...by waiting for all events to be processed before the listeners are removed Change-Id: I1aa4f6c43de97a567877a499c4c8fb51ef53eeea Reviewed-on: https://gerrit.libreoffice.org/72432 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-16More precisely count different event types in xwindow.pyStephan Bergmann
Change-Id: I6872684292b4e7ef04f4c590012f1af25243f22f Reviewed-on: https://gerrit.libreoffice.org/72426 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-16tdf#125054 fixed WhichIDs for cloned ItemsArmin Le Grand
Cause of error is that former operator= for SfxPoolItem copies all but the WhichID from the source, so being quite (and dangerously) dfferent from Clone() method. There were quite some places (and will be) that use that from my POV 'hidden' functionality by creating an Item with the target-WhichID and then using operator= to assign data from an Item with different WhichID Change-Id: Ia7e78d6d1b8b34c9c34e936db10cc850928531d5 Reviewed-on: https://gerrit.libreoffice.org/72399 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-05-16tdf#124825 sync UI between LibO implementations and LOOLandreas kainz
Change-Id: I003d68d6f97feb773c3b6590d385a58c98311755 Reviewed-on: https://gerrit.libreoffice.org/72281 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-16uitest for bug tdf#125051Zdeněk Crhonek
Change-Id: I7e347a1ce77f24855ad3e6c1c23f0308122501ba Reviewed-on: https://gerrit.libreoffice.org/72392 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-05-16sw layout, TabOverMargin: fix nbsp character going to a new lineMiklos Vajna
This is similar to what was fixed in commit 9ecc9e39112fdd2b55004a0c43eb8c3ceee2e540 (Related: tdf#120287 sw layout, TabOverMargin: fix too wide tab portion, 2018-10-05), but here the problem was that we decided to start a new line when there was still enough space in the compat option case. Change-Id: I61900044a175cd14b3cdc5d36d2fa50d45c304e3 Reviewed-on: https://gerrit.libreoffice.org/72405 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-05-16external/libodfgen: Honor -std=... passed in via CXXFLAGSStephan Bergmann
...which fixes an issue encountered when compiling with Clang against trunk libstdc++ (which contains pre-C++17-only code that triggers <https://bugs.llvm.org/show_bug.cgi?id=41896> "Bogus 'error: no return statement in constexpr function' when void return type is 'templated'") Change-Id: I33368996c8ac8cf32893ba1b631ace2a606dafb1 Reviewed-on: https://gerrit.libreoffice.org/72409 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-16tdf#125170 Deliver mouse events also when clicking into document contentSamuel Mehrbrodt
Event listeners are added once VCLXWindow::SetWindow is called. This never happened for the document content window. So we need to call Window::GetComponentInterface which will create an XWindowPeer and then call UnoWrapper::SetWindowInterface which calls VCLXWindow::SetWindow. After that, event listeners are registered so that we can deliver events. Change-Id: I2ed01f1ab20d87fedc4803bdbd96f5ef14d40043 Reviewed-on: https://gerrit.libreoffice.org/71948 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-16document ScMarkArray a littleNoel Grandin
because it took a loooong time staring at the code to figure it out Change-Id: Ia8f3b835cd7d18737e4b0ffe1aa67ad001822d82 Reviewed-on: https://gerrit.libreoffice.org/72395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-16Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Remove now useless <switchinline> Change-Id: If7c9ddda50735d349f59c3d8f138177c8fbd6de0 Reviewed-on: https://gerrit.libreoffice.org/72384 Tested-by: Jenkins Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-16vcl_complextext is still unreliable under windowsCaolán McNamara
Change-Id: Ia6ecd04b81abb751bd7159ca8432c00f97ab5e2d Reviewed-on: https://gerrit.libreoffice.org/72407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-16cache mdds position in ScTable::InvalidateTextWidth (tdf#108298)Luboš Luňák
Again, normally starts container search from the beginning, so without caching this is quadratic. Change-Id: I3bb1ff40a326eb46780e45d3e3934773a7b77d06 Reviewed-on: https://gerrit.libreoffice.org/72406 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-16update libodfgen README a bitDavid Tardon
Change-Id: I9d0a7e782b1bd5955cb524153b8a7bdea9e174e7
2019-05-16Using the m_FeedbackFDs is now apparently necessary also on iOSTor Lillqvist
The below commit message is relevant for the behaviour fixed by this change in the Collabora branch cp-6.0 (or core) and collabora-online-4 (of online). The behaviour here in master is broken in different ways, though, and I am not entirely sure whether this change fixes anything here. But let's apply it here, too, for consistency. Until recently we had managed without them on iOS, but that changed with the recent "Unipoll" work, I think. (Without this change, the iOS app now runs into assertion failures early on. But note that this change is not enough to make it work fully again.) Change-Id: I09d25326ba73ce897da5c91f30530f5b3d5fd272
2019-05-16javaunohelper: blind fix for Android build broken by 2d22f8bb15c1Michael Stahl
Change-Id: Ie56197b3f4a90b8f9510a1c29d0388f5f70e1d16 Reviewed-on: https://gerrit.libreoffice.org/72408 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-16Adapt compilerplugins to Clang 9 isExplicitSpecified -> getExplicitSpecifierStephan Bergmann
see <https://github.com/llvm/llvm-project/commit/ 76b9027f352a83c13c98820724071c5e3bea6232> "[c++20] Add support for explicit(bool), as described in P0892R2." Change-Id: Ia8a6902a64ab3377328fd5e3ed57246d214176f2 Reviewed-on: https://gerrit.libreoffice.org/72335 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-16optimize ScImportExport::Doc2Text() for large columnsLuboš Luňák
Again, mdds starts container search always from the beginning, so iterating over it is quadratic. Making a large selection triggers VclQt5Clipboard::setContents(), which calls this. Change-Id: Ic027ff7c5507b41d42b9561cd099e01b50055adb Reviewed-on: https://gerrit.libreoffice.org/72367 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-16optimize ScHTMLExport::WriteTables() with large columnsLuboš Luňák
Again, unless given a hint, mdds always starts a search from the beginning of the container, so iterating over a column becomes quadratic. Shows when selecting (the title of) a large column with different value types, e.g. in tdf#120558, which triggers setting the selection from VclQt5Clipboard::setContents(), which calls this. Change-Id: Ida009c5ddf18ccdc8dff88c15530cc7e33ce80e7 Reviewed-on: https://gerrit.libreoffice.org/72366 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-16cache mdds access in ScTable::ValidQuery() (tdf#80853)Luboš Luňák
Once more, mdds always searches from the start of the container, so iterating is quadratic. Change-Id: I8f8f3b5aad5c3342a10c21df3ad2d0d3fcaea8ad Reviewed-on: https://gerrit.libreoffice.org/72368 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-16Revert "tdf#120836 KDE5: Clipboard: don't put images to clipboard"Luboš Luňák
My previous commit has disabled setting non-text for selection, so this workaround is no longer needed (and it very much looks like a workaround, I see no good reason for never putting images in the clipboard). This reverts commit c8b0c382c6330865df50ae7cf7360c8a2c08ebe6. Change-Id: I0206211e3ff0adcb89f8ca5410831a428e71fb51 Reviewed-on: https://gerrit.libreoffice.org/72370 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-16Don't call Application::Quit() in Desktop::terminate() on iOSTor Lillqvist
When exiting from a document in the iOS app, the Application::Quit() would post an ImplQuitMsg user event that would however not be handled for that document. Instead, it would be handled by the next document opened and thus the code would immediately stop editing the document, causing grief. Change-Id: Id24c843b3f329673035da55f53c2134265fce003
2019-05-16We apparently need to drop the Solar Mutex when exiting lo_runLoop() on iOSTor Lillqvist
It seems to be held after soffice_main() returns for the first document opened, but not subsequent ones, for some reason. So acquire it an extra time to be able to use Application::ReleaseSolarMutex()... Without this, when opening a subsequent document, the loleaflet loading progress bar just hangs. Change-Id: I4e4e7b814f0dba836b790b6f68470aab54f8bbb9
2019-05-16Introduce vcl::lok::unregisterPollCallbacks() and clarify isUnipoll()Tor Lillqvist
There was a problem in the iOS app where a callback was done passing a registered mpPollClosure that pointed to the mainKit variable in lokit_main() even though that variable had already gone out of scope and been destructed. Introduce unregisterPollCallbacks(), which just sets the mpPollClosure pointer to null. That means no callbacks should be done any more. It does not mean that Unipoll would not be active. Change isUnipoll() to look at whether the mpPollCallback pointer has been set or not. Change-Id: I5d5527c0ef097682679371dc642f8896ff05450d Reviewed-on: https://gerrit.libreoffice.org/72283 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-16tdf#125254 Performance: A spreadsheet opens too slow, part1Noel Grandin
This takes the opening time from 55s to 48s for me. Change-Id: Ia60fff33e9948e0bd6906c82b48aa30f8b2551bb Reviewed-on: https://gerrit.libreoffice.org/72394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-16tdf#42949 Fix IWYU warnings in include/svx/[e-g]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I861d3f0fa15ee3b7e0e830c4fac2e5794ea4071b Reviewed-on: https://gerrit.libreoffice.org/72213 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-16tdf#97635 Added unindentation using shift-tab (mimicked eclipse behavior)Andreas Heinisch
Change-Id: Iaf64451c92f3465751032dde9c283141e548b3ca Reviewed-on: https://gerrit.libreoffice.org/72228 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-16Make gdb autoload template more pythonicJens Carl
Replace vim modeline with Python specific one to avoid problems with tabs and spaces, and also make code more pythonic. Change-Id: Ia0959787ceea740b5c97f500c60ef423fbed0651 Reviewed-on: https://gerrit.libreoffice.org/72375 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-16tdf#125254 Performance: A spreadsheet opens too slow, optimise listenerNoel Grandin
saves about 0.5s out of a 43s load And remove the comment in EndListeningAll, SfxBroadcaster::RemoveListener doesn't have any weird side-effects any more Change-Id: Id7c8ac1bed8ff3487cb8f977990d8fac351d7f03 Reviewed-on: https://gerrit.libreoffice.org/72396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-03-21 06:49:21 +0000