summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-01Accept iOS SDK 13.2Tor Lillqvist
Change-Id: I5d42a60a257661f39d1c9af6299ca3278f783d2b Reviewed-on: https://gerrit.libreoffice.org/81870 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-01tdf#127921 Don't change slides when clicking in Slide sorter viewSamuel Mehrbrodt
Change-Id: I21dfe232234d29dd110771a9edf9d4b9b0f6d53b Reviewed-on: https://gerrit.libreoffice.org/81833 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-01loplugin:finalclasses in sc/incNoel Grandin
Change-Id: I6a08a86262deae4bed3a05f77d3041a568f23595 Reviewed-on: https://gerrit.libreoffice.org/81853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-01loplugin:finalclasses in xmloffNoel Grandin
Change-Id: I664aa4dce822bcf14368fd8d08f678e2cd41fd12 Reviewed-on: https://gerrit.libreoffice.org/81852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-01odk: fix for change directory in complextoolbarcontrols sampleVasily Melenchuk
On Windows classical "cd" command does not change drive automatically. So if OO_SDK_OUT folder located on another drive than SDK_HOME we will receive confusing buid errors. To avoid this for Windows configuration we should use "cd /d". Change-Id: I22908d49fc915d3a834972357934349ba82bbec5 Reviewed-on: https://gerrit.libreoffice.org/80827 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-01Add ability to set tooltip text for toolbar controlsSerge Krot
Change-Id: I994b9cee248900786e0d386bd648bd1d64aeeff7 Reviewed-on: https://gerrit.libreoffice.org/79676 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit 092273919e1adec93617b08ebf1d44088301365c) Reviewed-on: https://gerrit.libreoffice.org/81639 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-01Toolbar: add usage of FixedText as toolbar controlSerge Krot
Change-Id: I26a79c485fa2e168058025e058bcfb793af7515f Reviewed-on: https://gerrit.libreoffice.org/81039 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit c2682ba52ea0cbb7af95e80f6d67b286061aeae2) Reviewed-on: https://gerrit.libreoffice.org/81643 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-01ToggleButton: add ability to set tooltip text for pop-up menu itemsSerge Krot
Change-Id: Iacd5c97438782ffddc8a9196688e1d58abce9abe Reviewed-on: https://gerrit.libreoffice.org/80906 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit 8f79936d5278fd5172f5864f99befaa878de5f5d) Reviewed-on: https://gerrit.libreoffice.org/81642 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-01Tooltips: Use HELPWINSTYLE_BALLOON when tooltip contains \nSerge Krot
Change-Id: I33ef48b5a90338471d85a613ede73eada323381c Reviewed-on: https://gerrit.libreoffice.org/80825 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit ba5722319a585bf887965177f2d26e859b8e732b) Reviewed-on: https://gerrit.libreoffice.org/81641 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-10-31Fix typoAndrea Gelmini
Change-Id: Id26980c410f512f711f674af72d070e3b074f13b Reviewed-on: https://gerrit.libreoffice.org/81866 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-31tdf#128431 Box info item is needed by the Border Background dialogJim Raykowski
...so put it back Change-Id: Ie2883410514496c247f840fb2d6755bec362a8b2 Reviewed-on: https://gerrit.libreoffice.org/81815 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-31jsdialogs: refresh SidebarDockingWindow after eventSzymon Kłos
Before we had JSON genertion in Deck now it was moved to the parent. Change-Id: I0fc11ec716542fd3aa6862292ae94985ee3d20d4 Reviewed-on: https://gerrit.libreoffice.org/81854 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31pass an explicit parent for the password dialogsCaolán McNamara
Change-Id: Ic25d6b61750df9ccf5271df1b4d314ae9cb07550 Reviewed-on: https://gerrit.libreoffice.org/81758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31crashtesting: null deref on import of fdo51601-2.xlsxCaolán McNamara
Change-Id: I2db907a9247b622b3977aec9686c09d56fe3ef38 Reviewed-on: https://gerrit.libreoffice.org/81846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31avoid intermediate vcl::WindowsCaolán McNamara
Change-Id: Ie0618107a3aee4a0d35867f3c1cf83715e7bc842 Reviewed-on: https://gerrit.libreoffice.org/81763 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31tdf#125688, cache token names as OUStringNoel Grandin
to avoid construction cost, shaves 2% off load time Change-Id: I37a70a6e989f53d67911a6cb217d07e2db55cb44 Reviewed-on: https://gerrit.libreoffice.org/81841 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31tdf#125688, better sizing for some OUStringBufferNoel Grandin
Change-Id: Ib1f49a53bd5e799455b57abd8532e3e61e119abe Reviewed-on: https://gerrit.libreoffice.org/81840 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31tdf#125038 DOCX import: better support for linebreaks in IF fieldsMiklos Vajna
IF fields can't contain linebreaks, so instead of just calling finishParagraph() and hoping it does something sane, explicitly handle them: remember the properties and perform the call only once the field is closed. Change-Id: I676aa2c83f12cb600829177a0eb25558822b1d94 Reviewed-on: https://gerrit.libreoffice.org/81847 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-31Fix typosAndrea Gelmini
Change-Id: I917e4cdac3690dd5134e4994a0ee4106ae88ae36 Reviewed-on: https://gerrit.libreoffice.org/81860 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-31crashtesting: null deref on import of fdo64646-4.xlsCaolán McNamara
Change-Id: Ie9d3e06a713660124148362f97f0f9dbe45f69bc Reviewed-on: https://gerrit.libreoffice.org/81844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31crashtesting: null deref on import of fdo48634-1.xlsCaolán McNamara
Change-Id: If718c39d31ae214f02cbb747f0ceafd35b297521 Reviewed-on: https://gerrit.libreoffice.org/81843 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31avoid intermediate vcl::WindowsCaolán McNamara
Change-Id: I5d6a03baed2af5801132f3e3a0411867ba60186e Reviewed-on: https://gerrit.libreoffice.org/81760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update Impress help pages (wip) refactor pages after menu changes remove unused page. Change-Id: I85caa9ab6cb42cf8da018d8e54e3387397b0e9f6 Reviewed-on: https://gerrit.libreoffice.org/81859 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-31fix position page alignmentCaolán McNamara
Change-Id: I6f48661172c652b14c703f35edae3b8962f7ec09 Reviewed-on: https://gerrit.libreoffice.org/81771 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Resolves: rhbz#1766990 starmath might not be availableCaolán McNamara
Change-Id: If2e02d8da85a2af576d9563c455487ac3463c935 Reviewed-on: https://gerrit.libreoffice.org/81837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31setting has-default true on an element in a GtkPopover is fatalCaolán McNamara
in gtk 3.24.12 at least. in ColorWindow explicitly track which button is the 'default' one for the two modes instead of using get/use-default and then just grab_focus instead of setting has-default for these popover cases Change-Id: Ia226f847f666d2356c6ea4e8c47f5db8e2535410 Reviewed-on: https://gerrit.libreoffice.org/81834 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31jsdialogs: .uno:XFillColor with string argumentSzymon Kłos
Change-Id: I7f078fc66cecacccd4473495f96e4e2dbfd89d14 Reviewed-on: https://gerrit.libreoffice.org/81832 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31remove some stray random propertiesCaolán McNamara
Change-Id: I0f20e057b97bcb3ab120ae6b211729ea60937bd8 Reviewed-on: https://gerrit.libreoffice.org/81769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31avoid intermediate vcl::WindowsCaolán McNamara
Change-Id: Iac6bc83265e007a699a8993b89ac2efaa3739d95 Reviewed-on: https://gerrit.libreoffice.org/81761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31loplugin:finalclasses in vbahelperNoel Grandin
Change-Id: I4f940ef52a17a315b74cea0f0218e9a9a610e78b Reviewed-on: https://gerrit.libreoffice.org/81826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31loplugin:finalclasses in vclNoel Grandin
Change-Id: Id6dd59d0a335d84c513059ed7870135cf9959af8 Reviewed-on: https://gerrit.libreoffice.org/81827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31tdf#125038 DOCX import: fix lost MERGEFIELD result inside an IF fieldMiklos Vajna
The problem here was that the IF field result didn't have a plain text string, rather it had a MERGEFIELD in it. Writer's conditional text field expects a plain text string, so just use the result of the MERGEFIELD for an IF parent. Do this in a generic way, it's likely that other parent-child field combinations want to do the same in the future. With this, all lost strings are fixed from the original bugdoc + all unexpected content is hidden in Writer as well. Change-Id: Ic5c03b1df2f08a2cd851647b625e0c303cc5d6c5 Reviewed-on: https://gerrit.libreoffice.org/81825 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-31Insert section is supposed to be a modal dialogCaolán McNamara
Change-Id: Ie67303cbe26313994a89b2057ae673805a38cced Reviewed-on: https://gerrit.libreoffice.org/81806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31sw: copy bookmarks in SwDoc::CopyPageDescHeaderFooterImpl()Michael Stahl
When importing tdf113521-1.doc, a footer is copied, but the fieldmark in it is not copied, so there are CH_TXT_ATR_FIELD* in the copy without matching fieldmark, and the result is sw/source/filter/ww8/wrtw8nds.cxx:2342: virtual void MSWordExportBase::OutputTextNode(SwTextNode&): Assertion `pFieldmark' failed. Change-Id: I42b005e22b57f181e4e8bc52afb053546db5f741 Reviewed-on: https://gerrit.libreoffice.org/81792 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-31sw: WW8 import: filter control characters in GetFieldResult()Michael Stahl
Triggers the assert in SwSubFont::GetTextSize_() on ooo58234-1.doc, which has a field result with ^G cell separators that is converted to SwInputField, which inserts the field result into SwTextNode. Change-Id: Ibdb93390862a11462d62cf744bac912d6009777e Reviewed-on: https://gerrit.libreoffice.org/81788 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-31pChartWindow cannot be null hereCaolán McNamara
Change-Id: I8cd994b7d948c1c59b178e8b9b520bc76f5b5632 Reviewed-on: https://gerrit.libreoffice.org/81759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31fix label alignmentCaolán McNamara
Change-Id: Ic2fa0432d5bbba6f1e520e36cada4743dcd8e4af Reviewed-on: https://gerrit.libreoffice.org/81770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31tdf#42949 Fix IWYU warnings in cppcanvas/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3e6b35acf6266157d4cf634e2143e6e19a73102a Reviewed-on: https://gerrit.libreoffice.org/81813 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-31Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - No hardcoded product name. Replace LibreOffice -> %PRODUCTNAME Change-Id: I4a6c83d6ba0bd1efdd078cf3d9f0cbc693e82a60 Reviewed-on: https://gerrit.libreoffice.org/81830 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-31Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add screenshot for Options General page Use kde5 breeze theme Change-Id: I6f2fbcdc80cf2e5f30a81386784d11581524b03d Reviewed-on: https://gerrit.libreoffice.org/81829 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-31jsdialogs: send grid attach dataSzymon Kłos
Change-Id: I667e1ba97f42ac3e7b806bcec929ff346400bdda Reviewed-on: https://gerrit.libreoffice.org/79699 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/81764 Tested-by: Jenkins
2019-10-31jsdialogs: .uno:XLineColor with string argumentSzymon Kłos
Change-Id: Ic06aaef076d101d90bf76461e2b3a97580ad311f Reviewed-on: https://gerrit.libreoffice.org/81821 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - sbasic.tree, uno_objects, ThisComponent better descriptions Change-Id: Ie1778adf59317260cc0c9a1c1eb43ed2d66e7518 Reviewed-on: https://gerrit.libreoffice.org/81822 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-31we already have a suitable parent for the dialogCaolán McNamara
Change-Id: Ib5da2fe6a5b56dfff088b16639ec7a3f226b18f2 Reviewed-on: https://gerrit.libreoffice.org/81744 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Resolves: tdf#124267 accelerator in tooltipCaolán McNamara
Change-Id: I5ab6aa00160aca427b260be535707fa55f6f953e Reviewed-on: https://gerrit.libreoffice.org/81715 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Fix missing param for screenshotting SdTabPageDialogMuhammet Kara
Change-Id: I8f467c9e72811cb6d7f015f7d7d9a944882d48ec Reviewed-on: https://gerrit.libreoffice.org/81820 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-31tdf#125688, deque->vectorNoel Grandin
shaves 5% off load time Change-Id: I555ce09d12f801c9d69efb816f9389e27ca396cc Reviewed-on: https://gerrit.libreoffice.org/81818 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31Missing test dependencyStephan Bergmann
> include/c++/10.0.0/bits/unique_ptr.h:81: error: undefined reference to 'SvxNumberInfoItem::~SvxNumberInfoItem()' > collect2: error: ld returned 1 exit status > make[1]: *** [solenv/gbuild/LinkTarget.mk:639: workdir/LinkTarget/CppunitTest/libtest_sc_screenshots.so] Error 1 Change-Id: Ifb498e7a54b37bd93c71110b6d7cfda4ea8ef1b5 Reviewed-on: https://gerrit.libreoffice.org/81805 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-31Fix StringAdd::isCompileTimeConstantStephan Bergmann
...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-31related tdf#99602 docxoutput: fix incorrect rounding on subscriptsJustin Luth
Adding .5 is a poor mans version of rounding which works fine with unsigned numbers, but not with negative numbers. Perhaps use the exotic round() function instead? In addition, the font size isn't necessarily an integer, so that should have been a float. The result of bad rounding was losing a percentage of the subscript every round-trip. Change-Id: I83e05d8367f059f3266d12a7e134e268fef758bb Reviewed-on: https://gerrit.libreoffice.org/80217 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>