Age | Commit message (Collapse) | Author |
|
The attributes 'vert' and 'vert270' set property TextPreRotateAngle on
import from OOXML. The property TextRotateAngle can be set by macro.
Both were written to file as 'draw:text-rotate-angle' attribute. So we
got a file format error 'duplicate attribute'.
The values are now added and the sum is written. That gives the same
rendering as after applying a macro. Using the sum is a workaround. We
have currently no way to save the direction specified by 'vert' and
'vert270' as style:writing-mode to ODF.
Change-Id: I93fd8ca42b82c1ed7f1bf6e33d932e5510615b2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135901
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
|
|
Change-Id: Ib82fd7a19a837521afbe0d0a6c154d4c5c5f2824
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135755
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update translations from branch 'master'
to 140d3bcbbdf20e83d772d419515e49846ae7e105
- Updated Slovenian translation
Change-Id: Ic93876c783b228af11b625e1a2e7370567798a84
|
|
* Update translations from branch 'master'
to ef3257698791a7e3312d5d859ac8229ee48a0e69
- update translations for master/7.4
and force-fix errors using pocheck
Change-Id: I748d74278038427100e6927f374e17d69a2eaee9
|
|
In 391cb44d415e2126f668ecf62387d5e98ffa6f5c
"Advanced Diagram support: UI visualization & simple interactions"
added a UI visualization to advanced diagrams.
However, the feature is incomplete at the moment, specially towards
LibreOffice 7.4, thus, make it experimental for now.
This can be reverted later on
Change-Id: Ibf21d11899460ab9ef1ddf91cffb851171119618
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135912
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
|
|
Change-Id: I3e6ab3d8f3e9dddfec90f1a9762e7bf2007c10db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135899
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I9769e01a95b10a798769104e16e6b0c37585a2d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135559
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The code responsible for sending an a11y focus event when the cursor
moves from elsewhere into e.g. a table cell depends on the fact that the
cursor was previously not in that object, i.e. the previous/old
cursor/caret position is -1, s. e.g.
`SwAccessibleParagraph::InvalidateCursorPos_`.
Already setting `m_nOldCaretPos` to the the actual cursor position
instead of -1 in the `SwAccessibleParagraph` ctor resulted in that
assumption no longer holding when initially moving the cursor into a
table (cell), so no focus event would get sent and
the NVDA screen reader on Windows would therefore also not refer to
the correct a11y object when handling the subsequent CARET_CHANGED
event and fail to retrieve the caret position in the previously
focused object (because focus/cursor have moved on).
Make focus announcement work by only setting `m_nOldCaretPos` to the
actual cursor position when processing the corresponding events related
to change of cursor position, not in the ctor.
Setting the cursor pos already in the ctor had been added to fix an
issue with IM handling in
commit 817da76529aa39f641d76805d429b09681348811
Date: Sat Nov 8 19:37:22 2014 +0300
fdo#85912 Delete surrounding text failing for input method calls regression.
When Apache OpenOffice code was merged in, a few lines were removed for
no apparent reason. This just adds the code back in, and resolves the bug.
See the comments in fdo#85912 for details about this bug. It is hard for
majority language users to reproduce since they don't use ibus/kmfl to
type their language's letters.
The issue mentioned in the referenced tdf#85912 (== fdo#85912) is not
reproducible for me with this change here in place either, neither with
the gtk3 VCL plugin nor with kf5 (for which the relevant IM handling has
been added in the context of tdf#149255, which has some more
information on the ibus/kmfl setup needed to reproduce the
original bug). The bug report already mentioned that the issue
was reproducible with Linux 13 Mint and LibreOffice 4.3.3.2, but not
Linux 17 Mint with exactly the same LO version, so without being able to
analyze this any further, the best explanation I can come up with is
that the root cause for tdf#85912 was somewhere else and has been fixed
in the meanwhile.
In hindsight, comment 5 in tdf#85912 already has further information
on why adding the assignment back to the ctor was problematic:
> Reviewed OpenOffice code as well. The missing lines exist (but are
> commented out) in the current AOO code. The commenting out
> occurred when Steven Ying implemented his huge "AOO IA2 enabled draft
> version 1" change on 27 Sep 2013.
> https://github.com/apache/openoffice/commit/0deba7fbda3d9908785c25a443701a293b6f4e71#diff-50d752f41bb880abd1094d09d9e1a7fc
>
> The current AOO comment is
> // If this object has the focus, then it is remembered by the map itself.
> // not necessary to remember this pos here. Generally, the pos will be updated in invalidateXXX method, which may fire the
> //Focus event based on the difference of new & old caret pos.
> //nOldCaretPos = GetCaretPos();
Change-Id: If8cd4e92bc1f6233775ccc2834230f3a388ccadb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135868
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Crash seen:
> mergedlo.dll!SvTreeList::GetDepth(const SvTreeListEntry * pEntry) line 106
mergedlo.dll!SalInstanceTreeView::get_iter_depth(const weld::TreeIter & rIter) line 4230
basctllo.dll!basctl::SbTreeListBox::FindVariable(const weld::TreeIter * pEntry) line 271
basctllo.dll!basctl::SbTreeListBox::FindModule(const weld::TreeIter * pEntry) line 695
basctllo.dll!basctl::MacroChooser::BasicSelectHdl(weld::TreeView & __formal) line 473
basctllo.dll!basctl::MacroChooser::RestoreMacroDescription() line 158
basctllo.dll!basctl::MacroChooser::run() line 178
Change-Id: Ic85758c0bbee952d0a23b1d52e8bbdd231e8de26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135914
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
This is a continuation of commit 85376a02348810812d515ee72140dbf56f2b6040
for the case when redlining is turned on.
Also try to restore the anchors in SwUndoRedlineDelete.
(regression from commit 3345feb67f2c49a1b76639965b56968e1c5f03ee)
Change-Id: I4199f5755398d469a606618c037ad9756cb7aeba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135909
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
This looks like copypasta, presumably both flags must be true to allow
grouping.
Change-Id: I96afeac98f94b122a3b1a155940776a3aa44b0a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135908
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
When reproducing tdf#135976 and then Undo, an UAF crash happens here:
assert(!pFrame->GetDrawObjs() || !pObjs->Contains(*pObj));
The pObjs was actually deleted and then re-created, because the pObj was
removed from the frame and added again to the same frame.
This is a bit unexpected, so prevent it by taking a shortcut in the
caller UpdateFramesForRemoveDeleteRedline() to insert a check that had
been removed in commit 14e87a4b15d31a34e6053f6194688f3aa23af991.
If the rPam is inside a single node, the sw::RedlineUnDelText hint that
was sent to the SwTextFrame should be sufficient to update it and the
rest of the code in the loop that deals with newly split paragraph can
be skipped.
Change-Id: I5f36eb91bc20003887ee0bad03ea4a6e67135de9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135907
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Just return `E_NOTIMPL`, as the
`IAccessible::put_accName` doc now says [1]:
> The IAccessible::put_accName method is no longer supported. Client
> applications should use a control-specific workaround, such as the
> SetWindowText function. Servers should return E_NOTIMPL.
[1] https://docs.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-put_accname
Change-Id: I4b36b6a4c4215f237ba7e7583d2f130e8d80f200
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135903
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
also when there are active UNO connections.
(Behavior was different when there were active UNO connections)
Change-Id: Ief37b0f362b7e2a47eccbec985ee3017c475046c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135905
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
a case of this -2 is also mentioned in
commit 97af58093978d8e6b9d90eedcc59141304e7200e
Date: Fri Apr 5 22:04:13 2019 +0530
tdf#123421 : xlsx export : Don't write data field entry...
Change-Id: Ieded6035539df9d3896f2f08cf03c195082d4987
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135817
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I72b861144e2634d074e7b6f7f91e27e4875304a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135613
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I040c8052a4cf0b4a29b967483ec5d77968f80976
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135659
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Similar to what oox::vml::ShapeType::getAbsRectangle() already does.
Crashreport signature:
Fatal signal received: SIGFPE code: 1 for address: 0x7fcd55eeff59
program/libooxlo.so
oox::drawingml::GraphicProperties::pushToPropMap(oox::PropertyMap&, oox::GraphicHelper const&, bool, bool) const
oox/source/drawingml/fillproperties.cxx:103
Change-Id: I0f82cbc955d9e60bad103682638b07153a5589e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135910
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
...shouldn't be treated as if the cursor was there.
Change-Id: Ida435635aab4442b93f969d6f473aacf3f229e02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134887
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Change-Id: I4094fb46bb6130f4befcc25136424a45b90b9d92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135897
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I7c3e24f3974dafeb9abb2af9e2a986003af7bfc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135873
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
the transliterate functions will realloc the Sequence, no need to do it
here
Change-Id: Ia53e79b7586679b5c8a2a47c11b86e336195a4cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135872
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I753fe8c17a572c734bb4f865c0b9920285849ca3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135623
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: Ice84ca4c1c6eed9e21e3d5916f47e686b61c79b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135621
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I45615f217120d90cb255ce1a3e9e1f710603770e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135663
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I4dbe6fcd04aebc25a17263f160b7683cbf01ac30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135671
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I460cd2ea6950cf9f8bc656a94c71973bd93c1fae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135879
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ie29092ed3a37cfd6bd0c95148a3edc5559ac260f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135763
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I0686e41c75c9887264c619d3f477bb7ca3c3a1fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135610
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I8445fef2a116d063c15f65ed4c8ac705a8ce7491
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135870
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ic2f07d9a4e8e8608e5a56f23d421004f6631427a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135760
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I093768c617490679d295cce37cc3ffe67c8e940a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135871
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibdaa15e1d573f34e3098bf00b883752ce4df40c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135767
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Split xcu files for Z compressable graphic formats. This introduces a
new option for exporting each Z compressed graphic format without
needing to check for extension.
Change type detection accordingly in graphicfilter.
Change-Id: Iabb971123f5e394196716900796632cb8ed12ece
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135181
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I2358434ffa3aff8bda16576bf8849eed52a3edd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76401
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I95fd738f4fa8e93c1d90f4b8701e36facadaa7fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135865
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I61593b4f147bb2b83bd979f8fd429b70b3286d77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135885
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This reverts commit 2da1cdd31312a70f205f29bb4dfcbc1771409aa4.
Comment from llunak:
I'm possibly not remembering it exactly. But the point is that if you're going to destroy something, it's faster to destroy it outright rather than move it somewhere and destroy it later. If you google it you'll find posts on how implementing std::move() using std:swap() is generally a pessimisation.
Change-Id: Ice4234ad074cd894a25782e9c52b34c5acb26c8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135880
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
mismatched Push/Pop, catch offending exception
Change-Id: Ib2297a8ab04a2f2491e4c922d9e4db82a66ea911
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135825
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I37fea3c5788ce4fd00bec50276bb6c41e11cdb99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135626
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: Iaed3953370a3e12aa1150dd6878d797ec0f9179c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135660
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
This follow-up on commit 483f3125ecd4744cbcc2f8fd3cdf243d81a601ff
("WIN drop effectively empty ImplDrawMenuBar") should probably
have been included in it. Windows was the only implementation of
that API, but the API is just called for a native menubar, which
Windows doesn't use (VisibleMenuBar returns false). Maybe Windows
SalFrame::SetMenu should also be dropped?
Change-Id: Ic3600e66c91ce9d56d7f911bce5674e0a9ee833c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135633
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I4b862e1f5c8ceb3adfe5009cf13b32073c3ebb5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135670
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
The .cxx are already separated, use a different
makefile for vba-macro-test.cxx
This might help to mitigate the CppunitTest_sc_macros_test
failure happening in Jenkins on Windows
Change-Id: I5708de3527041a5fcb33287f75f0e14642a88c4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135862
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 70653442aed4591284e2f543d74e5309f510ab87
- Clarify URL inside this document a bit
Change-Id: I7fdd48bd925619b42452df88fd8343727e1a2667
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135882
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
... keywords; that should catch most lower case queries. If there
are still remaining mismatches then either implement the bScan
thing, or enhance addNew() to not fail on case-different format
codes. That could be hit for the `General` keyword, for example.
Change-Id: Ic728b8c5e38db76eb791cb305595f84acf7dc867
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135854
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 8c1f8b9235eccee7650a0bc836c5543fc503be9e
- tdf#148901 update Left Page Border and Right Page Border
tdf#148593 changed the option labels:
"Left page border" -> "Left of page text area" and
"Right page border" -> "Right of page text area".
This patch updates the option names and makes
corrections in the description of the referent of these options.
Change-Id: Icf1bf4d493bd0c1b23b46f99e487defcd57b1587
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135875
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Can use CPPUNIT_TEST_FIXTURE() instead.
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
(CppunitTest_sw_rtfimport: convert one testcase to use
CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
Change-Id: I4ab9af48f80cd5f61db05554d31a8f02b89990ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135857
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Id9eeea1c57a4461e0d178492c6472174ff78065a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135867
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Add unit tests that check compressing->decompressing a file should
result in the same file. This is done by comparing the CRC32
before and after. The same tests also implicitly test that
compression/decompression works by checking the return
value of ZCodec::EndCompression.
Cases added for both mbGzLib=true/false.
Change-Id: I5516760eba5f233c20331cef83fd0b1a1603373f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135233
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|