summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-11-14tdf#151962: Math Shortcut to open documents in Spanish versionJulien Nabet
Change-Id: I9802703257f64c9bcb7bc2be77c2f85ef1dec5e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142557 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-11-14WASM: fix loading writer docs after rebaseBalázs Varga (allotropia)
Add missing UI elements to emscripten fs image. Change-Id: I1165fd227674656b818247e58b0a24e815c63392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142579 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2022-11-14sw: refactor to make a11y check for nodes independentTomaž Vajngerl
Add checkNodes, which will only check the current node for a11y issues. This prepares for online a11y check. Change-Id: I069cd200ceb58223b05baaafb7d796148e28398b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141603 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-13Fix typosAndrea Gelmini
Change-Id: Ic1fb0ea483954f2994a87e05f33b320da3795227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142661 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-11-13ofz#53182 TimeoutCaolán McNamara
Change-Id: Ied736c72f08a97de142bb781e01283330db6b3b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-13ofz#53338 AbrtCaolán McNamara
we're turning "false" to indicate nothing was drawn, but nothing was drawn because the entire output would have been clipped out, so there's no point drawing anyway, so return true instead to indicate the draw was successfully short-circuited to give a correct no-op result probably went wrong with: commit 9153a36b59f2efc2bfb2c9256c39eb5687808deb Date: Fri Mar 28 23:30:02 2014 +1100 fdo#74702 Refactor OutputDevice::DrawTransparent() Change-Id: I989ebffff267f57c036560cda59eb7abe14d405a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142635 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-13Clear only lookup caches of calling documentEike Rathke
It is the same for always reused interpreter context slots but does not hurt and prepares for when more than one document is to be cached. Change-Id: Icc8532080f618b9a50627a6e551dfb28803d3c34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142643 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-13vcl: extract functions AllRenderersPaused() and PruneMarkedRenderers()Chris Sherlock
Change-Id: I0fc55e829e22b81a076f2b66d78bb2b90abdfc41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136413 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-13vcl: small optimization determining if any renderers are activeChris Sherlock
Currently we look at every renderer to see if it is paused. However, you can think of this differently - instead of using a universal quantifier we can actually use an existential quantifier - if even one renderer is not paused, then we can say that not every renderer is paused - thus no global pause. Hence switch to any_of(), which stops the loop at the first instance of a non-paused renderer. Change-Id: I3b35bc41e86432374e4bc5fae0a2927ec8cc2309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136412 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-13tdf#114441: Convert use of sal_uLong to better integer typesHarshita Nag
The above change was possible because GetPos() returns value of type sal_Int32 Change-Id: I9fa4389531813eb3c866a355d2f55ddfb32233a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142634 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-11-13Adapted convertToBitmapEx to simpler BitmapEx creationArmin Le Grand (allotropia)
As long as not all our mechanisms are changed to RGBA completely, mixing OutDev with Alpha (2x VDev) and RGB target rendering is just too dangerous and expensive and may to wrong or deliver bad quality results (see comments in code for details). Nonetheless we need a RGBA result for convert to BitmapEx. Luckily we are able to create a copmplete and valid AlphaChannel using 'createAlphaMask'. Based n that we know the content (RGB result from renderer), alpha (result from createAlphaMask) and the start condition (content rendered usually against COL_WHITE). Tht makes it possible to calculate back the content, quasi 'remove' that initial blending against COL_WHITE. That is what the helper Bitmap::RemoveBlendedStartColor does. Luckily we only need it for convert To BitmapEx, not in any other rendering. This gives good results, it is in principle comparable with the results using pre-multiplied alpha tooling, also slightly reducing the range of color values where high alpha vlaues are used, but in areas that are highly transparent anyways. Also important is that this will work with RGB-based system-dependent renderers, too. The method before could only work with the VCL-based primitive renderers by principle (only there - by coincidence - OutputDevice with Alpha worked). NOTE: Had to re-add usage of *unused* alpha channel in convertToBitmapEx due to test SdPNGExportTest. It somehow creates an Alpha in Bitmap size when I *remove* Alpha in convertToBitmapEx, so I just keep it for now, it is created anyways, just wanted to make it sleeker. Change-Id: I12e47327f5793d6ed87e217a2355c608f528246f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142547 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-11-12cid#1516789 Division or modulo by float zeroCaolán McNamara
Change-Id: I191d475df5d1937e80fe6844de618a9ce315aee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142585 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-12Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 6b64fc6ca64e2096615dc3f85f079c9e00798060 - Fix typo Change-Id: I9c89564838a5d8c944c16849b2a2979ef4aa4298 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142582 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-11-12Resolves: tdf#152014 When reusing interpreter context slot clear lookup cacheEike Rathke
... if different doc As is, unthreaded the same slot gets reused for every calculation. That could benefit from keeping 2-3 documents cached to not throw away the lookup cache each time when alternating between documents. Change-Id: Id024333f72bcdcd6109042dec1104f3029955d3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142639 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-12vcl: remove unused WinFontFace() private membersKhaled Hosny
Change-Id: I0f7f9f03064a63f7c27346fd679e4cb436633cd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142638 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-12Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c3e7ddee14953d56f7672fcbcc3b81bd34b455e8 - Add screenshot for index entry in swriter Change-Id: Id8db451f9305d22a27d72452e92e80cdc369ff42 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142636 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3a41dd6f1d61dc8ddc95075cb692e63c862be5bd - tdf#151347 Improve Slide/Page pane references + Added pane entries in Index + refactor xml Change-Id: If4e4db9664a2fef301a742b2d34127fecf585ed1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142612 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12Update git submodulesBogdan B
* Update helpcontent2 from branch 'master' to 35e127cada4630c096b91126d07fe43f70a85b8f - tdf#152011 Improve View menu description Change-Id: I36e11dde9ca5398f9f9bb5c6600cb300380ac114 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142626 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12Update git submodulesBogdan B
* Update helpcontent2 from branch 'master' to 6301f83f2a36ea78ba8cfefbc39f710aff717ef8 - tdf#152011 Improve Form menu description Change-Id: Ic0c58c611fe2fb9260eeef235aac39cc85c9f4f2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142627 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12Update git submodulesBogdan B
* Update helpcontent2 from branch 'master' to 2c9bc4ba19109f877e9fa71ecaa071887943d3c3 - tdf#152011 Improve Tools menu description Change-Id: I4afb4edebc98e692d10ba7c83588886245303a79 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142628 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12Update git submodulesBogdan B
* Update helpcontent2 from branch 'master' to 55781399fdda75511fbc1e96bef79ace02ced37b - tdf#152013 Improve File submenus description Change-Id: I67ec0201c521c3d4fea3eaaa0f359da5bb760d46 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142629 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12Update git submodulesBogdan B
* Update helpcontent2 from branch 'master' to f934ad3e896be59c76e35cf0033be0c7abe1e41c - tdf#152011 Change "open" to "create" for a new document Change-Id: If5e5476465baa225a54448a6bccfebef30fd3f05 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142624 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12tdf#125085 PPTX WordArt import: get shape font from runRegina Henschel
PPTX uses the settings at the run for the text in a WordArt shape. LO uses the settings of the shape. The patch copies the run font and language properties to the shape. In addition I have split the old method lcl_createPresetShape and renamed the parts. Now the method lcl_putCustomShapeIntoTextPathMode contains the geometry changes to put a CustomShape into text path mode and to adapt the OOXML values to the values needed for our preset Fontwork shapes, which are based on binary MS Office. MS Office has the style of the characters of a WordArt as properties of the run. LibreOffice ignores most of the properties specified in the style of a span element, when the text is displayed as Fontwork. Instead LO uses the properties defined for the shape for styling the text. Copying the text properties to the shape is now done in method lcl_copyCharPropsToShape. The values in testTdf125573_FontWorkScaleX depend on the used Font. Since on creation time wrong Fonts were used and now correct Fonts are imported, the values have to be updated. Import of fill and stroke of the characters is still missing, only a rudimentary import of color for solid fill exists. Change-Id: I6f31fe07fb0656b2ce8581e7123265fa598ac9c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142421 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-11-12Resolves: tdf#145648 use the same reference device for comments as documentCaolán McNamara
so we get the same text measurements and so positioning matches. Change-Id: I7b3211cbd8eba41269688316d74a8f72ac734f13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-12ImplDbgTestSolarMutex assert from a11yCaolán McNamara
#5 0x00007fffee605ea2 in ImplDbgTestSolarMutex() () at vcl/source/app/dbggui.cxx:35 #6 0x00007ffff71186f0 in DbgTestSolarMutex() () at tools/source/debug/debug.cxx:54 #7 0x00007fffa95614d8 in SwAccessibleMap::GetContext(SwFrame const*, bool) (this=0x895a9c0, pFrame=0x5358800, bCreate=false) at sw/source/core/access/accmap.cxx:1788 #8 0x00007fffa961ac0e in sw::sidebarwindows::(anonymous namespace)::SidebarWinAccessibleContext::getAccessibleParent() (this=0xb90f800) at sw/source/uibase/docvw/SidebarWinAcc.cxx:65 #9 0x00007fffa961ae27 in non-virtual thunk to sw::sidebarwindows::(anonymous namespace)::SidebarWinAccessibleContext::getAccessibleParent() () at /home/caolan/LibreOffice/core/instdir/program/../program/libswlo.so #10 0x00007fffd8f4ae7d in atk_object_wrapper_new(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&, AtkObject*, AtkObject*) (rxAccessible=uno::Reference to (sw::sidebarwindows::SidebarWinAccessible *) 0xba7f450, parent=0x0, orig=0x0) at vcl/unx/gtk3/a11y/atkwrapper.cxx:970 #11 0x00007fffd8f4a820 in atk_object_wrapper_ref(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&, bool) (rxAccessible=uno::Reference to (sw::sidebarwindows::SidebarWinAccessible *) 0xba7f450, create=true) at vcl/unx/gtk3/a11y/atkwrapper.cxx:925 #12 0x00007fffd8f4d246 in wrapper_ref_child(_AtkObject*, int) (atk_obj=0xb9d06f0, i=0) at vcl/unx/gtk3/a11y/atkwrapper.cxx:500 #13 0x00007fffd95700c3 in add_pending_items () at /lib64/libatk-bridge-2.0.so.0 #14 0x00007fffea7154cb in g_idle_dispatch (source=0x21d40e0, callback=0x7fffd956fec0 <add_pending_items>, user_data=0x21d5890) at ../glib/gmain.c:5935 and... #5 0x00007fffee605ea2 in ImplDbgTestSolarMutex() () at vcl/source/app/dbggui.cxx:35 #6 0x00007ffff71186f0 in DbgTestSolarMutex() () at tools/source/debug/debug.cxx:54 #7 0x00007fffa95614d8 in SwAccessibleMap::GetContext(SwFrame const*, bool) (this=0x894ce20, pFrame=0x53390f0, bCreate=false) at sw/source/core/access/accmap.cxx:1788 #8 0x00007fffa956285f in SwAccessibleMap::GetContextImpl(SwFrame const*, bool) (this=0x894ce20, pFrame=0x53390f0, bCreate=false) at sw/source/core/access/accmap.cxx:1917 #9 0x00007fffa9550a91 in SwAccessibleChildSList_const_iterator::SwAccessibleChildSList_const_iterator(SwAccessibleChildSList const&, SwAccessibleMap&) (this=0x7fffffffbb58, rLst=..., rAccMap=...) at sw/source/core/access/accfrmobjslist.cxx:65 #10 0x00007fffa951c507 in SwAccessibleChildSList::begin() const (this=0x7fffffffbb80) at sw/source/core/access/accfrmobjslist.hxx:100 #11 0x00007fffa95421c2 in SwAccessibleFrame::GetChildIndex(SwAccessibleMap&, SwRect const&, SwFrame const&, sw::access::SwAccessibleChild const&, int&, bool) (rAccMap=..., rVisArea=SwRect = {...}, rFrame=..., rChild=..., rPos=@0x7fffffffbcc4: 0, bInPagePreview=false) at sw/source/core/access/accframe.cxx:179 #12 0x00007fffa9543be5 in SwAccessibleFrame::GetChildIndex(SwAccessibleMap&, sw::access::SwAccessibleChild const&) const (this=0xb7bd6e0, rAccMap=..., rChild=...) at sw/source/core/access/accframe.cxx:455 #13 0x00007fffa9569721 in SwAccessibleMap::GetChildIndex(SwFrame const&, vcl::Window&) const (this=0x894ce20, rParentFrame=..., rChild=...) at sw/source/core/access/accmap.cxx:2905 #14 0x00007fffa961ad89 in sw::sidebarwindows::(anonymous namespace)::SidebarWinAccessibleContext::getAccessibleIndexInParent() (this=0xb9ead70) at sw/source/uibase/docvw/SidebarWinAcc.cxx:80 #15 0x00007fffd8f4d781 in wrapper_get_index_in_parent(_AtkObject*) (atk_obj=0xc517810) at vcl/unx/gtk3/a11y/atkwrapper.cxx:529 #16 0x00007fffd957298c in append_cache_item () at /lib64/libatk-bridge-2.0.so.0 Change-Id: I852f40f30be7c10223ccfd570cb8ca30f1a67f47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-12Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d26dc8bf2215097db8092428cc05a991aa03f8a4 - tdf#89358 Example of implicit intersection for array formulas Change-Id: I6cb1b66a34f8bd95472e78dac03f8860c2cdd375 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142605 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12Update git submodulesBogdan B
* Update helpcontent2 from branch 'master' to 52bd59d3f0ab56d1e105e28c3c458640819e8af9 - tdf#152011 Change order of menus like in Writer Menu Change-Id: I4c7f531939825bf31f5fcc760568d878fff3cb79 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142622 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12Update git submodulesBogdan B
* Update helpcontent2 from branch 'master' to c80376a16c26407a6209dd4e5b3aa6639d599f4c - tdf#152013 Change order of menus like in File menu Change-Id: I3d77b293d36ebc60aad5fc75f7fa33277743b50b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142623 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-12Fix typoAndrea Gelmini
Change-Id: Icec4f84ba52578588512fa6cccd1d0d62b02ef06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142602 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-11-12tdf#151988: Enable "Characters per line" and "Character width" when switch...Kevin Suo
... back to grid type "lines and characters". Also enable "Snap to characters" for grid type "lines and characters" and disbale it for grid types "lines only" and "no grid". Change-Id: I101c8d80a79798fc6c992da766c658c3ba8802dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142513 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-11Fix VS2022 MSMs detectionMike Kaganski
After commits 42da199753515584e615cdcdd8601d2ffc27245b (more VS2022 integration, Oct 14 10:58:25 2021 +0200) and 9ea17a6331ca9491e7012dca837d3815cd4309ac (Adapt to latest VS 2022 MSM versions, Apr 08 09:15:19 2022 +0200), the new 143 version of MSMs gets detected and passed to SCP, but not used there, so MSIs lack CRT. Additionally, it may happen that a redist is configured that does not match the actual CRT used in the build, because it picked a latest available version, and then an error happens when building MSI, because it expects MSMs in wrong source directory. This simplifies the checks, makes sure to look for the correct MSM version, and adds an error message in SCP in case when the passed version is not handled, to detect the incomplete support early. Change-Id: I47d45472309c584314730e7f5f46a9596fc8d21d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142587 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-11dragonbox: upgrade to release 1.1.3Taichi Haradaguchi
Change-Id: I0d240c50c311269c10d53ba3e4bc3dc09273a600 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142378 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-11Resolves: tdf#151898 get hidpi font/highlight color iconsCaolán McNamara
Most of this wouldn't be necessary if we could solve the split alpha problem. In the meantime, let Image take a MetaFile as an arg, record what we want to do in the metafile, and play it back when we need to generate the bitmap for to render the image. That way we don't have alpha to worry about during the recording, and we only have one alpha in the final rendering, as opposed to having two alphas in a source and in destination VirtualDevice, which is problematic in most backends. Change-Id: I5b0d7c498473271f4ab2743f75614b1b93a0e9c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-11Related: tdf#151898 consider surface scaling if prescale with Bitmap::ScaleCaolán McNamara
whose introduction dates back to: commit c0ce7ca4884f7f6d1016bd1dbcc22066cb4a7797 Date: Sat Jul 7 13:07:03 2012 +0200 Prescale image with Bitmap::Scale to improve quality. don't prescale past the level of detail that the surface could retain Change-Id: I1022688d45d2bb7b692f4ba619198fccea8eab36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-11move password handling from SwModelTestBase to UnoApiTestXisco Fauli
so other places inheriting from UnoApiTest can also import/export protected documents Change-Id: I0e2716204dbb171c9e17e3939b266977e1b96dda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-11New loplugin:constmoveStephan Bergmann
"Find occurrences of std::move on const-qualified types. While there might theoretically be legitimate uses for such (for which this plugin would generate false positives and would need to be updated), in practice they tend to point at suspicious code that should be cleaned up in some way." (All issues found for a Linux build have already been addressed with eleven recent commits mentioning in their commit messages: "I came across this code with an upcoming loplugin:constmove that flags suspicious uses of std::move involving const-qualified types.") Change-Id: I891a66eb0ec5f9b7d93536bbccea0359893383df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142589 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-11SVG export: fix handling of semi-transparent, multi-para shape textMiklos Vajna
The bugdoc had a shape with two paragraphs. The export of the second paragraph went wrong: the position & size of the text was larger than expected. This problem was specific to semi-transparent text. SVGTextWriter::setTextPosition() is recursive in this case. The non-transparent case left nCurAction unchanged in the outer setTextPosition() and it returned 1 ("text is found"). The semi-transparent case changed nCurAction by +2 and returned 0 ("text is not found"). This led to all sorts of trouble, including mismatching Push() and Pop() calls on the output device when replaying the metafile. Fix the problem by routing the empty state from the inner setTextPosition() to the outer one: if we return 1 ("text is found"), then we know that the state is non-empty. Once the empty state is correct in the outer setTextPosition(), then even the transparent case also leaves nCurAction unchanged and the whole shape text has the correct position and size. I forgot to update this empty state in ther outer setTextPosition() in commit 666f252457bdb4371d15380a0289e107b2dfbe84 (SVG export: fix lost semi-transparent text on shapes, 2020-07-17). Change-Id: I7dc93fe13c4510220bf09a388e742799ed042510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142590 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-11-11.git-hook: Emit some warning about clang-format and renamed filesStephan Bergmann
...to avoid misguided clang-format'ing of previously excluded files, as discussed in the comment at <https://gerrit.libreoffice.org/c/core/+/142387/4#message-ce27921261661fe7488ef0564657dbb5b42fb5fa> "sc: factor out common code in make files". (Though this still doesn't warn about cases where some excluded file got renamed and the excludelist wasn't updated and the user already erroneously clang-format'ed the renamed file before this commit attempt. Also, I don't know how best to integrate this with libreoffice.autostyle, so just ignore libreoffice.autostyle for now when any suspicious renames are detected.) Change-Id: I8d176ce536548b67f5b2af100f579f362764b06b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142394 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-11SwModelTestBase: get rid of getSwXTextDocumentXisco Fauli
no much value in having it around Change-Id: I864f039c0129a922c8d86b5db0a18158f2155add Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142588 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-11SwModelTestBase: use createSwDoc everywhereXisco Fauli
In order to unify the code Also call getSwDoc only when it's needed so move it outside createSwDoc Change-Id: I082d46108581e8f2e2e430e854980035f471ceac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142586 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-11cid#1516788 Uninitialized pointer fieldCaolán McNamara
Change-Id: I9565a995aa400fd391de70606b59c16e68a042c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-11SwModelTestBase: Check supportsServiceXisco Fauli
Also simplify code a bit Change-Id: I93b277116cd21f9e7e058fdf31e0defab8247f13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142581 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-11Drop useless std::move of const objectStephan Bergmann
...introduced with d8b60f77f389a248f98aa45592e6e1045baafbe1 "rtl_String->OString in DirectoryItem_Impl". (I came across this code with an upcoming loplugin:constmove that flags suspicious uses of std::move involving const-qualified types.) Change-Id: I3df2e6fb9dbf97adba6fbeda51d24cf025f5b207 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142565 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-11ofz#53196 Out-of-memoryCaolán McNamara
Change-Id: I8cb6df1f109a1c10fb025b8ecd229487b73e900d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142578 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-11uiwriter7: simplify codeXisco Fauli
kudos to Mike Kaganski Change-Id: Ic10f794d09b882da95958ad42f3a02aaabbbe1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142583 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-11Clean up some seeming copy/paste mistakesStephan Bergmann
...all introduced with 2a26f136a36791c06caa895d5a25f4633fd10651 "tdf#151548 vba FormFields: Add basic word::XFormField support": For the SwVbaFormField ctor, std::move of a const lvalue has no effect here. (And I just don't bother applying the move-from-pass-by-value-param optimization here.) For FormFieldCollectionHelper, consistently make the data members non-const (a const css::uno::Reference wouldn't make that much sense anyway, as it doesn't transitively apply const'ness also to the referenced object) and non-reference, and make the FormFieldCollectionHelper params non-const (and non-reference) to make the move-from-pass-by-value-param optimization actually work here. (I came across this code with an upcoming loplugin:constmove that flags suspicious uses of std::move involving const-qualified types.) Change-Id: Ib41d4671b33871eddff41bc20ea38de02d616046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142568 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-11Resolves: tdf#151947 Merging separators must not scan for field endEike Rathke
Regression introduced with commit cf777cfcb22647b1f2d6ace307fbcc4f6d2cca30 CommitDate: Sun Oct 2 17:07:06 2022 +0200 Resolves: tdf#125110 tdf#151211 Disentangle the convoluted CSV/TSV-clip import a copy-paste replacement logic error. Change-Id: Ibd699a4edfa9f88da26d888afa8567ee34e78a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142572 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-11Drop a counterproductive top-level constStephan Bergmann
...that was apparently left by accident by caa10a1f80da856debf4f397503f27c86199208f "vcl: Use a hb_face_t wrapper in TrueTypeFace", thwarting the use of std::move here. (I came across this code with an upcoming loplugin:constmove that flags suspicious uses of std::move involving const-qualified types.) Change-Id: I460b11738b0f480a91c1212632cb428cb1331cd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142560 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-11Drop counterproductive const'ness of a member functionStephan Bergmann
...introduced in c8d2fa176a15a7ae76d6a4b76aea5f108313c2ec "reduce copying in drawinglayer", but thwarting the use of std::move on a data member. (I came across this code with an upcoming loplugin:constmove that flags suspicious uses of std::move involving const-qualified types.) Change-Id: I9b32d8762b4cc57875343664642494c7098ffb4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142563 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-11tdf#151980 sw content controls: fix RTL render of dropdownsMiklos Vajna
- check if this widget is meant to be RTL in SwSelPaintRects::HighlightContentControl() - route RTLness to the underlying tree view / drop-down in SwDropDownContentControlButton::InitDropdown() - fix up SwContentControlButton (positioning, rendering, hit testing) to assume the button on the left of the first text portion in the RTL case Change-Id: I637ee8f08311e1273f8b19ddf3ab572af839760b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142577 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-12 05:44:56 +0000