summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-06Missing XServiceInfoStephan Bergmann
Change-Id: I1ec148d239d6ea6ac72f820d5e5f41f1865f4b0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150069 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-05Add missing constructor attributesStephan Bergmann
...that were apparently forgotten by 155c056b1d4674d5ff73bbb5e1ad1dcd1e6aae36 "i18npool: create instances with uno constructors" and d2140a6320cd1cf4dea29b174cdb3bcb5261056b "i18npool: create instances with uno constructors", respectively Change-Id: I3caedf9d2a941a8671fab554a2358776d95c4938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150066 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-05Remove dead com.sun.star.i18n.Transliteration.ignoreKana service implementationStephan Bergmann
In 2002, fc680b643030fc2c99dcfffe75e762ee35e5f292 "#97583# Modify for new services" had added the two com.sun.star.i18n.Transliteration.IGNORE_KANA and com.sun.star.i18n.Transliteration.ignoreKana service implementations, both using the also added ignoreKana_CreateInstance factory function, to i18npool/source/registerservices/registerservices.cxx (back in a time when that still used active component registration via component_writeInfo). Then in 2010 a3c8a0ed0c5c6be1cb5c940750222f6381608bd7 "sb129: #i113189# change UNO components to use passive registration" (dropping the active component registration via component_writeInfo) faithfully listed both those service implementations in i18npool/util/i18npool.component. And in 2014 a4f17c00b16f5a983cd91ac5d2c43454f1775931 "i18npool: Constructor feature for few more implementations" switched the com.sun.star.i18n.Transliteration.IGNORE_KANA service implementation to use a constructor attribute in i18npool/util/i18npool.component. But it also removed from i18npool/source/registerservices/registerservices.cxx the ignoreKana_createInstance factory function and the > IMPL_TRANSLITERATION_ITEM (ignoreKana), aInstances element through which the other com.sun.star.i18n.Transliteration.ignoreKana service implementation was created via i18npool_component_getFactory. (It presumably either intended to also change com.sun.star.i18n.Transliteration.ignoreKana to use a constructor, but forgot to implement that, or accidentally broke that service implementation.) So the com.sun.star.i18n.Transliteration.ignoreKana service implementation has not been instantiatable ever since 2014. But it appears that nobody missed it much, so maybe it had already been a mistake to add it (alongside the com.sun.star.i18n.Transliteration.IGNORE_KANA service implementation) in 2002. So just remove it completely for good now. Change-Id: Ieda888038a70f4123a0c5f9f4e3306491f32ed64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150068 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-05Resolves: tdf#154308 if start center frame exists, use it as dialog parentCaolán McNamara
At least for the case the document is launched from the StartCenter, put that StartCenter as the parent for any dialogs that may appear during typedetection, this avoids such dialogs not getting associated with the start center and going behind the dialog if the start center is clicked while the dialog was appearing. The start center is always recycled to become the next document if it exists, so its window is the window the final document would appear in if successful. Change-Id: I75a92ff424aa0b9d5d6b808e2f7f1766a80fa50c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-05tdf#154549: vcl_pdfexport: Add unittestXisco Fauli
Change-Id: Ia2865346e966cdd4b64ed588a29cc1e760d36c73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149969 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-05Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 470abc85b20e113506966df8883e287d25079517 - tdf#154608 Add example of regex with \N{} to Help Change-Id: I7b6c847cc3fbcbb62d9590eea4050630933e85f5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150062 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-05Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to e4f2e673eae5e1c3ffcc54d2253a35145aba7774 - Refactor file (no content change) Remove xml-lang Change-Id: I88f54ed44b795f7a5731748eccbafbe5f926ff27 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150061 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-05tdf#146312 - Chapter numbering dialog: adapt extended tooltip for [None]Andreas Heinisch
Change-Id: I71cddd45a336d6e201e23fdf1c93928ec2928a0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149987 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-05fix leaks when using tools::JsonWriterNoel Grandin
Specifically in sd/source/core/annotations/Annotation.cxx We seem to end up fixing leaks here often. The current tools::JsonWriter API is just very hard to use correctly. So rather return an OString, which is cheap to copy, and push that down into the LOK code. AFAIK that seems to end up requiring less code and less adhoc copying of data (specifically the queueing code in init.cxx was creating copies when converting to std::string). Ideally, we could have some special API to avoid the new strdup() calls in init.cxx, but not sure how to prevent other people from accidentally using that. Change-Id: Ia33437c1bfd9cc2d54dfb99914d1b72db20335f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149963 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-05sw: fix crashtesting assert on tdf90408-1.docMichael Stahl
frmpaint.cxx:801: SwTextFrame::PaintSwFrame: Assertion `... || oTaggedParagraph || ...' failed. The problem is that here the SwNumberingPortion is outside of the table cell and even outside of the page due to negative indent, hence CalcPaintOfst() skips it. Have to add another special case to open the LBody/P tags in this case. Let's not produce Lbl tag in this case since it's not visible. (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd) Change-Id: Ic048849c9f426ebfa59e05acece1ec995fd28247 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150056 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-05sw: fix the other stale SwNumberPortion follow flagMichael Stahl
This happens since commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd on abi13630-1.abw. itrpaint.cxx:419: void SwTextPainter::DrawTextLine: Assertion `roTaggedLabel' failed. The problem is very similar to the situation fixed with commit 6c0105307efa15837e9e5287103995312f373b67; then it was the pField which ended up empty and deleted, while now it is "this" which ends up empty and deleted; in either case the DrawTextLine checks of the follow flags fail because some follow flag is erroneously set. This requires a further tweak because the length of the portion is set to 1, so Compress() returns the wrong result there but immediately after SwFieldPortion::Format() returns SwNumberPortion::Format() sets the length to 0 anyway, so simply set m_nFieldLen to 0 in ctor which is correct anyway as there's no dummy char for these. Change-Id: Ie99f67ee19a1f6019afe68764ec746cdc862984e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150055 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-05tdf#153847 add tooltip for Insert Index EntrySeth Chaiklin
According to officecfg/registry/schema/org/openoffice/Office/UI/Commands.xcs, TooltipLabel is supposed to default to Label if PopupLabel is empty, but in practice it seems TooltipLabel also defaults to ContextLabel when TooltipLabel is empty, so this patch adds back the original TooltipLabel, which is different from the ContextLabel, and is needed primarily for some toolbars. Change-Id: I538bb4d75ce9a5141c292408c3f670d4524f2069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149986 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-04-05jsdialog: dump menu for menubuttonSzymon Kłos
Change-Id: I449ae3f8cf294e2ab81a5b47862278e325f2cb1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148937 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150041 Tested-by: Jenkins
2023-04-05vcl,sw,sd: PDF/UA export: produce better /CT for SdrMediaObjMichael Stahl
7.18.6.2 Media clip data In the media clip data dictionary, the optional CT and Alt keys (ISO 32000-1:2008, 13.2.4.2, Table 274) are required. Presumably writing a potentially wrong hard-coded mime type here isn't intended. Change-Id: Ifa8ee199a4cf9ce83f410860d59b6c30475f80e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150050 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-05avmedia,*: guess the mime type of media files based on file nameMichael Stahl
.. at least for the most popular types, and do it automatically in MediaItem::setURL(). This should work in practice in most cases and is much simpler than adding some type detection or calling into platform dependent avmedia backends. Remove the parameter that was only ever set to "application/vnd.sun.star.media" anyway, the same value that would be used if it's missing. Stop using that silly type for everything, only use it when guessing fails. In case an ODF document is loaded, it will use the mime type loaded from the file (see setting of MediaMimeType in SdXMLPluginShapeContext) and not guess it because that would require updating the entry in manifest.xml as well. Change-Id: I8ce29cf7425678ae11dda1d8c875be818f8623af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150049 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-05Adapt expected test output to recent ClangStephan Bergmann
...after 90c590812eecb3a0eb2748a132e304fa6c0ea0ad "Simplify O(U)String::number implementation" Change-Id: I3f5d7b1ff41a6d55293f15f15fd67bd5d2e69d69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150045 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-05Notify LOK that application background color has been changedParis Oplopoios
Notify LOK when the application background color changes in Writer Change-Id: Ibc900cc8b3253aaa5b53602a007566896f04d9df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149906 Tested-by: Paris Oplopoios <parisoplop@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> (cherry picked from commit 0dca587be41718d2d88e80fc585829ad83da59ea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149892 Tested-by: Jenkins
2023-04-05tdf#148906: Ukrainian letters miss in bullets and numbering dialogJulien Nabet
Change-Id: Ieef2b2a7052da342709baf298b618d2c29fa3e43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149768 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-05Fix typoAndrea Gelmini
Change-Id: I1cf23442667a8ac6e9f8da2ea72bf60f5126236e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150047 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-05tdf#145614 Convert #define to enum in propctrlr/fontitemids.hxxJani Saranpää
- Removed fontitemids.hxx and moved new enum definition inside cxx file to optimize compiling. - Removed non-existing fontitemids.hxx from clang format excludelist. Change-Id: I67e782821d65241264de0926e445a58dc7307ba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149736 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-05Simplify O(U)String::number implementationMike Kaganski
Change-Id: I059f0324597a90aee01c95170a48ac5578f3caee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150037 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-05tdf#132112 excessive stretch of braces can trigger freetype into an errorCaolán McNamara
which propogates to cairo and once a cairo surface is in an error state, that cannot be cleared and all subsequent drawing fails, so bodge that with a high degree of stretch we draw the brace without stretch to a temp surface and stretch that to give a far poorer visual result, but one that can at least be rendered. Change-Id: I6b8bb079e82c3cf03a908de750c5c445ad230750 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150031 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-05split out a makeCacheIdCaolán McNamara
Change-Id: I89fbaca1fa7303904681f75ee4a7fc90aeb9ef8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150030 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-05jsdialog: enable table related dialogsSzymon Kłos
Change-Id: Ibcbd175e9b7c04f30acd4c5d23998b00889e7b0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149714 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150040
2023-04-05jsdialog: enable pick color dialogSzymon Kłos
Change-Id: I45c086ce652487017817fcdb2a3c5329a8f2a30f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149689 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150039
2023-04-04Make O(U)String::boolean also return an O(U)StringNumberMike Kaganski
Change-Id: I184fa0e4e45662e0fac86076d1c8733a0465bb56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149978 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-04split out the pieces that apply the font to the cairo contextCaolán McNamara
Change-Id: I0577832f57b15621d150da4cb50e134c9c06bae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150029 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-04tdf#153847 update labels to disambiguate insert/edit index entrySeth Chaiklin
primary purpose is to differentiate the two .uno commands so that they do not have the same label in the Customize dialog. ContextLabel is needed for use in submenus. PopupLabel needed for Edit..., but not for Insert. Change-Id: I4dc452805ff47669218158711b874b04330d02ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149881 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-04remove cairo_set_matrix calls that do nothing anymoreCaolán McNamara
in the past there was intermediate calls that these affected Change-Id: I5bb15046ff5869522dfafe72e16f9be4707c1f7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-04cairo_font_extents is unusedCaolán McNamara
since: commit 6c9948d80aaa1d4827ccf741d900093abe7a973e Date: Mon May 3 06:51:50 2021 +0800 vcl: adjust cairo text renderer for vertical writing Change-Id: I853b5f3b8c8979468d6c72617b7991f4c7d509d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150026 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-04Fix typoAndrea Gelmini
Change-Id: I4ff8556c954cae844fa35385535cf9b6e9477e08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150033 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-04Fix typoAndrea Gelmini
Change-Id: I09163a500caf66c6ac2921dca3128997574d20d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150032 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-04tdf#154565 ignore unwanted crossing event from search to treeview on "enter"Caolán McNamara
i.e if the crossing was triggered ultimately by a key stroke which is likely from exiting the search box. This way we can avoid the problem that with hover-selection that after "enter" is used in the search box, selecting a matching row, then during teardown of the widget the box is hidden, and the generated crossing notification triggers unwanted selection of a different row under the mouse. If needs be this could be refined further to only happen for a specific key or other details of the triggering event Change-Id: I7e64fb5fa31a446b85016d86ecd314d13130d7b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150016 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-04Convert SvtLineListBox to WeldToolbarPopupSzymon Kłos
Change-Id: I1849e40508a8754ec567da5913d3454571da5bee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149063 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150015 Tested-by: Jenkins
2023-04-04jsdialog: enable and make async chart line prop dialogSzymon Kłos
Change-Id: I21817b21fe6d2ce0a6f6bd784c0e24fe35b17fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149502 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150014 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2023-04-04tdf#153880 sc: Make Calc text hyperlinks stand out moreBalazs Varga
Add underlining for links in Calc. TODO: unit test Change-Id: Idd5a7de7464d8ce443cdec756ac803491e73b0ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149913 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-04-04MCGR: Improve performance for texture-mapped MCGR processingArmin Le Grand (allotropia)
Change-Id: I20b32e7c272112c6c3d9f7ee0ef59c6d4d006d94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150020 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-04-04tdf#151206 - Sc Auto Filter: filter items after search edit timeoutAndreas Heinisch
In addition, UI tests have been adapted to address the timeout of the search process. Change-Id: Id9d78896e45da43734346654762c3541b8c07ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149958 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-04Fix typos in XML that broke three implementation elementsStephan Bergmann
The typos all originated with d2140a6320cd1cf4dea29b174cdb3bcb5261056b "i18npool: create instances with uno constructors", causing three intended constructor attributes to rather be plain character data. Which apparently went unnoticed until recently (see the TODOs resolved here that had been introduced with 456a146b9eb643655ae2bd336740e8c5536913aa "tdf#151971: Fix used implementation names of transliteration services"), in part because the Parser class in cppuhelper/source/servicemanager.cxx silently ignores any unexpected character data via xmlreader::XmlReader::Text::NONE.) Change-Id: Ia8fdbc09c67d10530b4d86dbbbde2b6b84038e66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150021 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-04tdf#151338 Rearrange table popup menu in Draw/ImpressRafael Lima
I also added the SplitCell command to the Draw popup menu, since there's no reason for it not to be there. Change-Id: Iec0d51559bf03c0f352aa631bedb794f18e02e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149700 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-04tdf#154476 Fix accelerators in Print previewRafael Lima
As reported in the bug ticket, the +/- accelerators are inverted. Change-Id: Iafd648968ce8c3c2f461f31b65b1bd4bf85f1dab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149701 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-04tdf#154451 UITest_impress_tests{,2}: enable oneprocess modeMiklos Vajna
Execution time changes: - from 2m10,846s to 1m34,525s - from 1m37,723s to 1m7,339s for me. Change-Id: Id1bf511ec01694497b9fbc6b95aa7c4ac9bb4a44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150019 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-04tdf#152234 vcl,drawinglayer: PDF/UA export: produce Role for form controlsMichael Stahl
veraPDF complains: Specification: ISO 14289-1:2014, Clause: 7.18.4, Test number: 2 If the Form element omits a Role attribute (Table 348), it shall have only one child: an object reference (14.7.4.3) identifying the widget annotation per ISO 32000-1:2008, 14.8.4.5, Table 340. LO forms produce both page content in an MCID and an /Annot, so Role is needed. Change-Id: Ic231931a7c35d8da37ca76e02d97501edb43347c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149626 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-04Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 562c29b9451c68b607d980b6011726bbf9de0247 - tdf#153248 numbering is changed globally Add a sentence to note that changes to "Numbering" are applied retroactively to any existing captions. remove <xml-lang> Change-Id: I5279296cf27018d7f0f5a08a62e97689e6021339 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149879 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-04tdf#151971: Fix used implementation names of transliteration servicesStephan Bergmann
...after 04af4e4f55f3ef319a78edd4d0109e2e7eba90b6 "[API CHANGE] Fix all bad UNOIDL identifiers across offapi" had changed the spelling (character case) of some of the css.i18n.TransliterationModules[New] enum values involved here, so that the TmItem1 macro generated broken TMList::implName values now. (Which in turn caused TransliterationImpl::loadBody to throw "unsatisfied query for interface of type com.sun.star.i18n.XExtendedTransliteration!" css::uno::RuntimeExceptions, which remained uncaught.) Also add a test verifying that loading all those transliteration services no longer fails throwing exceptions. Which lead to two open TODOs: For one, the value of maxCascade in i18npool/inc/transliterationImpl.hxx might come from a time when there were fewer TransliterationModules[New] enum values and might no longer be appropriate. This would need some further investigation. But for another, there are two transliteration services that cannot currently be instantiated. That looks like a regression that should be fixed in a follow-up commit. Change-Id: Icfca3e841360d4b471013e2c96d6868a75a21a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150018 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-04vcl: PDF export: fix erroneous MCID produced for 1st pageMichael Stahl
PDFWriterImpl::beginStructureElementMCSeq() emits a spurious MCID definition outside of any stream, before the 1st page: /Document<</MCID 1>>BDC % PDFPage::emit 1 0 obj <</Type/Page/Parent... This is because SwPageFrame is translated to a Document StructElem in EnhancedPDFExportHelper, but PDFPage::emit is called at a later time than when the page content stream is produced, so this is just wrong; an MCID inside the page content stream is pointless because that's an object already anyway, so just suppress this. Looks like other applications don't produce Document currently. Change-Id: Ic2e30e4125c0e97c8e47330c7a247f74efc18f98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150017 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-04tdf#129726 make extended tips visible for 1st and 2nd keySeth Chaiklin
ce58da3240e508800bd3e6fd7d56fb5fbde3349d introduced extended tips, but the extended tips for "1st key" and "2nd key" should be the child of the GtkComboBoxText, and not GtkEntry. Change-Id: Iaaa23c76debaa87c37f2fa8308e81c31cfb657cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149888 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-04-04tdf#153242 "Separator" -> "Before caption"Seth Chaiklin
The "separator" option places an option text after the category name and number and before the caption text. This option is relabeled to "Before caption" to make its function more transparent and to reduce ambiguity with "separator" which is also used, with a different meaning, as part of Heading Numbering before Caption Number in the Caption Options. Also, add a tooltip for this option, and update extended tip to explain the option more precisely and fully. Change-Id: I3d1a53936ea68ac79c5f6a5ed41dd291826b0227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149878 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-04Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to e252239f3cd73b80f049fd1794338766fbd3fe6c - Change <embedvar> for <link> Change-Id: I233af09ea89c177c37ff4978107f626b749671a9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149975 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-04sw floattable: fix removal of last follow fly with a start/middle oneMiklos Vajna
The bugdoc has 3 pages: each page has 1 row of a floating table. Deleting the last row deleted the last fly frame, but the text in the body didn't move from page 3 to page 2. It seems what happened was that the condition in SwTextFrame::HasNonLastSplitFlyDrawObj() was wrong, it always filtered for the master anchor, not for the relevant anchor. Once that's fixed, the other problem was that by the time SwRootFrame::DeleteEmptyFlys_() would invalidate the anchor, the follow/precede relationship is already unlinked for the to-be-deleted fly, so we can't find the correct anchor of the to-be-deleted fly. Fix the second problem by invalidating the anchor earlier, in SwFlyAtContentFrame::DelEmpty(), where the to-be-deleted fly is still part of the flow frame chain. With this, deleting the last row in the document results in deleting the entire page 3 and moving up the body text, as expected. Change-Id: I3303408cafabcc61abfffe6c355ec3874fff30a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150008 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-11 06:49:01 +0000