summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-06-21cui: fix --without-java buildMiklos Vajna
This went wrong in commit 7795a2adc0a724220440dca997495043902f1384 (Allow bootstrap variables in Java user classpath settings, 2nd try, 2023-06-12), I assume that _rPath is always empty in the without-java case. Change-Id: I8749f5bd30b0853a76fb9ccf5d1e7a8e4e23f1ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153386 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2023-06-21sd: send correct slide visibility statusPranam Lashkari
The term visible may be a bit aambiguous here, we try trying to send info about if the slide is hidden or visible in the slide show. The correct property for that is "exclude" Change-Id: Ic505036181b71686656bd2338b9d0329c12d9e74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152688 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> (cherry picked from commit fe79008f70e7a790e4f78c1714c27ea223512327) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152988 Tested-by: Jenkins
2023-06-21svl: Use DateTime::Sub() instead of operator-()Eike Rathke
Change-Id: I036798013404df4bcfb988d4f231fcf30cec3162 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153382 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-21openldap: upgrade to release 2.6.4Taichi Haradaguchi
Because NSS support has been removed in release 2.5, switch TLS/SSL module used by OpenLDAP to OpenSSL. Add -pthread flag to openldap_LDFLAGS when building on Linux. This avoids errors that occur in libcrypto.a (libcrypto-lib-threads_pthread.o). Change-Id: I4779ce40233d144d930f20e85db7b4ba08f91ea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143646 Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-06-21sc: Use DateTime::Sub() instead of operator-()Eike Rathke
Change-Id: Ib73eec1c11ced76890b8eacb0079ae336072a4c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153379 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-21Use DateTime::Sub() instead of operator-()Eike Rathke
Commit this central place use early. Change-Id: Ib2e40ae7fbe9dc219ba0a7ec4e0f12a82d7b37b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153378 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-21Fix script classification of USCRIPT_WARANG_CITIKhaled Hosny
When the original code was introduced in: commit d83e115bae521fcf193978496d62dbc677a1d6ef Author: Martin Hosken <martin_hosken@sil.org> Date: Fri Mar 4 19:57:29 2011 +0700 USCRIPT_CODE_LIMIT was set to 146 and that what the original code wanted to classify as ScriptType::WEAK. ICU changes USCRIPT_CODE_LIMIT as it adds new scripts, so it got re-assigned with newer ICU releases and USCRIPT_WARANG_CITI was unintentionally classified as ScriptType::WEAK. Change-Id: I5deb5f2050380968ea83b3af969ceae75b1c0070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153373 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-21sc: add CharComplexColor and CellBackgroundComplexColor propertiesTomaž Vajngerl
Change-Id: I30153796a39b2aa3648cb107905974ed6f0f3851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151668 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-21tdf#114432: classify Tangut and Khitan Small Script as ScriptType::ASIANKhaled Hosny
They are CJK scripts so should not get spacing applied between them and other CJK scripts for instance. Change-Id: Iab88ff1490733e514fd37436cff937dc5fc8dce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153372 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-21Use switch statement in unicode::getScriptClassFromUScriptCode()Khaled Hosny
Makes it easier to tell which is script is given which class, and to extend it with newer scripts. Change-Id: I736e078b94f4d324dd5ceabeac5a2d11c25da3a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153371 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-21Fix typoAndrea Gelmini
Change-Id: Id2a9f8eeb5032ef65c5457cd747915914bc32d64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153317 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-21tdf#155951 sw: fix crash using XTextRange::getString() in selectionChanged()László Németh
XTextRange::getString() triggered selection change event, resulting infinite recursion, when getString() used in selectionChanged() of the listener. Steps to reproduce (used by the unit test, too): Add a XSelectionChangeListener to the document with a selectionChanged() calling the getString() of the selected text range. Select a word in the document editor using the Ctrl-Shift-arrow keys. Change-Id: I87a0f60cee3663f5303d6eb6980058ccdcc373e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153356 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-21CppunitTest_sw_htmlexport: avoid reqif magic in testNoLangReqIfMiklos Vajna
Set the filter options explicitly, rather than inferring it from the test name. Change-Id: I49cf0e34354178054db2daa10902917cb5d45080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153361 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-21Introduce double DateTime::Sub() as a substitute for friend double operator-()Eike Rathke
Change-Id: Idb93b3e9b4dcbd09ad7f4253a523fe5be24d0776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153354 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-21sw: Fix spell checking having no view separation in tiled modeParis Oplopoios
Turning spell checking on or off for a single view would turn it on/off for every view which is correct behavior normally but not in tiled mode because different views might want different view options Change-Id: Ib422f692e97618cfba6a7cb8b2a4f2b3f20a0ca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153343 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-06-21tdf#122270 sd: refresh notebookbar after switch to/from master viewJustin Luth
Although the state of the uno items was changing, the notebookbar was not refreshing to display the new state. Change-Id: Ifda5e6dcfa1d569ba75d0c94cdf0bc94c63977d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153360 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-21Allow bootstrap variables in Java user classpath settings, 2nd trySamuel Mehrbrodt
Add a second mode: When a classpath starts with '$', bootstrap variables are recognized. The classpath must then be provided as URL, not native path. Change-Id: Idcc229a2b4e9a512b0e712ea932a6e4293907db3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152899 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-06-21poppler: upgrade to release 23.06.0Taichi Haradaguchi
Add external/poppler/disable-nss-and-gpgmepp.patch.1 to get rid of some code that requires NSS or GPGMEPP. Update external/poppler/inc/pch/precompiled_poppler.hxx. Change-Id: I5e61371776c64962452022516446b5079c3840e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153097 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-06-20lok: vcl: fix "ImplConvertToAbsPos" functionHenry Castro
The conversion to absolute position is ignored for mirrored graphics, otherwise, the popup window will be closed after the mouse up event. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I2cb101b07f1aa79ab8aa605637b276ad3a56ce88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152681 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153328 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153368 Tested-by: Jenkins
2023-06-20lok: sc: reset RTL if it is changedHenry Castro
Reset the LOKSpecialFlags, otherwise the selection engine select wrong lines. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I94e33cc3e293330d9a3480bd3838a20c1d94d15f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151841 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153365 Tested-by: Jenkins
2023-06-20editeng: fix assertion uninitialized enumHenry Castro
constexpr typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = LOKSpecialFlags; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<LOKSpecialFlags, 119>::Wrap]: Assertion `o3tl::detail::isNonNegative( o3tl::to_underlying(lhs))' failed. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I8617c877ad2d705988f4dea0e54442e5002a43be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151533 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit cce4ad3dd4d678e1cc6bf7523f5375e10b100147) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153362 Tested-by: Jenkins
2023-06-20tdf#155814: only check parent style when it has a local css styleXisco Fauli
This also fixes the problem for filters and mask, since they are call from add_postProcess Adapt some tests to the new xml output. Visually nothing has changed Change-Id: I65d2491409019f4cd0b1113a9a7931fc602c57b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153355 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-20lok: sc: fix layout RTL mouse selectionHenry Castro
If the Calc is in layout RTL, the edit view mouse selection does not change. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I0bd2640dac3cdc96fa247c305c379b2d1a8564ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151974 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153357 Tested-by: Jenkins
2023-06-20lok: sc: fix layout RTLHenry Castro
The function "IsRightToLeft" fails in Hebrew language when Calc has a layout RTL, add additional condition to check the layout. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: If3972b80770a7aa6073881487e411a34cc6871d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150758 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153350 Tested-by: Jenkins
2023-06-20tdf#115321: Fix PDF position of emphasis mark in vertical textKhaled Hosny
This aligns the code in PDF writer with OutputDevice::ImplDrawEmphasisMarks(). Change-Id: I404beda30ff0eb1d6c59d971a7daa59b559ef70f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153326 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-20tdf#155863 sd: fix resizing of cropped images to original sizeTibor Nagy
Resizing with the function "Original Size" (e.g. in the context menu) resulted distortion in case of cropped images, if the original image and its cropping have different aspect ratios. Now zoom the cropped image to the original resolution instead of stretching it to the same size. Change-Id: I5e59f8b48dc03844a739c3eb803e3195a12d9c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153170 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-20tdf#155932: tdf#97717: only apply opacity when primitiveXisco Fauli
Partially revert d47b37eea9779e3c354e6c19a7211a306965b7ef "tdf#97717: do not call add_postProcess from g element" since we still need to call add_postProcess from g to apply the clip-path Change-Id: Ibdc5afadc0db239d0b0e14810943009a4c0a16a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153353 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-20svgio: simplify test file a bitXisco Fauli
Change-Id: I2ecbe089b74b9c9f155a44f8706b6832f778c3f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153320 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-20Remove German capitalization from some translatable stringsAdolfo Jayme Barrientos
Change-Id: I74f886c651ea7973cc60e3771f2de6eaa449fe4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153231 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-06-20Use tools::Duration in friend double operator-() if DateTime has Time setEike Rathke
Change-Id: Iff3e2aad596fdfd1530c46cdeff28b44e5142517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153327 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-20tdf#126095 impress notebookbar: don't force Master/Presentation toolbarsJustin Luth
When in the notebookbar mode, non-notebookbar toolbars should not be enabled automatically by the application. The user still has the ability to turn them on. Change-Id: Ib601b63390a8d806604b68ed2ea198198f4318ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153303 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-20tdf#43369 Refactor PosgresSQL connection setupOlivier Hallot
+ Moved static strings to ui file, handled by Glade + added extended tips to widgets + deleted references to strings in the controller. Change-Id: I0acb444eff37adbfc0225656669af9d5650b7bd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153127 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-06-20lok: sc: restore edit output areaHenry Castro
The edit view output area is modified after the draw, restore it so the mouse can handle selection at layout RTL. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I94dd9db385a3a9c60f015027894338504b4ce533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151146 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151972 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153325 Tested-by: Jenkins
2023-06-20tdf#122676 sc: fix format with * (filling) and NBSP thousand separatorCzeber László Ádám
Numbers containing no-break space (NBSP) thousand separator enabled the EditEngine layout, losing filling e.g. for stretching spaces. Enable EditEngine for NBSP characters only if there is no filling in the number format code, fixing MSO interoperability, too. In number format codes, asterisk (*) followed by a character is used to fill the available space in the column with that character, e.g. format code [>0]" "* # ##0" € ";[<0]-* # ##0" € ";" "* -#" € ";" "@" " put the minus sign at the left side of the column, while the number at the right side of the column. Because of the NBSP thousand separator, bigger numbers got different layout previously, i.e. minus signs right next to the numbers. Note: there is a better solution for the layout problem: using narrow no-break space (U-202F), which is the proposed thousand separator in typography, and it's back-compatible, because it doesn't enable the different layout. Change-Id: Ia35f01733687ee6005f06ff3ab999b7a4b712ad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152901 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-06-20lok: editeng: add LOK special flagsHenry Castro
The function "IsRightToLeft" fails in Hebrew language when Calc has a layout RTL, create a special flag to handle. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I661f49dc5990f39807c6dba10970dea8c502643c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151971 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153322 Tested-by: Jenkins
2023-06-20tdf#107718: Fix script itemization of vertical textKhaled Hosny
Mixed script vertical text was not correctly splitting runs at script changes, resulting in Hangul text being mixed with Han text in the same run breaking the Hangul composition. Change-Id: I09c3f799bede6aa8a19684779d500504a9813af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153313 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-20tdf#155920: next effect in END mode should no resume showDaniel Lohmann
When starting a presentation and moving over the last slide into the END mode the next effect should not resume the presentation. Instead it should exit the presentation. Furthermore, when hitting then the back key it should show again the last slide (only resuming the presentation, not directly resuming and moving back to the slide before the last. Change-Id: I816232725d923601356e0bc8e39421f256d184eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-20sd: fix setting theme for notes masterTomaž Vajngerl
Notes master also needs a theme set or the document will not load properly. For now we don't save the theme for the notes master on import, so we can only set the default "LibreOffice" theme instead. Change-Id: Ia9e5db53d4e1a4ca06b10d147cc879475166dfd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153314 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-20tdf#145651 Chart OOXML export: fix write error in exportSolidFillTünde Tóth
Don't export the background color, if the FillColor property is empty. Steps to reproduce: 1. E.g. in Impress, insert a chart (Insert > Chart...). 2. In chart editing mode, select the legend, use the "sidebar > Area > Fill" and change from "none" to "color". Notice how the default blue that is used does not correspond to the colour in the colour picker right underneath. 3. Save as > OOXML format. Change-Id: I33a060d8fc6c49708029008393e2e22e3d5335b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152951 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-20XMLTextParagraphExport::DocumentListNodes must be a complete typeStephan Bergmann
...at least when building with --with-latest-c++ against recent LLVM 17 trunk libc++, > In file included from xmloff/source/text/txtparae.cxx:22: > In file included from include/o3tl/any.hxx:21: > In file included from include/com/sun/star/uno/Any.hxx:28: > In file included from ~/llvm/inst/bin/../include/c++/v1/algorithm:1779: > In file included from ~/llvm/inst/bin/../include/c++/v1/__algorithm/inplace_merge.h:27: > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/uninitialized_buffer.h:14: > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:63:19: error: invalid application of 'sizeof' to an incomplete type 'XMLTextParagraphExport::DocumentListNodes' > 63 | static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type"); > | ^~~~~~~~~~~ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:297:7: note: in instantiation of member function 'std::default_delete<XMLTextParagraphExport::DocumentListNodes>::operator()' requested here > 297 | __ptr_.second()(__tmp); > | ^ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:263:75: note: in instantiation of member function 'std::unique_ptr<XMLTextParagraphExport::DocumentListNodes>::reset' requested here > 263 | _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); } > | ^ > xmloff/source/text/txtparae.cxx:1333:25: note: in instantiation of member function 'std::unique_ptr<XMLTextParagraphExport::DocumentListNodes>::~unique_ptr' requested here > 1333 | XMLTextParagraphExport::XMLTextParagraphExport( > | ^ > include/xmloff/txtparae.hxx:115:12: note: forward declaration of 'XMLTextParagraphExport::DocumentListNodes' > 115 | struct DocumentListNodes; > | ^ Change-Id: I319c1f682258950caf3571f51e5443d6753bcccd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153312 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-06-20Resolves: tdf#155750 allow private:factory urls in floating framesCaolán McNamara
they create a new document so there isn't an associated location which would trigger the prompt to allow it so just allow factory urls Change-Id: I7b693bcfe5ac04aaed06905637ab3c1eba43c51f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153316 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-20tdf#155827 MCGR: Axial to linear in oox export, apply...Regina Henschel
... separately for color and transparency gradient. The current solution had the change from axial to linear applied to color and transparency gradient at the same time. That resulted in wrong gradient if only one of them was axial. Because changing axial to linear changes the number of stops, it has to be applied before color and transparency gradients are synchronized. As now color and transparency are both linear already after they are synchronized, the switch can be replaced with a simple if. Change-Id: I75e6b495782bc8a9fe94504426efadec2f60b61f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153197 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-06-20loplugin:cstylecastStephan Bergmann
Change-Id: I32e3e9bff261f95010582c6e5e2d22abb725f402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153311 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-06-20sw floattable: fix negative vertical offset handling on page boundaryMiklos Vajna
The bugdoc has 3 floating tables, the last one was on page 1 in Word, but it was on page 2 in Writer. It seems what happens is that the vertical offset of the last table is negative, so it is moved above the paragraph before the last floating table, but once the anchor frame (last paragraph) is moved to a new page (because it doesn't fit), then its fly frame is also moved to page 2, which leads to overlapping text in the original bugdoc. Interesting this works already with 0 vertical offset, and in that case we split the last paragraph, fill the page 1 part with a fly portion and fill the page 2 part with the anchor text. Fix the problem by: - triggering a split of the frame in SwTextFrameBreak::IsBreakNow(): if the anchor frame doesn't fit (has to be moved to a next page), then split it, so only the anchor text is moved, the fly is not (so its position matches Word) - preventing the manipulation of the frame offset in SwTextFrame::AdjustFollow_(), so no content is moved from the follow to the parent, because that would mean later we move the joined frame to the next page - finally minimizing the frame height at the end of SwTextFrame::Format(), so the master still fits the current page An alternative approach would be to extend SwAnchoredObject::FindAnchorCharFrame(), which already has code to handle the case when the text frame master and the anchored object is not on the same page, but that operates on existing anchor frames, and here the original problem is that the entire anchor frame is moved to page 2, so we don't have anything left on page 1. Note that this is all specific to floating tables, I could not reproduce the same behavior with an anchored shape in Word. Change-Id: I007b57b369f5c1e98ccad77111958dfd9335f079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153309 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-06-20sw: document SwFormatLineNumberMiklos Vajna
The primary use-case here is to have this in certain paragraph styles, so that they can request "don't count these lines", like Caption or Header. Change-Id: I2af591d2713cc23f4b634b69797f0dd61a37a2de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153298 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-20Fix typo in .git-hooks/pre-commitTaichi Haradaguchi
...to avoid a error "Cannot run git diff-index. at .git/hooks/pre-commit line 51." that occures on Windows. Change-Id: I868e87940f9fcef950970b59e8cbe747f80c7198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152830 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-06-20tdf#122970 Fix direct cursor leaving screen trailHossein
Previously, an old method using RasterOp::Xor rendering (see tdf#38844) was used to draw the extra triangle left or right of the mouse pointer in direct cursor mode. Now, instead of drawing it manually, we change the cursor type to somewhat similar pointer type. There is no perfect match for the previous mouse pointer shape, so now instead of left triangle, PointerStyle::AutoScrollW is used. Also instead of right triangle, PointerStyle::AutoScrollE is used. Change-Id: Iadb955f9fcee0978a190e0b8920186a2579f3a4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153099 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-06-20lok: sfx2: fix change state "SheetRightToLeft"Henry Castro
The UNO command "SheetRightToLeft" can be disabled Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I54742c9d52eb52e36154e0aac2cdf440771eb177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152502 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit fc8270f06eca5ba2ba25673a424b36d9e352f62a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152546 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153267 Tested-by: Jenkins
2023-06-19sc: filter: oox: fix setting value to color scaleHenry Castro
The COLORSCALE_VALUE setValue method reset the mpCell that contains formula. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Idbbfcdc5bce78542ce671753d9a70dcd375e7966 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153281 Tested-by: Jenkins
2023-06-19tdf#145896: set style to 'text/css' by defaultXisco Fauli
This is a regression from 4c31a0be1d8048bf3340acbb59248185e4b93041 "Resolves: #i125326# accept CssStyles with missing type attribute" Calling setTextCss(true) when there are no attributes is wrong, since it might have attributes like 'id'. The unittest added also covers i125326 is still fixed Change-Id: Ic5e4899211ae98c866f64f17e69a3a8cd24e4959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153290 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-29 11:26:14 +0000