summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-11-17Work around loplguins:badstaticsStephan Bergmann
Change-Id: I243dcb86cc1a99550b26962daf47c19eb62aa8df
2015-11-17Use std::vector instead of boost::shared_arrayStephan Bergmann
Change-Id: If28713daab4bb5cbdb450879c2dc2a265c62a4f3
2015-11-17Improve commentStephan Bergmann
Change-Id: I25931d59fc1b4feb1fd1eaa036a64a28a269f409
2015-11-17Work around loplugin:badstaticsStephan Bergmann
...about static ImplImageTree instance; in ImplImageTree::get (vcl/source/gdi/impimagetree.cxx) due to StyleIconSet ImplImageTree::maIconSet; (of type std::unordered_map<OUString, IconSet, OUStringHash>) due to IconCache ImplImageTree::IconSet::maIconCache; (of type std::unordered_map<OUString, std::pair<bool, BitmapEx>, OUStringHash>), reported at least when building against Mac libc++. This is a false positive, as ImplImageTree::shutDown cleans this up. Change-Id: Idb1a99aa33f71286e57b31b7adb833e3ee8b5f5a
2015-11-17An SwMailMergeConfigItem_Impl instance per SwMailMergeConfigItem looks sanerStephan Bergmann
...than fixing the avalanche of loplugin:staticmethods issues caused by b5eaa0f9f00cd62f4769c3e8860d788844ccf557 "use unique_ptr for pImpl in sw/," given that SwMailMergeConfigItem_Impl has mutable state? Change-Id: I342511d0f39086f33e2a8abd2c377341455d54a7
2015-11-17android: don't crash on empty filelistCaolán McNamara
Change-Id: I46caceed3fdf0ad0aa51c8a8ede1177ca3d1855e
2015-11-17tdf#34882 Adding hex and decimal code searchSteve Hart
Change-Id: I809bac4b28e679c7dad8ed3ad28e36379bce4760
2015-11-17vcl: These can be static assertionsTakeshi Abe
Change-Id: I220ae4732f221c7798f162653cad01717afb659f Reviewed-on: https://gerrit.libreoffice.org/20011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-17Improve loplugin:badstatics diagnostic outputStephan Bergmann
Change-Id: Ia2f088a79b03ff866429e1cae73edccd36a01b4f
2015-11-17Resolves: tdf#89907 do not modify original ScViewData's ScMarkDataEike Rathke
Change-Id: I2ae5a06f9ffe29de0b1cc5875615010da75f4ae9
2015-11-17Use a DiagnosticsEngine::NoteStephan Bergmann
...a Remark prints the whole stack of includes leading up to the source Change-Id: I41e5bd2855b4a55b54e63432703f2e65b4c44249
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I3266bb049be3a9b558b68b40d741efdcab2eb759
2015-11-17Simplify down to a single appendSQLWCHARs functionStephan Bergmann
Change-Id: I882746f9c4a1c332c6657b93f104ecbf1c7be6f1
2015-11-17loplugin:nullptrStephan Bergmann
Change-Id: Iaf31a731c9151972ba2fe2ed50074ea59c147550
2015-11-17loplugin:unnecessaryvirtualNoel Grandin
update the plugin with lessons learned from the mergeclasses plugin and re-run it Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711 Reviewed-on: https://gerrit.libreoffice.org/20015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17other #includes should be AFTER the include-once #defineNoel Grandin
found with the following script: git ls-files *.hxx | xargs perl -0777 -ne 'if (/include.* .* .* "; close ARGV }' Change-Id: I3afb0e81eb315c34bc0eb6bb4733dd1f0537d5c0
2015-11-17Bin unneeded forward declarationsTor Lillqvist
And move some to the include file where needed. Change-Id: Ibbe2b7d531f41c1d58faf17f4795b4ce30355675
2015-11-17sw lok comments: fix text selection with custom zoomMiklos Vajna
SwPostItMgr::GetSidebarWidth() can be called in two scenarios: - inside PaintTile() the output device contains the zoom level and has the map mode enabled (and its scale factor is the zoom level) - outisde PaintTile() the output device is SwEditWin and has the map mode disabled (and the zoom level is to be taken from the view options) Change-Id: I6cf19f3241a2e972ae711e0efa7b0205aae1a3f2
2015-11-17use unique_ptr for pImpl in sw/Noel Grandin
Change-Id: I8508894d70e1ff16cfb9d7a9d716f11a923f453d
2015-11-17use unique_ptr for pImpl in tools/Noel Grandin
Change-Id: I7ac7eca32a67524f6c87696c16b16128e6d8518b
2015-11-17tdf#95845 Add methods for menu labels to CommandInfoProviderSamuel Mehrbrodt
Change-Id: Ibf6a26940ec194f540255584776f8ebcefbb94ae
2015-11-17WaE: loplugin:stringconstantTor Lillqvist
Change-Id: I8765ae89bcab8dc3c7360dace57a57094e5c5cc4
2015-11-17tdf#94272: Reduce copy'n'pasta code in sd unit testsKatarina Behrens
Change-Id: Id1a1180e00a1c1ce7020df52f246b0c135ba03f2 Reviewed-on: https://gerrit.libreoffice.org/19912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-17-Werror=maybe-uninitializedStephan Bergmann
Change-Id: I2c5626c0fd0244da46157ba286b4c08e4f73944f
2015-11-17tdf#95845 Use CommandInfoProvider to receive command propertiesSamuel Mehrbrodt
Change-Id: I41f9a661b7a5b355e50910d7f58f0d9d55dc62a6
2015-11-17Remove unused methodsSamuel Mehrbrodt
Change-Id: Ia78da9dac5fb426fbb145250c4e39eb7d30c4d03
2015-11-17vcl: fix the kde4 buildMichael Stahl
... after eca4c54e52363f80db26e228e586aeb7732c7100 - not sure if it's correct but at least it builds for me. Change-Id: I36083fac98c830560cdc799923d309f96e8cdd6d
2015-11-17Add icons for future display mode selectorPhilippe Jung
Change-Id: Iddc3a3dec55a4c1c2fb9fcb4cf6e9449b4f1d11e Reviewed-on: https://gerrit.libreoffice.org/16934 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-11-17Assume that this code wants to append a number, not a characterStephan Bergmann
The original code in 2638faa2e834c2da4c195224fd88d32c29b3d0cc "writerfilter08ooo330: applied patch for writerfilter08" used OUString::valueOf, which 64b993e046f23baaacaff1572b7d2a816588b5ef "finish deprecation of O(U)String::valueOf()" changed to a OUString ctor instead of OUString::number (as that change did for almost all other cases), but without giving a rationale for this particular case. But as nUnique starts out as zero, so in the first round would append a NUL character to "DOCX-Standard", it looks plausible that this code should add a number after all. Change-Id: I47136486e28b946fa334a416d1d2fe20ad616ff0
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I7a741130689721c69fd2879be6bda27fc6ec3646
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: Idcfa500c491fcedfff7d4c6e1bef25fd2d948d36
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I3411c688361e95b4c72b5257cdd63b137dab0538
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I5779c639c480d5a2fbefd47942a662ff7ca4a9f5
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: If61f46cceff4e2d4fe49e77788516ef60ab6eb50
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: Id3f43ba115d519e789b7eaf014734d2fd31d39cc
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: Id3bdce8776ebbdf700eabceed1e123a444a7bc4d
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I508520556cd5755d81740b00c7815eebdef6576e
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I6125c2abe1dbfd0a5ecf020b8363fc277d195157
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I27da462b553ef11e9d9ce7873e8fedc3af8c6041
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: Ia31a6817aa39da1edf76443fd7621375ea9dc191
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: Ia93c541ea21be89578789d58f642109184a18685
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I0439e40b0843ba9a0939eb47e339f396d26f3c64
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I870f7c5c68ee9c9668e82833ea6277adfd49a686
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I083a33e71d1bb9fcef3b287e1db15910779312ab
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I727951614587654c11af5f6635a45c52ebec1b5a
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I72b0f9956e866afd22f7335a57d7dca0297e3b8a
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I82bb9471479523d68641fd815da1208f0d45b8a8
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I1bf672c3d3c47b82906a0c755a6dd8e55dc48f88
2015-11-17Add SvStream::ReadUtf16 (don't assume sal_Unicode is unsigned short)Stephan Bergmann
Change-Id: I74f34e3389582617fa83f8f4a3d6867cf87189e1
2015-11-17make CPPUNITTRACE=TRUE a shortcut for debuging on WNTBjoern Michaelsen
Change-Id: Ie834e1e1592163977435f0af6dde04c4fe86c1bf Reviewed-on: https://gerrit.libreoffice.org/19977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>