summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-05-28Replace magic numbers in SwContentFrame::UpdateAttr_()Miklos Vajna
By using the same SwContentFrameInvFlags constants that SwContentFrame::SwClientNotify() already does. Change-Id: Ic22d53c886bb9d28d0250ed5e43d804417d516f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116271 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-28no need to allocate these on the heapNoel Grandin
and remove ByteEncoder because loplugin:unreffun complains about ByteEncoder::EncodeByte Change-Id: Iebc531fb7748cb9c6a83a8b4a574167a5aac58b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116257 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-28vcl: handle fallback glyph offset for vertical writing.Mark Hung
When GenericSalLayout::MoveGlyph() is called from MultiSalLayout::AdjustLayout(), new position is calculatd by adding glyph advances ( i.e. glyph items' m_nNewWidth ). To move the glyph, the moving offset should be calculated based on the corresponding position, i.e. m_nXOffset v.s. m_LinearPos.X(). Change-Id: I912d499f49f69f68d8388bc8677e6b47bfb6f066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115926 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-05-27flatten EventList data a littleNoel Grandin
no need to allocate the ListAction objects separately Change-Id: I02a591265c0da64d94a118b29bd0c4960d19a763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27no need to allocate PrintFont separatelyNoel Grandin
Change-Id: I8bc213e096ad6ae83d88c548ff8685a872c5ea91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116258 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27gtk4: reenable EntryTreeViewCaolán McNamara
Change-Id: If1b953f231199fe132783dafb0e26641b7b14d45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27gtk4: continue to provide Paintable via cairo surfaceCaolán McNamara
instead of squeezing through a GdkTexture and losing hidpi surfaces Change-Id: I1ee75ff804d1d769273e2f80335bfdf528ae8039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27no need to allocate these on the heapNoel Grandin
Change-Id: I6933260f589c67f463ee60572a31c52c6be7eb66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116262 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27TETextPortion can be allocated inside the vectorNoel Grandin
Change-Id: Ib54b94f5dcb2a9cf422ef30db99926f200b749c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27no need to allocate ListenerMap on the heapNoel Grandin
it is a movable type Change-Id: I2b5c8524115016b53ec5cb28312ff4d749e27368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27no need to allocate these on the heapNoel Grandin
Change-Id: I0740f7194c589d6949a816f365cd54403be72118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116260 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27IsDisposed->isDisposed in scNoel Grandin
Change-Id: Ie08509df7481a9128c865f19d2b45694b19d9f38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116179 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27IsDisposed->isDisposed in dbaccessNoel Grandin
Change-Id: I7a113dc01f76d53126b414cf132404ed8ef8db4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27installer-code: remove some unused or pointless subsChristian Lohmaier
of course just the very tip of the iceberg, but you gotta start somewhere… Change-Id: I24ef6a51ec70c70418368da54595637283055d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116255 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-05-27VisualStudio 16.10 doesn't like this constructionNoel Grandin
Change-Id: Idfef618b43735c48c9132d2fb932bc3bcb2ffe9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27sw XHTML / reqif export, RTF markup of images: write objdataMiklos Vajna
The native data is BMP, presentation data is not yet done. Change-Id: I30ef9f0c3b4dc7801e600ac751c32179372d5e4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116266 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-27gtk4: old GtkImage can be new GtkImage or GtkPictureCaolán McNamara
change to GtkPicture under some circumstances. GtkImage will force a square image so try and use GtkPicture for the non-icon case. The About dialog shows the need to use unscaled image if using GdkTexture. Change-Id: Iceb1e7dee5b53c93ceb432618fdda5650863029f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27configure: drop --disable-neonJan-Marek Glogowski
Use --with-webdav instead, which supports neon, serf or no and is available since commit dcae0509135c2067635ae3cf84b05dc9fb3d2d02 ("Build webdav based on serf if neon is disabled.") from 2014. Change-Id: I4b329b9c1d28e88961e86272a5554bfa4481f01e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116142 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-27tdf#135332 Return MAXROW/MAXCOL for rows/columns out of range.tushar
*Also change the number of rows to MAXROW in Row Header Control. Change-Id: Ie34361442a0944f62abbc9bb273a9efe72773c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115642 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-27gtk4: reenable menubuttonCaolán McNamara
not really expected to work yet Change-Id: I27fe5ecd8f78017dd669aeba0c1d8db797e91e3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116237 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27tdf#34724, tdf#91420: svl_qa_cppunit: Add unittestXisco Fauli
Change-Id: I81f784fb66b80ab0933047aa81d90aff1eec7971 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116246 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-27sw_uiwriter2: this is basically a export testXisco Fauli
Change-Id: I5b87f52ec4f905df1ae2e9175ac3807171614bdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116244 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-27tdf#60382 sw xmloff: import/export tracked table/row deletionLászló Németh
to OpenDocument format using <style:table-row-properties loext:text-changes-only="false"/> Rename also com::sun::star::text::TextTableRow::IsNotTracked to com::sun::star::text::TextTableRow::HasTextChangesOnly. Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf "tdf#60382 sw offapi: add change tracking of table/row deletion". Change-Id: Iefb0d4095af0983fdd15697d5b80073d18d21bd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116212 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-27tdf#94628: sw: allow setting for bullet style for outline paragraphsJustin Luth
Since LO 7.0 commit cad788328ec6ef4b3071cf9002dfac12347562da allowed bullets in the outline, I think you also want to be able to set the character style, wouldn't you? In any case, isOutlineNumbering is basically a meaningless and inaccurate concept anyway, so just get rid of that ancient clause. Change-Id: I2e40a3749b4a18864585c309349ea0e4ba73a9da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115613 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-05-27no need to allocate this on the heapNoel Grandin
Change-Id: Ief47dc18f858d4f90a537622c06f3df8e9f72fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27no need to allocate Style objects separatelyNoel Grandin
Change-Id: I88e4642a81b18c41216784332cc4a37a3bde9d95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27we can search std::set without allocating on the heapNoel Grandin
we just need to add some overloads to UniquePtrValueLess Change-Id: I91c395393a2de609c8f442de605d1dd2098dfae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27Fix typosAndrea Gelmini
Change-Id: I9a4ba6b6369da0bac489718230880b04912bd1d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116214 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-05-27add missing xmlns:loext to example_sl-SI.xmlCaolán McNamara
added to example.xml by commit 71ee09947d5a71105d64fd225bb3672dfa7ce834 Date: Tue Sep 19 15:37:04 2017 +0200 TSCP: add advanced classification dialog but not to example_sl-SI.xml Change-Id: I8aa46554867db8c51bd118b6cc87e649b922cdfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27gtk4: strip accelerator tagCaolán McNamara
unclear yet if there's another way to do it Change-Id: Ic3355d45bb3bb73c446b576b9cc65204cd39d180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27no need to make copies hereNoel Grandin
Change-Id: If3cd60bd48f640c353fd4c28449faed2cdcebdda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116243 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27tdf#117957 WMF Fix failing tests on arm64Bartosz Kosiorek
So the issue is caused by floating numbers, On x86_64 it is: 338.499728160392-445.269903703769 on arm it is: 338.499728160392-445.26990370377 As in test files, we have two ellipses (which are made from small lines), which points rounds differently on different architectures Change-Id: I10efe80fea0944cf957e949c8c209c94fd588702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116234 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-05-27tdf#141309 tdf#142215 OOXML import: fix double conversion in autofilterBalazs Varga
resulting missing selection of filtered time values and numbers ending with zeroes. No need to convert the filter values from string to number and back at OOXML import, because we'll do that later in the model by filtering with the formatted cell values. Follow-up to commit d5c2584bf36d21580db677b231c57f99f49aa2cb "Related: tdf#140968 avoid duplicated filter values". Change-Id: I75e5b2391624ff85a8ed545926ec519355a356bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115473 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-27no need to allocate Sw2LinesPos separately on heapNoel Grandin
Change-Id: I39dec50f491a313ac188bb2f73073ecc32ebfc21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27sw_ooxmlexport: just use exportonly hereXisco Fauli
Change-Id: I37fe18528dbe821eb60c7b1d6c65039e2ae91b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116236 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-27fix leaks in ScAcceptChgDlgNoel Grandin
Change-Id: Idaa946f06fdfdc1f908cff02cab542b64066763c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27tdf#47065 Add new file open UI options and implement a new threadMatt K
Add new UI options when opening a locked or non-writeable document to allow the user to be notified when such a document becomes editable . If the user selects "Notify", then that document is added to a list of open documents to be checked by a thread every 60 seconds for read/write access and whether lock file is available/obtainable. If access is allowed for a document, then show UI dialog to the user asking to Reload that document. If Reload is selected by the user then that document is reloaded with read/write access. The checking thread is spawned only once no matter how many "Notify" documents there are. The thread is spawned if not already running when a new "Notify" document is opened, and it terminates when all "Notify" documents have been closed or the application terminates. Also update badstatics clang plugin to ignore new global variables introduced. Change-Id: I7555ce6f5df79c2c87216e0129ef3b2883c7d921 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-27sw_ooxmlexport14: simplify codeXisco Fauli
Change-Id: I2e52a042b514e6724dbd282a41a4ca7f66981f2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116233 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-27gtk4: drop can't focus from GtkBox and GtkGridCaolán McNamara
it used to be that can-focus of true in a child with false in the parent allowed focus in the child, that's no longer true. We're already clearing can-focus of false from a widget if a child has can-focus but we build notebooks (especially) with separate .ui files each page so can't tell that there will be contents inserted. Plenty of ways to target just the case for notebook contents, but seems easiest to just clear can-focus of false from all GtkBoxes and GtkGrids. Change-Id: I460f3d5990a5df7b8b8e7d37ce592a5731794f31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116226 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27gtk4: apply 'border' to dialog content child widget if it existsCaolán McNamara
and if it doesn't apply to the object itself Change-Id: If73e1e78ddc7945480bb2c2e59bf50350ba53e3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27Introduce SwContentFrameInvFlags to replace magic numbers in ...Miklos Vajna
... SwContentFrame::SwClientNotify() SwContentFrame::UpdateAttr_() is not yet updated to produce these. Change-Id: Iccb1a9a5cfea967dfd9ca68d25dd9dccb6cc6fe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116229 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-27expand frames horizontally to fitCaolán McNamara
Change-Id: I2c2fc8a726c279583ef9aa3d51eebe7f28164684 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27resave with latest gladeCaolán McNamara
Change-Id: I91a3836e02cf3ed1cfdcea93f8812dcecc43afcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27tdf#139196 - Import/export macros using utf-8 including BOMAndreas Heinisch
Moved import logic to a local function, and during the import of a *.bas file, check if it starts with BOM in order to detect the correct charset. If there is no BOM, use the default charset of the system, since after the change in 178adcd8459af63ddb48927207baa5b4efbfda12, all the newly created *.bas files have a BOM and are written using the utf-8 charset. Change-Id: Iefdecb5762d896ce3e52fd6d212de42cf417ddac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116186 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2021-05-27osl::Module::loadRelative against symbol from executable is unreliableStephan Bergmann
It turns out that c8976bdfdfa361fec9e1e5ff342094e409981fad "tdf#137208 Assume that dladdr provides an absolute pathname" is wrong with glibc if the requested address is in the executable itself, not in a dso. In that case, glibc just returns argv[0] as Dl_info::dli_fname (see <https://sourceware.org/git/?p=glibc.git;a=commit;h=b8565e7817d7c6afd8eac804867b88c9bad1c9f1> "Fill in correct information if symbol is in main program"), which need not be absolute. With > cp workdir/LinkTarget/Executable/fftester instdir/program/ that causes > LD_LIBRARY_PATH=`pwd`/instdir/program instdir/program/fftester sd/qa/unit/data/cgm/pass/binary_corvette.cgm cgm to crash (cf. comment at <https://gerrit.libreoffice.org/c/core/+/111004/2#message-239c434e95f6fee5f5232e32f731595f56116aa3> "tdf#137208 Assume that dladdr provides an absolute pathname"): The call to osl::Module::loadRelative dlopen's instdir/program/libsdlo.so with a relative pathname containing at least one slash, which in turn causes dladdr with an address from libdlso.so to also return a relative pathname, which causes osl_getModuleURLFromAddress on such an address to fail, which causes the CGMPointer ctor in sd/source/filter/cgm/sdcgmfilter.cxx to set m_pPointer to null, causing SIGSEGV when TestImportCGM dereferences it. (Whereas e.g. > (cd instdir/program && PATH= LD_LIBRARY_PATH=`pwd` fftester sd/qa/unit/data/cgm/pass/binary_corvette.cgm cgm) would dlopen libsdlo.so with a relative pathname consisting just of a filename without a slash, so dlopen would search for the library, record its absolute pathname and return that from dladdr, and the program would have worked.) Change-Id: Ifa23124090275a397d4a9b0672ab845af23cf4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116194 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-27sw: rework to avoid the DECLARE_ODFIMPORT_TEST macroMiklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I7a6de527c28c543d7b622398dab406e2bfb80805 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116216 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-27cross-toolset: explicitly add PythonJan-Marek Glogowski
It's needed for the build and it was at least missing on Windows when building without galleries. Change-Id: Ibfcc6f0159e17d69755b230767b64b03dc5537a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116227 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26Cleanup Library_vcl.mkJan-Marek Glogowski
Merge a few duplicate calls and generally prefer inline $(if ..) over extra ifn?eq lines. There are minimal changes: * Move X11 settings from !DISABLE_GUI to USING_X11 * Move the vcl_opengl_denylist from WNT+!DISABLE_GUI to WNT only * SkiaHelper compiles to "isVCLSkiaEnabled() { return false; }" without the enabled feature, so move code to the general list. * Move the SKIA library to !DISABLE_GUI, where the code is * Move PDFium source + external to generic lists * "extract" common ${vcl_headless_freetype_libs} Change-Id: I9836ab3c1791b6406984ec4d4c27a8924faffdca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116220 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26configure: internal OpenLDAP depends on NSSJan-Marek Glogowski
So we need either NSS or a system OpenLDAP. Also add the $test_openldap flag. Change-Id: I134d1ed3a0a9654e264ccc66cdbe993a355620cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116109 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26gbuild: Handle glxtest + vclmain usage via macrosJan-Marek Glogowski
Use a macro to do the same checks for all Executable with glxtest or vclmain usage. Both are static libraries, so every user has the same dependencies. Introduces: * gb_Executable_use_vclmain * gb_Executable_use_glxtest Change-Id: Ib80b4e7c6f5078d47ad8f1ec5708a7174415f705 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116145 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
generated by cgit (git 2.34.1) at 2025-02-22 00:14:38 +0000