summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-09-17cid#1608561 Overflowed constantCaolán McNamara
Change-Id: I3115263da1c76f635d544e41c3cf96e068b34324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173543 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608578 Overflowed constantCaolán McNamara
Change-Id: Id7f5b94208f75a0fdc8ebb769b5a8265312c0995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173542 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17ofz#71606 use better upstream solutionCaolán McNamara
Change-Id: I088db3a8defd4cddee657c25d35724932339b983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17these can be constCaolán McNamara
Change-Id: Id560175cc69162b362e8f96b2dc0255118387f8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173539 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17Output what languages are handled by LanguageToolCaolán McNamara
to explain the absence of languages that are listed by 'Preloading' because the languages handled by a remote LanguageTool are removed from the languages handled with local data. Change-Id: I203657f68a7b9399e39ebf9ab9447c7ae56efe68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173448 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit c5fc86e770901eb90356cb31d4ac71ac7dad9ce6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17move setLanguageToolConfig out of extern "C" zoneCaolán McNamara
no logic change here Change-Id: I29153a11e1b841fa078d29a6431cd5af1179672e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173450 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 26e433e0e3c6dfbf2569c3b6f0a14249dc4d0c1f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173537 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17unoxml: move checkSPARQL from Java to CppUnittestXisco Fauli
Change-Id: Id8adaec00b9920966c91471fdd32720337a8c414 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173462 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-17unoxml: move checkRDFa from Java to CppUnittestXisco Fauli
Change-Id: Ife5cd7398bdbacbd8189c8451dab6351590052e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173484 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-17lok: sd: slideshow render improvementsMarco Cecchetti
Changed the slide layer message layout. Sometime some text field layer was missing. Try to skip empty layers. Change-Id: I52f00e637da7ab705a1fcb52a70af88cf619c8f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173540 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-17sc: use SAL_RET_MAYBENULL() in GetViewBindingsXisco Fauli
Change-Id: I67e3e7921869a22d2bf6ce713fd581a9c3881aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173521 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-17Related tdf#161657 Define default Comments style attributesKira Tubo
* Line spacing = Single * Indents/Margins = 0 * Top/Bottom spacing = 0 * Font color = COL_AUTO * Highlight = None (COL_TRANSPARENT) Change-Id: Idd0d4d896a0cc6021c99c7c13280ef6e18ae2602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173507 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-09-17cid#1607476 Overflowed return valueCaolán McNamara
Change-Id: I38c72db66e47b0e09a53413457f167159c599202 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1606987 silence Overflowed integer argumentCaolán McNamara
Change-Id: I77380d12a5d51c3debb1365a5fc9b57c33299eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 614dd5fba24a70bc5b5a4cb43eb431fc4dacd3c0 - tdf#162607 disambiguate hid2file.js, InsertAuthor + moved insert author to shared/ + Document access command, delete old command paths Change-Id: Ic2ce72a47f842b6bdaf8cdb7469beaded3f43f06 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173483 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-17cid#1608367 silence Overflowed return valueCaolán McNamara
Change-Id: If60d9607678ac9193923cad63895d654b8283ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173522 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608226 Overflowed integer argumentCaolán McNamara
and cid#1607920 Overflowed integer argument cid#1606589 Overflowed integer argument cid#1606576 Overflowed integer argument Change-Id: I2b1c0e871e7f7a913e0f14128fb13fc04d993ca1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173520 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f7b6ce51459426167f1f17ea209ba38707788673 - tdf#162607 disambiguate hid2file.js, Select Row/Col + deleted singleton pages not a target + deleted embed how-to-get not used anymore. Change-Id: I3e93b758fcd7d87f8c37a0ae47ffe39fc794d0c7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173482 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-17cid#1608289 silence Overflowed constantCaolán McNamara
Change-Id: Ia42be7ae929767dbb02cecd0f87d6b3a994b8f90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 42ecd2971a60e08485dbafbace2f2ed7245cd48c - update translations for master and force-fix errors using pocheck Change-Id: Ic6577d3caf2dfad168da2a61b78bf2bc26e5d361
2024-09-17tdf#162990 Colibre (and Dark) SVG: fix unlocked icon and add locked iconIlmari Lauhakangas
Change-Id: Ic2121cdddc5bafb38b5082f4ba6e6774670a1543 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173509 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Jenkins
2024-09-17cid#1557158 Unguarded readCaolán McNamara
Change-Id: If749fd6fd232beaa44162956bd4f1e992d8e976d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173430 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17scriptforge.py - improve debugging modeJean-Pierre Ledure
To facilitate the debugging of the ScriptForge Basic code called by the python scripts, 2 methods have been added to the ScriptForge() class: - initializeRoot(force = False) Initialize the global scriptforge data structure. - When force = False, only when not yet done. - When force = True, reinitialize it whatever its status. - errorHandling(standard = True) Determine how errors in the ScriptForge Basic code are handled. Either - the standard mode, i.e. display a "crash" message to the user - the debugging mode, i.e. the execution stops on the line causing the error Example (cfr. tdf#162962) from scriptforge import CreateScriptService, ScriptForge sf = ScriptForge() sf.errorHandling(False) def testSF(): srv = CreateScriptService("Calc") g_exportedScripts = (testSF,) Change-Id: I25d7d8e36e71d95ff8a04191bb8344794886d69e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173458 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2024-09-17-Werror,-Wunused-variableStephan Bergmann
...in code newly introduced with 56588663a0fddc005c12afaa7d3f8874d036875f "tdf#131728 sw inline heading: fix DOCX paragraph layout interoperability" Change-Id: I676c7cd1605e7eb94dd56108160a8b841065abee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173465 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2024-09-17dont use GetItemSurrogates for gathering SvxUnderlineItemNoel Grandin
which is very expensive these days Change-Id: Ia8485f38b7aeb763a49a1acb433e22d1360694e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173513 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-17cool#9992 lok doc sign: fix signature status after loadMiklos Vajna
Load a document, see the 'signaturestatus: 4' callback (SignatureState::NOTVALIDATED, "signature is OK, but certificate could not be validated"), wait till the view is initialized, notice the strange later arriving 'statechanged: .uno:Signature=3' callback, which hints that the document was modified, but we're right after load, so that should not happen. I already tried to prevent doc modified status in commit 654f972a97c374fa90eb3984a44c7f54ddba9c61 (sw lok: make sure author name change doesn't mark the doc as modified, 2023-01-16), but this is not enough for the doc sign case, where SfxObjectShell::SetModified() ends up refreshing the doc title, which calls SfxObjectShell::GetDocumentSignatureState() and then caches the wrong SignatureState::INVALID state. Fix the problem by adding a flag to not mark the document as modified during "init view" in the first place: that keeps the document unchanged after updating fields, but doesn't break the doc sign status. Now LOK clients get a first 'signaturestatus: 4' on load, and a 'statechanged: .uno:Signature=4' on initializing the view, which is a bit redundant, but at least is consistent. Change-Id: I42d50525ba96900eeeb927a50f1484c882347b13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173514 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-09-17cid#1607788 Overflowed return valueCaolán McNamara
Change-Id: I302dc99a70ccaa1c995065df5c72202a7c025dec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173516 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-17tdf#162866 package: fix loading AutoCorrect file with case-insensitiveMichael Stahl
... duplicates; the directory names of AutoCorrect entries are user-editable, so this needs to be supported. AutoCorrect uses an ODF package because the ODF document loading code requires the ODF document to be in an ODF storage with a MediaType property. AutoCorrect writes an empty mimetype file, and if such is present in an .odt file that is being loaded, existing checks will detect it as corrupted, so we can use this to check that the file is an AutoCorrect file and turn off the case-insensitive check. (regression from commit 4833f131243bdb409ddfaff8b4db87d4ed2af98f) Change-Id: I43887f7dad0c8cbb465b4c0f1c38bcc3244a7675 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173477 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-09-17sw: fix assert due to invalid nEndPos in SwAutoCorrDoc::ChgAutoCorrWord()Michael Stahl
Happens when using a "non-text-only" replacement (which can be created by selecting text before opening AutoCorrect dialog). asserts in SvxAutocorrWordList::WordMatches(): /usr/include/c++/14/string_view:256: constexpr const std::basic_string_view<_CharT, _Traits>::value_type& std::basic_string_view<_CharT, _Traits>::operator[](size_type) const [with _CharT = char16_t; _Traits = std::char_traits<char16_t>; const_reference = const char16_t&; size_type = long unsigned int]: Assertion '__pos < this->_M_len' failed. The "IsTextOnly()" branch adjusts nEndPos, clearly it's needed in the else branch too. Change-Id: I442042a5560d8143f1293ac29476aff6e93d7f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173476 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-09-17tdf#161810 sw smart justify: fix overhanging lines containing tabsLászló Németh
Length of tabulator portions wasn't taken into account during calculating overhanging lines, resulting missing space shrinking. Regression from commit 17eaebee279772b6062ae3448012133897fc71bb "tdf#119908 sw smart justify: fix justification by shrinking". Change-Id: I34bb007940b91e861b24413e76c910ee62aed158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173451 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2024-09-17sfx2: Synchronously set control state in file picker on all platformsMichael Weghorn
Unify the handling to initialize the control state in `FileDialogHelper_Impl::preExecute` and set the state of the controls synchronously (right away) for all platforms. This was already done for Windows and macOS, but not for Linux, where this was delayed by doing so asynchronously in a user event. The asynchronous way of doing it was introduced in commit e1d6dc26677c9ef24360cd3b2b40acfc7dee13a0 Author: Frank Schönheit <fs@openoffice.org> Date: Tue Oct 30 13:12:46 2001 +0000 #93977# do an asynchronous InitControls and the the comment gives this reason: // allow for dialog implementations which need to be executed before they return valid values for // current filter and such However, this doesn't work everyhwere, so this was already switched back to being synchronous for macOS in commit 420c7215ad52ce0a2fc652c9b537af20c80e86f0 Author: Kurt Zenker <kz@openoffice.org> Date: Wed Mar 5 15:44:58 2008 +0000 INTEGRATION: CWS aquafilepicker02_DEV300 (1.134.22); FILE MERGED 2008/02/11 17:38:41 fheckl 1.134.22.2: RESYNC: (1.134-1.138); FILE MERGED 2008/01/14 08:40:47 fheckl 1.134.22.1: Allowing for corrrect fpicker init on MacOSX and for Windows in commit 9ebe7641b7f5f5ceebbe0b2dad73e8bb73997967 Author: Oliver Bolte <obo@openoffice.org> Date: Fri May 30 10:34:06 2008 +0000 INTEGRATION: CWS hro35_DEV300 (1.142.32); FILE MERGED 2008/05/26 09:16:01 hro 1.142.32.1: #87244# Dialog initialization sequence has to be done synchronous for modal Vista dialog . The asnyc way also doesn't work for the Qt-based VCL plugins as mentioned in Change-Id: I9edf65a31f8268feb13fd6abf627744d68fd79e3 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Sep 16 14:06:39 2024 +0200 qt: Add "Sign with default certificate" to QtFilePicker : > When no signing key is set there, the checkbox currently > isn't disabled as expected, but that's a separate issue, > also seen with the "Edit filter settings" checkbox that > is disabled with gtk3, but not with qt6 independent of this > commit. Unify to set the state synchronously everywhere again, which makes the Qt-based VCL plugins work, and also works as expected in my tests with the gen and gtk3 VCL plugins on Linux, even when locally disabling the `CommonFilePickerElementIds::LISTBOX_FILTER` handling in `FileDialogHelper_Impl::handleControlStateChanged` for testing. (That gets called for these implementations when the dialog shows and would otherwise take care of setting the proper state as well.) The gtk4 file dialog currently doesn't shown these checkboxes at all, independent of this commit. Since the first commit mentioned above only refers to an issue in the internal StarDivision bug tracker, it's not clear on what platform the synchronous handling was causing problems in the past, but it seems that the issue is gone by now. Change-Id: I4bbc7f8d03061f9858b2e355b6d1874a0b71adfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173456 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17Update "Sign with default" checkbox in FileDialogHelper_Impl::preExecuteMichael Weghorn
commit 426c641976688e3e4d1ce66f76b27ccbd2dca55a Date: Wed Jul 17 12:47:22 2024 +0200 tdf#159040: add sign with default certificate to save dialog added a call to `FileDialogHelper_Impl::updateSignByDefault` to `FileDialogHelper_Impl::InitControls` that gets asynchronously called for non-Windows and non-macOS, see `FileDialogHelper_Impl::preExecute`. Also explicitly call it for the Windows and macOS case, like all of the other methods that also get called there in that code path. This makes the "Sign with default certificate" checkbox disabled when no GPG key is set up in "Tools" -> "Options" -> "User Data" -> "Signing Key" even if commenting the call to `FileDialogHelper_Impl::updateSignByDefault` in `FileDialogHelper_Impl::handleControlStateChanged` on Windows, i.e. the correct state of the checkbox no longer depends on an implicit filter change when the dialog gets started. This is mostly in preparation of using the same code path for the Qt-based VCL plugins on Linux, where no implicity filter changed signal happens and the "Sign with default certificate" and "Edit filter settings" checkboxes are currently always enabled after starting Writer and opening the "Save As" dialog. Change-Id: Ibc6c2a16dc04f0fe7e41317aeb98ea159e7aec8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173455 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17sfx2: Drop duplicate MACOSX checkMichael Weghorn
There since: commit e103887c8c158e7059a586ef5a5f7b234c547dfe Date: Fri Jan 11 11:07:23 2013 +0200 QUARTZ is equivalent to MACOSX Change-Id: I34d04913af45c529e01249a5f1a9c5f66b7260b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173454 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17qt: Add "Sign with default certificate" to QtFilePickerMichael Weghorn
Extend `QtFilePicker` to implement the new feature added and implemented for other file picker implementations in commit 426c641976688e3e4d1ce66f76b27ccbd2dca55a Author: Sarper Akdemir <sarper.akdemir@allotropia.de> Date: Wed Jul 17 12:47:22 2024 +0200 tdf#159040: add sign with default certificate to save dialog This makes the checkbox show up when opening the "Save As" dialog in Writer using Ctrl+Shift+S and behaves as expected when a GPG key has previously been set in "Tools" -> "Options" -> "User Data" -> "Signing Key". When no signing key is set there, the checkbox currently isn't disabled as expected, but that's a separate issue, also seen with the "Edit filter settings" checkbox that is disabled with gtk3, but not with qt6 independent of this commit. Change-Id: I9edf65a31f8268feb13fd6abf627744d68fd79e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173453 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Drop CAccValue::GetXInterfaceMichael Weghorn
Be consistent and just use the `m_xValue` member directly, as is already done elsewhere in the same methods. Change-Id: I9b7a1e91cbe224115863cde9bb8d4fed14448436 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173447 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-17wina11y: Prefix and rename CAccValue memberMichael Weghorn
Use m_ and x prefixes, as it's a class member and a uno::Reference. Change-Id: I3b345749c256bccb3c6c59b54eed4db8f38c5a7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173446 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Merge CAccComponent{,Base}Michael Weghorn
Merge the `CAccComponentBase` class into its only subclass `CAccComponent`. While at it, make the `m_xComponent` member private, which was previously protected for no reason anyway. Change-Id: I029348c51aefd1b7cdc3db68bac6abc31de15d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173445 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-17wina11y: clang-format AccComponent.hMichael Weghorn
... in preparation of merging `CAccComponent` and `CAccComponentBase`. Change-Id: Ic7f436ec1bf1d4cbebfe27e86a29710719a33785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173444 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Drop CAccComponentBase::GetXInterfaceMichael Weghorn
Just use the `m_xComponent` member directly, as already happens elsewhere in these methods. Change-Id: I1f3020e568d0d9b29576d0f446dea2f159119880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173443 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Use standard naming prefixes in CAccComponentBaseMichael Weghorn
Use an `m_ ` prefix because it's a class member, and `x` because it's a uno::Reference. Change-Id: I084f41f4bca97b39d3bf365dd9025b0a9d145d24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173442 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Drop "//special query" commentsMichael Weghorn
It's unclear to me what these //special query comments above the null checks refer to and I find them more confusing than helpful. Remove them. Change-Id: I3a3d886a664d03ec37085e2f074928c2a3055820 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173441 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-17wina11y: Just assign the referenceMichael Weghorn
No need to manually use the pointer, and have special handling for an empty Reference. Change-Id: I414cfdccacecc79594c0bc5b57d782ea98b811fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173440 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Drop unused CAccComponentBase::grabFocusMichael Weghorn
Accessible's `IAccessibleComponent` interface [1] has no `grabFocus` method and `CAccComponentBase::grabFocus`. Therefore, drop it. The `IAccessible` interface has an `IAccessible::accSelect` method that can be used to request focus by passing the `SELFLAG_TAKEFOCUS` flag [3], but that is implemented in `CMAccessible::accSelect`. [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_component.html#a8709fdbf3f51ae079af274854a8bffd4 [2] https://learn.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-accselect [3] https://learn.microsoft.com/en-us/windows/win32/winauto/selflag Change-Id: I1ae99fdbf60aa18a041c086a73f9bd7c6a80cace Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173439 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Drop unused CAccComponentBase::get_locationOnScreenMichael Weghorn
While IAccessible's `IAccessibleComponent` interface [1] has a `get_locationInParent` method and the implementation in `CAccComponent::get_locationInParent` calls the base class one, `CAccComponentBase::get_locationInParent`, there is no `IAccessibleComponent::get_locationOnScreen` equivalent, and `CAccComponentBase::get_locationOnScreen` is simply unused. Therefore, drop it. The `IAccessible` interface has a `IAccessible::accLocation` method to return the location on screen, but that is implemented in `CMAccessible::accLocation`. Therefore, drop `CAccComponentBase::get_locationOnScreen`. [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_component.html#a8709fdbf3f51ae079af274854a8bffd4 [2] https://learn.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-acclocation Change-Id: I1a38844101b4eca10afdc6356c46156ad2091f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173438 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17use more concrete UNO types in sdNoel Grandin
Change-Id: I04578521e86759af7fdd6d2d19d8313ed8bc1bf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173457 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-17use more concrete UNO types in sdNoel Grandin
Change-Id: I9205552d45fb4a77b51419f04256a9d0609823d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173452 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-17dont use GetItemSurrogates for gathering SvxColorItemNoel Grandin
which is very expensive these days Change-Id: I26da48f3b29bc3029d359214e0c50fa51e9e2194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173479 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-17Fix formatting of datesMike Kaganski
Redression after commit 81e1e0a2a671f19950c1bd3c69f9aa24b0c562e7 (Refactor SbxValue::Format, 2024-09-13). Change-Id: Ie7eb50c32f3c1a3aec73fc882dc33cce42734747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173449 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-17Only call GetViewBindings onceMike Kaganski
Change-Id: I172937f7f2dd6a9a5b128777ea95271c565f3ae5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173437 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-17Check return value of GetViewBindingsMike Kaganski
... as done in all other places where it's called Change-Id: Ic941cf433e96bb8bfa6ea81c52c044cc424100eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173436 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-17tdf#162987: check return value of GetViewBindingsMike Kaganski
Change-Id: Iaeec22ed07e18aa59f2ab87b2ea7d8a0c7ae1467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173435 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-03 08:20:28 +0000