summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-06-10drop unused suppressionsCaolán McNamara
Change-Id: Ibaf8856839e134432297b96e1d68f5ecd484335c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-10fix Gtk-WARNING **: Could not load image 'res/unlocked.png'Caolán McNamara
use icon-name instead of pixbuf Change-Id: Ibb0a09047ada6ac3301ca0a40dbeb25351c41ed1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168609 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-10fix GLib-GObject-CRITICAL **: invalid cast from 'GtkImage' to 'GtkLabel'Caolán McNamara
Change-Id: I29024237cc2d92d16433cf432f87e2b42107a487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168630 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-10add test for hyphenation related crashCaolán McNamara
of: commit f050103c3324d878b310f37429ea3580a8230905 Date: Fri Jun 7 20:14:15 2024 +0100 stale hyphenation data after skipping blanks Change-Id: I9743d67b49db054968e9f13c5fc6a13136953733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-10android-viewer translated using WeblateWeblate
Japanese currently translated at 82.7% (96 of 116 strings) Change-Id: I823d969cd027cbdd3778c5ca6887722831d01fbf android-viewer translated using Weblate Hebrew currently translated at 99.1% (115 of 116 strings) Change-Id: I610c1282074f709b2b08baf6303cd70e2eef19c1 Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Co-authored-by: Weblate <noreply@documentfoundation.org> Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/he/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168567 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-06-10tdf#160321 - Don't execute jump statement if the expression is out of rangeAndreas Heinisch
Don't execute On expression GoSub Statement; On expression GoTo Statement if the expression lies out of range. Change-Id: I5c1de25918b5e812d7ec82034f8d56351374d56a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165960 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2024-06-10loplugin:ostr in sw/../uibaseNoel Grandin
Change-Id: I4f4284b55d481caa006743688e6d83cc3c713b5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168601 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-10silence unknown property 'HyphNoLastWord'... etc warningsCaolán McNamara
warn: linguistic:3688232:3688232:linguistic/source/lngprophelp.cxx:636: unknown property 'HyphNoLastWord' warn: linguistic:3688232:3688232:linguistic/source/lngprophelp.cxx:636: unknown property 'HyphKeepType' warn: linguistic:3688232:3688232:linguistic/source/lngprophelp.cxx:636: unknown property 'HyphKeep' Change-Id: I4f99961e17bd4e0f90925b8530e25729d964d42e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168600 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-10loplugin:ostr in sw/qa/extrasNoel Grandin
Change-Id: Ia11b13ec7ed2402e717a4e64e7c7e4aa0b41d70f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168598 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-10Related tdf#134193: declare right-to-left in Math.xcsJulien Nabet
Change-Id: I4341f8dd84a17b4f8dd9da2e4f031ed38590d881 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168568 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-10svx: prefix members of SdrGrafObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: Icc587c31582fb5fdfbdfe375005b96ea219bf4a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168597 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-10tdf#161488: allow failed image loading in repair modeMike Kaganski
Change-Id: I19a68f2f016b5ab95565c7fbcc4c435cf13c6b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168596 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-10tdf#160538 Quickfind sidebar list finds in frames and footnotes andJim Raykowski
endnotes in the order of occurance in the document Change-Id: Ifd91065ed416495084ba7f396f740daef5233c90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168566 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-06-10tdf#99528 Use vertical tabs in para dialogSamuel Mehrbrodt
Change-Id: I7ec61c07f75e9a8aa124ac5b3d67c90077cca033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166625 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-06-10tdf#161454 - Fix new array functions handle empty matrix cellsBalazs Varga
Newly added calc array functions didn't handle empty matrix cells as empty cells but they were handled as empty strings. Change-Id: Ie24a38dd8c3f947cfe10ba05b234807891453824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168591 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-06-09Related: tdf#137543 - fix LET function jump count numberBalazs Varga
Clean-up and fix wrong jump count. Change-Id: Ie64ff95f63c17d2726b3a522af981bcaea2a9a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168590 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-09tdf#161467: fix assertion in Impress when inserting table (gtk4)Julien Nabet
Change-Id: Ib3b21c46e7c19be27a64b52badc618480f0a86c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168593 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-09ofz#69444 Integer-overflowCaolán McNamara
Change-Id: I24d93f4c61256cd0750ab01cf5a8f313e875d35b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168580 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-08cid#1603563 Unchecked return valueCaolán McNamara
Change-Id: Ie41d77d8809b28e44b2fa084f2f9e6cdfb6e167f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-08stale hyphenation data after skipping blanksCaolán McNamara
what I see is that after skipping the blanks that the m_xHyphWord remains describing the word at the original m_nBreakStart, but we have changed that m_nBreakStart and in the example I have the m_nBreakStart is at the next word, so the contents of m_xHyphWord bear no relationship to the current break position. Change-Id: I07c91495f0cd7ef6d78c0f0d5cef70070ebb6ff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168561 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-08Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' to 95755ff59d2fc074796f341d2dc781660c52ce74 - Tip link to INDIRECT wiki page Change-Id: I53d0bb0932617785ff64adc84c890d0be115125f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168578 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-06-08tdf#100037 vml import: set fly-anchored AS_CHARs above fly's zOrderJustin Luth
Normally an AS_CHAR is the lowest in the heaven-layer zOrder, but if it is inside a fly, it should be just above the fly's zOrder. In order to get at the parent's properties, I had to remove the stack abstraction so I changed the stack to a vector. That seemed a lot saner than popping and re-pushing. make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf100037_inlineZOrder2 make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf100037_inlineZOrder3 Change-Id: Idc159e8203b3f304133a9b110c135e4d0f001dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168565 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-06-07Modernize wasm debug symbol generationThorsten Behrens
Rolling a few suggested split debug changes from https://developer.chrome.com/blog/faster-wasm-debugging/ into our code. Added emdwp after linker line, to collect .dwo DWARF info into one single file (otherwise Chrome lacks local variable support) Still not working: * -gdwarf-5 does not work yet with neither -O1 nor -Og * -Og results in massive binary sizes, -O1 still required to not blow up browser mem right after load Change-Id: Ibf9ea42882df88d947f9bb3881430f0745c0df54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168562 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-06-07tdf#43157 Use SAL_WARN_IF instead of OSL_PRECONDGabor Kelemen
Change-Id: I9876ac2bb83f8dc96c41c20dfd2bf779ffe105fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167997 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-06-07crash on exit with std::optional created from u"FOO"_ustrCaolán McNamara
#0 0x00007ffff7edaa90 in rtl::str::release<_rtl_uString> (pThis=0x7fffd8fa7c00) at sal/rtl/strtmpl.hxx:745 #1 0x00007ffff7eeb385 in rtl_uString_release (pThis=0x7fffd8fa7c00) at sal/rtl/ustring.cxx:1151 #2 0x00007fffed56d058 in rtl::OUString::~OUString (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>) at include/rtl/ustring.hxx:546 #3 0x00007fffed6084e9 in std::_Optional_payload_base<rtl::OUString>::_M_destroy (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:287 #4 0x00007fffed608497 in std::_Optional_payload_base<rtl::OUString>::_M_reset (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:318 #5 0x00007fffed608459 in std::_Optional_payload<rtl::OUString, false, false, false>::~_Optional_payload (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:441 #6 0x00007fffed608435 in std::_Optional_base<rtl::OUString, false, false>::~_Optional_base (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:512 #7 0x00007fffed607885 in std::optional<rtl::OUString>::~optional (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:707 #8 0x00007fffee14d910 in ImplSVAppData::~ImplSVAppData (this=0x7fffef433b20 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+296>) at vcl/source/app/svdata.cxx:526 #9 0x00007fffee14d480 in ImplSVData::~ImplSVData (this=0x7fffef4339f8 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance>) at vcl/source/app/svdata.cxx:518 #10 0x00007ffff785ea2d in __cxa_finalize () at /lib64/libc.so.6 #11 0x00007fffed55d287 in __do_global_dtors_aux () at instdir/program/libvcllo.so #12 0x00007fffffffd0f0 in ??? () #13 0x00007ffff7fca0f2 in _dl_call_fini (closure_map=0x7ffff7657580) at dl-call_fini.c:43 presumably since: commit 40dde4385cd913ac08292ad3be28bf17de9d296c Date: Fri May 10 13:19:35 2024 +0200 loplugin:ostr in vcl Change-Id: Ie7562a933291522a2c458bdca70ca9b0a5f4048c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168560 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-07tdf#161215 sw: layout: don't move into section frame on same pageMichael Stahl
The problem is that in SwFrame::GetNextFlyLeaf() pLayLeaf is in the body on the same page as pFlyAnchor, so the MoveSubTree() effectively removes the pNext chain from the layout into a circular structure whose upper is an indirect lower, causing an infinite loop later. Change-Id: I08f96cf483205d6213d7cec7b239f750fff5d3ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168529 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-06-07tdf#161217 sw: layout: don't move into to-be-deleted section frameMichael Stahl
The problem is that in SwFrame::GetNextFlyLeaf() pLayLeaf is found inside a SwSectionFrame that has no m_pSection because it has been scheduled for deletion via SwRootFrame::InsertEmptySct(). Skip such frames, now it goes into infinite loop later... Change-Id: I93e5febba19213c1503fd699c8e4517067c6ec6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168528 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-06-07Make Embind-related code also available under --disable-dbgutilStephan Bergmann
...and just keep embindtest.js --enable-dbgutil--only. For convenience when using EMSCRIPTEN_EXTRA_SOFFICE_POST_JS recently introduced in 82640810efd1636e358c047a1a5b3e4e3fc9d28a "New EMSCRIPTEN_EXTRA_SOFFICE_POST_JS configure variable". Change-Id: I03311d89ff14a70f84e03e99ab8e609641ea589b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168552 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-06-07prep AutoFill menu in kit mode onlyCaolán McNamara
Change-Id: Id533d78e1433b616ce661e855dad0d571d24cf8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-07add AutoFill menu items - LOK_CALLBACK_CONTEXT_MENUBayram Çiçek
- added AutoFill menu items "Copy cells" and "Fill series" - send information with LOK_CALLBACK_CONTEXT_MENU Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I3118f5535f74cfa4ab049e643930df83512b6850 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168086 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit a3f4d31783721f61b8436c5f8032321b4c97de1a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-07Revert "framework/qa/complex/dispatches/checkdispatchapi.java to CppUnit"Xisco Fauli
This reverts commit 227f5c77278c96f7f1b126aade457422949a095c. Reason for revert: I clicked the push button to fast. it needs more checking Change-Id: I092691c6ebcf7921d26df58ba4c0a38cfdd418b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168532 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-07CppunitTest_framework_CheckXTitle: simplify code a bitXisco Fauli
Change-Id: I1e3fe2d081daf6c7b4097c266695f69c2f377b0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168521 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-07tdf#158914 sc a11y: Send TEXT_CHANGED event when text changesMichael Weghorn
Don't always send an `AccessibleEventId::VALUE_CHANGED` event when the string value of a Calc cell changes, but send a `AccessibleEventId::TEXT_CHANGED` event instead. Only send an `AccessibleEventId::VALUE_CHANGED` event in addition if the cell actually has value data, as the `XAccessibleValue` interface and the related `VALUE_CHANGED` event are meant to handle numerical values only. Together with changes like the one in PS 11 of [1], sending the `TEXT_CHANGE` event might help with missing text updates on the AT side, e.g. the NVDA or Accerciser scenarios described in [2], s. further discussion there. [1] https://gerrit.libreoffice.org/c/core/+/167961 [2] https://gerrit.libreoffice.org/c/core/+/167961/comments/16394c5a_338dbbf2 Change-Id: Ideba61a9200100c66d55fa18e81ea28e75092905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168526 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-06-07tdf#160591 PPTX export: fix colormap mapping in slide masterTibor Nagy
Change-Id: I154f0ff1769fbda361ec62f1dd589ca0d7686bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168506 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-06-07New EMSCRIPTEN_EXTRA_SOFFICE_POST_JS configure variableStephan Bergmann
...which can be useful during development, to add e.g. additional test code to the generated qt_soffice.html Change-Id: Ic498dcd4c812b7b4c8e48b07c2bff411a9f19438 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168522 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-06-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 4167f524c4718c3960cae2e4f390d04ffdb20839 - tdf161442 Help page for Calc LET function Change-Id: I81a5304786f626eaf7b556bb5faf6fa90f2eab34 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168508 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-06-07tdf#100037 vml import: add AS_CHAR images to zOrder calculationJustin Luth
Inline shapes are at the level of body text, so any heaven-layer floating objects should be above it, and any hell-layer flys should be below it. DML images already do this in applyZOrder(). make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf100037_inlineZOrder Change-Id: I51ab2eb4c1b59ebf048f16dca60a02b327c5e6b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168511 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-06-07NFC related tdf#100037: unify duplicate PropertySets, etcJustin Luth
This is supposed to be a No Functional Change commit, as cleanup prior to fixing the untracked zOrder of as-character VML shapes. There shouldn't be any reason why both xProps and xShapePropertySet need to be defined separately. Initial duplicate xShapePropertySet was introduced by vmiklos in 2013's commit 8738ded7bb1bb6262fe1038e310b5110407f4cfa. Plus, all clauses of the if statement will need the GraphicZOrderHelper, so lets just pull that out ahead of everything. make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf100037_inlineZOrder Change-Id: I6bbd9ab8b3062258f010ac9fb7eda7035722cfbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168510 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-06-07Embind: Add some type-inquiry functions to uno_Type and uno_AnyStephan Bergmann
...that proved useful in experiments wrapping a JS Proxy around the Embind representation of C++ UNO objects. Change-Id: Ia4018ec8dee2c222fb76ba8e2f529f4845f0134c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168518 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-06-07replace fpicker-related Help::GetHelpText with core-side translationsCaolán McNamara
Change-Id: I109554a3282c4c919cfbf859918cf0f9d75cc967 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168509 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-07framework/qa/complex/dispatches/checkdispatchapi.java to CppUnitAdam Seskunas
Ports the checkDispatchOfXXX tests including the three database dependent tests. The other tests in the file will be ported in another commit, to be merged with this one. Change-Id: I6bcbcbf91ad4d9cc52c817f4efef9779a17f2198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168482 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-07tdf#161443 DOCX import, table style: fix para border leaking into cell borderMiklos Vajna
Open the document with a single table, notice that start of the text in A1 cell is missing. Seems what happens is that the cell has some positive border distance, then the para has the same negative left margin, so in total there is 0 left margin for the text, which makes this readable in Word. On our side, we map the paragraph border from the table style to the LeftBorderDistance property, then throw this on the cell object, which gives us 0 border distance, so the negative para left margin results in an unwanted shift of text towards the left: the start of the text is hidden by clipping to make sure the painted text is inside the cell frame. (Both paragraphs and cells have a LeftBorderDistance property, by accident.) Given that a visible paragraph border from table style is not actually imported, first just do the minimal fix and make sure we don't import paragraph borders from table style at all: this solves the problem of unwanted 0 cell border distances and the full text is now readable. In case the paragraph border in the table style would be actually visible, that would be useful to route to the paragraphs in the cell, that's not yet done here. Change-Id: I79907a2487c48659effcc55253b9d9881550284d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168516 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-07Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 842cf7acf0f77bbffdb61b42fc5b935773094dcb - Precision about Win environment variable Change-Id: I2105960d58fa0342dde9d7f762ecc1a18b3e9bb5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168448 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2024-06-06Update git submodulesDione Maddern
* Update helpcontent2 from branch 'master' to ef98081ca946d506c0bc0198f508358ef6e3a9aa - tdf#106335 Add info for Impress tables to Clone Formatting Guide In source/text/shared/01/03020000.xhp - Added variable tags to make the page easier to link from other pages In source/text/shared/02/paintbrush.xhp - Added variable tags to H1 to make page easier to link from other pages. - Hid the "From Sidebar" heading in the How to Get section behind an application switch, so there isn't an empty section for Impress and Draw. In source/text/shared/guide/paintbrush.xhp - Added links to the help pages for Standard Bar and Clone Formatting tool. - Added information for copying attributes within Impress - Added a Related Topics section In source/text/shared/main0201.xhp - Added embedded link to the Paintbrush icon. Change-Id: Ib6a7b380bcbe70a0626c69e409a7b05142e1b30b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168326 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-06-06Related: tdf#137543 - Add new LET function to CalcBalazs Varga
Fix parsing name strings in Let function, so the invalid names will be parsed as an ocBad - svString like before. follow-up commit: 521a56d8d1e12b7471fda6b62b21d51776c9fbaf Change-Id: If4645584500ffd85556695b12fa7c99eaa8f7662 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168503 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-06-06the remaining Help::GetHelpText calls don't want their parent as fallbackCaolán McNamara
so we can drop the hierarchical search these probably do nothing in the absence of the classic help. fpicker case might benefit from moving some a11y translations out of help into core. Change-Id: I01b8d0c7cc1a1b3697d3332e330c6b4654e76af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168507 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-06drop searching for widget extended tips in the offline helpCaolán McNamara
by now these extended tips for the widgets of the general ui appear in the .ui file directly instead as accessibility descriptions instead. In any case, the default build configs of distro-configs/LibreOfficeLinux.conf distro-configs/LibreOfficeMacOSX.conf distro-configs/LibreOfficeWin64.conf use --with-help=html where these ahelps are not available. So, existing in the classic help only. Change-Id: Ie27736e9140e445c7f8986a741c2002f2efa9ccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-06customization entry help never wants to search for parent widget helpCaolán McNamara
it's not a widget context help where help about the parent widget might help in the case of nothing available for the child widget, but help for the specific selected command/script see also: https://bugs.documentfoundation.org/show_bug.cgi?id=116494 Change-Id: Ib4b5650ca00c90b4b4b2a76ef0e3d8a438023327 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168504 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-06ICU: upgrade to 74.2Xisco Fauli
Downloaded from https://github.com/unicode-org/icu/releases/tag/release-74-2 Change-Id: I35a1b087f658541903a368fcaaad22c1c1e41d2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168502 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-06tdf#146756 unit test font: substitute Carlito for Calibri fontJustin Luth
I first substituted the theme font with Liberation Sans, but with those font metrics the label looked OK. So I tested with Carlito, which is metric-compatible with Calibri, and indeed it did give the same numbers both for the broken state and for the fixed state. Change-Id: I65c29443d6a867ef70a344eaddea6852b953f6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168497 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-23 03:26:01 +0000