summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-05gtk3: New Folder dialog from Templates dialog doesn't get keyboard focusCaolán McNamara
ctrl+shift+N, and click new folder, no keyboard input is accepted. The dialogs don't get keyboard events, because the keyboard events go to the top level window because of... commit 011ce226e89ecabaf621603d692547c88061eaba Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jan 19 13:22:10 2016 +0000 Resolves: tdf#99604 ungrab modal dialogs (should be tdf#96604) which stripped away the grab from the sub dialog but I did that because menu dropdowns from comboboxes inside modal dialogs didn't receive mouse focus otherwise. I had set our "modal" dialogs to be truly modal and triggering that problem with commit 8d5822983e9b6a1e04874ce4d2c807fd0cf1ee04 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Dec 14 11:36:50 2015 +0000 Related: rhbz#1290014 gtk3: use gtk_window_set_modal on modal dialogs which makes modal dialogs (which are most of them) place correctly under wayland. Modeless ones are still uselessly shoved far to the left, but this makes things near usable and gives the same "graying into the bg" effect for the main window as other gtk apps which I still contend is "a good thing" if we stop removing the grab from the modal dialog, then we need to grab the keyboard and mouse on to the menu on showing those. This then runs into the problem that sometimes we want the keyboard to go to one window and the mouse to go to another, i.e. mouse to the floating menu and the keypresses to its parent combobox. Which was the joy of... commit 27e0fee7da99f3df722668d132bc034bef421514 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Mar 27 15:28:28 2015 +0000 gnome#745909 grab/ungrab keyboard for menus and subsequent fix of commit 57ec66e294b1405a85029aa1f1c0e9485ad4e5b4 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 23 09:55:01 2015 +0100 Resolves: tdf#92689 grab keyboard focus to parent, not to earlier generations so... lets drop the ungrab on modal dialog attempt and leave that alone. That means that the keyboard focus travels around the modal dialogs stack correctly. For the mouse and keyboard events in menu problems, instead gtk_grab_add on the menu itself, and convert the separate grab of keyboard and mouse to different places with a single grab of everything to the menu, and in the keyInput of such menus where the keyInput would have gone to their parent in the past, forward it on ourselves directly. Using the gtk_grab_add makes the bOwnerEvents mode of mouse grabbing not work correctly anymore. So throw my hat at it, and instead use the simpler mouse grabbing where all events go to the menu, and doesn't send the events outside of it to the parent, the side effect is that now clicking outside the menu doesn't make it go away automatically because its the parent window which used to do that. So instead of dismissing the menu within the gtk plugin when the button click is outside the application, take it onto ourselves to dismiss the menu when the button click is outside the menu. and ditch some metacity hack around thing at this point too I hate this crap Change-Id: If10e758585f156b33680b8d40355302cc1ae72f3
2016-05-05silence default button spew in template dialogCaolán McNamara
Change-Id: I0ef5b6c273238fc564ec6f0d81ac18c0ce00842d
2016-05-05drop commented out codeCaolán McNamara
Change-Id: Ifb4a19bf9c86cf6294859da73ac380e93b2deb45
2016-05-05loplugin:nullptrNoel Grandin
Change-Id: Iacfe15cdb3c827892ef3db049a0405337faadc0d
2016-05-05loplugin:simplifyboolNoel Grandin
Change-Id: I994ff5ad74dcc68eef31c3779b5711160cc5ac5a
2016-05-05-Werror,-Winconsistent-missing-overrideNoel Grandin
Change-Id: I14a8df27dc5bf8f16f5955d45f21f5f4079d79e0
2016-05-05Related: tdf#84695 sw: fix TextBox begin text edit by pressing normal charMiklos Vajna
When a draw shape is selected, but its text is provided by a TextBox, then F2 and Enter could start editing already, but pressing a normal character didn't work (unlike for TextFrames or regular draw shapes). Fix this by calling into lcl_goIntoTextBox() at one more place. Change-Id: Ia594279918a6c3087cac8b0c859ce7432e4a685d Reviewed-on: https://gerrit.libreoffice.org/24671 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-05tdf#93124: Fix incorrect text fit in imported PPT - take twoMike Kaganski
This patch just fixes incorrect decision when the block alignment must be applied. Also, unit test is included. Change-Id: I458184778c5e9e115d1a4eac749ecb6991b227a8 Reviewed-on: https://gerrit.libreoffice.org/24648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-05gather calls to IterateParametersIfs() in one place, tdf#97831 follow-upEike Rathke
Change-Id: I62d8a32c624a550947edf423e89069e4d1892687
2016-05-04tdf#97831 [part] Add Excel 2016 functions to CalcWinfried Donkers
Functions MINIFS and MAXIFS Change-Id: I4bd2e8b82f8377af81f4373d0c33ac286588b8df Reviewed-on: https://gerrit.libreoffice.org/24619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-04loplugin:staticmethodsStephan Bergmann
Change-Id: I679fd93c409035ce87101f7fe150822c2214765e
2016-05-04fix export crash test due to assert hit, tdf#61996 follow-upEike Rathke
Fallout of 88a79589843efc24f8af99bd511a1fff0f7bebef Cause was a crappy number format that now is parsed differently and results in UNDEFINED type, hence XMLTokenEnum was XML_TOKEN_INVALID which later made assert(XML_TOKEN_INVALID < eToken) in xmloff/source/core/xmltoken.cxx GetXMLToken() bail out. Handle that during export and map to number-style. An example of fdo82933-1.ods that triggered this is [>0]" $"\"#"٬##0٫"00"٬"\";[<0]" $("\"#"٬##0٫"00);" $-"\"#"٬"\";@ Already import massively complained about xmloff/source/style/xmlnumfi.cxx:1710: invalid number format but not only for this format, the document contains a pile of crappy stuff. Possibly number format code scanning could be improved to type that NUMBER instead, which it could be as only the #...00 and #...00) are actually digit related, everything else are string constants. However, that likely was not the intention of the document author.. Change-Id: I7c2b202b0b87e1a7fa7a9f56862a6bb7618ad9ff
2016-05-04sfx2: fix SfxViewShell::CheckIPClient_Impl()Michael Stahl
Probably the Edit->Plug-in removal removed the wrong branch there since m_bPlugInsActive was always true before. This caused embded::UnreachableStateException to be thrown out of a Timer and that was only handled as a FatalError in desktop::Main, for example on kde84498-1.html. (regression from 4b3c211cfb4f64f0f31461aa2e623d64224c4423) Change-Id: If9e2578f722ea5c5b0821d3d894bb439dbf3c40c
2016-05-04tdf#88502 Firefox Theme URL in custom theme searchSusobhan Ghosh
Persona Dialog modified. Search supports Firefox Theme URL. Added display of installed theme on personalization dialog. Fixed category buttons. Added SOLID as category. Removed invalid/duplicate results. Change-Id: I603c0c292fe5c3e380553b9a2eaab6f4bc0683e1 Reviewed-on: https://gerrit.libreoffice.org/23385 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-04Add covertPropertyValue bool overloadStephan Bergmann
...as the behavior of the generic covertPropertyValue template instantiated for bool would be quite different from the behavior of the convertPropertyValue sal_Bool overload, leading to potential surprises. (Though it seems there were no uses yet of covertPropertyValue with bool, only with sal_Bool.) Change-Id: I107a0608fc4271e95464a7f9bdc340a9e6dc1336
2016-05-04Declaration of sal_Bool overload of convertPropertyValue had been missingStephan Bergmann
...ever since b525a3115f54576017a576ff842dede5e2e3545d "initial import" Change-Id: I0824b673d222b6376ca199ad37f916ccaf80aa58
2016-05-04Remove leftover declaration of convertPropertyValue overloadStephan Bergmann
...that had originally been introduced with a comment // This template is needed at least for msci4 compiler in b525a3115f54576017a576ff842dede5e2e3545d "initial import", and whose corresponding definition had been removed in 6231a9b4e926d5dc213f94ddf35b14bab411d77d "visual studio version 4 is long gone" Change-Id: I0cf4913a2c2c4701d41cf24d2f89c1de0bd86323
2016-05-04tdf#89466: Getting/setting page size works nowKatarina Behrens
Change-Id: Idd421c45b0e3e82a792672849ef34189398bddb5 Reviewed-on: https://gerrit.libreoffice.org/24451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-04tdf#89466: Give those slots a separate GetState methodKatarina Behrens
only SID_ATTR_PAGE_SIZE does anything so far Change-Id: I30de1b8b72702b0ddd536ed4026b433ed9295bb7 Reviewed-on: https://gerrit.libreoffice.org/24450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-04tdf#89466: Access to page setup dialog, alignment of labelsKatarina Behrens
Change-Id: I687457d26cf8e6f9e8d5fb5667eddd66baf3719e Reviewed-on: https://gerrit.libreoffice.org/24449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-04tdf#89466: Slide Background tabRishabh Kumar
Change-Id: Ic3ba6b47a1e5fcaeec76c4e4ff0ba6128653af86 Reviewed-on: https://gerrit.libreoffice.org/17007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-04filter: svg: avoid undefined variablesHenry Castro
Change-Id: Ibc3b678decfb36f5ac5779edb43aef1657507df2 Reviewed-on: https://gerrit.libreoffice.org/24627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-05-04Better fix for Windows-only codeStephan Bergmann
Change-Id: I8437ec66b615754d71c726f715a6beeb4a0f7dda
2016-05-04Missing includesStephan Bergmann
Change-Id: Ic0618ff8a8f01937a467e4ba5184fe68f14cd24b
2016-05-04Fix Windows-only code, part 8Stephan Bergmann
Change-Id: I875c4f4382221baaaedcdfe9513ed75706e8517b
2016-05-04Fix Windows-only code, part 7Stephan Bergmann
Change-Id: Idf118bee77b55004897ae085e124b9cec2ba4237
2016-05-04genLang .tree files got "help_section"jan Iversen
Added text type to .tree files fixed line wrap problem when saving to .pot Change-Id: I551521bb81e21724edf8f3bfa8aba1516ca7e879
2016-05-04No need to explicitly delete ctor the compiler wouldn't implicitly declareStephan Bergmann
Change-Id: Idd0e764765bd76e1f6a2d8ec6e18ebac27b91ec6
2016-05-04tdf#62525 vcl: use cow_wrapper for wallXisco Fauli
Change-Id: Iaf0b288a4c40f1e471a0a59b6baf17c317810d23 Reviewed-on: https://gerrit.libreoffice.org/24575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-04Fix Windows-only code, part 6Stephan Bergmann
Change-Id: Ib9a311dd199db81b0be46a7c32c49a10e1b866e7
2016-05-04tdf#62525 vcl: use cow_wrapper for mapmodXisco Fauli
Change-Id: I25ddaeb051f171388bb490a23bf03dbaf0add281 Reviewed-on: https://gerrit.libreoffice.org/24438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-04-Werror=maybe-uninitializedThorsten Behrens
Change-Id: Id516aa921d13ff5c0085fb9cf76fefd56acb31ad
2016-05-04Fix Windows-only code, part 5Stephan Bergmann
Change-Id: I1e51996d1035624b373dc5d27a7528f8351e0934
2016-05-04Resolves: tdf#94146 a11y crash, obtain formula using the correct pointerEike Rathke
Fallout from IAccessible2 integration. Of the union, wrong string pointer instead of formula cell pointer was used. Change-Id: I1afaf0ffff14a770ab52e8cbf880708bd66b3ef2
2016-05-04Fix Windows-only code, part 4Stephan Bergmann
Change-Id: Idf3f8c24a61973068f5354873d25dc2317fbb732
2016-05-04Fix Windows-only code, part 3Stephan Bergmann
Change-Id: I1a87cb1b8c5b5603c4043cd2d5de37a336ad88b6
2016-05-04genlang keygen with newline changedjan Iversen
when generating the keyid for text, all newlines \n must be converted to 0x0A Change-Id: I626776e94a6573d044522990a7f9ccc3d52b825b
2016-05-04genlang correct xcu filterjan Iversen
modified algorithm for adding "." Change-Id: Ibaa59cf5faa7bf211ead222dbb2e5a391929d679
2016-05-04Fix Windows-only code, part 2Stephan Bergmann
Change-Id: I5e860cd88e851b7bce5fa503108ffe61a36c0817
2016-05-04Fix Windows-only codeStephan Bergmann
Change-Id: Iaf6d668f65e31c60dba8140d789f6578ef461264
2016-05-04sal_Bool -> boolStephan Bergmann
Change-Id: I770a8507cdc1ee56456642b1f878381d6cf9d0b3
2016-05-04Remove unnecessary ScUnoHelpFunctions::SetBoolInAnyStephan Bergmann
Change-Id: I4814618758bbb2fe1ed3fbf279b0bbbb370d5cef
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04Underline should be a split buttonMaxim Monastirsky
Change-Id: I072293e7939d3d9f9349f40aec58729c3731d972
2016-05-04tdf#42949: clean up includes in include/oox/dump with iwyuJorenz Paragas
Additionally, include cmath instead of math.h in dumperbase.hxx. Change-Id: I0ee7158c86bdf266c783340bcf891aff44399066 Reviewed-on: https://gerrit.libreoffice.org/24632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-04tdf#97831 follow up : use ScInterpreter::ReverseStack()Winfried Donkers
Change-Id: Ic72a71ab4f90680f1e3496d68441151a36b8f41e Reviewed-on: https://gerrit.libreoffice.org/24630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-04loplugin:staticmethodsStephan Bergmann
Change-Id: I4b9dc149f5b2a18df0cab91e7706be14d584cf8f
2016-05-04tdf#94260 Convert pixel to 1/100 mmRosemary Sebastian
The scaling factor 0.28 is chosen as per https://www.w3.org/TR/2001/REC-xsl-20011015/slice5.html#pixels Change-Id: I8dc7846699fbb2aa6e2a181a041b66d3cc33b8e5 Reviewed-on: https://gerrit.libreoffice.org/24547 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-04underline popup control possible to use outside sidebarSzymon Kłos
Change-Id: I48097007c7dc0439b33233939c1d73902dfeb679 Reviewed-on: https://gerrit.libreoffice.org/24491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-06 08:09:36 +0000