summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-16new loplugin finalprotectedNoel Grandin
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16loplugin:countusersofdefaultparams in include/svx..unotoolsNoel Grandin
Change-Id: I02e933da66241e99e3b81d90d679f1502bab3fef Reviewed-on: https://gerrit.libreoffice.org/30866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16tdf#92346 - Copy functionality in the viewerChamal
Reference class added to desktop/source/lib/lokandroid.cxx for Java_org_libreoffice_kit_Document_getTextSelection() Change-Id: I211d5709df39fd9fafdab9232af760613f6b86c0 Reviewed-on: https://gerrit.libreoffice.org/29804 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-16Let's keep these guys private.Kohei Yoshida
Change-Id: I196c9c2b24f94ac66bb200fea561bdc5ccc679e5
2016-11-15tdf#71409: properly remove itself from the context it listens.Kohei Yoshida
When the context itself is being disposed. While this solves the issue of addAccessibleEventListener() being called twice despite removeAccessibleEventListener() being called only once, it won't solve the problem of leaky atk focus events. Change-Id: I984107ed2d30e6dba8067d11f400ff64d665d157
2016-11-16tdf#103784: Shift the upright glyphs like old codeKhaled Hosny
It turns out we actually need the horizontal shift, so re-enable it. Change-Id: If9d16276f0f56b518c6bedc2fcbbd3d8746d8d5d
2016-11-16Fix thinko in previous commitKhaled Hosny
Negative descender means the glyph is above the baseline and no shift should happen. Change-Id: I0ee3575051e47f16c64db4e85c0b8a390029567f
2016-11-15tdf#96475 PutFormulaCell: any other cell than formula is utter nonsenseEike Rathke
This is called only if a cell has the table:formula attribute and that *is* a formula cell and nothing else. In fact in ODFF the initial leading '=' is not mandatory, so attempting to set a different cell type if it is not present is wrong. Commit 62ec7f9e824ed1c17f01beaf8f4cec3b76b3aae9 introduced that, which at that time may have been necessary, but doubtful.. Additionally, ScFormulaCell::CompileXML() that tries to group formulas had to be adpated to not rely on the presence of a leading '='. Luckily there was an assert.. These changes enable loading of "error cell" formulas that were stored without a leading '=' if they originated from a paste special with only values, which maintains an error result as error formula. Change-Id: I43394de108066a24b792eec958b19f51f990403b
2016-11-15tdf#96475 sort error result between text and empty cellEike Rathke
Error results weren't handled at all and sorted same as numeric 0, which due to "stable sort" resulted in arbitrary looking sort order if 0 values or results where included. Change-Id: Ib7c516b57ea92bc5b813f448d9c2bb5491e43940
2016-11-15add REPT test caseZdeněk Crhonek
Change-Id: Ieae4e6606fad89611819f1a736139091e44977a3 Reviewed-on: https://gerrit.libreoffice.org/30879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-15tdf#103146 Revamp Extension Manager Dialog, Part 2Muhammet Kara
Move the "Remove" button which was customly implemented from the ExtBoxWithBtns_Impl to the new row. This should also solve some accessibility issues. Also wipe some useless code which implements custom tab behavior. Change-Id: I602fcf23631498145d8b9ead2936ee549caf3f0d Reviewed-on: https://gerrit.libreoffice.org/30867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15screenshotannotation: include image size in XML markupKatarina Behrens
Change-Id: I1c02055280b929ddd3ad12e6f6562c95bfe2a48a Reviewed-on: https://gerrit.libreoffice.org/30870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-15tdf#103785: Correctly position vertical glyphsKhaled Hosny
Change-Id: Ibd0ae230f54ada55a26d24ea865e7b93070ce2a0
2016-11-15Add the Target for xd:QualifyingPropertiesTor Lillqvist
Change-Id: Ic15c34c77ff24a506b59ed02db3cfbb6722d0f25
2016-11-15Sign also the xd:SignedPropertiesTor Lillqvist
Change-Id: If5793cd8a721ac5b4fce5280b6180f2827c72501
2016-11-15replace explicit delete and simplifyDavid Tardon
Change-Id: I750a965195aef32b29bb98725fd1c74c876b051d
2016-11-15fix typoDavid Tardon
Change-Id: I2dd093a12518c2c23d9f1610fb8a4b45a94656ab
2016-11-15remove prop. name variableDavid Tardon
It is not used consistently anyway. Change-Id: Ia842668dfb36dc2a8fbf3b938758b81c78d5c868
2016-11-15vcl PDF sign: add initial 'signing-certificate' signed attributeMiklos Vajna
Page 10 of "PAdES Basic" specification from <http://www.etsi.org/deliver/etsi_ts%5C102700_102799%5C10277802%5C01.02.01_60%5Cts_10277802v010201p.pdf> says: "At minimum, it [the signature] shall include the signer's X.509 signing certificate." This adds the signed attribute, but it's disabled by default as the value is just an empty sequence at the moment. Change-Id: Icda96f63618b08fadcb411204e132fe88d5f7d1d Reviewed-on: https://gerrit.libreoffice.org/30877 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-15fix build of kde3 addressbookCaolán McNamara
Change-Id: I109f6ff9ca35792d3337bac2a6612ba12d2272fd
2016-11-15Replace some trivial Sfx*Item derivations with make* functionsStephan Bergmann
...as the trivial derivations (used to offer "convenience ctors") didn't override Clone(), so -fsanitize=vptr would cause warnings like > sd/source/ui/dlg/layeroptionsdlg.cxx:42:26: runtime error: downcast of address 0x603001dff830 which does not point to an object of type 'const SdAttrLayerName' > 0x603001dff830: note: object is of type 'SfxStringItem' > 61 05 80 1e 70 d6 f7 22 67 7f 00 00 01 00 00 00 4e 6e 00 be 60 f8 df 01 30 60 00 00 02 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SfxStringItem' > #0 0x7f66931db4b0 in SdInsertLayerDlg::SdInsertLayerDlg(vcl::Window*, SfxItemSet const&, bool, rtl::OUString const&) sd/source/ui/dlg/layeroptionsdlg.cxx:42:26 when doing "Insert - Layer..." in Draw. Change-Id: I54ade09027daecc8bbf6f4789a8b5318bbe8d22d
2016-11-15tdf#103725: Default to GDI even with the new layout engineKhaled Hosny
It seems that our DirectWrite integration is missing few key features, so back to GDI so at least people who need these feature can have away to make them work. So the situation is now with the new layout engine is like the old one; GDI when OpenGL is not use and DirectWrite when OpenGL is used. Fixing DirectWrite is now someone else’s problem. Should also fix tdf#100986. Change-Id: I102cac8a324f77b050d5183911b5cfda0b6b8f2b Reviewed-on: https://gerrit.libreoffice.org/30868 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-15Resolves: tdf#102957 revert SetMinOutputSizePixel workaroundCaolán McNamara
of commit afeddaf7e0d11ad9b1df0c80bcc3f50caa87e21a Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Dec 16 10:46:10 2015 +0000 Related: rhbz#1281906 set a min size on un-resizeable non-layout dialogs and using a mixture of gtk_window_set_default_size before its visible, and gtk_window_set_default_size + gtk_window_resize after its shown now works for me under wayland so the original problem can be solved that way Change-Id: Iaf8fd3019a7e902ad07b6825f919c6f25288e9b7
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15fix tdf#101832 and tdf#100617Thorsten Behrens
OutDev mapmode takes shortcuts for 'simple' mappings, so clear that flag once we set scale/origin away from defaults. Change-Id: I00321e27322d9cb8b86e6cc8400f6396d03328cc Reviewed-on: https://gerrit.libreoffice.org/30855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-15sigh, then you can't shrink manually past size requestCaolán McNamara
Change-Id: Ia919f65f93a3dad0af06a2fa4f7b42b5f9ae2052
2016-11-15Revert some chart2 shader-affecting changesNoel Grandin
from commit 8d4a306eb04742f499ab693e7f8ebd3ae3c01415 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Nov 15 11:26:59 2016 +0200 loplugin:unusedfields and commit c79b7fd8d4e6e029cf8e6bfb2c7e10b52a4d5781 Author: Noel Grandin <noel@peralex.com> Date: 2015-11-20 10:41:00 (GMT) loplugin:unusedfields in chart2 Change-Id: I6b61aa9c6abb1d51e96d5eb6c623d86fd6fd5b82
2016-11-15Spurious whitespace at end of lineStephan Bergmann
Change-Id: I684f8ad46527ce13b8c19a52265af3a581dca6cb
2016-11-15fix buildNoel Grandin
after commit 0d051730156f633150fa9e3107fe97cf7be6d8f9 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Nov 15 09:13:33 2016 +0200 loplugin:constantparam Change-Id: Ia3e761168043e5a8d22793689e9f224a85a6b7ca
2016-11-15use only widget_set_size_request in gtk3Caolán McNamara
and remove some bogus out of date comments Change-Id: I589eb64016241cf2bcd425ccbaa62229f36880e8
2016-11-15Resolves: tdf#102957 revert SetMinOutputSizePixel workaroundCaolán McNamara
of commit afeddaf7e0d11ad9b1df0c80bcc3f50caa87e21a Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Dec 16 10:46:10 2015 +0000 Related: rhbz#1281906 set a min size on un-resizeable non-layout dialogs and setting a size-request seems to do the right thing for me now under wayland so the original problem can be solved that way Change-Id: Ie2dd71c5a32131a60729448f0665d5cae2a83692
2016-11-15loplugin:constantparamNoel Grandin
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15update lo-pack-sourcesjan Iversen
os-x has a problem with progress bar on tar Also remade to sed expression to a simpler one that osx understands. change change Change-Id: If09573760a4bedfa285519241582bbd639a4e976 Reviewed-on: https://gerrit.libreoffice.org/30043 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-15loplugin:unusedfieldsNoel Grandin
Change-Id: I1400ca0af2c357dff06e5f733ec62b13d6a96461 Reviewed-on: https://gerrit.libreoffice.org/30861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Add the missing lok::Office::registerCallback().Jan Holesovsky
Change-Id: I0aebf12c4d685f69f094b9acbe6b04bb5b3234a4
2016-11-15tdf#103725: Fix horizontal scaling on WindowsKhaled Hosny
* Create IDWriteFont from LOGFONT instead of HDC, as it seems the later will discard the font width. Without font width, GDI/DirectWrite will not scale the font horizontally. Does not seem to work with all Windows versions (at least not Windows 10 Anniversary Update), seems like this undocumented behaviour have been dropped :( * Adjusting font width on Windows during layout, see the inline comment. Change-Id: I19b788460b6b6ca2c83d75bbf09a0601a250c289 Reviewed-on: https://gerrit.libreoffice.org/30847 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-15tdf#34467 - FitToFrame: stretch text to fill drawing objJustin Luth
Help for Fit To Frame says "Resizes the text to fit the entire area of the drawing or text object". reverts commit b7628798ec1a966c97a64d7cf0aa9f3859b78bef and partially addresses the problem of "Shrink font automatically when text overflows" by treating text as "Autofit" while it is being edited. It's not WYSIWYG, but good enough, and maybe better. Since that part of the change prevents any way of setting ::Autofit, I also changed the default setting to Autofit instead of NONE, since there is no good reason why text should be allowed to spill outside of a textbox. For those who REALLY want that odd behaviour, they can use .uno:TextFitToSize (Ctrl-Shift-F8) to toggle between "stretch" and "none". Change-Id: I8313a82cbea82f11fad0f50d966fc77874977da9 Reviewed-on: https://gerrit.libreoffice.org/30727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-15New compilerplugins/clang unit testsStephan Bergmann
...to check that loplugin produces warnings/errors as expected: * Clang has a -verify switch that makes it easy to write test input .cxx files that list in comments all the warnings/errors that are expected, and let Clang check those expectations instead of generating object code. See include/clang/Frontend/VerifyDiagnosticConsumer.h in the Clang source tree for documentation. * Introduce a CompilerTest gbuild class that uses the existing LinkTarget class as much as possible. Checking the input files is implicitly phony, as the compilation step doesn't generate any object files, and the link step does nothing because there is no gb_LinkTarget_set_targettype for CompilerTest. The setup at least works for Clang on Linux (will need adaptions for Clang on Windows; compilers other than Clang are not relevant for now given this is used to check compilerplugins). * Definition of gb_CFLAGS_WERROR in solenv/gbuild/platform/com_GCC_defs.mk needs to be lazy ('=' vs. ':=') so that CompilerTest can override it: The Clang -verify mode wants the input files to specify whether the loplugin diagnostics are warnings or errros, so they consistently need to be errors independent of --enable-werror configuration. * A first (example) test is in compilerplugins/clang/test/salbool.cxx. The corresponding gbuild CompilerTest instance is in solenv/CompilerTest_compilerplugins_clang.mk for now. The reason for that odd split across compilerplugins/ and solenv/ is that there is no compilerplugins/Modules_compilerplugins.mk file, so this setup is the easiest hack for now (to be cleaned up). (Another area that could be improved is that all test files need to be listed explicitly in the CompilerTest_*.mk file, instead of, say, using all .c/.cxx/.m/.mm files in a specified directory.) * The test is run somewhat late during a top-level 'make', after loplugin has already been used in compilation. But it can be run manually (e.g., 'make solenv') when making changes to loplugin during development. Change-Id: I01e12fb84887d264ac03ef2484807458c2075af4
2016-11-15tdf#82824 DOCX import: fix at-char embedded object handlingMiklos Vajna
The anchor type of embedded object was simply not handled, we always assumed that it's as-char. When it's at-char set the anchor type accordingly, and also set the usual 6 properties determining the position of the anchored object. Change-Id: I3f8bede33c6f1a0bdc4f4d4ea59c4fc805802291 Reviewed-on: https://gerrit.libreoffice.org/30860 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-15tdf#96099 Reduce no of typedefs used for trivial containersChamal
OStringSet replaced with std::set< OString > Change-Id: Ifad06cd77c5c4123b85171df866ac10a3bea4705 Reviewed-on: https://gerrit.libreoffice.org/29803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-11-15loplugin:constantparamNoel Grandin
Change-Id: I1a6e13584ca516f44195e724b39e78360a842c7c Reviewed-on: https://gerrit.libreoffice.org/30859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15loplugin:countusersofdefaultparams in include/vclNoel Grandin
Change-Id: I16979e6d49e7f1ff7ea53194cfc64fddf27d00cf Reviewed-on: https://gerrit.libreoffice.org/30841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15tdf#88827 - double-thin border: MINGAPWIDTH is a valid widthJustin Luth
double-thin borders are available in the UI starting from 0.5pt. The actual minumum (as seen in a round-trip), is 1.10pt. (Each thin line is ~ .50pt, the gap is ~ .05pt, and then some approximations and rounding show it as 1.10 - at least that is how I understood it). 1.15pt is the first point at which the gap is larger than the minimum - and double_thins with a minimum gap were considered invalid, and thus were not imported. With this fix, double-thin borders created with a size less than 1.15pt are valid and visible on import. Change-Id: I6da2a40d13ed83281de403b22b3acbea4288ac60 Reviewed-on: https://gerrit.libreoffice.org/30857 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2016-11-15vcl: include redux in MapModeThorsten Behrens
Change-Id: Icc43510a3e561b426319465ea98eb374a3aa1f8d
2016-11-15vcl: cleanup whitespace in MapModeThorsten Behrens
Change-Id: Ib790bab105c337d62ffc93f72bf6da49a74f00cf
2016-11-15vcl: add/unify some clipboard SAL_INFO tracingThorsten Behrens
Change-Id: I4989da02cbc82d253a486a7adde95551eddb45b3
2016-11-15tdf#76296 Import MathML's <mspace>Takeshi Abe
as possibly multiple "~" and/or "`" by honoring its width attribute. Change-Id: I17e361c3f8f5d061c856b72266332369497d16b9 Reviewed-on: https://gerrit.libreoffice.org/30809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-15sc-perf: HasAttrChanged: save unnecessary calls to SfxItemPool::Get()Eike Rathke
SfxItemPool::GetItemState() can already return a pointer to a set item so that doesn't need to be obtained again through SfxItemPool::Get() tdf#103493 'LotroPlan 3.8.ods' https://bugs.documentfoundation.org/attachment.cgi?id=128252 Incl. Self Called Before: 10,210,820,257 1,162,295,513 34,670,201 After: 9,887,701,235 1,384,985,151 34,670,201 Only ~3% and 0.5% of the overall load time, but.. Change-Id: Icbed8a7982a27472fdfb1dbe4fd2061ab1e601bd
2016-11-14vcl PDF NSS sign: upgrade SHA-1 hash to SHA-256Miklos Vajna
Page 10 of "PAdES Basic" specification from <http://www.etsi.org/deliver/etsi_ts%5C102700_102799%5C10277802%5C01.02.01_60%5Cts_10277802v010201p.pdf> says: "The use of SHA-1 is being phased out in some countries and hence the use of other hashing algorithms is recommended." Change-Id: I1fbf4a194a24090b719322f3cb4f9d7eef58f134
2016-11-14avoid reallocating if allocating once is enoughEike Rathke
Change-Id: I30dbdd59304095c3a535af98217ddcb973ba0416
generated by cgit (git 2.34.1) at 2025-01-18 05:40:40 +0000