summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-05-29weld SfxCmisPropertiesPageCaolán McNamara
Change-Id: I3a824acd126dcbd3bde60ca9d68afd79cb708ed8 Reviewed-on: https://gerrit.libreoffice.org/73126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-29tdf#56738: fix encoding in comments in doc files (>= Word 97)Julien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=56738#c3 Change-Id: I8dbab3fe76b2c2d83cbb07509fabe9f784664c03 Reviewed-on: https://gerrit.libreoffice.org/73088 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-29ellipsize over-large locationsCaolán McNamara
Change-Id: I154f97d8e7f5688e9e81b8590f3dc0ab7d84c380 Reviewed-on: https://gerrit.libreoffice.org/73154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-29tdf#120412 character formatting UI: allow >100% raisingLászló Németh
in superscript/subscript text positions instead of changing the greater values (eg. imported from DOCX) to 100% by accident, simply using the character formatting window. Change-Id: I3adf6445070c183bd6005a02239962f18f504f9d Reviewed-on: https://gerrit.libreoffice.org/73151 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-05-29tdf#120412 DOCX filter: fix missing superscriptJozsef Szakacs
by editeng support of large superscript raising. Maximal raising of superscript text is 1584 pt in MSO, while LibreOffice didn't import the values greater than 100% of the current font height. Using the maximal percent value of the default 11 pt font, the limit is 14400% now, fixing most of the import problems. Greater raisings will be limited to 14400% during the DOCX import. Note: the standard doesn't limit the bigger percent values, see "20.374 style:text-position" and "18.3.23 percent" in OpenDocument 1.2. Change-Id: I3d0d08f273f2067180f74fba40c47d62364fcc59 Reviewed-on: https://gerrit.libreoffice.org/69164 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-05-29Avoid -fsanitize=nullability in external/zlibStephan Bergmann
...as seen during CppunitTest_sw_layoutwriter: > testUserFieldTypeLanguage::TestBody finished in: 1271ms [...] > workdir/UnpackedTarball/zlib/trees.c:873:42: runtime error: null pointer passed as argument 2, which is declared to never be null > /usr/include/string.h:43:28: note: nonnull attribute specified here > #0 in _tr_stored_block at workdir/UnpackedTarball/zlib/trees.c:873:5 > #1 in deflate at workdir/UnpackedTarball/zlib/deflate.c:1025:17 > #2 in ZipUtils::ThreadedDeflater::Task::doWork() at package/source/zipapi/ThreadedDeflater.cxx:163:15 [...] Change-Id: I7d4b68ab2c4fb3080fc48211236cb33ca4bf7126 Reviewed-on: https://gerrit.libreoffice.org/73143 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-29The iOS DataFlavorMapper::getAllSupportedPboardTypes() is unusedTor Lillqvist
Change-Id: Icc72fca62e189559956abc0ebbca9ce196a02073
2019-05-29tdf#124752: We do need to accept text/html from the system clipboardTor Lillqvist
Sadly we can't accept public.utf8-plain-text, i.e. text/plain;charset=utf-8, as the code does not know of such a SotClipboardFormatId. The only text/plain is UTF-16. And it probably is a good idea to accept HTML anyway. We have to continue to (I think) not offer text/html because of the assertion failure issue, see comment in DataFlavorMapper::openOfficeToSystemFlavor(). Change-Id: If5d77b97649424e347c50af10475c2be997c8632
2019-05-29Add a couple of SAL_INFOs about types available on the system clipboardTor Lillqvist
Change-Id: I821a699ee4f44881aadac89f265974a10095b544
2019-05-29tdf#114596 dbaccess: fix mysterious dataloss bug (part 2)Xisco Fauli
Same problem as in 96ae2a3300811897c24cccb20f8c2faf382483df Regression from 497e40ad03c27837978551ba15491c3fb2a0bf53 Change-Id: I00e7bf3559e688e7fbc5429ace2b5c18221c9890 Reviewed-on: https://gerrit.libreoffice.org/73146 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-05-29weld ScDocStatPageCaolán McNamara
Change-Id: I24d264f6318adfd9f67303d95b3b8fe0987f928a Reviewed-on: https://gerrit.libreoffice.org/73144 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-29tdf#122765: Legend interferes with pie chart after pptx import, second partTamás Zolnai
Revert of: 2903c5f59d257b6ab94f32df64513f2edf94fb0b Reverting this commit does not lead to the original bug to come back, so we can revert it without a problem. Change-Id: I244a6b9451c47e1094db8a77c71b6696e0c464cc Reviewed-on: https://gerrit.libreoffice.org/73139 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-05-29tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: Ib5459a365231514efa0e8a33a880857378cd239e Reviewed-on: https://gerrit.libreoffice.org/73121 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-29tdf#42949 Fix IWYU warnings in opencl/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I0aedc40c49c8cb1382f45571f54873d6017ec62c Reviewed-on: https://gerrit.libreoffice.org/72637 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-29writerfilter: various small cleanupsMiklos Vajna
Some parameters were passed by value for no reason, it's always a good idea to declare a variable at the point where we can also initialize it, etc. Change-Id: Ia07bbef7826132fa0326445b89fcaf48dd38b11b Reviewed-on: https://gerrit.libreoffice.org/73125 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-29tdf#120905 Add missing doxygen comments.Gülşah Köse
Change-Id: I3211f32521d578b1a5f72df7c5ccc4267ee01d38 Reviewed-on: https://gerrit.libreoffice.org/73101 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-29SmartArt: sort shapes by Z order after layout algorithmsGrzegorz Araminowicz
so that they are laid out in correct order Change-Id: I82baa61311197880654d09f356decc666e6fa4c7 Reviewed-on: https://gerrit.libreoffice.org/73094 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-29tdf#125372 writer, file with lots of hints very slow to open, part4Noel Grandin
Takes load time from 4m to 3m Use equal_range to give us a start and an end, so we avoid the operator< cost while scanning Change-Id: Ie57d460237cddaacecdc6032136f614e02d13760 Reviewed-on: https://gerrit.libreoffice.org/73124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-29NB tabbed layout update in all appsandreas kainz
Change-Id: Ic291a6f9907e2449093469ae8a899093dc296e26 Reviewed-on: https://gerrit.libreoffice.org/73127 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-29Removed duplicated includeAndrea Gelmini
In any case is included a few lines after, so I guess it can be removed the check (if it's not ready also for future other includes). Change-Id: Id603022092a60b71a5b35ec57930146d23c6544a Reviewed-on: https://gerrit.libreoffice.org/73093 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-29Fix typoAndrea Gelmini
Change-Id: Ib79782671d890100318a92bb4718e190d735e579 Reviewed-on: https://gerrit.libreoffice.org/73128 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-29Fix typoAndrea Gelmini
Change-Id: Ib504a5243edd5df96a0f4ff8f7f846e83d384a7b Reviewed-on: https://gerrit.libreoffice.org/73130 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-29Fix typoAndrea Gelmini
Change-Id: Ic94aaada392b197e3fa955ec5b51ca8106347a38 Reviewed-on: https://gerrit.libreoffice.org/73133 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-29Fix typoAndrea Gelmini
Change-Id: I677f7d50d6b93993f6e3d47426434eb570965b7c Reviewed-on: https://gerrit.libreoffice.org/73129 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-29Fix typoAndrea Gelmini
Change-Id: Ibfaba910db1ef59af68f57e52a683b5ef147e5a6 Reviewed-on: https://gerrit.libreoffice.org/73132 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-29Fix typoAndrea Gelmini
Change-Id: I217ece9296e5e5d8db264a3590e5af1f8ab0cfcb Reviewed-on: https://gerrit.libreoffice.org/73134 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-29Fix typoAndrea Gelmini
Change-Id: I3414f8badfbab89d0cab72e51fb4dcafc85b35e4 Reviewed-on: https://gerrit.libreoffice.org/73136 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-29Fix typoAndrea Gelmini
Change-Id: I5ce7f422fc6d26eb451ba43fe7bc6f8a540e7d8a Reviewed-on: https://gerrit.libreoffice.org/73131 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-29Fix typoAndrea Gelmini
Change-Id: Ib1af986d52bbc4ea7e2ee7dc5964da81e6508265 Reviewed-on: https://gerrit.libreoffice.org/73137 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-28drop unused boxCaolán McNamara
copy and paste from the normal document info page I imagine Change-Id: Iff40fbf2b4d21dd3d51c63cb6068b0b88b5438ed Reviewed-on: https://gerrit.libreoffice.org/73115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28drop some unneeded includesCaolán McNamara
Change-Id: I42b2ccbb4484ab2acb8208ad88c6f22e4af09f7d Reviewed-on: https://gerrit.libreoffice.org/73114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28weld SfxCustomPropertiesPageCaolán McNamara
Change-Id: I1b1ba1c2b879d270eb3af486a4d006f170d1b92e Reviewed-on: https://gerrit.libreoffice.org/73111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28tdf#124752: Simplify the iOS DataFlavorMapping thing a lotTor Lillqvist
Now it works to copy and paste images (PNG ones at least) between the iOS Collabora Office app and other apps. We don't seem to need the PNGDataProvider after all, as we use it only for data that is already in PNG format. Possibly I am missing somethin, though. Change-Id: Ia6bcc8aefbe1a6687f13e28454b96658fc66c856
2019-05-28tdf#124752: Reduce number of formats offered on clipboard on mobile devicesTor Lillqvist
It seems a bit pointless to offer formats that no other app will use. Change-Id: I54474a4ba40d91c184592cede4224cbfbb78d518
2019-05-28tdf#124752: Use best speed for PNG encoding on iOSTor Lillqvist
Still awfully slow for "realistic" images as taken by modern digital cameras, though. It would be much better to not encode the PNG to put on the clipboard from the internal bitmap representation, but use the ooriginal PNG or JPEG data. Change-Id: Ib72a573bd31d4ae7380dacccb4287e19afabb0d4
2019-05-28NB: add tabbed_compact and contextual NB to Drawandreas kainz
Change-Id: Ibdca2026f29483948c2fafaf499a82d2a4acf08b Reviewed-on: https://gerrit.libreoffice.org/73095 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-28sw: implement select-all for the frame shellMiklos Vajna
There is no reason why Ctrl-A should be a NOP when you have an image selected. No test, there is one in the cp-6.0 copy&paste code, that coverage will arrive as part of that copy&paste code forward-port. Change-Id: If0013ee0e9ff9a6fb038a22de7b5d3c76e5c52b9 Reviewed-on: https://gerrit.libreoffice.org/73118 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-05-28tdf#125326 add photoalbumdialog icon to breeze, sifr and colibreandreas kainz
Change-Id: I33e7882ed2792a9d1f23ee42645efc4f5003f01d Reviewed-on: https://gerrit.libreoffice.org/73099 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-28SmartArt: simplify text body empty conditionGrzegorz Araminowicz
Change-Id: Ie1c14bdc4f4db6f8f919433d40ea2281736c38ed Reviewed-on: https://gerrit.libreoffice.org/73097 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-05-28NB Draw add tabbs for 3D and MasterPageandreas kainz
Change-Id: I51bf435b555302fe96493f540f5e5a8dc33d0267 Reviewed-on: https://gerrit.libreoffice.org/73081 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Remove xml comments from file xml comments inside <bookmark> index are moved as is to Pootle and are not handled as comment when brought back to translated file. Change-Id: I040cf84851dea3feea26054cb9a0a20e1241c53b Reviewed-on: https://gerrit.libreoffice.org/73112 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-28tdf#120905 Remove old FuOutlineBullet dialog code.Gülşah Köse
Change-Id: I4bd0986f23414edc857ca890f6437c6029116e72 Reviewed-on: https://gerrit.libreoffice.org/73070 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-05-28Avoid -fsanitize=signed-integer-overflowStephan Bergmann
...with e.g. `--convert-to pdf abw/abi10006-1.abw` as obtained by bin/get-bugzilla-attachments-by-mimetype, reporting > vcl/source/fontsubset/cff.cxx:1697:63: runtime error: signed integer overflow: 55810 * 52845 cannot be represented in type 'int' and > vcl/source/fontsubset/cff.cxx:1137:38: runtime error: signed integer overflow: 233492066 * 52845 cannot be represented in type 'int' Using unsigned here is faithful to the algorithm presented in Chapter 7 Encryption of "Adobe Type 1 Font Format" (<http://wwwimages.adobe.com/ www.adobe.com/content/dam/acom/en/devnet/font/pdfs/T1_SPEC.pdf>). Change-Id: Ic27a5ebbe5f766fef425d241e14487ea4ae81da4 Reviewed-on: https://gerrit.libreoffice.org/73104 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-28ScNumberFormatControl uses an SfxUInt16ItemStephan Bergmann
...not an SfxInt16Item. Probably a typo introduced when adding the class with bf3f3a6bfb08c2d1a2c95f1c1cf62117e0002235 "notebookbar: working number format listbox". (Found with -fsanitize=vptr when switching Calc to "View - User Interface - Tabbed Compact".) Change-Id: I6142b20750872037767e1857edeae83b1b2fa849 Reviewed-on: https://gerrit.libreoffice.org/73089 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-28Fix typos (including sequenze->sequence)Andrea Gelmini
Change-Id: Icfd6c5cbc405bad51a0d7f10cdb55c70a1fe5b00 Reviewed-on: https://gerrit.libreoffice.org/73078 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-05-28uitest for bug tdf#119343Zdeněk Crhonek
Change-Id: I45aa7b4fda0f19319d3e009bf8d29099e8497c71 Reviewed-on: https://gerrit.libreoffice.org/73067 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-05-28lo: disable under-used hyperlink fields that are buggy online.Michael Meeks
Reviewed-on: https://gerrit.libreoffice.org/72781 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 418adc09f503a5714f58f56619161fed6d668088) Change-Id: If2069288fac14c6113754288eb9136449626393d Reviewed-on: https://gerrit.libreoffice.org/72782 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-28tdf#125372 writer, file with lots of hints very slow to open, part3Noel Grandin
There were O(n^2) issues all over the places where we walk these lists. This takes the opening time from 10m+ to 4m. (*) Invalidate the sorting on a much less aggressive basis, by having the SwTextAttr objects tell the SwpHints object when start and end pos changes (*) Add a bool field to indicate when the maps become unsorted, so we can resort them only when we actually need sorted access (*) Add an API for walking the list of SwTextAttr* without triggering sorting, which is particularly important when the RedlineManager starts moving things around. (*) Add various asserts to catch code that tries to iterate over these sorted lists but triggers resorting during the loop. I also moved some of the logic around so that instead of update hint delete hint insert hint it now goes delete hint update hint insert hint which means that the needToSort flag does not get set because the hint is disconnected while it is being updated. Change-Id: Ie153ddafc9ef9e3470d588db2be2457c676232a8 Reviewed-on: https://gerrit.libreoffice.org/73090 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-28tdf#92335 DOCX: fix multiplying of "ListLabel" stylesLászló Németh
by removing the redundant export of the temporary DOCX import character styles for bullets of bulleted lists. Note: this commit will fix the older documents – sometimes with thousands of unused styles – by the next export. The problem was escalated from the commit f9c8d97d82a85b897520a2fe897352ee5ad879d9 "tdf#95213 DOCX import: don't reuse list label styles" Change-Id: I90590352c0c85a92dbad19a45e82339e1201f1e9 Reviewed-on: https://gerrit.libreoffice.org/73098 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-05-28Qt5 implement SalSurface support for cairoJan-Marek Glogowski
Current qt5+cairo uses the plain VCL canvas. This patch is just a copy of Gtk3Surface (minus comments) with a different update call. This way the Cairo path now uses the Cairo canvas instead. It fixes at least tdf#122668 for me, but other Impress bugs might be fixed this way too. Change-Id: Iba511c851001753328293c28e53eaa4acc4315d0 Reviewed-on: https://gerrit.libreoffice.org/72921 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Aleksei Nikiforov <darktemplar@basealt.ru>