summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-10-29convert usages of DPIScalingFactor from int to floatTomaž Vajngerl
Change-Id: I049b3d2cde4dcb8c8c0690d75a015a43cb71b0c0 Reviewed-on: https://gerrit.libreoffice.org/30381 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29HiDPI: remove more unneeded scaling of iconsTomaž Vajngerl
Change-Id: I521024af62ea15db80f5e851875b18dcf18556e4 Reviewed-on: https://gerrit.libreoffice.org/30380 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29tdf#100164 change scaling unit to precentage for *.5x factorsTomaž Vajngerl
Currently we support DPI scaling by a integer factor. This commit changes that to percentage so we can have scaling factors like 1.5x or 1.25x. This is useful with 2.7k monitors that are in between standard DPI and HiDPI. Thresholding was adjusted to scale to 1.5x when DPI is between 120 and 168 DPI. The old method GetDPIScaleFactor has been changed to return a float value insted of int. Sometimes it is however more accurate to use GetDPIScalePercentage which was added in this commit. Change-Id: Iaecee793ff3d5084d00adeebbcf5d7368c580882 Reviewed-on: https://gerrit.libreoffice.org/30379 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29surpress automatic scaling / conversion for document shadowTomaž Vajngerl
Change-Id: Ib020161db8d5e241e923dcd629a9a4e4bb4c23da Reviewed-on: https://gerrit.libreoffice.org/30342 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29add HYPGEOMDIST test caseZdeněk Crhonek
Change-Id: I996161ff95fb682f3a9bb62fe6444be96fd6fd3f Reviewed-on: https://gerrit.libreoffice.org/30355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-29add LOGINV test caseZdeněk Crhonek
Change-Id: Ie05a462418322aac43f36c069749fdae195a8585 Reviewed-on: https://gerrit.libreoffice.org/30354 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-29vcl: add bitmap::loadFromResource with additional flagsTomaž Vajngerl
Sometimes we want to surpress automatic scaling and converting for dark theme. This adds a loadFromResource function with additional flags which makes this possible. Change-Id: I893cee82ad6942644755f0c5b772fb5f073bbf00 Reviewed-on: https://gerrit.libreoffice.org/30341 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29HiDPI: remove unneeded image scaling when HiDPI is enabledTomaž Vajngerl
We don't need to scale images for HiDPI mode anymore - this is now done automatically when the image is loaded. Change-Id: Ie285cf4d672f4c098a468d3f7560ee2700365b92 Reviewed-on: https://gerrit.libreoffice.org/30340 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29tdf#51733 support SVG icon theme, disk cache and scaling / darkenTomaž Vajngerl
Also resolves tdf#92248 This extends icon name resolving so that is in addition tries to find an icon with the "svg" extension and load that instead of stated (mostly "png") extension. If the filename extension is "svg" we load the icon with the SVG filter instead. This also adds icon scaling and conversion for HiDPI or when a dark theme is wanted. If the SVG icon is available, we render it at a higher resolution instead of scaling As loading of SVG icons can be computatunally expensive, a icon disk cache was added. This saves the rendered SVG as a PNG image into the "cache" folder. The same caching is also used for HiDPI and dark theme converted icons so we don't always scale or convert the icons. In addition some style changes and DRY fixes were made to the ImplImageTree source code. Change-Id: I9e421395a342ffe8da9facea7ea06e5db2778b26 Reviewed-on: https://gerrit.libreoffice.org/30339 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29display matching search per selected category, tdf#67974 follow-upEike Rathke
Also select category All while typing in Search, and display the LRU list independently. Change-Id: I8a734cc202e017d3a10d8a6f89b1814073a77c81
2016-10-29tdf#103753: DOCX: Handle relative positions to left or right marginTamás Zolnai
Positioning relative to left or right margin in MS Word works the same as the positioning relative to left or right page border in LO Writer. Change-Id: I476a5e9e76f766b7fb7f1c7f4a068af8bb3c8813 Reviewed-on: https://gerrit.libreoffice.org/30376 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-10-29Add layout engine info to the About dialogKhaled Hosny
Change-Id: I6a87efa5e1072bac3588226df0e1351aa51c4d0d Reviewed-on: https://gerrit.libreoffice.org/30108 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-29tdf#103473: Ensure positive rectangle sizeMike Kaganski
Also remove conversion of both negative scales into rotation, because it is handled by flip; use strict comparison instead of approximate float less because it's correct here, and also because basegfx::fTools::less ultimately uses rtl_math_approxEqual, which description states: attention approxEqual( value!=0.0, 0.0 ) _never_ yields true. Unit test included. Change-Id: Ia878fce360cf8aed539d95f2d4a1a3ad94379978 Reviewed-on: https://gerrit.libreoffice.org/30373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-10-29filter hidden functions also in search, tdf#67974 follow-upEike Rathke
Change-Id: Iaa23759e01d8f86bfc5c0bbd8b333cd331b7b8cd
2016-10-29tdf#67974 UI: Add a search box in function wizard in SpreadsheetAbhilash Singh
Change-Id: Idd243824a25ba99b2163f094c531dad7fe1153c8 Reviewed-on: https://gerrit.libreoffice.org/30118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-29crashtesting: piles of pdf import crashesCaolán McNamara
e.g. ooo112863-2.pdf Change-Id: I359f7e50f416f0a756e16099cdf47be3b1c32d90
2016-10-29tdf#33278: Enable UI for vertical left-to-rightKhaled Hosny
Used mainly for traditional Mongolian. This has been disable since 2010 (shortly after the code was merged): commit faf68cc7565cb2662d4ed5b5902ec52975d99865 Author: Mathias Bauer <mba@openoffice.org> Date: Fri Jun 25 11:10:43 2010 +0200 CWS mongolianlayout: disable new direction until problems are fixed No idea what the problems are, but lets enable it and see what happens (the actual layout code have been enabled all the time and one can always manually craft ODT files that use it anyway). Change-Id: Id38d1735013d451f9fe116876483df3484dec051 Reviewed-on: https://gerrit.libreoffice.org/30364 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-29tdf#41542 rename variable to match LO5.4 terminologyJustin Luth
Changing /Allow_*Spacing_*Without_*Borders/I to AllowPaddingWithoutBorders related to tdf#103275 where "spacing to contents" is to be changed to Padding. Rename this already in LO53 to simplify potential backports and laying other groundwork for fixing this bug. Also, I can easily see setting AllowPaddingWithoutBorders globally in 5.3 for the purpose of being able to share documents when the UI in LO5.4 permits creation of padding without borders. Otherwise older versions will display significantly different formatting. Change-Id: I253173274f824a019ebc09a039c471d170c1be73 Reviewed-on: https://gerrit.libreoffice.org/30372 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2016-10-28vcl: move method to the appropriate file, some C++11-ificationTomaž Vajngerl
Change-Id: If51d16673c8b241487cae5305e293f213b7db5cb Reviewed-on: https://gerrit.libreoffice.org/30338 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-28sc: remove antique reference counting hacks from ScDocumentPoolMichael Stahl
This attempt to prevent overflowing a 16-bit counter was obsoleted by the conversion of SfxPoolItem's reference count to ULONG in 2001 or so. Change-Id: Iafb6f151f68cbb84fda59bd134a7a4930f9a4d1f
2016-10-28svl: change SfxPoolItem ref-count to sal_uInt32Michael Stahl
Fixes the inconsistency between potentially 64-bit sal_uLong and the max-value macros that are ~2^32. Change-Id: I895c674819cf4766cb2c7441f670bc1305362a74
2016-10-28svl: more SfxPoolItem assertsMichael Stahl
Change-Id: Ic73fe09fc401359f043269fc8e5a1910fc8ddb02
2016-10-28svl: SfxPoolItem reference counting assertionsMichael Stahl
Change-Id: Ice2ec9a4592a1fad36913ae7d089aa8c63dfc669
2016-10-28tdf#98879: Fix vertical text on Windows for the new layoutKhaled Hosny
The DirectWrite rendering code wasn’t handling vertical text correctly at least when used with CommonSalLayout. It has been fixed and now made the default. We are also doing all vertical text handling on our own, so loading special vertical fonts on Windows is now disabled. Change-Id: I10d150367fe59c77459bb1b813b6f31a0ff0c5d0 Reviewed-on: https://gerrit.libreoffice.org/30346 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-28reset border should clear all bordersJustin Luth
If no borders were originally defined, the reset button was failing to clear the last-selected border line. Eg. page border, click on two of the borders, then hit reset. One border remains defined, and didn't reset to the starting value of non-visible. Because one border was still "selected", it became visible again as SelStyleHdl_Impl reinitialized. Change-Id: I2d20ae1e02816d5b30fe126572b54e7083114fc3 Reviewed-on: https://gerrit.libreoffice.org/30365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-10-28loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I70ba8d3b03c56a597785f109f0cb687bd936bc64
2016-10-28xmlsecurity PDF verify: start using offsets from xref streamsMiklos Vajna
This is needed (but not enough) to verify PDF 1.5 signatures. What's missing next is support for object streams. Change-Id: I5afec0a77839ffabe0aaa07e367064210535a1a9
2016-10-28xmlsecurity PDF verify: initial support of cross-reference streamsMiklos Vajna
This adds support for cross-reference streams (which can be used instead of plain-text cross-reference tables) + also one stream predictor. The actual parsed data is still not used, though. Change-Id: Ia806abd8a97636a1bd25dfdafea377b088800f00
2016-10-28tdf#63846 assign macros after VBA project fully loaded.Justin Luth
fixes regression caused by d4743045a0b320449d07a957463a76bb8b13f939. see the documentation for VbaMacroAttacherBase, which indicates that the macros are to be attached after all objects are finished loading. Made attachMacros() public so it could be called separately since so many things are inter-dependent in the logic flow. Change-Id: I11f7f4a1a75d6f77a97e12e3359d6ea8a995f518 Reviewed-on: https://gerrit.libreoffice.org/30337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-28add MAX test caseZdeněk Crhonek
Change-Id: Ie32504b84e227cc3f33d89ec46bca1835e433844 Reviewed-on: https://gerrit.libreoffice.org/30352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-28loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Ib75f2c8c06c6219aa0f2a8b2b29d19fb95e09527
2016-10-28tdf#103544: DOCX exp.: Image loss when have a frame anchored to the same para.Tamás Zolnai
Regression from: 83d51e5e52688c4c9bc0ad70a511458bb06a242d Partly revert the commit causes this regression. I checked the related bugs (tdf#78590,tdf#80748) intended to be fixed by this commit and reverting this part does not bring back the corruption. I guess something changed in frames' and text boxes' import in the meantime, because this MergeMarks::IGNORE is useless now. Change-Id: If17776e8628561961c7ce2a2994e3fc609f75639 Reviewed-on: https://gerrit.libreoffice.org/30351 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28tdf#89329: use unique_ptr for pImpl in fpicker/Rohan Kumar
Change-Id: I4a5db5ceafe509bffc32a8800ab3d678f41244f7 Reviewed-on: https://gerrit.libreoffice.org/30309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28note yet another color selectorCaolán McNamara
Change-Id: I781da1ec218148dcb723db04dfe6ef3eacffe293
2016-10-28ImplInitMenuButtonData can be folded into ctor nowCaolán McNamara
because theres no ResId loader anymore Change-Id: Id90786d710fe75e47c162fd00ad7fd672b9cee30
2016-10-28only draw menubutton separator when two sides do something differentCaolán McNamara
Change-Id: If6e3b72eacef2325f9f30770bbed32c627bc035c
2016-10-28the case without a separator is as a Toolbox itemCaolán McNamara
Change-Id: I948a63ab9741aa89738b5e44b0ec0e078d0faaa0
2016-10-28rename and explain the MENUBUTTON_MENUMODE_TIMED stuffCaolán McNamara
Change-Id: Ifc6ddfb0cc249e537c01f28bab84b42c6b1577d9
2016-10-28these need to be VclPtrsCaolán McNamara
Change-Id: I83616728289e398c97e50f33b5dd1de404deaa27
2016-10-28fix leakCaolán McNamara
Change-Id: I5bc8efa8a9de6d7a2be99f6c816e3dfca4f2b390
2016-10-28can do this in one stepCaolán McNamara
Change-Id: Iab4798b34018a272a68d3d1a206dfbeef6ff19ca
2016-10-28these usings are unnecessaryCaolán McNamara
Change-Id: Ieeb753b700631958ad101354406b13863b3bab03
2016-10-28tdf#103507 quickfix: Automatic selection of Oracle Java runtime on WindowsStephan Bergmann
...which had been broken since 5e9a2e9b0f33ab50aa3a84728db75383aede19d9 "Check each potential JRE location only once", as jfw_findAndSelectJRE calls jfw_plugin_getAllJavaInfos on each vendor in turn, but that now only operates on any items newly added by addAllJREInfos, so the first call to jfw_plugin_getAllJavaInfos (with sVendor being "Sun Microsystems Inc." unsuccesfully operated on all items, and the next call (with sVendor being "Oracle Corporation") didn't see any further items to operate on. So the quickfix (at least for any Java runtimes by Oracle) is to reorder the vendors in javavendors_wnt.xml. The proper fix will be to reorder the code so it obtains the list of all Java runtimes only once, and then matches that list against the known vendors. (Other plaforms appear not to be affected by this issue. Some jvmfwk/distributions/OpenOfficeorg/javavendors_*.xml already sort Oracle first, anyway. And e.g. on Linux, jfw_findAndSelectJRE typically already succeeds with calling jfw_plugin_getJavaInfosFromPath and so doesn't reach the problematic code. Change-Id: Ied571ae1d4745d53ce0c8697d0f1b268e1aac407
2016-10-28sd: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Id2dc5762668b7c3f78f0a0a1ede97d4ac63fab5d
2016-10-28coverity#1371275 Missing move assignment operatorCaolán McNamara
Change-Id: I6c47c797d2654506bdc95c35b2558ce812f4070d
2016-10-28coverity#1371262 Missing move assignment operatorCaolán McNamara
Change-Id: Ibb430a683f818add50facc23ac2893b558bff70c
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28tdf#103514: Always ignore bitmap fonts on WindowsKhaled Hosny
We should never see any bitmap fonts now, so all the Courier stuff can go away. Since we never list the bitmap fonts in the first place, the old code for replacing some of them with scalable equivalents never kicks in. We instead implement PreMatchFontSubstitution hook for the same effect. Change-Id: I54f3c068bcd64554ed3498f4ba5b0f76bbd38589 Reviewed-on: https://gerrit.libreoffice.org/30345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-28tdf#98587 Inconsistency menu/shortcut for layer visibilityUlrich Gemkow
Changed author, patch was received by htietze. Change-Id: I1962930c5c9c6eea4731a83147a7705d24c20b8e Reviewed-on: https://gerrit.libreoffice.org/30322 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>