summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-30No apparent reason to limit nLineHeight to sal_uInt16 instead of longStephan Bergmann
Change-Id: I6431da3ff753feadead8f59119f502b54669fdc3
2018-01-30No apparent reason to limit nFontHeight to sal_uInt16 instead of longStephan Bergmann
Change-Id: Id2cf2c667871e551082e00424d36aef481f5819c
2018-01-30No apparent reason to limit nYStep to sal_uInt16 instead of longStephan Bergmann
Change-Id: I31ce86926d01e641f517beba3b3a784402ddaa1c
2018-01-30No apparent reason to limit nXStep to sal_uInt16 instead of longStephan Bergmann
Change-Id: Iee74da2f6e58fa809b068675c250c0445d9adf58
2018-01-30No apparent reason to limit nYMiddle to sal_uInt16 instead of longStephan Bergmann
Change-Id: I58958b7c7eae9f764cd88d3c1e3ca175af9fc370
2018-01-30No apparent reason to limit nXStart to sal_uInt16 instead of longStephan Bergmann
Change-Id: I6775c36c9b0eb3b1e56968b4ca212fcd43a3be1b
2018-01-30No apparent reason to limit nYStart to sal_uInt16 instead of longStephan Bergmann
Change-Id: I471eca407cb45daba62d679c8c43fb37d98dd762
2018-01-30No apparent reason to limit nWidthRelation to sal_uInt16 instead of longStephan Bergmann
Change-Id: I946e2a74ac5f03132791132e8d5b07d573cb76c5
2018-01-30No apparent reason to limit nYMiddle to sal_uInt16 instead of longStephan Bergmann
Change-Id: I3c1d082c99af94078a0a1505d3e69368aa5070ab
2018-01-30No apparent reason to limit nNumberXPos to sal_uInt16 instead of longStephan Bergmann
Change-Id: Ic46fbb6ca905cc93943927117aa8c70beebee5a4
2018-01-30No apparent reason to limit nTextOffset to sal_uInt16 instead of longStephan Bergmann
Change-Id: Idbd4e4aae63441537aff243d852272739b73f78e
2018-01-30No apparent reason to limit nBulletWidth to sal_uInt16 instead of longStephan Bergmann
Change-Id: I7ce0705e9edd5cff4e6c6977909d7e903f6e1765
2018-01-30Move long vs. sal_uInt16 mismatch out of lcl_Draw{Graphic,Bullet}Stephan Bergmann
...in preparation of getting rid of the mismatch Change-Id: I650a94ec043c4ce2763070a3441f08c0a77e7c73
2018-01-30Introduce name for one specific use of USHRT_MAXStephan Bergmann
(and use SAL_MAX_UINT16 instead, as the variables involved are actually of type sal_uInt16) Change-Id: Ibdd22c10bb70ae9d0ebfc5f49e736f390b694862 Reviewed-on: https://gerrit.libreoffice.org/48915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-30Don't let PythonTest_solenv_python fail due to Emacs lock files in SRCDIRStephan Bergmann
Emacs has a habit of placing lock files next to files being edited, which are actually dangling symlinks not pointing at actual files, but where the symlink content itself encodes some information about who locked the file. When such a lock file happens to be present in the source tree during `make PythonTest_solenv_python`, the latter fails because shutil.copytree by default copies files pointed at by symlinks, instead of the symlinks themselves, and causes an error if that fails. An alternative fix would be to call shutil.copytree with symlinks=true (copy symlinks, not the files pointed at) or ignore_dangling_symlinks=true (don't fail if a dangling symlink can't be copied). But for now just don't copy any of those additional files that Emacs likes to place next to edited files (and which are also all ignored in our .gitignore). Change-Id: Ib731a5395fe8d40767878c17b1fb422b914bb329 Reviewed-on: https://gerrit.libreoffice.org/48898 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-30Fix compilation with GCC 4.8Milian Wolff
Workaround a bug in variadic template parameter pack expansion in lambdas that affects GCC 4.8. The workaround expands the pack outside the lambda into a custom functor that then calls readIpcArgs. Change-Id: I7a2d8572a6f2b330bb22a4f18f5cc13fd7ef9b45 Reviewed-on: https://gerrit.libreoffice.org/48895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-30Updated coreOlivier Hallot
Project: help 875dbb65c79bd52049c270197aaa71cc243821fb New Help: Add donation link for online version Change-Id: I340362a70ecc115565c7fd7cb2be1a5d0fbb5599 Reviewed-on: https://gerrit.libreoffice.org/48929 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-30tdf#114821 calculate better label positionSzymon Kłos
Positioning hack was improved. It calculates position depending on direct chart size factor. Preffered label positions are: top - vertical, and center - horizontal Change-Id: Ic25f08cd0bc3105fe34841dbc3f8aacacb694d43 Reviewed-on: https://gerrit.libreoffice.org/48909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-01-30Updated coreIlmari Lauhakangas
Project: help e37c19a9dd3f2d3e5a31f91975ee5a8aac2dc2af Switched from list.js to fuse.js and paginathing.js Fuse.js has Apache License 2.0 and paginathing.js has Expat License (aka MIT). Paginathing is a paginating utility and it was originally jQuery, but due to performance concerns I converted it to pure JavaScript and rather brutally adapted it to our needs. Fuse.js gives us fuzzy search with multiple strings. The settings can be refined, if needed. Settings can be easily tested with the live demo: http://fusejs.io/ Change-Id: I1cf6a6f7d06adbcac95760db90187ee26be8e908 Reviewed-on: https://gerrit.libreoffice.org/48906 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-30Remove shared mxComponent in scimportdescriptorbaseobjJens Carl
Change-Id: I11e80ca9e985650db783a8bee6b0334ec5be0d4c Reviewed-on: https://gerrit.libreoffice.org/48885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scheaderfootercontentobjJens Carl
Change-Id: Id4546f47af5729f9ba074423c9656f757d739448 Reviewed-on: https://gerrit.libreoffice.org/48883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scfunctionlistobjJens Carl
Change-Id: I7fe5778afb397d62d9a7530fc094dd97011fbca7 Reviewed-on: https://gerrit.libreoffice.org/48882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scfilterdescriptorbaseobjJens Carl
Change-Id: If92339f38bdb24e364fd378de772fa714f73e380 Reviewed-on: https://gerrit.libreoffice.org/48881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in sceditfieldobj-headerJens Carl
Change-Id: I32c881c263698c04cf39b7ce6389207b30fefdcf Reviewed-on: https://gerrit.libreoffice.org/48880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in sceditfieldobj-cellJens Carl
Change-Id: I13065c1d73813359e21bdbc708d4c0fdb9720ba3 Reviewed-on: https://gerrit.libreoffice.org/48879 Reviewed-by: Jens Carl <j.carl43@gmx.de> Tested-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scdocumentconfigurationobjJens Carl
Change-Id: I74004064d65307e3d4ddcd02a22f8e297aac7bb4 Reviewed-on: https://gerrit.libreoffice.org/48878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scdatapilottablesobjJens Carl
Change-Id: I0648bab36217a63155e78e4f4bb56da93fde888f Reviewed-on: https://gerrit.libreoffice.org/48876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Avoid GPG when --enable-mpl-subsetTor Lillqvist
Change-Id: I91bf310c77927e24c0693dc5b0b1297f11c001a0
2018-01-30Every AC_MSG_CHECKING executed should have a matching AC_MSG_RESULT executedTor Lillqvist
Also, the message displayed by AC_MSG_CHECKING is prefixed with "checking ", so adjust to get correct grammar. Change-Id: I3bc109699486949256a772c6aa44b9f780e4d55b
2018-01-30Use for-range loop for SdrMarkList::ClearJulien Nabet
instead of calling n times GetMark Change-Id: I5a00fd039d42b45dd491d8927dc1e44fe559ce3a Reviewed-on: https://gerrit.libreoffice.org/48886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-30ofz#5822 Divide-by-zeroCaolán McNamara
Change-Id: Ibfffd57f74b579f869115ad961aa2ec9b35faca3 Reviewed-on: https://gerrit.libreoffice.org/48889 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-30ofz#5825 tweak max table in table depthCaolán McNamara
Change-Id: If56bbef6d6560294bd5c2b87b6aa50382dd30a07 Reviewed-on: https://gerrit.libreoffice.org/48894 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-30Clarify that links to other files can also be external resourcesEike Rathke
Change-Id: Iea299f0b895e77116623dff22fd49727b8c5c83c
2018-01-30Update liborcus to 0.13.2.Kohei Yoshida
Change-Id: I485757eb743e066730509202a3c077e5d822a311 Reviewed-on: https://gerrit.libreoffice.org/48863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-01-30Remove obsolete patchMike Kaganski
A leftover from commit 147cb6a2ae63debed3dd500e19b2776cebbc0031 Change-Id: I1744f87dfe508aea6cb17b4411594dad5771b028 Reviewed-on: https://gerrit.libreoffice.org/48877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-30tdf#115090 prevent SfxBaseModel destruction during notificationsThorsten Behrens
Additionally ensure refcount stays above sea level while notifying clients (who might dispose their own references, causing our own refcount to drop to zero). Otherwise, 2nd loop in postEvent_Impl() might already operate on freed mem. Change-Id: Ie06de9ea33f7e2e334e0ef39d13c50009261791e Reviewed-on: https://gerrit.libreoffice.org/48871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-30Use new property FormulaResultType2 to determinate ...Jens Carl
what result to return if the cell content type is formula. Cleans up the confusion which was introduced with commit 8a73799d12f0d2dc04890b96bd0adf0ffcf50d17. Change-Id: Ie4346173abf6bc3732d2fec06341f4e32cf68b82 Reviewed-on: https://gerrit.libreoffice.org/48725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-30Clarify that updating links "Always" is from trusted locationsEike Rathke
Change-Id: Ia3d5b88cb7ce3b440cebc23726e6544643afd888
2018-01-30silence coverity#1428735 Use of untrusted scalar valueCaolán McNamara
Change-Id: I7e40f25ce506b1a26d683848a1bc83c16baf762f
2018-01-30coverity#1428736 Dereference null return valueCaolán McNamara
and coverity#1428737 Dereference null return value Change-Id: Ia743107e194a7945be1eb3ab521ef7fe1a168ab3
2018-01-30Typ-o negativIlmari Lauhakangas
Fixed some typos and translated a couple of German words Change-Id: I24ae28dd537ba283a9480413659f85bd6711acad Reviewed-on: https://gerrit.libreoffice.org/48892 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-30fixup Modernize a bit vcl (part2)Julien Nabet
Change-Id: I7eb75ef33ebb6b701668f2d99fc3d231d81168f4 Reviewed-on: https://gerrit.libreoffice.org/48890 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-30Ignore Emacs lock filesStephan Bergmann
Change-Id: Idd754a4ecdd76ff6f6d0e2b848ea3526fc90dc54
2018-01-30ofz#5313 TimeoutCaolán McNamara
Change-Id: I5a51bf241d1a3c3c04b4f46cd26d2afab518787c Reviewed-on: https://gerrit.libreoffice.org/48854 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-30Revert "tdf#114821 calculate correct label position"Szymon Kłos
This reverts commit 1ede9f7ff6f2250fa2c75bc4dc099246a59dcec0, because it caused division-by-zero errors, see comment at <https://gerrit.libreoffice.org/#/c/48242/6> "tdf#114821 calculate correct label position". Change-Id: Ifca811bda04721898387b4799de2d2da31290fa0 Reviewed-on: https://gerrit.libreoffice.org/48860 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-30tdf#115155 RTF import: fix left indent handling inside list definitionMiklos Vajna
This used to work in the past only because the left indent was also imported as a direct paragraph formatting, but that is not the case since left margin of lists is deduplicated during import after commit c9dee880d88305312094b311abdae155e452bf14 (tdf#104016 RTF import: deduplicate before text indent from numbering, 2017-12-05). Change-Id: I1c9be30700c51ef97fb274e8781d6008db3121d8 Reviewed-on: https://gerrit.libreoffice.org/48855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-30iOS: linker changes for on deviceJon Nermut
[ae490dd] iOS: add script to sym link the dylib to the right spot Adds a shell script to symlink the right dylib into the build products folder, which means we can reference libKit.dylib relative to that, rather than absolutely [ba4c072] iOS: pass in user path On device using appPath/user as the user directory causes a crash, as an app cannot write inside it's bundle. Instead, add a new param to pass the documents dir into the init. [088ad49] iOS: linker changes to run on device Change-Id: I16f5d85f3ca483df11b82108ee39c4ec461214f4 Reviewed-on: https://gerrit.libreoffice.org/48866 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2018-01-30Clean up conversion to sal_uInt16Stephan Bergmann
Change-Id: I95ecb0f68e737a25ff90437e82411d1e6eb42675 Reviewed-on: https://gerrit.libreoffice.org/48846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-30loplugin:unused-returns in swNoel Grandin
Change-Id: I753fcdd35d461880a8d8160213cabd465cfde967 Reviewed-on: https://gerrit.libreoffice.org/48189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-30tdf#63388: use SMTP_SSL for port 465Justin Luth
Thanks to Jurassic Pork and prrychr (tdf#99363) for the 2016 patch. I used smtp.gmail.com as my testing server. Port 587 is the "official" port to use for encrypted email. I confirmed that 587 CANNOT use SMTP_SSL [SSL: UNKNOWN_PROTOCOL], so I limited SMTP_SSL use to common TLS port 465 only. Port 465 was temporarily recommended, but OFFICIALLY has long since been abandoned. However, LOTS of documentation and ISPs still recommend it as the port to use. I confirmed that 465 DOES NOT support STARTTLS, so it is specifically excluded. So, technically the button should say use STARTTLS instead of SSL, but only for SMTP. IMAP/POP do use SSL, so terminology gets rather confusing. This patch forces SSL without STARTTLS for port 465 regardless of the "use SSL" setting due to all the confusion. Currently we don't support ANY SSL/TLS connections. With this patch we now at least support the extremely common use case of port 465. Change-Id: I210cc307491157c1121cfffd70cbb94347ee2856 Reviewed-on: https://gerrit.libreoffice.org/48210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>