summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-26sc lok: Make the Validation "Invalid value." message box working.Jan Holesovsky
Change-Id: Ic0131fa6fc397ae440efed834266b8396aa9e619 Reviewed-on: https://gerrit.libreoffice.org/50160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-02-26RES_CHRATR_SHADOW should be SvxShadowItemMike Kaganski
Follow-up for commit 35f5274ece0fcbb70753a71619b526ed0d4cbd6b Change-Id: I7bd2f28565e574a6f0e36bc34959b8ecaf8cc4b1 Reviewed-on: https://gerrit.libreoffice.org/50340 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-26Move convenience abstractions to DocPasswordHelper, tdf#104250 follow-upEike Rathke
Change-Id: If0775ccf14b631918e51342a767412948e812c87
2018-02-26Translate German variable namesJohnny_M
Akt -> Current in prcntfld Change-Id: If9e4ecc36ad89837825b6d2581424d316dd20e30 Reviewed-on: https://gerrit.libreoffice.org/50313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-26Translate German variable namesJohnny_M
Translated the enum values in editeng, but kept the their translation references in editrids.hrc, to prevent a need to update translations. "UPPERCASE" was used instead of "CAPS", in alignment to style::CaseMap. The values in svxitems.sdi don't seem to be used anywhere, but translated anyway. Change-Id: I1b3a9a68ce814841819b361ce5767764e3b1968c Reviewed-on: https://gerrit.libreoffice.org/50305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-26Translate German variable namesJohnny_M
Akt -> Current in callnk Change-Id: I53506b07c73f4cd663be01f6a224a7fcd8c3ac89 Reviewed-on: https://gerrit.libreoffice.org/50311 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-26Translate German commentJohnny_M
Change-Id: If9f4d51827f2da11efbed6839bd36ff6a653d37b Reviewed-on: https://gerrit.libreoffice.org/50309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-26Translate German variable namesJohnny_M
Akt -> Current in itemset Change-Id: I22f24505c220775fcbbcc64f6fdfc529c772dbe9 Reviewed-on: https://gerrit.libreoffice.org/50312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-26loplugin:useuniqueptr in SvxMSDffSolverContainerNoel Grandin
Change-Id: Ied7b60ac59cf1c869232a96e1b2ccb4e1b5cbf53 Reviewed-on: https://gerrit.libreoffice.org/49945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26nfc: use std::min in fly.cxx:CalcRelJustin Luth
Other parts of CalcRel are already using std::min. It makes it much easier to read when the code is consistent. Change-Id: Ie3b07b96e48843271683cdf6a7dabca16cfab10b Reviewed-on: https://gerrit.libreoffice.org/50035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-26tdf#116020: use actual whichIds in dialogs for character propertiesMike Kaganski
... instead of converting back and forth between character-specific whichIds and generic. This eliminates creating duplicate properties in the set passed to dialog. A temporary GrabBag entry "DialogUseCharAttr" is used to indicate that dialogs should use character-specific Ids. This simplifies and unifies preparation of the set for different dialogs. Change-Id: I41b982ff05d54b0dfc283c07aef806f51c87209c Reviewed-on: https://gerrit.libreoffice.org/50339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-26extend testTextBoxPictureFill - check that the graphic is presentTomaž Vajngerl
Change-Id: Ib7ee52bbbf4bbbd41adcc7c15740b8d13bbe5bfa Reviewed-on: https://gerrit.libreoffice.org/50337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-26xmlsecurity nss: create XMLSecurityContext instances with a constructorMiklos Vajna
Change-Id: I0133469e08b6d48aaf949e928ec4436d309963eb Reviewed-on: https://gerrit.libreoffice.org/50223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26move MovePoint and MoveRect into Rectangle and PointNoel Grandin
Change-Id: Ie75c7c10288da00aac89479879e0b9fb1a4459b2 Reviewed-on: https://gerrit.libreoffice.org/50247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26fix alpha computation in chart2 getColorAsVectorNoel Grandin
The alpha value was not being shifted, and because of associativity, the alpha color was also not being inverted before being divided by 255. Found while doing other Color work. This was introduced in commit a0842e53b999cee3cddbd209b43e313874760f0b Date: Mon May 12 05:22:52 2014 +0200 more sal_Int32 to sal_uInt32 and simplification Change-Id: I99b9e866a4f63676e194e65d64c31fb4c0442e0a Reviewed-on: https://gerrit.libreoffice.org/50245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26ColorData->Color in variousNoel Grandin
Change-Id: I22018b6a535224316d93bfd621771248b873a218 Reviewed-on: https://gerrit.libreoffice.org/50167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26vcl: consolidate ColorOf() and GrayOf() functionsChris Sherlock
Change-Id: Ic80dda409ceaff89be5f249cf906abbb40679f3c Reviewed-on: https://gerrit.libreoffice.org/50272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26vcl: remove init and destroy functions from Bitmap{Info|Read}AccessChris Sherlock
Nothing else ever calls them except the constructor and destructors of the BitmapInfoAccess class itself - thus there is no real need for them to exist. Change-Id: Ib9a78dc5ed67b11c837f2c347ad74d0164e91770 Reviewed-on: https://gerrit.libreoffice.org/50324 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26xmloff: remove unused code when loading/saving the bitmap tableTomaž Vajngerl
Change-Id: I6bffe243e813079538a4cb57111266b41d7c03f1 Reviewed-on: https://gerrit.libreoffice.org/50333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-26bool cast operator for Graphic objectTomaž Vajngerl
Change-Id: Iec236538271b33eb9e6dcfd98903657c1198476e Reviewed-on: https://gerrit.libreoffice.org/50332 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25tdf#115329 make navigate by drawing to previous drawing workJim Raykowski
Change-Id: I7d93dc3accd7cc092f068524cb567de74a479343 Reviewed-on: https://gerrit.libreoffice.org/50273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-25tdf#115329 Fix Navigate By Table after Navigate By Drawing or ControlJim Raykowski
Change-Id: I2068d5d9c0ccebc83834d4db5a40225c972829ff Reviewed-on: https://gerrit.libreoffice.org/50315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-25vcl: test Bitmap::MakeMonoChris Sherlock
Change-Id: I0387981296313eba4e0fb796750c0a5de8e3b7a2 Reviewed-on: https://gerrit.libreoffice.org/50306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25vcl: add BitmapColor testsChris Sherlock
Change-Id: Ic7f781f7f174d40b81ba85e8386acec325fefc4e Reviewed-on: https://gerrit.libreoffice.org/50271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25oox: Remove setting the GraphicURL in fillpropertiesTomaž Vajngerl
Change-Id: I543b77bce7232d56a4cf107992e1c006b75b63bd Reviewed-on: https://gerrit.libreoffice.org/50168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25Updated coreCaolán McNamara
Project: help 72c2f044662c92c8e1dec700160cb94835bfc092 update help for warning dialog conversion Change-Id: I8c4bae6f0e43178b2189b3986c9f280dcb76b085
2018-02-25convert remaining InfoBox to weld::MessageDialogCaolán McNamara
Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8 Reviewed-on: https://gerrit.libreoffice.org/50205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25tdf#115353 layout fixTamas Bunth
Change-Id: I085b330e6539adb8b924f4d7f4cd10fb593a0da6 Reviewed-on: https://gerrit.libreoffice.org/50257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-02-25oss-fuzz build fixCaolán McNamara
Change-Id: I64e0839428e238471a75f2609330171e86472429
2018-02-25oss-fuzz: issue 1188, per-fuzzer configCaolán McNamara
instead of copying the whole bunch around, now the scheme is to copy each individual fuzzer and matching config around, so duplicate the previously shared config for each one an Change-Id: I479ea13abfab382b6aee23bc04d5f7e535b489c9
2018-02-25accessibility: cleanup constructors and destructorsArnaud Versini
Change-Id: Id9d420e633691cf87706088d7415aeb8ed1bdb8d Reviewed-on: https://gerrit.libreoffice.org/50307 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-25accessibility : remove useless Impl patternArnaud Versini
Change-Id: I6a3744b742db12ded79d273d49b041c578eccab6 Reviewed-on: https://gerrit.libreoffice.org/50302 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-25amend Sequence sizeJochen Nitschke
Change-Id: Ib5fd612c2cba6190f414aca261415b3b977971c0 Reviewed-on: https://gerrit.libreoffice.org/50300 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-25uitest - calc's autofilter bugsZdeněk Crhonek
tdf#115046 tdf#94055 tdf#77479 tdf#112656 tdf#81124 tdf#73565 tdf#65505 tdf#74857 tdf#35294 tdf#55712 Change-Id: I98a79499c3b0eab27e0330e17b9e94f5ecc7ef14 Reviewed-on: https://gerrit.libreoffice.org/50009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25uitest for bug tdf#53460Zdeněk Crhonek
Change-Id: I6e1f720bf815ebdcb3eb94d45b5ceb8863f1ddb5 Reviewed-on: https://gerrit.libreoffice.org/50215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25uitest - Writer Asian phonetic guide dialogZdeněk Crhonek
Change-Id: Ied8c5c880e1a6aa77ac478f988d579fa469a86c3 Reviewed-on: https://gerrit.libreoffice.org/50184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25uitest for bug tdf#51352Zdeněk Crhonek
Change-Id: I5ad054c7226c43c60dd0770ff7f7bd7bba34c93d Reviewed-on: https://gerrit.libreoffice.org/50263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25uitest Calc merged cells- tdf#51368 tdf#105412 tdf#37901 tdf#51368 tdf#63766Zdeněk Crhonek
Change-Id: Iecf46561b999bdb56a93a3412418332513fa83fd Reviewed-on: https://gerrit.libreoffice.org/49561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25Improve loplugin:dyncastvisibility a bitStephan Bergmann
Change-Id: Iab9d333d08a8b90a69f3a096e5f39baf3e7bb638 Reviewed-on: https://gerrit.libreoffice.org/50279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-25forcepoint #8 null derefCaolán McNamara
Change-Id: I29450ab45eba5cccfbfff4744c853e2e70ce679e Reviewed-on: https://gerrit.libreoffice.org/50291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25When exporting a shape, use "Graphic" property from imagesTomaž Vajngerl
We still used "GraphicURL" when exporting a shape, but as it is being replaced, change that to use "Graphic" property instead. Change-Id: Ia2b6bdacf0e28de6cfe2eaa36e5b558250ebee8e Reviewed-on: https://gerrit.libreoffice.org/50142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25Use "Graphic" instead of "GraphicURL" property for SimpleShapeTomaž Vajngerl
We don't need to create an URL when we get the XGraphic from the signatures, that use SimpleShape. We can just use the XGraphic directly and set the "Graphic" property on creation of SimpleShape. Change-Id: I82b1f76cd358fca29f5b9dfbed0e735bd1f38e15 Reviewed-on: https://gerrit.libreoffice.org/50141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25vcl: bitmap tests: bit-width, number colors, PrefSize, and byte-sizeChris Sherlock
Change-Id: I783cb0f8d25a0147dfb908d659ab26c5e1ac2748 Reviewed-on: https://gerrit.libreoffice.org/50299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25vcl: remove vcl/qa/cppunit/BitmapTest.cxx from clang-format blacklistChris Sherlock
I am actively working on bitmap tests, it is much easier if I just make a seperate commit which runs clang-format over this file, gives a clear line of demarcation so you can see what is being changed. Change-Id: I70357c935aaeac4cabdf95a98b2cc8e40fd736e0 Reviewed-on: https://gerrit.libreoffice.org/50298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25Blind fix for 3ceb01afc3e5f47930e24fb0b21e6e85b86f660eJulien Nabet
Change-Id: I01649065c93de368f900eb836a0467693f361f68 Reviewed-on: https://gerrit.libreoffice.org/50297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-25remove const property name member for "GraphicURL"Tomaž Vajngerl
All of them should be removed however.. Change-Id: I83c9ec3c8d5f547b39528121a8d4be12aa1b911c Reviewed-on: https://gerrit.libreoffice.org/50296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25remove "FillBitmapURL" propertyTomaž Vajngerl
Change-Id: Icac13a412ae16e4b367362ca85a37fa29802c68b Reviewed-on: https://gerrit.libreoffice.org/50169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25use "Graphic" property to transport Graphic for controlsTomaž Vajngerl
Currently "ImageURL" property is used to transport the Graphic (as an string URL), which is being replaced by transporting XGraphic directly. There is already a property that all controls use - "Graphic", so use that instead. Change-Id: I2514b475735f3e430c2baa9b1685a231fc694b28 Reviewed-on: https://gerrit.libreoffice.org/50139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25fix import of graphic bulletsTomaž Vajngerl
When changing to use "GraphicBitmap" property instead of "ImageURL", the import wasn't adapted and there was no test which would warn of such an situation. This also changes the difference between writer and impress where impress used "Graphic" and not "GraphicBitmap" property. Also adds missing tests for both writer and impress Change-Id: Ieed629d2d37f7806d63e729b6ef23cd848593071 Reviewed-on: https://gerrit.libreoffice.org/50140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>