summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-07-01lool - bccu#1307 - images must be scaled in a non-uniform wayMarco Cecchetti
Change-Id: I4093452d543ba45d8c1a2c1fc0811646e12c23a5 Reviewed-on: https://gerrit.libreoffice.org/26828 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01sc lok: add LOK_CALLBACK_CELL_VIEW_CURSORMiklos Vajna
So a view can be aware where the cell cursors of other views are. Change-Id: Ifcf06c0019c6af8b859e2e92222e4f3fd18da74f Reviewed-on: https://gerrit.libreoffice.org/26844 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-01sd: sd_export_ooxml still takes the most time, split it in 2Michael Stahl
Change-Id: Ib102ba9b54c4b7730c583e3cb5e769f70fcb5b09
2016-07-01sd: split up sd_export_testsMichael Stahl
Move all PPTX export tests to a new file. Change-Id: Idb90baf6b145cdfaf5301583489a7257c5fa23a4
2016-07-01cppunittester: always print execution time of each testMichael Stahl
Not much point in disabling this by default, nobody but the author will find it. Change-Id: I637b214644d2cc7bc70b8bca4f214955355ea951
2016-07-01re-enable unit tests accidentally disabled with HAVE_FEATURE_ATLMichael Stahl
Macro is only true on WNT, but the tests should be enabled then. Change-Id: Ife5657c8204c9906afd42b4b4671a7fa6356a748
2016-07-01CppunitTest_sal_rtl_ostringbuffer: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: I1b7710556f179f35694c05e209854bbcb152041f Reviewed-on: https://gerrit.libreoffice.org/26842 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-01Improve readability of OUString concatanation in SvxPixelCtlAccessibleMuhammet Kara
, SvxShowCharSetVirtualAcc , SvxBmpMask , SvxSuperContourDlg , and SvxTPView It is more readable and more efficient as a bonus. See: https://goo.gl/jsVAwy: Change-Id: Id0641673e1e6fb04b3193c2b8e9a2ab3156b4552 Reviewed-on: https://gerrit.libreoffice.org/26794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-01remove stylename dependency from rtfimportJustin Luth
It was not the intention of this unittest to specify the name of the style. Better not to hardcode a "random" name in a unit test. Change-Id: Ibf96f8c0e88ec61c4994d57c67d8958cde9a8d25 Reviewed-on: https://gerrit.libreoffice.org/26735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-01clang-analyzer-deadcode.DeadStoresStephan Bergmann
...after 0f17e343306fd457c542067c09242ddd04ca39e9 "loplugin:singlevalfields in chart2" Change-Id: I111d6a0eb5380d9559799db348deb43594f90630
2016-07-01Make SmStructureNode's ctor initialize the number of sub nodesTakeshi Abe
This also drops newly unused SetNumSubNodes() as a result. Change-Id: I9b33cb547eb6883da4b45dc5760144cce8fa14ee Reviewed-on: https://gerrit.libreoffice.org/26795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-30loplugin:badstatics: new static only found with libc++Stephan Bergmann
Change-Id: I93f12629fe6aa4bddae7379a5a7ac4f4c42c7923
2016-06-30Minor changes for Pattern tabRishabh Kumar
Change-Id: Ibc10b24c2367fd7a6ca068ee61fd4098d2f66bdb Reviewed-on: https://gerrit.libreoffice.org/26825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-06-30Rename GetFoucsPosIndex() to GetFocusPosIndex()Muhammet Kara
Change-Id: Ic05d69976d053037c9d02cf5f8b843c6b590000c Reviewed-on: https://gerrit.libreoffice.org/26803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-30Resolves: tdf#100440 check mode to be 0 or 1 for MONTHS(), YEARS() and WEEKS()Eike Rathke
Needed to adapt the WEEKS and YEARS test documents to cope with the change. Change-Id: Ia52505418f4fed684bd04290c608e2a65eee2fbc
2016-06-30everything is called Dispose, hard to find anythingCaolán McNamara
Change-Id: I473ed39c975886a6be30860cb61f6fe59c5508a4
2016-06-30tdf#100179 correct cell merging in pptx.Mark Hung
Change-Id: I7a5bc6fb33c64d1ff398986eff5b960fe037df4d Reviewed-on: https://gerrit.libreoffice.org/25791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-06-30GSoC added button with small paddingSzymon Kłos
+ vcl builder setups action for custom buttons + new control: vcllo-SmallButton with WB_SMALLSTYLE property Change-Id: I54891969f26d237eac8e45532906d76040264272 Reviewed-on: https://gerrit.libreoffice.org/26781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30Resolves: tdf#100692 crash in sidebar on deleting image from writerCaolán McNamara
stumbled on this in passing and it has the same bt as http://crashreport.libreoffice.org/stats/signature/vcl::Window::setPosSizePixel(long,long,long,long,PosSizeFlags) Change-Id: I1f19275029b05f353dfa823a2ff435e5045250a6
2016-06-30tdf#65356 Photo Album: Disable "Insert Link" in the add dialogSamuel Mehrbrodt
since we have that option in the dialog directly Change-Id: Id8f0e39df7c468759cb4dc4d94f0042f09c8296b Reviewed-on: https://gerrit.libreoffice.org/26797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30Add new open dialog type: Preview only (without link)Samuel Mehrbrodt
This is needed e.g. for the "Insert Photo Album" dialog where we don't want the "Insert Link" option in the file open dialog (tdf#65356) Change-Id: I01aecaaf8194a8123931b0482b4a37155654dfc2 Reviewed-on: https://gerrit.libreoffice.org/26796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30sw lok: mix missing invalidation due to page calc in visible cursor changeMiklos Vajna
Steps to reproduce in gtktiledviewer: - two windows, then enable edit in both - view #0: go inside a word - view #1: select the same word - press Del in view #1 -> no invalidation Fix the problem by changing the LOK-specific GetPageNum() call in SwVisibleCursor::SetPosAndShow(), so that it doesn't re-calculate the frame, that way later when SwLayAction::TurboAction_() attempts to re-calculate the layout, then the frame will be still invalid, and that re-calculation then triggers the necessary invalidations. Change-Id: I8c4472b9809537fcbd4a20c73f39be7ebca16b1f Reviewed-on: https://gerrit.libreoffice.org/26802 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-30use GetInt*() in the most obvious placesEike Rathke
found with /approxFloor.*GetDouble Change-Id: Ice058c9cb318d7b0b0cadb9a26b4eb9f3691752f
2016-06-30use GetInt*() in the most obvious placesEike Rathke
found with /approxFloor.*GetDouble Change-Id: I2a08d8c268e6c1d64270d9c9f343b69a62f27708
2016-06-30use GetInt*() in the most obvious placesEike Rathke
found with /approxFloor.*GetDouble Change-Id: Ib14a60e872c6a3adde2aa11f96f391c42b4e510c
2016-06-30return SAL_MAX_... instead of 0 for GetInt*()Eike Rathke
Most places will use GetInt*() to obtain flags or enums in a range 0..somenumber and explicitly check for valid values, so returning MAX instead of 0 will save us an extra comparison of nGlobalError and push/return. Change-Id: I84c5d693d3642ea643308dc4650a391de2ebe82a
2016-06-30introduce ScInterpreter::GetInt32WithDefault()Eike Rathke
Change-Id: Ic3a5c65e4846a4582461564f572be83897b1d12d
2016-06-30introduce ScInterpreter::GetUInt32()Eike Rathke
Change-Id: Iba1a8cfcab01083a23b4956d7da51651ad3a447f
2016-06-30use GetInt16()Eike Rathke
in the places changed by 2606915f0f480af30367a5d0f67adbf930c2c6b9 and 002697221215e009cdf20fd5c12b50350b8a2128 Change-Id: Iea056b3101c5c41ee932defe13edf4769cb9eab1
2016-06-30introduce ScInterpreter GetInt32() and GetInt16()Eike Rathke
in preparation of replacing oversimplifying casts and special handling like in 2606915f0f480af30367a5d0f67adbf930c2c6b9 and 002697221215e009cdf20fd5c12b50350b8a2128 Change-Id: I81327dbc2218f40359c3485cf3d639d19fd69cef
2016-06-30loplugin:badstatics: further (Linux-only) static only found with libc++Stephan Bergmann
Change-Id: I048212e3feb3f548d5a65940dd71ccb71cade778
2016-06-30Photo Album: Allow assigning keyboard shortcutsSamuel Mehrbrodt
Change-Id: Ie3a31a02733048421423f8f44846fc7374ae71f0 Reviewed-on: https://gerrit.libreoffice.org/26799 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30Photo album: Remove padding from preview imageSamuel Mehrbrodt
So that it aligns well with the other controls Change-Id: I32fcb50bf378443dc27c10a1a674ff672b95a15f Reviewed-on: https://gerrit.libreoffice.org/26798 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30tdf#65356 Photo Album: Allow inserting images as linkSamuel Mehrbrodt
Change-Id: Ic7d1228b9e0a5ee5a303c5e3f4ce4d5a1b2b2036 Reviewed-on: https://gerrit.libreoffice.org/26793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30distclean the generated bin/bffvalidator.shStephan Bergmann
Change-Id: I3ea4f0682250ddb475c66a9782194177e6ae7586
2016-06-30fix Window::~Window: inconsistency in top window chain leakCaolán McNamara
Change-Id: I4f32b77a4b107e5315e0c2bc9b20db897135c8b0
2016-06-30lokdocview: avoid pointless setView() before getView()Miklos Vajna
This fixes the following use-case: 1) Start gtktiledviewer, click New View 2) Click Edit in the first view 3) Click somewhere in the document in the first view -> nothing happens Change-Id: I79d63538607f03b78851a639adf158d918745276 Reviewed-on: https://gerrit.libreoffice.org/26789 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-30Explain usage of -isystem instead of -IStephan Bergmann
Change-Id: Ib7153db5c2c1542ff7e9a0daa6d7124225c7701c
2016-06-30Who needs that $(CLANGDIR)/tools/clang/include anyway?Stephan Bergmann
It was included ever since 02a8d36ebf3d54784903f2899eafe010bedf2f4c "initial support for clang compiler plugins" but will probably point at either a non- existing dir or a dir in the Clang source tree (that does not even contain all the include files that the corresponding installation dir would contain, as some include files are generated during the build). For a properly installed LLVM/ Clang, all include files should be found underneath a single include/ dir. Change-Id: Ie23cb1ae701eed1ee78448eb6c828d07b15121c2
2016-06-30RTF export: it's enough to pass these by const ref, no need to copyMiklos Vajna
Change-Id: I6854c3c8e9a2b5c6d478551c5f9bba19e114152c Reviewed-on: https://gerrit.libreoffice.org/26787 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30loplugin:unusedfieldsNoel Grandin
Change-Id: If06fffa8db050df0f9c1c7da6163575bf522382e Reviewed-on: https://gerrit.libreoffice.org/26754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30Modify the ImpGraphic class SwapFile to use a shared pointerMark Page
Change-Id: I2cf85f91d9022a4ea10804efe2e986e95a63419f Reviewed-on: https://gerrit.libreoffice.org/26284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30Improve readability of OUString concatanation in ODatabaseExportMuhammet Kara
It is more readable and more efficient as a bonus. See: https://goo.gl/jsVAwy: Change-Id: I3cf18cfb6879ea1598ad98a0bccd3ec91c88c875 Reviewed-on: https://gerrit.libreoffice.org/26760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30Step towards disposing of ScDataFormDlg properlyKatarina Behrens
There were some VclPtrs hiding inside std::vector (twice), so fix that, but the destructor is still not called (getting Window::~Window inconsistency assert). With this patch however the screenshot cppunit test no longer fails Thanks noelgrandin for help Change-Id: I8b46c4608cbab2070e36ef4abec226bcd997425e Reviewed-on: https://gerrit.libreoffice.org/26772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30tdf#89616 Find toolbar: Activate search arrows when input has textSamuel Mehrbrodt
Not only when input is modfified Change-Id: Ic6b94dbfba34ec6eb88c9c385aaa36a7bac19de7 Reviewed-on: https://gerrit.libreoffice.org/26782 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30remove pageStyle name dependencies from rtfexportJustin Luth
It was not the intention of these unittests to specify the name of the style. Better not to hardcode a "random" name in a unit test. Change-Id: Ic071bf42dc45c4fa831fec433e3c02b161b4268c Reviewed-on: https://gerrit.libreoffice.org/26734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-30LOK: change back type of view ids to intMiklos Vajna
Commit 45c2410041c48c22bd860efb42d4daadad7869b0 (LOK: change type of view ids to uintptr_t, 2016-06-17) fixed the problem of view IDs being reused for the price of random IDs, which makes debugging harder. Implement a simple shellToView() function that makes sure view IDs are not reused, and stop exposing view shell pointer addresses, which allows reverting the LOK API change. Change-Id: I63089e6de08ee7e1c7706757d43a11f6cf4d6e06 Reviewed-on: https://gerrit.libreoffice.org/26773 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-29Add MS binary format validator support for wineThorsten Behrens
Run bffvalidator also from Linux, reportedly works from wine 1.9 upwards. Wraps stuff in a shell for path name conversion. Change-Id: I3093b10bbbf89aaff97f63485b8ccadb417b3561 Reviewed-on: https://gerrit.libreoffice.org/26784 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-29compilerplugins: -isystem /usr/include breaks the buildMichael Stahl
... on Fedora 24, and it's a Bad Idea in general because it breaks "#include_next" ordering of GCC's and glibc's variously distributed headers. Change-Id: I0c8b51a6d7191ec9cc5187636ea2717e8fd97715
2016-06-29dynamic_cast followed by static_castCaolán McNamara
Change-Id: I9ebdc33ceabc8aaa34dc897cc47e692fedde9199